1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-06 06:57:39 +08:00
osu-lazer/osu.Game
Bartłomiej Dach 13c81db0cf Fix incorrect classic score formula
Upon closer inspection the classic score formula was subtly wrong. The
version given in the wiki is:

	Score = Hit Value + (Hit Value * ((Combo multiplier * Difficulty
	multiplier * Mod multiplier) / 25))

The code previously used:

	bonusScore + baseScore * ((1 + Math.Max(0, HighestCombo.Value - 1)
	* scoreMultiplier) / 25);

which is not equivalent to the version on the wiki. The error is in the 1
factor, as in the above version it is being divided by 25, while it should
be outside the division to keep parity with the previous formula.

The tests attached in the previous commit demonstrate that this change
causes a single hit without combo to increase total score by its exact
numeric value.
2020-04-14 01:09:58 +02:00
..
Audio Use [Resolved] wherever possible 2020-02-14 20:14:00 +07:00
Beatmaps Fix possible legacy beatmap encoder nullref 2020-04-09 20:21:42 +09:00
Configuration Revert "use SettingSource to define IconTooltip format" 2020-03-20 16:05:12 -04:00
Database Fix download failures causing a non-safe drawable change 2020-03-10 20:11:06 +09:00
Extensions Add keybinding repeat extension method 2020-04-03 18:15:24 +09:00
Graphics Merge branch 'master' into update-overlay-headers 2020-04-09 16:29:34 +09:00
Input Change default global bindings for volume changing to include the alt key prefix 2020-03-02 18:59:05 +09:00
IO Allow LineBufferedReader to keep underlying stream open 2020-03-31 10:13:50 +09:00
IPC Move ArchiveModelManager import process to async flow 2019-06-10 13:42:22 +09:00
Migrations Code quality, read position offsets 2020-03-08 14:02:39 -07:00
Online Re-namespace into song select 2020-04-07 15:31:22 +09:00
Overlays Remove unintentional edge effect 2020-04-11 15:29:52 +09:00
Properties Merge branch 'master' into correct-preview-loop 2019-01-31 10:53:09 +01:00
Replays Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
Rulesets Fix incorrect classic score formula 2020-04-14 01:09:58 +02:00
Scoring Merge conflict "resolution" 2020-03-31 23:36:06 +09:00
Screens Fix editor beatmap potentially not updating hitobjects 2020-04-10 13:29:46 +09:00
Skinning Merge branch 'master' into mania-stage-background-skinning 2020-04-09 15:37:48 +09:00
Storyboards Fix storyboard videos being offset incorrectly 2020-04-07 00:26:38 +09:00
Tests Merge branch 'master' into per-ruleset-skinnable-tests 2020-04-07 22:59:42 +09:00
Updater Add comment about rationale behind always updating version in config 2020-03-05 15:35:27 +09:00
Users Fix crash caused by user json order changing 2020-04-02 18:46:09 +09:00
Utils Make accuracy formatting more consistent 2020-02-07 22:09:45 +01:00
osu!.res
osu.Game.csproj Update framework 2020-04-11 15:13:20 +09:00
OsuGame.cs Merge pull request #8129 from peppy/fix-dummy-track-completion-feedback 2020-03-05 17:57:57 +09:00
OsuGameBase.cs Increase sample concurrency to better match stable 2020-03-22 02:16:28 +09:00