9823 Commits

• Add groupings to all tags list
  Bartłomiej Dach · 2025-03-31 10:45:44 +02:00
  624948f082
• Move the extra tag selector out of popover
  Bartłomiej Dach · 2025-03-28 14:05:35 +01:00
  1d44d5e100
• Redesign vote buttons to better work with hierarchical tags
  Bartłomiej Dach · 2025-03-28 13:24:26 +01:00
  9b9cfbc9c2
• Merge pull request #32610 from bdach/user-tags-on-beatmap-set-overlay

  Show user tags on beatmap set overlay

  Dean Herbert · 2025-03-28 17:10:57 +09:00
  f4c96ecb54
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Merge pull request #32596 from bdach/fix-bogus-daily-challenge-lookup

  Fix daily challenge not querying beatmap properly

  Dan Balasescu · 2025-03-27 21:25:47 +09:00
  b414ed0e42
• Merge pull request #32458 from smoogipoo/refactor-room-panels

  Refactor multiplayer/playlists room panels

  Bartłomiej Dach · 2025-03-27 12:43:32 +01:00
  e5ff123e11
• Fix tests
  Bartłomiej Dach · 2025-03-27 12:39:19 +01:00
  2ba621550c
• Merge pull request #32606 from smoogipoo/fix-mod-overlay-panel-refresh

  Refresh mod panel active states when recreated

  Bartłomiej Dach · 2025-03-27 12:07:35 +01:00
  dbd97166a4
• Merge pull request #32577 from bdach/improve-card-button-input-handling

  Improve input handling in beatmap card buttons

  Dean Herbert · 2025-03-27 20:03:37 +09:00
  a91dcbab6b
• Merge branch 'master' into refactor-room-panels
  Dan Balasescu · 2025-03-27 19:46:07 +09:00
  914c425fa7
• Add failing test
  Dan Balasescu · 2025-03-27 19:05:11 +09:00
  8c244134d5
• Merge pull request #32604 from bdach/fix-multiplayer-join-logging

  Fix several issues with multiplayer & playlists room join error logging

  Dan Balasescu · 2025-03-27 18:30:52 +09:00
  c69e0cbb73
• Merge pull request #32573 from smoogipoo/refactor-mp-user-mod-display

  Add multiplayer-specific implementation for user mod display

  Bartłomiej Dach · 2025-03-27 10:08:30 +01:00
  eeed29ce03
• Fix test
  Dan Balasescu · 2025-03-27 17:49:21 +09:00
  2cfb06bcde
• Fix several issues with multiplayer & playlists room join error logging

  This is in response to
  https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user
  is having a problem with joining multiplayer, but I have basically no
  diagnosing capabilities, because the logs are all
  
      2025-03-26 18:57:57 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:40 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
  
  which appears to originate from
  
  https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91
  
  Now, as far as I can tell, there are two possibilities here:
  
  1. The exception's `Message` is null or empty. That's not exactly great
     or typical, but sure, this could possibly happen - in which case the
     error logging is silently eating whatever little relevant detail
     there is left to use.
  
  2. The exception is *actually* `null` itself, and we're in the X Files.
  
  This PR is intending to defend against (1).
  
  In examining the logging further, I also spotted the following issues:
  
  - In the single path that specifies a custom failure handler (which is
    `DrawableLoungeRoom` which handles joining a passworded room), the
    custom failure handler being present means that the error would be
    presented to the user, but it would not be logged. At all.
  
  - In playlists, if the exception for whatever reason had an empty
    message, an empty notification would get posted. And in general to me
    it feels a bit dodgy to be directly presenting exception notifications
    to users without any preamble, hence the added "Failed to open
    playlist" prefix.

  Bartłomiej Dach · 2025-03-27 08:52:33 +01:00
  1c4ecba950
• Merge pull request #32571 from smoogipoo/refactor-mp-availability

  Refactor online play beatmap availability, add multiplayer-specific implementation

  Bartłomiej Dach · 2025-03-26 13:52:07 +01:00
  c82eaafe98
• Merge branch 'master' into refactor-room-panels
  Bartłomiej Dach · 2025-03-26 11:58:20 +01:00
  43d652bc3e
• Remove unused local
  Dean Herbert · 2025-03-26 19:10:14 +09:00
  90bc2318e1
• Fix tests
  Bartłomiej Dach · 2025-03-25 20:59:25 +01:00
  491f28c451
• Allow tagging already played beatmaps without playing another time

  Addresses
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12610577.
  
  No changes in criteria (yet?), just allowing locally imported plays to
  count the same way as full beatmap completion does.
  
  The test scene is a bit rough / semi-manual but dealing with score
  imports is a bit of a pain in general. The way to semi-manually test
  with the test scene is to import a subset of scores, then recreate the
  statistics panel, and observe behaviour. I'm not sure it's worth it to
  be putting subscriptions in there, so the full recreation of the panel
  is necessary.

  Bartłomiej Dach · 2025-03-25 14:16:26 +01:00
  40d20f4e10
• Add tests
  Dan Balasescu · 2025-03-25 16:25:02 +09:00
  3ff05b7330
• Adjust tests to add tracker to hierarchy
  Dan Balasescu · 2025-03-25 15:41:03 +09:00
  bc2b7aae1c
• Split tracker into per-system implementations
  Dan Balasescu · 2025-03-25 14:56:12 +09:00
  53ece9396a
• Refactor tracker to be a bit more stateless

  Removes storage of `selectedBeatmap` that was referenced through
  multiple class-level methods.
  
  To expound a bit, this structure felt better (or otherwise passing
  `APIBeatmap` through methods) alongside removal of the `#nullable
  disable`, otherwise each method would check `selectedBeatmap != null`.

  Dan Balasescu · 2025-03-25 14:23:05 +09:00
  72b56146ee
• Merge branch 'master' into show-full-rank
  Bartłomiej Dach · 2025-03-24 12:56:20 +01:00
  c631e7a1c5
• Add extra test coverage
  Bartłomiej Dach · 2025-03-24 12:28:46 +01:00
  f6dd2e4ac2
• Merge pull request #32460 from smoogipoo/refactor-match-footer

  Refactor multiplayer match footer

  Bartłomiej Dach · 2025-03-24 12:14:57 +01:00
  fdcf40d4a6
• Merge pull request #32532 from frenzibyte/sheared-dropdown

  Implement sheared dropdowns

  Dean Herbert · 2025-03-24 16:34:42 +09:00
  5b191dad8f
• Add failing test case
  Salman Alshamrani · 2025-03-23 21:38:36 -04:00
  b3d572029f
• Add sheared dropdown
  Salman Alshamrani · 2025-03-22 22:49:34 -04:00
  25e404c734
• Add test coverage
  Salman Alshamrani · 2025-03-22 22:15:02 -04:00
  b6068e6e29
• Merge pull request #32478 from peppy/no-tag-on-convert

  Disallow tagging beatmaps when playing as convert

  Dean Herbert · 2025-03-20 19:54:47 +09:00
  6b1d09bec7
• Add visual test coverage for no convert conditional
  Bartłomiej Dach · 2025-03-20 10:32:40 +01:00
  36ba9dbc8c
• Merge pull request #32467 from peppy/diff-display-spectrum-no-churn

  Fix `DifficultySpectrumDisplay` churning drawables

  Bartłomiej Dach · 2025-03-20 08:43:51 +01:00
  0580d806b9
• Merge pull request #30866 from frenzibyte/image-proxying

  Fix some image attachments in comments not loading in game

  Dean Herbert · 2025-03-20 16:00:22 +09:00
  5183078801
• Merge pull request #32446 from GioSDA/chat-right-click-functionality

  Add more functionality to right clicking in the chat window

  Bartłomiej Dach · 2025-03-19 12:34:21 +01:00
  8b566d2955
• Fix DifficultySpectrumDisplay churning drawables

  Was causing so much GC that song select (v2) was grinding to a halt.

  Dean Herbert · 2025-03-19 19:31:57 +09:00
  63fcde5538
• Remove unnecessary customisation settings in DifficultySpectrumDisplay
  Dean Herbert · 2025-03-19 19:31:57 +09:00
  cfb14fbca6
• Merge pull request #32459 from smoogipoo/remove-superfluous-method

  Replace superfluous method with concrete implementation

  Bartłomiej Dach · 2025-03-19 11:02:42 +01:00
  e51b666f5c
• Fix intermittent mod customisation panel test
  Dan Balasescu · 2025-03-19 16:13:56 +09:00
  9272ada859
• Fix code quality issue
  Dan Balasescu · 2025-03-19 15:50:39 +09:00
  54b079098b
• Remove no-longer used bindable from footer
  Dan Balasescu · 2025-03-19 15:48:25 +09:00
  606bf1eb9f
• Refactor ready button to remove selected item bindable
  Dan Balasescu · 2025-03-19 15:48:25 +09:00
  ca2c48bbd6
• Refactor spectate button to remove selected item bindable
  Dan Balasescu · 2025-03-19 15:41:24 +09:00
  b4a934a797
• Replace superfluous method with concrete implementation
  Dan Balasescu · 2025-03-19 15:32:29 +09:00
  23fa3060b2
• Add playlists/multiplayer versions of RoomPanel
  Dan Balasescu · 2025-03-19 15:28:50 +09:00
  ec0f8142c2
• Rename DrawableRoom -> RoomPanel
  Dan Balasescu · 2025-03-19 15:24:51 +09:00
  36e78119ae
• Rename APIUser.IsOnline and add better documentation around online checks
  Dean Herbert · 2025-03-19 15:01:40 +09:00
  b17ec5e69d
• Merge pull request #32376 from nekodex/better-kiai-fountain-sfx

  Improve SFX playback behaviour of rapid kiai/star fountain activations

  Dean Herbert · 2025-03-18 17:49:21 +09:00
  aa6d644f70