72537 Commits

This Branch

This Branch

All Branches

• Compromise between popover and persistent view with a slideout
  Bartłomiej Dach · 2025-04-01 14:29:50 +02:00
  ffed666b97
• Unify voted displays
  Bartłomiej Dach · 2025-04-01 13:47:10 +02:00
  dcf35ff104
• Fix enter-to-select-tag interaction
  Bartłomiej Dach · 2025-03-31 12:13:50 +02:00
  6cc48eb976
• Async load panels to avoid update thread hitching
  Bartłomiej Dach · 2025-03-31 11:55:42 +02:00
  8ff63e158c
• Final sizing adjustments
  Bartłomiej Dach · 2025-03-31 11:50:46 +02:00
  9d75bb43a3
• Always show all tags in full list & allow voting from both views
  Bartłomiej Dach · 2025-03-31 11:41:46 +02:00
  a9ba615959
• Adjust flow direction
  Bartłomiej Dach · 2025-03-31 11:03:18 +02:00
  8e562c1ded
• Add groupings to all tags list
  Bartłomiej Dach · 2025-03-31 10:45:44 +02:00
  624948f082
• Adjust transform
  Bartłomiej Dach · 2025-03-31 09:49:49 +02:00
  dadb014a69
• Move the extra tag selector out of popover
  Bartłomiej Dach · 2025-03-28 14:05:35 +01:00
  1d44d5e100
• Redesign vote buttons to better work with hierarchical tags
  Bartłomiej Dach · 2025-03-28 13:24:26 +01:00
  9b9cfbc9c2
• Merge pull request #32610 from bdach/user-tags-on-beatmap-set-overlay

  Show user tags on beatmap set overlay

  Dean Herbert · 2025-03-28 17:10:57 +09:00
  f4c96ecb54
• Merge pull request #32616 from frenzibyte/fix-dropdown-chevron-alignment

  Fix chevron alignment in dropdown menu items

  Dean Herbert · 2025-03-28 16:06:07 +09:00
  d0afc54e57
• Fix chevron alignment in dropdown menu items
  Salman Alshamrani · 2025-03-27 23:11:15 -04:00
  0eb89f94f8
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Merge pull request #32607 from smoogipoo/fix-mp-panel-background

  Fix background not showing in multiplayer room panel

  Bartłomiej Dach · 2025-03-27 14:00:20 +01:00
  9a67d0727a
• Merge pull request #32596 from bdach/fix-bogus-daily-challenge-lookup

  Fix daily challenge not querying beatmap properly

  Dan Balasescu · 2025-03-27 21:25:47 +09:00
  b414ed0e42
• Fix background not showing in multiplayer room panel
  Dan Balasescu · 2025-03-27 21:08:05 +09:00
  d43beeaf55
• Remove unused bindables
  Dan Balasescu · 2025-03-27 20:44:56 +09:00
  3c479032f1
• Merge pull request #32563 from smoogipoo/refactor-mp-background

  Refactor multiplayer background to remove selected item bindable

  Bartłomiej Dach · 2025-03-27 12:43:59 +01:00
  e0bb88b49c
• Merge pull request #32458 from smoogipoo/refactor-room-panels

  Refactor multiplayer/playlists room panels

  Bartłomiej Dach · 2025-03-27 12:43:32 +01:00
  e5ff123e11
• Fix tests
  Bartłomiej Dach · 2025-03-27 12:39:19 +01:00
  2ba621550c
• Merge pull request #32606 from smoogipoo/fix-mod-overlay-panel-refresh

  Refresh mod panel active states when recreated

  Bartłomiej Dach · 2025-03-27 12:07:35 +01:00
  dbd97166a4
• Merge pull request #32577 from bdach/improve-card-button-input-handling

  Improve input handling in beatmap card buttons

  Dean Herbert · 2025-03-27 20:03:37 +09:00
  a91dcbab6b
• Merge branch 'master' into refactor-room-panels
  Dan Balasescu · 2025-03-27 19:46:07 +09:00
  914c425fa7
• Apply suggestions from review
  Dan Balasescu · 2025-03-27 19:24:57 +09:00
  050cc27125
• Refresh mod panel active states when recreated
  Dan Balasescu · 2025-03-27 19:05:26 +09:00
  dcb5389ab7
• Add failing test
  Dan Balasescu · 2025-03-27 19:05:11 +09:00
  8c244134d5
• Merge pull request #32604 from bdach/fix-multiplayer-join-logging

  Fix several issues with multiplayer & playlists room join error logging

  Dan Balasescu · 2025-03-27 18:30:52 +09:00
  c69e0cbb73
• Merge pull request #32573 from smoogipoo/refactor-mp-user-mod-display

  Add multiplayer-specific implementation for user mod display

  Bartłomiej Dach · 2025-03-27 10:08:30 +01:00
  eeed29ce03
• Resolve inspection
  Dan Balasescu · 2025-03-27 17:53:45 +09:00
  1f77ef5544
• Fix test
  Dan Balasescu · 2025-03-27 17:49:21 +09:00
  2cfb06bcde
• Use == consistently
  Bartłomiej Dach · 2025-03-27 09:46:14 +01:00
  094a22a4a0
• Use alternative method of fixing issue of improper beatmap query in daily challenge (and expand to other online play modes)
  Bartłomiej Dach · 2025-03-27 09:33:35 +01:00
  f73601535d
• Fix several issues with multiplayer & playlists room join error logging

  This is in response to
  https://osu.ppy.sh/community/forums/topics/2058708?n=5, wherein the user
  is having a problem with joining multiplayer, but I have basically no
  diagnosing capabilities, because the logs are all
  
      2025-03-26 18:57:57 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:40 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
      2025-03-26 18:58:41 [error]: Failed to join multiplayer room:
  
  which appears to originate from
  
  https://github.com/ppy/osu/blob/c82eaafe98d96b9f49a4a7f168ef5c484e67d76f/osu.Game/Screens/OnlinePlay/Multiplayer/MultiplayerLoungeSubScreen.cs#L91
  
  Now, as far as I can tell, there are two possibilities here:
  
  1. The exception's `Message` is null or empty. That's not exactly great
     or typical, but sure, this could possibly happen - in which case the
     error logging is silently eating whatever little relevant detail
     there is left to use.
  
  2. The exception is *actually* `null` itself, and we're in the X Files.
  
  This PR is intending to defend against (1).
  
  In examining the logging further, I also spotted the following issues:
  
  - In the single path that specifies a custom failure handler (which is
    `DrawableLoungeRoom` which handles joining a passworded room), the
    custom failure handler being present means that the error would be
    presented to the user, but it would not be logged. At all.
  
  - In playlists, if the exception for whatever reason had an empty
    message, an empty notification would get posted. And in general to me
    it feels a bit dodgy to be directly presenting exception notifications
    to users without any preamble, hence the added "Failed to open
    playlist" prefix.

  Bartłomiej Dach · 2025-03-27 08:52:33 +01:00
  1c4ecba950
• Make class partial
  Dan Balasescu · 2025-03-27 00:35:21 +09:00
  c720f2b33f
• Fix room background not working in multiplayer

  At the core of the problem is that the multiplayer server does not
  serialise beatmap covers to clients -- only the beatmap ids. Because of
  this, any components that need to display the background should query it
  from an online source first (i.e. via `BeatmapLookupCache`).
  
  There is a slightly tricky situation here formed of two parts, which
  I'll try to explain below.
  
  `Background.Sprite` is exposed publicly and some inheritors override the
  sprite's texture in a similar fashion to the way this changeset does.
  While I frankly believe this is unnaceptable from an encapsulation point
  of view, I've gone for consistency in this regard.
  
  The other fail case is `UpdateableBeatmapBackgroundSprite`. Contrary to
  its name, that object is _not_ a `Sprite` - it is a
  `ModelBackedDrawable` that _contains_ a `Sprite`. The logic in this PR
  could be extracted into a separate object similar to
  `OnlineBeatmapSetCover` (an actual `Sprite`), but even so it would
  require `Background` to provide a path for overriding its contained
  `Sprite`.
  I went through the path above originally with the changes visible in
  https://github.com/smoogipoo/osu/tree/fix-mp-backgrounds, but it looks
  quite daunting and I feel like there would be a lot of emphasis on the
  correct abstraction model for `Background`, of which I'm not entirely
  sure of.
  
  Instead of dealing with both of the above, this commit presents a
  direct; local resolution to the problem.

  Dan Balasescu · 2025-03-27 00:26:08 +09:00
  f907758b8b
• Fix daily challenge not querying beatmap properly

  Noticed during review of https://github.com/ppy/osu/pull/32571.
  
  The reproduction scenario is as follows:
  
  1. Download beatmap used in daily challenge
  2. Go to editor and modify it
  3. Go to daily challenge, wherein the availability tracker will notice
     the MD5 mismatch, block the button, and require a redownload
  4. Redownload the beatmap
  5. Start gameplay
  6. Gameplay start will fail due to web not issuing a submission token
     because the attempt to start gameplay ended up using the modified
     version of the map from step (2) rather than the redownloaded
     original from step (4).
  
  Thankfully, due to (6), this is not exploitable, but nevertheless pretty
  bad.
  
  Probably regressed somewhere around
  https://github.com/ppy/osu/pull/31747 actually.

  Bartłomiej Dach · 2025-03-26 15:06:50 +01:00
  f3524ad8f5
• Merge pull request #32571 from smoogipoo/refactor-mp-availability

  Refactor online play beatmap availability, add multiplayer-specific implementation

  Bartłomiej Dach · 2025-03-26 13:52:07 +01:00
  c82eaafe98
• Merge branch 'master' into refactor-room-panels
  Bartłomiej Dach · 2025-03-26 11:58:20 +01:00
  43d652bc3e
• Remove loading spinner and fade out icon instead
  Dean Herbert · 2025-03-26 19:33:20 +09:00
  2b471919e9
• Merge pull request #32579 from bdach/allow-tagging-if-local-score-present

  Allow tagging already played beatmaps without playing another time

  Dean Herbert · 2025-03-26 19:32:53 +09:00
  e09e38be58
• Remove unused local
  Dean Herbert · 2025-03-26 19:10:14 +09:00
  90bc2318e1
• Merge pull request #32530 from frenzibyte/song-select-v2-aqumarine-mod-select

  Change mod select colour scheme to aquamarine in new song select

  Dean Herbert · 2025-03-26 14:48:13 +09:00
  f0b38a45d8
• Merge pull request #32567 from peppy/fix-christmas-music-oh-no

  Fix christmas menu track potentially playing out of season

  Dan Balasescu · 2025-03-26 14:41:31 +09:00
  a14623a4ab
• Merge pull request #32585 from frenzibyte/teams-external-page

  Open teams page externally when clicking team flags

  Dan Balasescu · 2025-03-26 14:12:02 +09:00
  84174eb4da
• Open teams page externally when clicking team flags
  Salman Alshamrani · 2025-03-25 21:47:22 -04:00
  28f3d9cec9
• Fix tests
  Bartłomiej Dach · 2025-03-25 20:59:25 +01:00
  491f28c451
• Inline method calls to make multiple enumerations explicit
  Dean Herbert · 2025-03-25 22:25:56 +09:00
  f36bc51520
• Merge pull request #32578 from bdach/fix-fountains-loop-alt

  Fix menu star fountains getting stuck looping sounds when leaving menu

  Dean Herbert · 2025-03-25 22:21:36 +09:00
  7de67434a0