Dean Herbert
|
885d832e98
|
Fix deserialise failing with some old skins
|
2024-08-23 20:44:45 +09:00 |
|
Dean Herbert
|
48cfd77ee8
|
Component -> Lookup
|
2024-08-23 14:48:50 +09:00 |
|
Dean Herbert
|
46d55d5e61
|
Remove remaining early base lookup calls which were missed
|
2024-08-22 20:13:28 +09:00 |
|
Dean Herbert
|
1435fe24ae
|
Remove requirement of base calls to ensure user skin container layouts are retrieved
|
2024-08-22 19:14:30 +09:00 |
|
Dean Herbert
|
b57b8168a6
|
Rename Target lookup to Component
|
2024-08-22 19:00:28 +09:00 |
|
Dean Herbert
|
9a21174582
|
Move GlobalSkinnableContainers to global scope
|
2024-08-22 18:46:07 +09:00 |
|
Dean Herbert
|
f37cab0c6e
|
Rename SkinComponentsContainerLookup to GlobalSkinnableContainerLookup
|
2024-08-22 18:39:36 +09:00 |
|
Dean Herbert
|
41756520b1
|
Rename SkinComponentsContainer to SkinnableContainer
|
2024-08-22 17:42:50 +09:00 |
|
Dean Herbert
|
f6ada68e47
|
Fix migration failure due to change in class name
|
2024-08-09 17:27:39 +09:00 |
|
Dean Herbert
|
e645651ef4
|
Merge branch 'master' into mania-combo-counter
|
2024-08-09 00:19:17 +09:00 |
|
Dean Herbert
|
88c5997cb3
|
Add back removed xmldoc
|
2024-08-08 16:36:54 +09:00 |
|
Dean Herbert
|
60d383448f
|
Avoid making non-ruleset transformers in Ruleset.CreateSkinTransformer
This didn't make any sense, so let's do it a better way.
|
2024-08-08 16:29:54 +09:00 |
|
Salman Ahmed
|
0c34e7bebb
|
Store layout version in SkinLayoutVersion instead and refactor migration code
|
2024-07-01 08:30:37 +03:00 |
|
Dean Herbert
|
9286398633
|
Move naming migrations to more correct place
|
2024-03-08 10:26:08 +08:00 |
|
Salman Ahmed
|
49b3e81e8a
|
Migrate DefaultPerformancePointsCounter and rename it
|
2024-03-05 04:35:39 +03:00 |
|
Salman Ahmed
|
78cb6b6851
|
Abstractify LegacyComboCounter to re-use for mania
|
2023-12-30 05:29:22 +03:00 |
|
Dean Herbert
|
b88e3cd26f
|
Change ResourceStore provided to Skin to be a fallback, not replacement
|
2023-11-16 20:19:01 +09:00 |
|
Salman Ahmed
|
314ecec65b
|
Refactor player max dimensions test scene to actually upscale textures
|
2023-09-30 01:34:49 +03:00 |
|
Dean Herbert
|
c44cca2c23
|
Fix skin version being incorrectly set to 1.0 when skin is missing skin.ini
Closes https://github.com/ppy/osu/issues/24939.
|
2023-09-27 16:50:03 +09:00 |
|
Dean Herbert
|
990c54519b
|
Merge branch 'master' into limit-gameplay-sprite-dimensions
|
2023-09-26 16:40:32 +09:00 |
|
Salman Ahmed
|
b823507b2a
|
Add size limitation for approach circles
|
2023-09-19 04:38:10 +03:00 |
|
Salman Ahmed
|
57dc76b345
|
Revert "Update GetTexture signature rather than creating new overload"
This reverts commit 96f12cfbaa.
|
2023-09-19 03:21:19 +03:00 |
|
Bartłomiej Dach
|
fe3683ed5b
|
Adjust formatting slightly
The uneven spacing was bothering me...
|
2023-09-06 18:41:27 +02:00 |
|
Dean Herbert
|
dce6adb895
|
Add text explanation of icons
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
|
2023-09-07 01:23:56 +09:00 |
|
Dean Herbert
|
6c95b88589
|
Add debug output for skin configuration lookups
We've struggle with debugging these over the years so I think this was
worth a couple of hours of work.
Example of osu! lookups:
```log
[runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: SpinnerFrequencyModulate) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: SpinnerFrequencyModulate)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: SpinnerFrequencyModulate) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]:
[runtime] 2023-09-06 08:38:30 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: Vickeblanka - Lucky Ending (TV Size) (tears_) [Normal] } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: ScorePrefix) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: ScorePrefix) 🟢
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: osu.Game.Skinning.ResourceStoreBackedSkin }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-osu.Game.Skinning.ResourceStoreBackedSkin.GetConfig(lookup: ScorePrefix) 🔴
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: TrianglesSkin{ Name: osu! "triangles" (2017) } }.GetConfig(lookup: ScorePrefix)
[runtime] 2023-09-06 08:38:30 [verbose]: |-|-|-TrianglesSkin{ Name: osu! "triangles" (2017) }.GetConfig(lookup: ScorePrefix) 🔴
```
Example of osu!mania lookups:
```log
[runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🔴
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnWidth col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnWidth col:0 totalcols:4]) 🟢
[runtime] 2023-09-06 08:28:34 [verbose]:
[runtime] 2023-09-06 08:28:34 [verbose]: BeatmapSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacyBeatmapSkin{ Name: antiPLUR - Runengon (Raveille) [Easy] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-RulesetSkinProvidingContainer.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: LegacySkin{ Name: Test Skin [test-skin] } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-LegacySkin{ Name: Test Skin [test-skin] }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🔴
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-SkinProvidingContainer+DisableableSkinSource{ skin: SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } } }.GetConfig(lookup: [ManiaSkinConfigurationLookup lookup:ColumnSpacing col:0])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-SkinTransformer{ Skin: DefaultLegacySkin{ Name: osu! "classic" (2013) } }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4])
[runtime] 2023-09-06 08:28:34 [verbose]: |-|-|-|-DefaultLegacySkin{ Name: osu! "classic" (2013) }.GetConfig(lookup: [LegacyManiaSkinConfigurationLookup lookup:ColumnSpacing col:0 totalcols:4]) 🟢
[runtime] 2023-09-06 08:28:34 [verbose]:
```
|
2023-09-06 18:03:40 +09:00 |
|
Dean Herbert
|
96f12cfbaa
|
Update GetTexture signature rather than creating new overload
|
2023-09-05 18:01:19 +09:00 |
|
Bartłomiej Dach
|
43724472c4
|
Clarify comment to avoid playing pronoun game
|
2023-02-20 20:09:24 +01:00 |
|
Dean Herbert
|
18700b4daa
|
Add note about skin migrations being on read and remove an older deprecation notice
|
2023-02-20 19:51:54 +09:00 |
|
Dean Herbert
|
6b3652f567
|
Change serialisation format of skin layouts to allow more flexibility
Also adds per-ruleset storage for each container type.
|
2023-02-17 14:19:19 +09:00 |
|
Dean Herbert
|
76f7accd13
|
Standardise all local SkinComponentsContainerLookup variables to containerLookup
|
2023-02-16 15:33:56 +09:00 |
|
Dean Herbert
|
a92e42bb84
|
Rename SkinnableTargetContainer to SkinComponentsContainer
Also use full `SkinComponentsContainerLookup` instead of the sub-type.
This will potentially be useful once we bring in per-ruleset targets.
|
2023-02-15 18:37:41 +09:00 |
|
Dean Herbert
|
e61d2d571c
|
Move the lookup type out of ISserialisableDrawableContainer
|
2023-02-15 18:37:41 +09:00 |
|
Dean Herbert
|
a7b47f6503
|
Rename ISkinnableTarget to ISerialisableDrawableContainer
|
2023-02-15 18:37:41 +09:00 |
|
Dean Herbert
|
856efd9fd9
|
Rename SkinnableDrawableInfo to SerialisedDrawableInfo
|
2023-02-15 18:23:19 +09:00 |
|
Dean Herbert
|
8bbd00822c
|
Simplify and rename SkinnableTargetComponentsContainer
|
2023-02-15 17:30:21 +09:00 |
|
Bartłomiej Dach
|
c5e1f54185
|
Fix sample store creation mutating shared resource store
|
2023-01-30 20:48:52 +01:00 |
|
Dean Herbert
|
8caf960f9a
|
Revert weird nullable changes to Skin.cs
|
2023-01-25 14:43:46 +09:00 |
|
Dean Herbert
|
0a9b20d5d5
|
Split lookup store into own file / class
|
2023-01-25 14:43:46 +09:00 |
|
Dean Herbert
|
c1a5c16973
|
Reduce maximum texture size to a more commonly-supported 8192
|
2023-01-25 14:43:46 +09:00 |
|
Dean Herbert
|
d000a4ed28
|
Make sure to dispose of the original texture upload as we are replacing it
|
2023-01-25 14:43:46 +09:00 |
|
Dean Herbert
|
598c6fcbad
|
Add basic support for stupidly long hold note skin textures
|
2023-01-25 14:43:46 +09:00 |
|
Berkan Diler
|
c7ca4bbba5
|
Use generic Enum methods
|
2022-12-26 20:36:39 +01:00 |
|
Dean Herbert
|
eae8530722
|
Fix SkinnableSprite lookups broken in lazer-first skins
Regressed with removal of local `GetTexture` calls in e19ba65f91
|
2022-11-13 12:46:21 +09:00 |
|
Dean Herbert
|
1aa0e40f2f
|
Add "Component" prefix to lookup naming
|
2022-11-09 17:46:43 +09:00 |
|
Dean Herbert
|
e75c3b3f94
|
Rename SkinnableTarget to GlobalSkinLookup
|
2022-11-09 17:46:43 +09:00 |
|
Dean Herbert
|
c908969d9b
|
Rename ISkinComponent to ISkinLookup
|
2022-11-09 17:46:43 +09:00 |
|
Dan Balasescu
|
c4b9b2a14b
|
Merge branch 'master' into irenderer-glwrapper
|
2022-08-05 20:35:06 +09:00 |
|
Dan Balasescu
|
6632367c6d
|
Ensure skin samples are looked up in correct order
|
2022-08-04 14:48:12 +09:00 |
|
Dan Balasescu
|
b4e55f7309
|
Apply IRenderer changes
|
2022-08-02 19:50:57 +09:00 |
|
Dean Herbert
|
93b783d9ea
|
Fix previous skins not loading due to namespace changes
|
2022-07-31 03:25:38 +09:00 |
|