1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-16 09:22:58 +08:00
Commit Graph

362 Commits

Author SHA1 Message Date
Bartłomiej Dach
3640342805
Add logging on comment post failure 2023-01-17 21:30:46 +01:00
ansel
1480c691ae Explain empty string in editor's footer 2023-01-14 23:42:56 +03:00
ansel
c36922dd2c Use clock to obtain a position for comment insertion 2023-01-14 22:57:51 +03:00
ansel
c2bb0949f5 Take type and id from container directly on submit 2023-01-14 22:57:23 +03:00
ansel
cdf3aafddd Add check for any drawables in content before looking for placeholder 2023-01-14 22:37:05 +03:00
ansel
88c3eef8e1 Add test case with no existing comments 2023-01-14 20:59:13 +03:00
ansel
bb8bcd7248 Move avatar update bind to LoadComplete 2023-01-14 02:50:30 +03:00
ansel
9e7ecbf4a1 Adapt to changes in base class 2023-01-14 02:41:11 +03:00
ansel
e9995410e8 Merge branch 'master' into comment-editor-3 2023-01-14 02:32:06 +03:00
ansel
0bd1c46c74 Undo sizing changes 2023-01-12 19:48:11 +03:00
ansel
b38cf8c56c Use empty string as default 2023-01-11 02:26:25 +03:00
Dean Herbert
23a78e6fad Combine commit button enabled handling 2023-01-10 23:59:17 +09:00
ansel
23e4cfb469 Show spinner next to buttons and get rid of EditorCommitButton 2023-01-09 23:37:36 +03:00
Dean Herbert
13b00928c8 Rename loading spinner bool to reflect that it has a setter 2023-01-09 15:52:18 +09:00
ansel
927773d565 Display submitted comments locally 2023-01-07 04:15:43 +03:00
ansel
32e90829e3 Integrate comment editor into container 2023-01-07 02:59:24 +03:00
ansel
387326db0d Make commit action abstract 2023-01-06 22:51:57 +03:00
Feodor0090
930cd15649
Merge branch 'master' into comment-editor-1 2022-12-28 17:46:01 +05:00
cdwcgt
ffa32307c3
abstract ReportPopover 2022-12-21 01:37:16 +09:00
Bartłomiej Dach
db1380a346
Refactor markdown extension management 2022-12-19 20:19:51 +01:00
Dean Herbert
b64a5cbda6 Merge branch 'master' into guard-url-protocols 2022-12-19 15:46:45 +09:00
Joseph Madamba
6e62033bc4 Fix some comment actions not being lowercased 2022-12-18 20:20:15 -08:00
Dean Herbert
27c497145f Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0 2022-12-16 18:16:26 +09:00
ansel
1763618488 Fix spinner presense check & field click 2022-11-30 13:58:03 +03:00
ansel
43628903a7 Make spinner bigger 2022-11-30 13:57:09 +03:00
ansel
1cc7ffce39 Keep button's text 2022-11-30 13:40:47 +03:00
ansel
bedc771e99 Remove useless check 2022-11-30 13:32:01 +03:00
ansel
a8422961dc Rename button spinner prop again 2022-11-30 13:30:57 +03:00
ansel
5ea824534b Use default button 2022-11-30 13:25:59 +03:00
ansel
642e0ac718 Increase footer height to look better with default buttons 2022-11-30 13:25:18 +03:00
ansel
956acbc86f Use fixed width 2022-11-30 13:11:54 +03:00
Dean Herbert
4a747182b4 Merge branch 'master' into comment-editor-1 2022-11-30 17:22:59 +09:00
ansel
e30d97c94e Comments 2022-11-29 14:39:59 +03:00
ansel
84aaf5fedf Change ways to access submit button state 2022-11-29 14:37:35 +03:00
ansel
6c126f5223 Remove useless local actions on click 2022-11-29 14:25:51 +03:00
ansel
16962d9a57 Localize deleted string 2022-11-29 07:02:02 +03:00
ansel
a4819e5c9c Localize actions 2022-11-29 07:01:52 +03:00
ansel
472d9274b6 Reorder members 2022-11-29 06:23:25 +03:00
ansel
af0ee9dbd6 Make spinner a little bigger 2022-11-29 06:19:54 +03:00
ansel
894fb98fa2 Rebase CommitButton to RoundedButton 2022-11-29 06:17:02 +03:00
ansel
a874345da0 Rebase CancelButton to RoundedButton 2022-11-29 05:46:30 +03:00
ansel
d20dc3668e Enable nullability 2022-11-29 05:17:44 +03:00
ansel
8b033bf9f7 Allow localisable strings 2022-11-29 05:13:54 +03:00
Dan Balasescu
7bc8908ca9 Partial everything 2022-11-27 00:00:27 +09:00
Dean Herbert
1edde8f73c Merge branch 'master' into disabled-button-sfx 2022-11-03 20:27:41 +09:00
Jamie Taylor
59bbd9c460
Fix some components using wrong sample set 2022-11-03 17:47:49 +09:00
Salman Ahmed
6c82bc36ed Encapsulate report logic inside button implementation
Avoids complicating the `DrawableComment` class, and allows for isolated
testability.
2022-10-22 02:48:27 +03:00
Salman Ahmed
9b5e35d599 Remove dependency on DrawableComment from report popover and simplify logic
Allows for testing the button and popover in isolation.
2022-10-22 02:47:33 +03:00
Salman Ahmed
081cf1cc47 Adjust comment report popover design 2022-10-22 02:45:31 +03:00
ansel
15aeb4a137 Display text in buttons flow instead of toast 2022-10-21 17:25:41 +03:00
ansel
81bdf716ef Change test 2022-10-20 19:56:00 +03:00
ansel
0ef903230c Make report button a separate component 2022-10-20 18:47:42 +03:00
ansel
da4f04ace7 Make dropdown not resize 2022-10-20 18:22:55 +03:00
ansel
635900085c Disable button when there is no text 2022-10-20 18:12:20 +03:00
ansel
ed39481932 Use another string for title 2022-10-20 18:11:35 +03:00
ansel
3258a41ca3 Merge branch 'comment-report' of https://github.com/Feodor0090/osu into comment-report 2022-10-17 20:41:46 +03:00
ansel
cd77ae062e Localize the button 2022-10-17 20:41:23 +03:00
ansel
797acf334f Show username in popup 2022-10-17 20:41:13 +03:00
Feodor0090
6efe7b5334
Merge branch 'master' into comment-report 2022-10-17 16:08:13 +03:00
ansel
ceb4d624b5 Delete wip form 2022-10-17 13:43:35 +03:00
ansel
ffa22d8a68 Update popover not to use labelled drawables 2022-10-17 13:42:17 +03:00
ansel
7ed26369a3 Make a new report form, closer to web 2022-10-17 12:41:57 +03:00
ansel
4a8d976cb4 Use api's endpoint 2022-10-16 20:20:34 +03:00
ansel
ba595ab8fa Display toast instead of notification 2022-10-16 19:57:21 +03:00
ansel
9822a092c4 Add localization for enum 2022-10-16 19:50:55 +03:00
ansel
dc0aa2295a Add test 2022-10-14 16:51:48 +03:00
ansel
3e9fd4c08c Implement reporting flow 2022-10-14 16:26:25 +03:00
ansel
c65a8a83f3 Add basic UI for reporting 2022-10-14 15:52:09 +03:00
ansel
8a47628fe1 Use spacer drawable instead of spacing on links container 2022-10-14 00:04:13 +03:00
ansel
295e6f5a68 Move toast to it's namespace 2022-10-13 23:57:25 +03:00
ansel
34ff072a9b Change text 2022-10-13 22:47:48 +03:00
ansel
a0cca391f6 Add copy link button to comments 2022-10-13 22:18:26 +03:00
Dean Herbert
e43c8e84b0 Use Show instead of Alpha=1 2022-10-12 15:48:42 +09:00
ansel
c384093802 Update main test and add failure scenario test 2022-10-08 18:53:41 +03:00
ansel
b697200460 Properly modify comment visual state on deletion 2022-10-08 18:41:08 +03:00
ansel
4e7c30504f Schedule action buttons visibility changes 2022-10-08 17:15:10 +03:00
ansel
abf56c27a1 Do not requere dialog overlay 2022-10-08 17:11:09 +03:00
ansel
85adfc2df7 Fix DI type 2022-09-28 18:26:36 +03:00
ansel
636befb499 Add visual feedback for deleting process 2022-09-28 17:49:37 +03:00
ansel
ae0d62838b Move API and DO to fields 2022-09-27 22:46:23 +03:00
ansel
58d9509ce6 Apply NRT to Comment 2022-09-27 22:45:05 +03:00
ansel
60ee813e45 Implement delete button 2022-09-27 18:33:16 +03:00
ansel
31a7ba3f91 Add delete button 2022-09-27 18:23:15 +03:00
Salman Ahmed
5e4e3dfc2c Fix markdown container not rendering certain text correctly 2022-09-10 02:55:20 +03:00
basseX
383afe04f3 Remove not needed override 2022-08-14 15:15:36 +02:00
basseX
932becc4b2 Remove CommentMarkdownTextFlowContainer and rather use base-class OsuMarkdownTextFlowContainer 2022-08-14 10:11:49 +02:00
basseX
b05acb0073 Make CommentMarkdownTextFlowContainer render images 2022-08-13 21:32:24 +02:00
Dean Herbert
31a447fda0 Update parameter discards 2022-06-24 21:26:19 +09:00
Dan Balasescu
f8830c6850 Automated #nullable processing 2022-06-17 16:37:17 +09:00
Joseph Madamba
5e5c8e78a6 Use existing web localisation for most hardcoded strings 2022-04-20 16:31:11 -07:00
Susko3
19467e58c1 Remove unused params from BDL methods 2022-01-15 01:06:39 +01:00
Joseph Madamba
98524d60a4 Fix clear identifier typos 2021-12-27 20:26:28 -08:00
Bartłomiej Dach
6d30248cef
Merge branch 'master' into use-class-rename 2021-11-07 15:41:00 +01:00
Dean Herbert
0ecf5f201c Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
Salman Ahmed
f013a1e37f Move CreateContent() to BDL 2021-11-05 10:13:42 +03:00
Salman Ahmed
3a3ec1436b Re-enable possible null refernece exception inspections and move code 2021-11-05 09:14:50 +03:00
Salman Ahmed
4245af28e1 Disable other false-positive null inspections with comment 2021-11-05 04:50:58 +03:00
Dean Herbert
6944151486 Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Dean Herbert
a5f6c287ea Split out pinned comment content to only be constructed when required 2021-08-24 14:43:28 +09:00
Gagah Pangeran Rosfatiputra
9233f396aa
centered thumbtack icon and text 2021-08-14 00:22:01 +07:00