214 Commits

• Improve visuals of tournament song bar

  This is a stop-gap until we add new versions (and share between game and tournament client).

  Dean Herbert · 2023-08-16 17:16:36 +09:00
  f02416f877
• let MatchIPCInfo .Beatmap be nullable
  cdwcgt · 2023-08-09 19:13:49 +09:00
  5ad80879b7
• remove nullable for Box
  cdwcgt · 2023-07-30 02:49:13 +09:00
  ba80d1e2d5
• string mod should not null

  Already assigned in the constructor

  cdwcgt · 2023-07-30 02:41:45 +09:00
  0590121309
• remove #nullable disable in tournament
  cdwcgt · 2023-07-29 22:25:06 +09:00
  8a06914438
• Fix potential startup crash due to early application of animations

  This was always haphazard code, but by luck it never triggered before
  drawable load until now. With the recently nullability changes, this
  would be triggered when `flash` is not yet constructed.
  
  Switching to `AddOnce` seems safer to avoid multiple applications,
  regardless.

  Dean Herbert · 2023-07-28 17:17:15 +09:00
  f58c69e639
• Fix even more missed nullability-related inspections
  Bartłomiej Dach · 2023-07-27 22:10:41 +02:00
  3c923b9e81
• Apply NRT and avoid throws from null RoundBeatmap.Beatmaps
  Dean Herbert · 2023-07-26 17:49:07 +09:00
  fa4992f05a
• Merge pull request #24346 from cdwcgt/tournament-no-unload-cover

  Use `DelayedLoadWrapper` in `TournamentBeatmapPanel` to avoid beatmap cover unload in map pool

  Dean Herbert · 2023-07-25 16:27:52 +09:00
  04c1333b59
• Reword comments to make more sense
  Dean Herbert · 2023-07-25 16:15:16 +09:00
  7b3bd0b042
• set LoadDelay to 0
  cdwcgt · 2023-07-25 07:45:48 +09:00
  6f66e2fdd7
• Fix dodgy implementation of current bindable in DateTextBox
  Dean Herbert · 2023-07-25 01:46:45 +09:00
  e0c0797f55
• Use DelayedLoadWrapper to avoid beatmap cover unload in map pool
  cdwcgt · 2023-07-25 00:52:02 +09:00
  fd4d3a6d66
• Never remove significant digits from stsar rating displays

  Closes https://github.com/ppy/osu/issues/24079.

  Dean Herbert · 2023-06-29 13:55:04 +09:00
  34f53965c4
• Remove no-longer-needed BDL permitNulls spec
  Bartłomiej Dach · 2023-06-25 17:39:15 +02:00
  7d9d7066cd
• Use alternative guard

  Early-returning from ctors feels pretty bad. Also saves on some
  nested accesses.

  Bartłomiej Dach · 2023-06-25 17:37:05 +02:00
  9862992af0
• null guard for Current Match in MatchMessage
  cdwcgt · 2023-06-25 20:46:58 +09:00
  a3cd0d14a3
• Revert nullability enables in tournament client

  Not trivial to fix right now and I'm not fixing in a 1k-line changeset.

  Bartłomiej Dach · 2023-06-24 16:05:19 +02:00
  caf5673b68
• Merge branch 'master' into mass-nrt
  Dean Herbert · 2023-06-24 09:59:15 +09:00
  2bda63c2c8
• Manual fixes to reduce warnings to zero
  Dean Herbert · 2023-06-24 01:52:53 +09:00
  df5b389629
• Automated pass
  Dean Herbert · 2023-06-24 01:00:03 +09:00
  0ab0c52ad5
• let team member color match their team color
  cdwcgt · 2023-06-12 22:11:06 +09:00
  2da8335da2
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Construct notifications client inside ChannelManager
  Dan Balasescu · 2022-11-04 18:51:00 +09:00
  fa18b5f701
• Remove unused using
  Dan Balasescu · 2022-11-02 15:23:11 +09:00
  58c6b026ae
• Fix one more case of constructing connector directly
  Dan Balasescu · 2022-11-02 15:22:46 +09:00
  fe66b20702
• Use polling connector in tests
  Dan Balasescu · 2022-10-28 18:08:08 +09:00
  169bcc2654
• Adjust ChannelManager to use notifications client
  Dan Balasescu · 2022-10-28 16:28:58 +09:00
  2f731f86ba
• Fix team name not updating on TeamDisplay immediately
  Dean Herbert · 2022-07-13 18:10:27 +09:00
  1516756d8b
• Find video by recursive check rather than marker interface

  Seems a lot more reliable, and allows falling back to the "main" video
  in cases which didn't support this previously.
  
  A next step may be to allow every screen to support a video based on its
  screen name, rather than specifying the local `TourneyVideo` every time.

  Dean Herbert · 2022-07-11 20:42:05 +09:00
  73e924479f
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Merge pull request #18751 from frenzibyte/tournament-beatmap

  Improve tournament beatmap JSON storage using lightweight model

  Dean Herbert · 2022-06-18 11:00:26 +09:00
  f3c9f9a216
• TournamentPlayer -> TournamentUser
  Salman Ahmed · 2022-06-18 02:33:26 +03:00
  4c47996130
• Replace tournament beatmap storage type with lightweight model
  Salman Ahmed · 2022-06-18 01:34:09 +03:00
  9f97d1a7db
• Replace tournament player storage type with lightweight model
  Salman Ahmed · 2022-06-17 21:35:04 +03:00
  b977ce7995
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Update flag sizes after switch to twemoji assets

  The old flags used a size of 150x100, while the new assets based on
  twemoji use a size of 150x108. Update existing usages to match this new
  aspect ratio better.

  Bartłomiej Dach · 2022-06-15 21:45:47 +02:00
  f88c568c8d
• Ensure ChannelManager has access to API from point of construction

  Closes https://github.com/ppy/osu/issues/18451.

  Dean Herbert · 2022-06-08 19:15:23 +09:00
  c661f2b059
• Display star ratings in tournament mode using two decimal places
  Dean Herbert · 2022-02-27 23:17:04 +09:00
  df4170b939
• Remove unused constants
  Dean Herbert · 2022-02-27 23:16:04 +09:00
  297e5ec62e
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Turn on high poll rate when tournament chat is expanded
  Salman Ahmed · 2022-01-22 16:34:57 +03:00
  b2d1bd029d
• Remove unused params from BDL methods
  Susko3 · 2022-01-15 01:06:39 +01:00
  19467e58c1
• Cache and consume IRulesetStore where feasible
  Dean Herbert · 2021-12-03 18:16:01 +09:00
  e75e209053
• Migrate custom tournament client assets to uppercased directories

  It has transpired that on filename-case-sensitive filesystems, the
  tournament client does not consistently handle custom asset paths.
  Videos and mods could only be looked up from `videos` and `mods`
  directories (lowercase), while flags could only be looked up from the
  `Flags` directory (uppercase).
  
  A complicating circumstance is that default country flags, coming from
  osu-resources, also depend on the flag lookup being uppercased.
  
  To attempt to clean up the handling as much as it appears to be
  possible, automatically move user-supplied lowercase directories to
  uppercase.

  Bartłomiej Dach · 2021-11-28 16:36:19 +01:00
  87d6a743dd
• Update all actual usages of RulesetInfo.ID to use OnlineID instead
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  bbd3ea5b77
• Update existing usages of Author as string to access Username directly
  Dean Herbert · 2021-11-04 18:57:54 +09:00
  86540d1fb6
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-04 18:21:31 +09:00
  b9983add15
• Fix beatmap creator showing twice in tournament map pool panels
  Dean Herbert · 2021-11-01 14:33:24 +09:00
  10a9266956