Givikap120
f3251bfcfd
reset to miss instead of 0
2024-11-05 22:15:18 +02:00
Givikap120
ec046651b2
Update OsuPerformanceCalculator.cs
2024-11-05 22:08:43 +02:00
Bartłomiej Dach
00e795cf76
Merge pull request #30484 from peppy/store-scale-origin-mode
...
Remember origin for editor scale/rotation popover
2024-11-04 12:58:06 +01:00
Bartłomiej Dach
e2a4a9b300
Fix rotation popover potentially crashing due to activating selection origin just before disabling it
2024-11-04 10:58:48 +01:00
Bartłomiej Dach
f616c7b752
Fix scale clamps undoing the intended 5% scaling minimum
2024-11-04 10:36:49 +01:00
Dean Herbert
3a3471c202
Remember origin for editor rotation popover
2024-11-03 15:23:55 +09:00
Dean Herbert
b03963ac84
Remember origin for editor scale popover
2024-11-03 15:20:51 +09:00
Dean Herbert
57227b5aab
Allow scaling down to 5% in popover scale dialog
...
Request from mapper IRL.
2024-11-03 14:19:57 +09:00
Dan Balasescu
c1a40388ff
Cap effective miss count to total hits
2024-10-30 23:47:56 +09:00
Joseph Madamba
74dc0dc480
Fix editor sidebar resizing on hover repeatedly when polygon popover is opened
2024-10-29 20:24:46 -07:00
Dean Herbert
b1b0aadbfb
Merge pull request #30294 from bdach/fuzzin
...
Fix several cases of deselection not correctly terminating drag operations on slider selection blueprint
2024-10-23 18:35:52 +09:00
Dean Herbert
ba4411f72c
Merge pull request #30315 from OliBomby/popover-ux
...
Improve scale/rotate popover UX to better match user expectation
2024-10-23 18:18:24 +09:00
Dan Balasescu
71eb7120ba
Merge pull request #27691 from Finadoggie/estimation-removal
...
Remove estimations where score data is available for osu! difficulty calculations
2024-10-23 00:59:34 +09:00
Bartłomiej Dach
8349226d9f
Merge branch 'master' into barrel_roll_fix
2024-10-21 12:33:37 +02:00
StanR
acf282dddd
Fix effectiveMissCount being calculated wrong
2024-10-21 15:06:34 +05:00
StanR
bcb997028e
Refactor and add comments
2024-10-21 14:38:03 +05:00
finadoggie
98800fea71
Fix variables being used before being assigned
...
slightly miffed by the lack of build errors but oh well
2024-10-21 00:34:26 -07:00
finadoggie
5907c2a1c4
Only clamp estimated miss count with relevant statistics
2024-10-20 22:47:02 -07:00
finadoggie
3778246a55
Addressed code quality concerns
2024-10-20 22:15:15 -07:00
finadoggie
e31e10d616
merge effectivemisscount functions
...
having two functions was unnecessary
2024-10-20 21:47:01 -07:00
finadoggie
31e0853641
add large tick misses back into effectivemisscount
2024-10-20 21:39:15 -07:00
finadoggie
6d4cb608ab
Revert "use LargeTickHit instead of LargeTickMiss"
...
This reverts commit 1337b7eb41
2024-10-19 05:43:10 -07:00
finadoggie
1337b7eb41
use LargeTickHit instead of LargeTickMiss
...
LargeTickMiss appears to not be stored
2024-10-17 15:58:42 -07:00
jhk2601
7416106321
Fixes cursor rotating along with playfield when using Barrel Roll in standard
2024-10-17 14:38:13 -04:00
Dan Balasescu
80c77e6e05
Merge pull request #30281 from bdach/remove-irrelevant-hacks
...
Fix slider ticks and repeats incorrectly moved to position of head when strict tracking and any conversion mod that moves objects is active
2024-10-17 14:10:36 +09:00
OliBomby
66bf6ed6b4
Close scale/rotate popover on Enter keypress
...
This matches the expectation from stable where the popover also closes when you press enter. The side-effect is that spacebar also causes it to close, but luckily you don't need spacebar in the popover.
2024-10-16 21:53:56 +02:00
OliBomby
c5e406a007
add keyboard step matching osu stable
2024-10-16 21:18:48 +02:00
Bartłomiej Dach
882df6b828
Remove unused field
...
Not sure why inspectcode is quiet about this?
2024-10-16 09:59:05 +02:00
Bartłomiej Dach
dcf78a6e2c
Merge branch 'master' into grids
2024-10-16 09:55:27 +02:00
Bartłomiej Dach
b92cbff81d
Merge branch 'master' into scale-with-no-axes-should-do-nothing
2024-10-15 14:20:24 +02:00
Bartłomiej Dach
634f20e8de
Ensure at least scale popover axis toggle is active at any time
...
As in, toggling off an axis if it is the only one enabled will enable
the other one in turn.
Co-authored-by: Dean Herbert <pe@ppy.sh>
2024-10-15 14:12:17 +02:00
Bartłomiej Dach
232301f27d
Terminate existing anchor create operation when object is deselected
2024-10-15 12:54:11 +02:00
Bartłomiej Dach
1a7acbac33
Terminate existing anchor drag operations when object is deselected
2024-10-15 12:53:40 +02:00
Bartłomiej Dach
1f1a174c50
Remove no longer required nested object reposition hacks
...
As touched on in
https://github.com/ppy/osu/issues/30237#issuecomment-2408557766 , these
types of maneouvers are no longer required after
https://github.com/ppy/osu/pull/30021 - although as it turns out on
closer inspection, these things being there still *did not actually
break anything*, because the `slider.Path` mutation at the end of
`modifySlider()` causes `updateNestedPositions()` to be called
eventually anyway. So this is at mostly a code quality upgrade.
2024-10-14 14:26:27 +02:00
Bartłomiej Dach
275b86cd3c
Fix strict tracking mod not populating path progress for ticks/repeats
...
Closes https://github.com/ppy/osu/issues/30237 .
This is the root failure in the issue, and one that *only* presents when
another conversion mod that repositions the objects is also active. That
makes the `PathProgress` of the nesteds to be zero, therefore making
them occupy the position of the slider head after any mutation to the
path.
2024-10-14 14:26:27 +02:00
finadoggie
6bcfed8963
Revert "remove score debugging code I accidentally left in"
...
This reverts commit 5192599543
2024-10-12 16:53:32 -07:00
finadoggie
5192599543
remove score debugging code I accidentally left in
2024-10-12 16:45:34 -07:00
finadoggie
88af57818c
only assign countLargeTickMiss for slider accuracy scores
...
helps indicate it should only be used for slider acc scores
2024-10-12 15:36:42 -07:00
finadoggie
29b1697a70
consolidated if statements for getting effectiveMissCount and countSliderEndsDropped
2024-10-12 15:34:04 -07:00
finadoggie
3ac6a9f0ae
Join variable assignments with declarations
2024-10-12 15:30:02 -07:00
finadoggie
3b517e03aa
Convert estimateSliderEndsDropped assignment into '?:' expression
...
I would just like to say that I don't know why anyone would ever want this but github told me to do it
2024-10-12 01:08:39 -07:00
finadoggie
b921424461
Update to use variable usingClassicSliderAccuracy
2024-10-12 01:00:15 -07:00
Fina
3d7f4aec99
Merge branch 'ppy:master' into estimation-removal
2024-10-12 00:44:13 -07:00
Dean Herbert
05c8b3cbce
Simplify cycle logic
2024-10-12 02:18:36 +09:00
Bartłomiej Dach
4e8e4a34bd
Fix scale popover doing things when both scale axes are turned off
...
Spotted in passing when reviewing https://github.com/ppy/osu/pull/30080 .
The popover would very arbitrarily revert to scaling by Y axis if both
checkboxes were checked off.
Not sure how this passed review.
2024-10-11 15:18:43 +02:00
Bartłomiej Dach
5db1f05953
Merge branch 'master' into clamp-scale2
2024-10-11 15:13:54 +02:00
Bartłomiej Dach
d1da1d4079
Rename methods to fit new changes better
2024-10-11 15:03:30 +02:00
OliBomby
550e575221
Rename "Cycle grid display mode" to "Cycle grid spacing"
...
The "display mode" is easy to confuse with grid type, so I renamed it to literally the grid property it affects.
2024-10-11 14:09:50 +02:00
OliBomby
ada20d230a
Fix grid type cycling not taking into account the radio button selection
2024-10-11 14:09:50 +02:00
OliBomby
b93bc21e45
Add back the old keybind for cycling grid spacing
2024-10-11 14:09:50 +02:00
