296 Commits

• Remove lifetime override of DrawableManiaHitObject

  The `AlwaysAlive` logic is now in all DHOs and it is now not necessary (and potentially conflicting).

  ekrctb · 2021-06-17 10:15:24 +09:00
  a4f362dca6
• Fix DrawableHoldNote retaining hit states through applications
  smoogipoo · 2021-05-12 17:07:42 +09:00
  f992b59b4f
• Fix base.OnLoadComplete() not being called
  smoogipoo · 2021-05-12 17:06:44 +09:00
  1af3bbf400
• Fix crashes
  smoogipoo · 2021-05-12 16:40:46 +09:00
  4e7551d50e
• Initial implementation of DHO pooling
  smoogipoo · 2021-05-12 16:35:05 +09:00
  5692cecaa4
• Fix mania crashing on playing samples after skin change
  smoogipoo · 2021-05-11 16:21:21 +09:00
  713c169332
• Tidy up implementation in DrawableNote
  Dean Herbert · 2021-05-01 20:39:10 +09:00
  db815f7930
• Replace BeatDivisorFinder with GetClosestBeatDivisor
  Justus Franklin Tumacder · 2021-05-01 11:57:47 +08:00
  fdf8c12947
• Merge branch 'master' of https://github.com/ppy/osu into justusft/mania-color-snap
  Justus Franklin Tumacder · 2021-05-01 11:20:28 +08:00
  ecb053b0de
• Add visual tests for timing based note coloring
  Justus Franklin Tumacder · 2021-04-27 19:02:57 +08:00
  c4d28110d6
• Add concurrent objects check

  Here we use `IHasColumn` to support rulesets with columns, and so I moved that interface out into `osu.Game` from `osu.Game.Rulesets.Mania`.
  
  We also use the same threshold as the unsnap check to ensure that no problems slip through. Specifically where an object is simultaneously not concurrent and not unsnapped but still on the same tick.

  Naxess · 2021-04-26 20:17:18 +02:00
  a3570e18dd
• Rename ColourCodedNotes to TimingBasedNoteColouring
  Justus Franklin Tumacder · 2021-04-26 19:05:12 +08:00
  559d403abe
• Move BindValueChanged hooks to LoadComplete()
  Justus Franklin Tumacder · 2021-04-26 19:00:40 +08:00
  58ebec4803
• Rename {Snap -> BeatDivisor}Finder
  Bartłomiej Dach · 2021-04-25 17:44:26 +02:00
  e14255f395
• Reduce casting
  Bartłomiej Dach · 2021-04-25 17:41:23 +02:00
  afb67726f0
• Use null-permitting BDL to reduce number of fields
  Bartłomiej Dach · 2021-04-25 17:40:23 +02:00
  f9e228d6bf
• Fix cake errors
  Justus Franklin Tumacder · 2021-04-25 09:21:25 +08:00
  211bff6a8f
• Remove caching for ConfigColourCodedNotes
  Justus Franklin Tumacder · 2021-04-25 08:32:49 +08:00
  8b9d2a6cff
• Simplify DrawableNote
  Justus Franklin Tumacder · 2021-04-25 08:11:44 +08:00
  d3db19c3ce
• Move SnapFinder from mania ruleset to osu.Game
  Justus Franklin Tumacder · 2021-04-25 07:35:53 +08:00
  e0ca44c908
• Fix cake errors
  Justus Franklin Tumacder · 2021-04-24 22:12:07 +08:00
  bedabc1ddf
• Fix visual tests missing dependency for ColourCodedNotes
  Justus Franklin Tumacder · 2021-04-24 21:28:48 +08:00
  8b01082cbb
• Move snapping logic into SnapFinder
  Justus Franklin Tumacder · 2021-04-24 21:28:35 +08:00
  3103fd8343
• Remove ManiaColourCode in favor for boolean
  Justus Franklin Tumacder · 2021-04-24 20:39:22 +08:00
  a8b401522b
• Move color snap logic from Note to DrawableNote
  Justus Franklin Tumacder · 2021-04-24 19:53:21 +08:00
  d6d81fb8e5
• Remove beatmap argument in Note
  Justus Franklin Tumacder · 2021-04-24 19:37:10 +08:00
  f9905ebe68
• Add snap color option for osu!mania
  Justus Franklin Tumacder · 2021-04-24 16:23:52 +08:00
  7e3a611f95
• Fix hold note crashing with 0 length
  smoogipoo · 2021-04-22 19:51:33 +09:00
  4148d473e3
• Miss all ticks when hold note is hit
  smoogipoo · 2021-03-31 12:21:14 +09:00
  43e48406ca
• Fix mania hold note heads hiding when frozen

  This was an insidious regression from a3dc1d5. Prior to that commit,
  `DrawableHoldNoteHead` had `UpdateStateTransforms()` overridden, to set
  the hold note head's lifetime. When that method was split into
  `UpdateInitialStateTransforms()` and `UpdateHitStateTransforms()`, the
  lifetime set was moved to the former.
  
  Unfortunately, that override served two purposes: both to set the
  lifetime, and to suppress hit animations which would normally be added
  by the base `DrawableManiaHitObject`. That fact being missed led to
  `UpdateHitStateTransforms()` hiding the hold note head immediately on
  hit and with a slight delay on miss.
  
  To resolve, explicitly override `UpdateHitStateTransforms()` and
  suppress the base call, with an explanatory comment.

  Bartłomiej Dach · 2021-03-21 18:46:41 +01:00
  9a330c4c56
• Adjust namespace
  ekrctb · 2020-12-07 12:32:52 +09:00
  e3c035fe9c
• Move piece files of Mania ruleset
  ekrctb · 2020-12-07 12:31:56 +09:00
  40da799103
• Add MaximumJudgementOffset to DrawableHitObject, use in more places
  smoogipoo · 2020-11-26 01:12:42 +09:00
  0414e5c550
• Merge pull request #10877 from smoogipoo/fix-mania-judgement-displays

  Fix hold note judgements displaying incorrectly

  Dean Herbert · 2020-11-18 19:00:14 +09:00
  49b8331ccd
• Fix hold note judgements displaying incorrectly
  smoogipoo · 2020-11-17 13:37:58 +09:00
  77942af3a6
• Store time of hold note break
  Bartłomiej Dach · 2020-11-13 21:14:34 +01:00
  b62bf5798d
• Disable pressed/released action logic when rewinding
  Bartłomiej Dach · 2020-11-13 20:49:06 +01:00
  7a89e58483
• Update existing implementations
  Dean Herbert · 2020-11-04 17:14:23 +09:00
  a3dc1d5730
• Replace assignment references to HitResult.Miss with Judgement.MinResult
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  1f0620ffd4
• Replace comparison references to HitResult.Miss with IsHit
  Bartłomiej Dach · 2020-10-02 23:31:24 +02:00
  2b1ef16f89
• Don't display hold note tick judgements
  smoogipoo · 2020-09-29 16:33:38 +09:00
  e789e06c86
• Use new hit results in mania
  smoogipoo · 2020-09-29 16:33:38 +09:00
  b1877b649b
• Remove note shaking mention that doesn't apply in mania
  Bartłomiej Dach · 2020-08-31 12:03:05 +02:00
  d419fe4dbf
• Add/improve xmldoc
  smoogipoo · 2020-08-31 13:33:41 +09:00
  acbeb5406f
• Merge branch 'master' into mania-notelock
  smoogipoo · 2020-08-31 13:31:41 +09:00
  aa151e4cd7
• Implement basic mania hit order policy
  smoogipoo · 2020-08-27 20:24:21 +09:00
  deb172bb6c
• Merge branch 'master' into hold-note-lighting
  smoogipoo · 2020-08-26 20:22:07 +09:00
  1db836e9e0
• Implement hold note lighting
  smoogipoo · 2020-08-26 20:21:56 +09:00
  9372c6eef6
• Remove fade on successful hits
  smoogipoo · 2020-08-21 23:56:27 +09:00
  b3338347b7
• Fix hold notes bouncing with SV changes
  smoogipoo · 2020-08-21 23:11:15 +09:00
  8632c3adf0