75322 Commits

This Branch

This Branch

All Branches

• Fix song select not changing global beatmap correctly when switching rulesets

  Closes https://github.com/ppy/osu/issues/35113.
  
  Regressed in dfed564bda - setting
  `Carousel.CurrentSelection` was not all that
  `requestRecommendedSelection()` was doing there...
  
  A potential point of discussion is whether this global beatmap switch
  should be debounced or instant. I'm not sure I have a particularly
  well-formed opinion on that. One argument in favour of not debouncing is
  that if you look closely at the left side of the screen while the
  debounce is in progress, you can still sort of see the broken behaviour
  happen - it just doesn't stay there forever.
  
  Thankfully `ensureGlobalBeatmapValid()` being called in every scenario
  on screen suspension prevented this bug from being any worse than it is
  right now.

  Bartłomiej Dach · 2025-09-30 13:34:26 +02:00
  f66c8d10e0
• Demonstrate failure in test
  Bartłomiej Dach · 2025-09-30 13:19:03 +02:00
  ac2df49c35
• Merge pull request #35149 from smoogipoo/qp-fix-nullref

  Fix nullref when users leave quick-play rooms

  Dean Herbert · 2025-09-30 19:23:05 +09:00
  a078d4bdb4
• Merge pull request #35056 from OliBomby/anchor-snap

  Allow snapping slider control points to nearby objects in the editor

  Dean Herbert · 2025-09-30 18:01:02 +09:00
  1a084f28ff
• Merge pull request #35057 from OliBomby/snap-to-anchor

  Allow snapping to nearby visible slider control points in the editor

  Dean Herbert · 2025-09-30 18:00:31 +09:00
  a0ff7728b9
• Merge branch 'master' into qp-fix-nullref
  Dean Herbert · 2025-09-30 17:46:53 +09:00
  9860bba2f3
• Merge pull request #35151 from bdach/maybe-fix-bss-clicking

  Ensure submission progress sample is stopped when transitioning into a final state

  Dean Herbert · 2025-09-30 17:29:21 +09:00
  bb9b4a2827
• Simplify logic further
  Bartłomiej Dach · 2025-09-30 08:32:53 +02:00
  057406c910
• Merge pull request #35049 from AeroKoder/fix-scaling-sliders

  Fix certain sliders incorrectly registering as a horizontal/vertical only slider.

  Bartłomiej Dach · 2025-09-30 15:17:05 +09:00
  062174d874
• Updated moveSelectionInBounds in OsuSelectionScaleHandler to match the one in OsuSelectionHandler
  AeroKoder · 2025-09-29 09:27:01 -07:00
  41698d5848
• Merge pull request #35145 from tadatomix/song-select/coloured-group-ranks

  Colour Rank Achieved panels to the related rank

  Dean Herbert · 2025-09-29 23:40:28 +09:00
  838b8d3013
• Ensure submission progress sample is stopped when transitioning into a final state

  Probably closes https://github.com/ppy/osu/issues/35138. I'm not sure. I
  only got the issue to reproduce once, on dev, using a very large
  archive that was uploading really slowly, and then never again.
  
  The working theory is that basically handling of `progressSampleChannel`
  is quite dodgy and it could possibly, in circumstances unknown, be
  allowed to play forevermore after transitioning to failed / canceled
  state. Success state does not get this treatment because it has special
  logic to set progress to 1.

  Bartłomiej Dach · 2025-09-29 15:30:45 +02:00
  2c39e1e9db
• Remove all linq calls from getScreenSpaceControlPointNodes
  OliBomby · 2025-09-29 15:07:03 +02:00
  18549ea7dc
• dont snap inherited bspline type control points to nearby objects
  OliBomby · 2025-09-29 14:44:12 +02:00
  d76dce76ec
• Revert inline method for code abstraction
  OliBomby · 2025-09-29 14:23:19 +02:00
  40cbe58220
• Merge pull request #35128 from peppy/matchmaking-design-work

  Switch to using more standardised beatmap cards in quick play

  Bartłomiej Dach · 2025-09-29 20:15:10 +09:00
  68523a637a
• Always explicitly assign the action for beatmap cards
  Dean Herbert · 2025-09-29 17:31:45 +09:00
  3f5b71fdc3
• Fix nullref when users leave quick-play rooms
  Dan Balasescu · 2025-09-29 16:56:48 +09:00
  573d639238
• Add failing test
  Dan Balasescu · 2025-09-29 16:55:54 +09:00
  82beeec730
• Merge pull request #34934 from Valerus9/fixtestdouble

  Fix TestDouble failing on systems where the decimal separator isn't a dot

  Bartłomiej Dach · 2025-09-29 16:46:32 +09:00
  5336bcd71d
• Avoid duplicating rank name colour constants
  Bartłomiej Dach · 2025-09-29 09:44:05 +02:00
  47b6b70cae
• Adjust initial pool size for group rank displays

  11 is excessive. There can ever be at most 9 of these panels, ever,
  because there are at most 9 possible letter grades at this time (F, D,
  C, B, A, S, S+, SS, SS+).

  Bartłomiej Dach · 2025-09-29 09:42:36 +02:00
  fd412618db
• Avoid passing the same thing three times
  Bartłomiej Dach · 2025-09-29 09:42:33 +02:00
  9dc79e6f0d
• Merge pull request #35120 from LumpBloom7/fix-toolbox-tooltip

  Fix composition tool tooltip not changing text when enabled

  Bartłomiej Dach · 2025-09-29 16:04:15 +09:00
  ba3d7392bf
• Merge pull request #35044 from Joehuu/old-badge-alignment

  Match profile badge centre alignment with web

  Bartłomiej Dach · 2025-09-29 15:57:47 +09:00
  bed9fb0ba6
• Merge branch 'master' into fixtestdouble
  Bartłomiej Dach · 2025-09-29 08:43:49 +02:00
  9257e62bac
• Use slightly nicer way of invarianting rate adjust setting value
  Bartłomiej Dach · 2025-09-29 08:39:01 +02:00
  70f683e7fa
• Remove redundant double string invariance
  Bartłomiej Dach · 2025-09-29 08:33:18 +02:00
  d1cf248b9a
• Add actual test coverage for relevant failure
  Bartłomiej Dach · 2025-09-29 08:32:09 +02:00
  295adf9f28
• Add a new test for Rank Achieved panels
  tadatomix · 2025-09-28 23:10:32 +03:00
  6ac4f482ee
• Call a new panel style, when Rank Achieved grouping is picked
  tadatomix · 2025-09-28 22:56:32 +03:00
  33791318fe
• Add a new Rank Achieved panel to BeatmapCarousel.cs
  tadatomix · 2025-09-28 22:55:22 +03:00
  cf20bbbf80
• Add a separate panel for RankAchieved group
  tadatomix · 2025-09-28 22:49:45 +03:00
  55ef221390
• Adjust stage display animation to linger for longer
  Dean Herbert · 2025-09-26 18:26:11 +09:00
  0f8d8780d3
• Keep panel backgrounds loaded
  Dean Herbert · 2025-09-26 18:26:11 +09:00
  b743506207
• Use BeatmapCard for matchmaking beatmap display
  Dean Herbert · 2025-09-26 18:09:05 +09:00
  0a17a3c4ed
• Allow visibly disabling the "go to beatmap" button

  Easiest way to make this work without rewriting the layout logic.
  
  I think it makes sense to have the button still exist there but not be
  usable on certain screens.

  Dean Herbert · 2025-09-26 18:08:47 +09:00
  da80b61f38
• Change beatmap in selection panels to always be non-null
  Dean Herbert · 2025-09-26 16:53:22 +09:00
  badeb24d56
• Improve selection animation border isolation

  I'm not final on the design, just wanted to split it out into an actual
  border element rather than an "underlay".

  Dean Herbert · 2025-09-26 16:48:56 +09:00
  76c3043913
• Handle disabled text in composition tool button
  Derrick Timmermans · 2025-09-26 09:28:04 +02:00
  c66cc5ebb1
• Scale active stage larger
  Dean Herbert · 2025-09-26 16:15:37 +09:00
  9dc5605d95
• Remove pointless TestSceneMatchmakingScreenStack

  Should always be using `TestSceneMatchmakingScreen` right?

  Dean Herbert · 2025-09-26 15:48:29 +09:00
  3af4edf051
• Simplify flash layer
  Dean Herbert · 2025-09-26 15:48:29 +09:00
  e9063dcf57
• Add context menu to show beatmap details
  Dean Herbert · 2025-09-26 14:52:23 +09:00
  d690477776
• Simplify avatar handling in beatmap selection panels
  Dean Herbert · 2025-09-26 14:39:20 +09:00
  7879e091c0
• More matchmaking renames and spacing adjusts
  Dean Herbert · 2025-09-26 14:22:55 +09:00
  702511c918
• Adjust matchmaking naming, namespaces, xmldoc (#35123)

  * Adjust matchmaking naming, namespaces, xmldoc
  
  * Change partial filenames to use `.` instead of `_` separator

  Dean Herbert · 2025-09-26 12:17:28 +09:00
  e1ba1b45b0
• Fix composition tool tooltip not changing text when enabled
  Derrick Timmermans · 2025-09-25 10:44:05 +02:00
  df795da070
• Attempt to fix flaky TestGameplaySettingsDoesNotExpandWhenSkinOverlayPresent

  See https://github.com/ppy/osu/pull/35118/checks?check_run_id=51202910556.

  Dean Herbert · 2025-09-25 15:56:48 +09:00
  12e29f0bcc
• Matchmaking stage display / screen layout design improvements (#35118)
  Dean Herbert · 2025-09-25 15:16:22 +09:00
  ff54908687