1
0
mirror of https://github.com/ppy/osu.git synced 2026-06-07 02:13:38 +08:00

Fix song select not changing global beatmap correctly when switching rulesets

Closes https://github.com/ppy/osu/issues/35113.

Regressed in dfed564bda - setting
`Carousel.CurrentSelection` was not all that
`requestRecommendedSelection()` was doing there...

A potential point of discussion is whether this global beatmap switch
should be debounced or instant. I'm not sure I have a particularly
well-formed opinion on that. One argument in favour of not debouncing is
that if you look closely at the left side of the screen while the
debounce is in progress, you can still sort of see the broken behaviour
happen - it just doesn't stay there forever.

Thankfully `ensureGlobalBeatmapValid()` being called in every scenario
on screen suspension prevented this bug from being any worse than it is
right now.
This commit is contained in:
Bartłomiej Dach
2025-09-30 13:22:45 +02:00
Unverified
parent ac2df49c35
commit f66c8d10e0
+3 -1
View File
@@ -600,7 +600,9 @@ namespace osu.Game.Screens.SelectV2
if (validBeatmaps.Any())
{
carousel.CurrentBeatmap = difficultyRecommender?.GetRecommendedBeatmap(validBeatmaps) ?? validBeatmaps.First();
var beatmap = difficultyRecommender?.GetRecommendedBeatmap(validBeatmaps) ?? validBeatmaps.First();
carousel.CurrentBeatmap = beatmap;
debounceQueueSelection(beatmap);
return true;
}
}