45877 Commits

This Branch

This Branch

All Branches

• Mark as non-null and move current bind to BDL instead
  Salman Ahmed · 2021-11-05 05:42:19 +03:00
  f528488aa2
• Merge branch 'master' into fix-more-null
  Salman Ahmed · 2021-11-05 05:14:22 +03:00
  2764ad90ea
• Disable other false-positive null inspections with comment
  Salman Ahmed · 2021-11-05 04:50:58 +03:00
  4245af28e1
• Merge pull request #15478 from bdach/fix-labelled-drawable-descriptions
  Dean Herbert · 2021-11-05 10:13:11 +09:00
  fc59e20c14
• Move action to private named method to avoid null inspection
  Salman Ahmed · 2021-11-05 03:51:08 +03:00
  36d99a2e34
• Disable another "code heurstically unreachable" with comment
  Salman Ahmed · 2021-11-05 03:50:17 +03:00
  6197ef426d
• Remove hacky code with explicit pragma disable
  Salman Ahmed · 2021-11-05 03:49:35 +03:00
  af6ae1cce5
• Fix labelled drawable descriptions not showing
  Bartłomiej Dach · 2021-11-04 21:44:08 +01:00
  4c8d6a77be
• Add failing test coverage for labelled drawable description visible
  Bartłomiej Dach · 2021-11-04 21:43:20 +01:00
  9246adc349
• Merge pull request #15468 from smoogipoo/upgrade-nvika

  Use official nvika package again

  Salman Ahmed · 2021-11-04 15:16:03 +03:00
  2021.1105.0 78ed77805f
• Merge branch 'master' into upgrade-nvika
  Salman Ahmed · 2021-11-04 14:48:42 +03:00
  9846596c02
• Merge pull request #15467 from peppy/update-framework

  Update framework

  Dan Balasescu · 2021-11-04 20:19:56 +09:00
  66509264ff
• Merge branch 'master' into upgrade-nvika
  Salman Ahmed · 2021-11-04 13:53:30 +03:00
  4b46833ee9
• Merge branch 'master' into update-framework
  Salman Ahmed · 2021-11-04 13:51:57 +03:00
  aa2711e6ec
• Merge pull request #15458 from peppy/beatmap-refactor/playlist-use-api-beatmap-extended

  Refactor `PlaylistItem` to allow `Beatmap` to be an interfaced type

  Dan Balasescu · 2021-11-04 19:23:33 +09:00
  f12a2c7767
• Use official nvika package again
  smoogipoo · 2021-11-04 19:19:00 +09:00
  30635fb476
• Update framework
  Dean Herbert · 2021-11-04 19:01:39 +09:00
  28e9b9a25f
• Merge branch 'master' into beatmap-refactor/playlist-use-api-beatmap-extended
  Dan Balasescu · 2021-11-04 18:59:04 +09:00
  45dcf187b9
• Fix unintentionally broken background update logic
  Dean Herbert · 2021-11-04 18:07:39 +09:00
  df3c3a32ce
• Merge pull request #15464 from peppy/fix-crash-on-gameplay

  Fix crash on gameplay startup if beatmap has no background

  Dan Balasescu · 2021-11-04 18:07:10 +09:00
  388c074c15
• Fix crash on gameplay startup if beatmap has no background
  Dean Herbert · 2021-11-04 17:24:40 +09:00
  b80c02b757
• Fix APIBeatmapSet.Beatmaps being IEnumerable, causing stupid issues
  Dean Herbert · 2021-11-04 16:50:14 +09:00
  5a078da4d9
• Merge pull request #15461 from peppy/fix-more-computationally-expensive

  Fix a few more "maybe null" inspections

  Dean Herbert · 2021-11-04 16:49:38 +09:00
  c820d445ad
• Merge pull request #15312 from jaswon/editor-context-menu-on-select

  Fix editor context menu requiring two right-clicks to display

  Dean Herbert · 2021-11-04 16:49:19 +09:00
  e50c961185
• Merge pull request #15460 from smoogipoo/upgrade-nvika

  Upgrade to nvika 1.0.4

  Dean Herbert · 2021-11-04 16:47:23 +09:00
  a9eef4199a
• Fix a few more "maybe null" inspections
  Dean Herbert · 2021-11-04 16:11:23 +09:00
  317506d4d7
• Merge branch 'master' into upgrade-nvika
  Dan Balasescu · 2021-11-04 16:10:23 +09:00
  63cfa69bd1
• Upgrade to nvika 1.0.4
  smoogipoo · 2021-11-04 16:03:59 +09:00
  0c14d8af23
• Use explicit primitive type specification
  Dean Herbert · 2021-11-04 16:02:37 +09:00
  09701d0af1
• Merge branch 'master' into editor-context-menu-on-select
  Dean Herbert · 2021-11-04 15:59:06 +09:00
  0f4f1349db
• Merge pull request #15456 from peppy/beatmap-refactor/beatmap-metadata-nullable-enable

  Enable nullable support on `BeatmapMetadata`

  Dan Balasescu · 2021-11-04 15:47:18 +09:00
  222c3e552b
• Add fallback for cases where BeatmapSet may be null

  Seems to only happen in tests, but better safe than sorry.

  Dean Herbert · 2021-11-04 15:22:33 +09:00
  84d36cbae7
• Fix another case of incorrect null checking in editor verification processing
  Dean Herbert · 2021-11-04 15:18:10 +09:00
  e43d91ad5d
• Add temporary disable of failing r# inspection
  Dean Herbert · 2021-11-04 15:09:04 +09:00
  09f9731d74
• Update some other missed incorrect null/empty usages
  Dean Herbert · 2021-11-04 14:50:43 +09:00
  d1e6d1cb98
• Remove nullability from IBeatmapInfo.Metadata
  Dean Herbert · 2021-11-04 14:28:39 +09:00
  a49366ff84
• Fix another couple of cases of incorrect string null/empty checking
  Dean Herbert · 2021-11-04 14:22:28 +09:00
  1e73b09e57
• Fix incorrect check on AudioFile presence
  Dean Herbert · 2021-11-04 14:02:09 +09:00
  41854f2e16
• Fix new inspections
  Dean Herbert · 2021-11-04 14:02:09 +09:00
  67d9590a79
• Fix incorrect invocation of download method in SoloSpectator
  Dean Herbert · 2021-11-04 13:50:04 +09:00
  0df339d0b8
• Add inline comment explaining why we are manually populating beatmap.BeatmapSet
  Dean Herbert · 2021-11-04 13:45:59 +09:00
  0ab50f1cc9
• Revert PlaylistItem.APIBeatmap to be private
  Dean Herbert · 2021-11-04 13:36:32 +09:00
  9f9c960fe3
• Remove unnecessary properties and parameters
  Dean Herbert · 2021-11-04 13:33:54 +09:00
  05f1fd4bc9
• Change PlaylistItem.Beatmap to be an IBeatmapInfo
  Dean Herbert · 2021-11-04 13:16:56 +09:00
  3453160a8b
• Enable nullable support on BeatmapMetadata
  Dean Herbert · 2021-11-04 12:11:42 +09:00
  772b6c6dcd
• Use APIBeatmap instead of BeatmapInfo in playlist display classes where feasible
  Dean Herbert · 2021-11-04 11:55:50 +09:00
  6fdeb66dc1
• Expose PlaylistItem.APIBeatmap for now
  Dean Herbert · 2021-11-04 11:53:26 +09:00
  1d8e253112
• Merge pull request #15447 from peppy/fix-invalid-characters-zip-export

  Fix beatmaps being exported with malformed filenames inside `.osz` zip files

  Dan Balasescu · 2021-11-04 09:03:51 +09:00
  dd948e5ada
• Merge pull request #15455 from bdach/fix-multiplayer-text-flow-usages-with-correct-hitbox

  Fix multiplayer text flow usages incorrectly wrapping text

  Dan Balasescu · 2021-11-04 08:53:18 +09:00
  e2ec8e8f40
• Fix text flow wrapping incorrectly in multiplayer usages
  Bartłomiej Dach · 2021-11-03 18:36:43 +01:00
  098fa181b4