Dan Balasescu
db512e5469
Merge pull request #7995 from bdach/fix-catch-judgement-crash
...
Fix crashes in catch upon ending combo with banana shower or juice stream
2020-02-26 08:14:34 +09:00
Bartłomiej Dach
bf36dc10a5
Fix invalid cast
...
Since introduction of IgnoreJudgement and its usage in JuiceStream
and BananaShower the hard cast in CatcherArea that was used to check
if the drawable hit object should cause the fruits on the plate explode
at the end of combo caused a hard crash instead, since IgnoreJudgement
was no longer deriving from CatchJudgement.
Replace the hard cast with a soft pattern-matched cast.
2020-02-25 23:21:54 +01:00
Bartłomiej Dach
88ec31c262
Add tests demonstrating crash
2020-02-25 22:48:47 +01:00
Lucas A
535a7989d6
Open rankings overlay on spotlights page.
2020-02-25 20:57:15 +01:00
Dean Herbert
d77420d58b
Merge pull request #7977 from peppy/expose-editor-save-to-mobil
...
Expose save option in editor to non-desktop platforms
2020-02-25 21:24:38 +09:00
Dean Herbert
efa81c9f7f
Merge pull request #7974 from peppy/fix-barline-lifetimes
...
Fix bar lines in osu!taiko and osu!mania not correctly being cleaned up
2020-02-25 21:15:27 +09:00
Dean Herbert
9557a2cd96
Use object initialiser
2020-02-25 20:52:33 +09:00
Dean Herbert
d564440fe7
Merge branch 'master' into fix-barline-lifetimes
2020-02-25 20:41:04 +09:00
Dan Balasescu
ff063b229b
Merge pull request #7973 from peppy/fix-dho-lifetimes-via-judgements
...
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
2020-02-25 20:38:29 +09:00
Dean Herbert
e44ddbeb40
Merge pull request #7989 from peppy/update-framework
...
Update framework
2020-02-25 20:37:03 +09:00
Dean Herbert
61af80c1af
Merge pull request #7982 from EVAST9919/comments-crash-fix
...
Fix potential crash when clicking on show more button in comments
2020-02-25 20:14:58 +09:00
Dean Herbert
b872f782e7
Update framework
2020-02-25 20:04:39 +09:00
Dean Herbert
8136f91ac9
Merge pull request #7969 from peppy/fix-loading-animation
...
Fix scale of loading animation on player loading screen
2020-02-25 19:27:43 +09:00
Dan Balasescu
90aa89b2e3
Merge branch 'master' into fix-loading-animation
2020-02-25 19:26:45 +09:00
Dan Balasescu
ee5203f5bc
Merge pull request #7968 from peppy/follow-point-performance
...
Improve gameplay performance via follow point renderer optimisations
2020-02-25 19:24:48 +09:00
Dean Herbert
36079236e6
Remove pointless comment
...
Co-Authored-By: Dan Balasescu <smoogipoo@smgi.me>
2020-02-25 19:22:51 +09:00
Dean Herbert
29e2e17144
Merge branch 'master' into fix-dho-lifetimes-via-judgements
2020-02-25 19:07:57 +09:00
Dean Herbert
a047456354
Revert changes to make HitObject abstract
2020-02-25 19:07:15 +09:00
Dean Herbert
d6046abe70
Only expose save for now
2020-02-25 18:59:16 +09:00
Dan Balasescu
b1686a264a
Merge branch 'master' into fix-loading-animation
2020-02-25 18:42:22 +09:00
Dan Balasescu
7e445c31b3
Merge branch 'master' into follow-point-performance
2020-02-25 18:40:39 +09:00
Dan Balasescu
d11ec392f4
Merge pull request #7967 from peppy/judgement-line-performance
...
Reduce hit error display performance overhead
2020-02-25 18:33:37 +09:00
Andrei Zavatski
c1455be855
Add tests
2020-02-25 10:29:03 +03:00
smoogipoo
f71c45cb1b
Remove shallPropagate
2020-02-25 11:30:33 +09:00
Andrei Zavatski
d8413c558b
Use fully qualified name for enum item description in CommentsHeader
2020-02-24 23:41:34 +03:00
Andrei Zavatski
a020566b1e
Add HoverClickSounds
2020-02-24 23:37:46 +03:00
Bartłomiej Dach
4cbb2a2f59
Move comment to more pertinent place
2020-02-24 21:30:27 +01:00
Andrei Zavatski
fe1f2858c1
Refactor to avoid duplicated code
2020-02-24 23:10:37 +03:00
smoogipoo
6c28fd21c7
osu-side changes
2020-02-24 20:52:15 +09:00
Andrei Zavatski
7bc9a9b3d8
Implement OverlayPanelDisplayStyleControl and UserListToolbar components
2020-02-24 07:28:33 +03:00
Dean Herbert
e6cfafffe9
Fix incorrect LifetimeStart and add todo regarding Expire usage
2020-02-24 12:24:15 +09:00
Andrei Zavatski
b0b52146ea
Fix crash when clicking on ShowMore button
2020-02-24 05:53:33 +03:00
Andrei Zavatski
0cfe1ac823
Implement UserSortTabControl component
2020-02-24 05:47:21 +03:00
Bartłomiej Dach
71c34a36ed
Use pattern matching instead of .(Has)?Value
2020-02-23 14:46:42 +01:00
Dean Herbert
575946d923
Expose save and export options in editor to non-dekstop platforms
2020-02-23 20:47:14 +09:00
Dean Herbert
be08e69862
Merge branch 'fix-dho-lifetimes-via-judgements' into fix-barline-lifetimes
2020-02-23 14:30:23 +09:00
Dean Herbert
401bf1c928
Remove unnecessary checks on NotNull attributes
2020-02-23 14:30:08 +09:00
Dean Herbert
0e29d3c4a2
Correctly expire bar lines in osu!taiko and osu!mania
2020-02-23 13:50:05 +09:00
Dean Herbert
ffc7eaa3f2
Fix hitobjects with unknown lifetimes by enforcing non-null judgement
...
We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.
This fixes BananaShower and JuiceStreams in osu!catch.
This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 13:49:06 +09:00
Andrei Zavatski
74c7e29108
Apply suggestions
2020-02-23 01:22:37 +03:00
Andrei Zavatski
db7f29cc0e
Merge remote-tracking branch 'refs/remotes/ppy/master' into changelog-retouch
2020-02-23 00:54:54 +03:00
Dean Herbert
0c3286fa5e
Merge branch 'judgement-line-performance' into follow-point-performance
2020-02-23 05:36:22 +09:00
Dean Herbert
560cf21b12
Add lenience to comparison
...
Noticed that they could still stack up on maps with hitcircles at the same point in time (centipede).
2020-02-23 05:29:17 +09:00
Dean Herbert
4949977d7e
Merge branch 'judgement-line-performance' into follow-point-performance
2020-02-23 05:14:21 +09:00
Dean Herbert
187770ee7d
Merge branch 'fix-loading-animation' into follow-point-performance
2020-02-23 05:14:18 +09:00
Dean Herbert
aaa888a7c1
Adjust spin duration to make rotation more variable
2020-02-23 05:00:38 +09:00
Dean Herbert
8dbcdebd28
Use LoadingLayer at player loading screen
2020-02-23 05:00:08 +09:00
Dean Herbert
090d9d9350
Make FollowPointRenderer a LifetimeManagementContainer
2020-02-23 04:37:04 +09:00
Dean Herbert
cb9a7ee0bb
Give FollowPointConnections a valid lifetime
2020-02-23 04:36:50 +09:00
Dean Herbert
e8ebb31517
Expire old judgement lines if too many exist
2020-02-23 03:53:51 +09:00
