Dean Herbert
f3677ab33d
Simplify depth change logic
2023-01-18 16:38:21 +09:00
Dean Herbert
17c35cf811
Merge branch 'frame-stable-cache' into skin/argon-song-progress-cleaner
2023-01-18 16:36:22 +09:00
Dean Herbert
7d0388c55c
Cache IFrameStableClock
in Player
for easier access
...
Allows directly referencing rather than going through `DrawableRuleset`.
Helps with testing and implementation of the new song progress display
(#22144 ).
2023-01-18 16:31:58 +09:00
Dean Herbert
42e9b2b48c
Tidy up clock logic in all SongProgress
classes
2023-01-18 16:29:42 +09:00
Dean Herbert
5ead85f461
Limit catch-up speed in test to emulate gameplay
2023-01-18 16:13:43 +09:00
Dean Herbert
8030194cd5
Use actual beatmap's hitobjects in test to better display density
2023-01-18 16:11:46 +09:00
Dean Herbert
8bfd853889
Fix missing comment
2023-01-18 16:11:14 +09:00
Dean Herbert
bfb75730a9
Prefix subclasses of DefaultSongProgress
with Default
2023-01-18 15:45:16 +09:00
Dean Herbert
04c0a5d728
Update TestSceneSongProgress
to properly work with new implementation
2023-01-18 15:44:19 +09:00
Dean Herbert
1e5dd9165a
Adjust SkinnableTestScene
to give more breathing room to RelativeSize
components
2023-01-18 15:37:46 +09:00
Dean Herbert
7266d8e10d
Move "show difficulty graph" settings back to respective implementations to avoid legacy version showing it
2023-01-18 15:31:55 +09:00
Dean Herbert
5a272b4bd6
Merge branch 'master' into skin/argon-song-progress-cleaner
2023-01-18 15:25:02 +09:00
Dean Herbert
742a026077
Add comment mentioning why reference clock fallback logic is required
2023-01-18 15:24:35 +09:00
Dean Herbert
e8770b84cd
Remove no longer necessary interface type
2023-01-18 15:23:55 +09:00
Dean Herbert
f9dd3f6def
Switch test to specifically target the argon verison of the progress bar
2023-01-18 15:23:55 +09:00
Dean Herbert
5429979049
Combine common code into SongProgress
base class
2023-01-18 15:23:55 +09:00
Dean Herbert
afc12e0b83
Tidy up ISongProgressBar
interface
2023-01-18 14:43:20 +09:00
Dean Herbert
45c5bd8403
Simplify HUD test to not require casting to specific ProgressBar
type
2023-01-18 14:37:09 +09:00
Dean Herbert
f7c4199a77
Merge pull request #22262 from Joehuu/chat-mention-user
...
Add ability to easily mention users in chat by right clicking username
2023-01-18 13:30:02 +09:00
Dean Herbert
736ff419c0
Merge pull request #22261 from peppy/fix-bad-operation
...
Fix song select potentially operating on `Carousel` before it is fully loaded
2023-01-18 12:06:33 +09:00
Dean Herbert
4ad79a8a0a
Move IsLoaded
check inside BeatmapCarousel
2023-01-18 12:00:47 +09:00
Dean Herbert
0a47dc733f
Merge pull request #22268 from Feodor0090/comments-margin
...
Reduce padding for too nested comments
2023-01-18 11:45:41 +09:00
ansel
ca3be71381
Track comment's nesting and reduce padding for too nested
2023-01-18 02:11:07 +03:00
ansel
12544c16ea
Remove canBeNull
2023-01-18 02:10:02 +03:00
Dan Balasescu
dddcc10ec6
Merge pull request #22266 from bdach/user-profile/update-design-stats
...
Update appearance of user statistics on profile overlay to match web
2023-01-18 07:53:40 +09:00
Joseph Madamba
dfea42fd16
Add space after username mention
2023-01-17 14:13:50 -08:00
Joseph Madamba
254c881ded
Also check null for bindable channel value
2023-01-17 14:12:48 -08:00
Bartłomiej Dach
f7c942ac10
Move user stats into detail header container
2023-01-17 22:32:24 +01:00
Bartłomiej Dach
7a475d9cf8
Move out stats from top header container
2023-01-17 22:32:15 +01:00
Bartłomiej Dach
350cce1315
Move contents of detail header to separate component
2023-01-17 22:32:12 +01:00
Bartłomiej Dach
c38f3b461c
Merge pull request #22193 from Feodor0090/comment-editor-3
...
Integrate comment editor into comments view
2023-01-17 22:21:41 +01:00
Dan Balasescu
71e25b789b
Merge pull request #22258 from ekrctb/remove-slow-test
...
Reduce number of value combinations of a test that is taking 2min+ to execute
2023-01-18 06:09:56 +09:00
Bartłomiej Dach
f5459909f9
Merge branch 'master' into comment-editor-3
2023-01-17 21:31:08 +01:00
Bartłomiej Dach
3640342805
Add logging on comment post failure
2023-01-17 21:30:46 +01:00
Bartłomiej Dach
53d968499e
Merge pull request #22254 from peppy/tournament-always-use-production-endpoint
...
Always use production (non-experimental) endpoints for tournament client
2023-01-17 20:39:17 +01:00
Bartłomiej Dach
bb4d520500
Merge branch 'master' into tournament-always-use-production-endpoint
2023-01-17 19:46:48 +01:00
Bartłomiej Dach
b27fa1beb1
Merge pull request #22255 from peppy/tournament-fix-save-changes-on-population
...
Fix tournament client not saving changes after populating new data
2023-01-17 19:46:15 +01:00
Joseph Madamba
97bd76efc6
Add ability to easily mention users in chat by right clicking username
2023-01-17 10:01:07 -08:00
Bartłomiej Dach
7dbbb7caa2
Merge branch 'master' into tournament-fix-save-changes-on-population
2023-01-17 18:49:08 +01:00
Bartłomiej Dach
9415de5cf3
Merge pull request #22256 from peppy/tournament-repopulate-ranks-after-ruleset-change
...
Fix player rank data not being re-fetched after a tournament's ruleset is changed
2023-01-17 18:47:05 +01:00
tsrk
f1989ba24d
quality: remove unused Darken
bindable boolean
2023-01-17 17:26:05 +00:00
Bartłomiej Dach
452bf92550
Fix code quality inspection
2023-01-17 18:02:06 +01:00
Dean Herbert
8e1002b744
Fix song select potentially operating on Carousel
before it is fully loaded
...
Should fix test failures like
https://github.com/ppy/osu/actions/runs/3939620830/jobs/6739690253 .
2023-01-18 01:56:18 +09:00
tsrk
d91aa341e5
refactor(ArgonSongProgress): reorder layering and make density graph visible for past time
2023-01-17 13:16:56 +00:00
tsrk
66441d4421
test: remove test for ArgonSongProgressGraph
2023-01-17 13:16:11 +00:00
ekrctb
e65108533a
Reduce number of tested value combination
...
121 combinations took 2min+
2023-01-17 22:12:06 +09:00
Dean Herbert
74bb44e05d
Fix player rank data not being re-fetched after a tournament's ruleset is changed
2023-01-17 19:00:31 +09:00
Dean Herbert
68636aeaaa
Fix tournament client not saving changes after populating new data
2023-01-17 18:56:15 +09:00
Dean Herbert
26cd70f2bf
Always use production (non-experimental) endpoints for tournament client
2023-01-17 18:46:06 +09:00
Dean Herbert
3f2077a527
Merge pull request #22079 from Joehuu/fix-pause-gameplay-action-not-closing
...
Make pause overlay close with pause gameplay action
2023-01-17 18:19:41 +09:00