osu-lazer

Refactor audio preview logic in ranked play cards to match expectations while hopefully not looking buggy anymore (#37463 )

RFC.

See https://github.com/ppy/osu/pull/37453#issuecomment-4289403735 for
why.

Of note:

- To facilitate mutual exclusivity of playback `PlayerHandOfCards`
maintains a bindable pointing at the currently playing song preview.
- Because of how card drawables are passed between multiple parenting
drawables, some of which are and some of which are not
`PlayerHandOfCards` instances, DI fails horribly at working with this
bindable unless it is manually managed. See relevant overrides in
`PlayerHandOfCards`.
- I renamed one of the overloads of `HandOfCards.RemoveCard()` to
`DetachCard()` because I found the fact that there are two overloads of
one method that do WILDLY DIFFERENT THINGS utterly *asinine*. (One
overload scrapes the `RankedPlayCard` out for you to plop elsewhere. One
*drops it on the floor entirely*.)

This took way too long to write.

Bartłomiej Dach · 2026-04-22 12:48:45 +09:00

2026.422.0-lazer f1a9be4a19

Code quality improvements for child/draw order handling in HandOfCards (#37423 )

Attempt at adressing the points made in
https://github.com/ppy/osu/pull/37419#issuecomment-4279123323

- `CardContainer` is now being sorted immediately instead of only doing
it once per frame. Given that its only ever gonna have a handful of
children there wasn't really a need to optimize that that in the first
place.
- `HandOfCards.Cards` now exposes `cardLookup.Values` as an
`IEnumerable` instead of exposing the card container's children
directly.
- `HandOfCard` now exposes `GetCardsInDisplayOrder` which returns a copy
of all cards in display order. Since it's making a copy I made sure this
isn't called on any hot code paths.
- `HandOfCard.Clear` previously didn't clear the `cardLookup`
dictionary. Didn't cause any issues since we're not re-adding cards to
the hand anywhere but not good regardless.
Switched to looping over all cards and calling `RemoveCard` to make sure
changes to the removal logic can't get overlooked there again.

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

maarvin · 2026-04-21 22:54:36 +09:00

7b0e5ecc13

Rewrite ranked play card song preview playback logic to hopefully work around framework breakage (#37453 )

Similar idea to
https://github.com/ppy/osu/commit/622216d8911832c39fa4e126b2810e4e0f46cbf7
(which was included in https://github.com/ppy/osu/pull/37218).

Probably closes https://github.com/ppy/osu/issues/37420.

I wouldn't be myself if I didn't remark that the WTF/sec on ranked play
code continues to be quite high as I fix these issues. Like, look at the
old code: why does `Enabled` becoming false stop the preview track, but
`CardHovered` becoming false *doesn't*? Even though `shouldBePlaying`
was explicitly defined as derived from *both flags*? Maybe me changing
this to be actually consistent incurs a behaviour change, but like... I
can't tell if it is a bug or not.

Not to mention this nugget:


https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Hand/HandOfCards.HandCard.cs#L107

https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs#L47-L50

What is this naming even?

Bartłomiej Dach · 2026-04-21 22:19:25 +09:00

71b3d51ed5

Use placeholder user models in ranked play if online lookups fail (#37455 )

Suboptimal? Sure. But the primary goal is not to crash. Crashing is a
failure of the game programmer.

Better can be done later.

Remedies/fixes https://github.com/ppy/osu/issues/37421.

Bartłomiej Dach · 2026-04-21 22:16:45 +09:00

71356a9455

Do not cache null values in beatmap lookup cache (#37456 )

RFC.

The reason I'm bringing this up is
https://github.com/ppy/osu/issues/37383.

In this case, the retrieval of the beatmap failed on a timeout:

```
2026-04-19 02:43:10 [verbose]: Request to https://osu.ppy.sh/api/v2/beatmaps/?ids[]=5090069 failed with System.Net.WebException: Request to https://osu.ppy.sh/api/v2/beatmaps/?ids[]=5090069 timed out after 10 seconds idle (read 0 bytes, retried 0 times)..
2026-04-19 02:43:10 [verbose]: Failing request osu.Game.Online.API.Requests.GetBeatmapsRequest (System.Net.WebException: Request to https://osu.ppy.sh/api/v2/beatmaps/?ids[]=5090069 timed out after 10 seconds idle (read 0 bytes, retried 0 times).)
```

```
2026-04-19 02:43:10 [error]: Failed to load beatmap 5090069 for playlistItem 0.
2026-04-19 02:43:10 [verbose]: ⚠️ Failed to load beatmap 5090069 for playlistItem 0.
```

This fails at


https://github.com/ppy/osu/blob/0e9664bfdfa69b4b26ff9cf84615c4b83a195a0e/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Card/RankedPlayCard.cs#L167-L171

Just this failing wouldn't cause the game to soft-lock; when I suppress
the lookup locally, the game continues as normal. *However*, suppressing
the lookup is not the same as the lookup *failing*, because a failed
lookup will write a null to the cache, which means that when a beatmap
download is initiated later in


https://github.com/ppy/osu/blob/1b488949e13568c23faa0d88b18c8036f4a7dbc8/osu.Game/Screens/OnlinePlay/Matchmaking/Match/ScreenMatchmaking.cs#L308-L320

it'll just do nothing and the user will be stuck, even though they could
very well attempt to download the beatmap here if the lookup were to
succeed on the second go.

To a degree changing the whole cache for this could be viewed as the
tail wagging the dog, but I think in general caching nulls here seems
pretty anti-user. From within the client I would generally not expect
very many complete misses when looking up beatmaps.

Note that this wouldn't soft-lock the match anymore since
https://github.com/ppy/osu-server-spectator/pull/471. It's just another
step in making degradation less impactful.

Bartłomiej Dach · 2026-04-21 22:12:50 +09:00

553c20397a

Attempt to improve safety of pushing matchmaking screens (#37452 )

Due to the push of the relevant screens being delayed it's possible that
the room goes away between the scheduling of the push and the actual
execution of the push.

This maybe closes https://github.com/ppy/osu/issues/37374 but my hopes
are not high.

Includes some extra cleanups I noticed along the way.

Bartłomiej Dach · 2026-04-21 19:11:35 +09:00

1eee6dc870

Implement WebSocket server skeleton for external integrations (#37335 )

- Supersedes / closes https://github.com/ppy/osu/pull/18129. Reasons I
didn't use that PR are hopefully obvious upon comparing diffs but I can
elaborate if they are not.
- Single metric included for demonstration purposes.
- Do not want to talk about further schema design at this time.
- Specify `OSU_WEBSOCKET_SERVER=1` envvar to enable.
- Can test consumption with [this five minute html
job](https://github.com/user-attachments/files/26839923/index.html)
(works even as a standalone file opened in browser, no CORS bs!)
- There's a lot of inline comments, go read them. There are many WTFs
because the .NET frozen websocket API is weird and stanky and reeks of
the year 2007. The inline comments attempt to explain.

Bartłomiej Dach · 2026-04-21 18:25:12 +09:00

9a2846539f

Fix ranked play chat deselecting when typing shift-numbers (#37450 )

Fixes https://github.com/ppy/osu/issues/37434

---------

Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

Dan Balasescu · 2026-04-21 11:07:11 +02:00

a7ac628e94

Disable discord invites for ranked play (#37439 )

Closes #37196

Zihad · 2026-04-21 08:24:38 +02:00

b3987741d6

Hide beatmap download notification in ranked play (#37444 )

Similar implementation to `BundledBeatmapDownloader`. The notification
should not be cancellable, but there's no easy way to do that right now
other than hiding the notification altogether.

The beatmap availability status visible on the corner pieces is probably
a little too small/hides importance, but that will be addressed later to
make up for this.

Dan Balasescu · 2026-04-21 08:04:45 +02:00

4f02594265

Update resources

Dean Herbert · 2026-04-21 00:05:56 +09:00

2026.421.0-lazer 0ecb8926bd

Fix illegible star rating text colour in ranked play intro animation (#37429 )

Closes https://github.com/ppy/osu/issues/37406.

I almost applied

```diff
diff --git a/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs b/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
index 318572d28f..76719a7de8 100644
--- a/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
+++ b/osu.Game/Screens/OnlinePlay/Matchmaking/RankedPlay/Intro/StarRatingSequence.cs
@@ -5,8 +5,10 @@
 using osu.Framework.Allocation;
 using osu.Framework.Audio;
 using osu.Framework.Audio.Sample;
+using osu.Framework.Extensions.Color4Extensions;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
+using osu.Framework.Graphics.Effects;
 using osu.Framework.Graphics.Shapes;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Graphics.Transforms;
@@ -134,6 +136,14 @@ private void load(OsuColour colour, AudioManager audio)
                     Anchor = Anchor.BottomLeft,
                     Origin = Anchor.BottomLeft,
                     Colour = colour.ForStarDifficulty(Math.Max(difficulty, 0.1)),
+                    EdgeEffect = difficulty < OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF
+                        ? default
+                        : new EdgeEffectParameters
+                        {
+                            Type = EdgeEffectType.Glow,
+                            Colour = colour.ForStarDifficultyText(difficulty).Opacity((difficulty - OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF) / (10 - OsuColour.STAR_DIFFICULTY_DEFINED_COLOUR_CUTOFF) / 2),
+                            Radius = 4
+                        },
                     Height = 0
                 });

```

as a bonus but I'm not that confident in myself.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Bartłomiej Dach · 2026-04-20 23:50:25 +09:00

c148e2056e

Stop all samples when exiting ranked play results screen early (#37427 )

Intends to close https://github.com/ppy/osu/issues/37408.

I have got to say, the way ranked play apparently re-invents screen
sub-stacks *again* in a slightly different way to everything else before
had me *very* confused as to why things I would expect to get called
aren't getting called.

Bartłomiej Dach · 2026-04-20 22:32:59 +09:00

8691004499

Fix queue screen crashes on mobile (#37425 )

Closes https://github.com/ppy/osu/issues/37345

Aside from
https://github.com/ppy/osu/commit/9f4b1c8b8dbba68f815af61bf46824cfb25b2d3b,
this also tweaks the grid sizings on mobile which were the secondary
cause of the android crashes. I'm bothering because it looked awful even
with the primary crash fixed.

Only tested on android. I wanted to test visually on iOS but rider
doesn't want to talk to xcode *or* my iPhone anymore, so I give up.

| before | after |
| :-: | :-: |
| <img width="2400" height="1080"
alt="Screenshot_2026-04-20-12-04-17-44_25a1a32208bbcdc1d450b7aa854bb161"
src="https://github.com/user-attachments/assets/e9bac850-7256-4a0d-8358-992490e1381d"
/> | <img width="2400" height="1080"
alt="Screenshot_2026-04-20-12-07-35-26_25a1a32208bbcdc1d450b7aa854bb161"
src="https://github.com/user-attachments/assets/a525485e-f2b5-4252-ae50-dc84c29945ec"
/> |

Bartłomiej Dach · 2026-04-20 21:14:13 +09:00

a0be214d03

Disable sentry during test runs

Exposed to be running by 48434dd683 which
caused test failures.

You'd think that the `IsDeployedBuild` check would catch it but it
doesn't. `IsDeployedBuild` is `AssemblyVersion.Major > 0`, and the
assembly version is taken from the entry assembly. In tests the entry
assembly is either resharper or nunit.

Bartłomiej Dach · 2026-04-20 13:37:53 +02:00

16bbfbb4e2

Fix crash when dragging card as discard phase ends (#37419 )

Closes: #37402

Issue was `HandOfCards.CardContainer.Compare` working under the
assumption that the it would never be called with the same child for
both entries, which can happen when doing a `BinarySearch` (called in
`RemoveInternal`).
This lead to `IndexOf` returning a negative value despite the card being
present in the container, and the drawable getting disposed but not
actually removed.

I also included a precautionary `cardContainer.Sort()` call before the
removal as well, seemed to work without that from testing but better not
rely on that.

TLDR: card container child sorting was unstable due to poor assumptions

maarvin · 2026-04-20 10:58:27 +02:00

11f01113a1

Remove sentry DSN from repo

People doing stupid shit submitting stupid errors we don't care about.

Dean Herbert · 2026-04-20 17:16:41 +09:00

48434dd683

Fade out "waiting for a game" sound effect loop (#37415 )

Feedback that this can be annoying when waiting for a match with the
game in the background for several minutes. Agree with this.

Dean Herbert · 2026-04-20 09:36:54 +02:00

6c7487f774

Unify damage multiplayer formatting (#37366 )

Previously the current stage overlay would not display the decimal part
of the damage multiplier.

Resolves #37357.

Krzysztof Gutkowski · 2026-04-20 09:28:38 +02:00

10543e6b8f

Fix viewing beatmap details in ranked play not working (#37351 )

https://discord.com/channels/188630481301012481/1440912440224120882/1495066077175222422

Haven't really tested whether this works - dev server is also lacking
data in general, however relying on the previous example set by quick
play:


https://github.com/ppy/osu/blob/1168c477d95f019aea2b676ef51db4ab6cd7253f/osu.Game/Screens/OnlinePlay/Matchmaking/Match/BeatmapSelect/MatchmakingSelectPanel.CardContentBeatmap.cs#L418-L421

Dan Balasescu · 2026-04-20 09:01:03 +02:00

5995ecf5de

Set user activity during ranked play matches (#37342 )

Best that can be done for the time being.

Dan Balasescu · 2026-04-20 08:54:56 +02:00

807b21ed97

Disallow external beatmap changes during ranked play (#37358 )

Fixes https://osu.ppy.sh/community/forums/topics/2198450?n=3

Dan Balasescu · 2026-04-20 12:29:03 +09:00

b1ef351f83

Turn on ranked play

Dean Herbert · 2026-04-18 19:52:52 +09:00

2026.418.0-lazer 1168c477d9

Avoid recomputing full path vertices in SliderPath when possible (#36285 )

In some cases `SliderPath.GetPathToProgress` used to compute the whole
path when it can be not needed since it can be already stored inside
`calculatedPath` list.
Also some of these use cases will no longer require additional array
wheen only readonly access is all we need.

Andrei Zavatski · 2026-04-17 21:35:27 +09:00

b36f8f9c47

Fix failing test

Dan Balasescu · 2026-04-17 17:06:24 +09:00

9bea31986c

Limit maximum password length for multiplayer lobbies to conformant value (#37329 )

See https://github.com/ppy/osu/issues/37324.

Dean Herbert · 2026-04-17 15:33:49 +09:00

2026.417.0-tachyon cb843b1a2b

Avoid moving auth files during storage migration

Dan Balasescu · 2026-04-17 15:00:37 +09:00

964d3fbdbc

Reduce log spam from spectator client when playing offline (#37316 )

Noticed in passing when doing something else.

Bartłomiej Dach · 2026-04-16 22:17:46 +09:00

9ac1ad2843

Update framework (#37315 )

Dean Herbert · 2026-04-16 14:11:24 +02:00

c2ed2f7d65

Add note on AI usage in contributions

Dean Herbert · 2026-04-16 18:24:14 +09:00

96513ceb3b

Ranked Play: Work around rating data not always including user (#37310 )

Fixes
https://discord.com/channels/188630481301012481/188630652340404224/1493678774540304505

The rating distribution is updated once every 5 minutes, so there are
periods where it may not include the local user's rating. This is simply
a workaround where it's considered if it's bounded by it.

Am a little surprised this is as easy to handle as it appears to be,
even if not the cleanest presentation (it's an edge case).

Dan Balasescu · 2026-04-16 14:36:02 +09:00

e6a74fd1f3

Add support for grouping by keys in song select for osu!mania (#37285 )

https://github.com/user-attachments/assets/edfc8d06-4f04-4876-84a5-dfc83a18f160

Of note:

- Supports both native beatmaps and converts
- Supports key mods (changing key mods will trigger song select refilter
when key count grouping is engaged)
- The option to group by keys is only visible when mania ruleset is
active
- If the user selects key count grouping and then switches to another
ruleset, song select will fall back to no grouping, but this change will
not be written back to config. Only the user changing the grouping mode
manually will reflect in config changes. This is done so that key
grouping persists across ruleset changes, and this even survives game
restarts.

---

I've only done some light behaviour testing on this because this feature
needs a lot of subjective shot calls and I don't want to commit too deep
before I get a temperature check on the shot calls I made here.

In particular some performance profiling of
https://github.com/ppy/osu/commit/7de8f70b1dbbdf2e3f13ba10faf25329abf6468d
may be warranted.

Bartłomiej Dach · 2026-04-15 19:01:20 +09:00

8050ee36ce

Safeguard rating distribution graph against null InputManager (#37304 )

I don't know how to reproduce this:
```
[runtime] 2026-04-15 05:43:26 [verbose]: 📺 OsuScreenStack#478(depth:4) exit from ScreenQueue#281
[runtime] 2026-04-15 05:43:26 [verbose]: 📺 OsuScreenStack#478(depth:4) resume to ScreenIntro#687
[runtime] 2026-04-15 05:43:26 [verbose]: 📺 BackgroundScreenStack#692(depth:1) exit from MatchmakingBackgroundScreen#393
[runtime] 2026-04-15 05:43:26 [verbose]: 📺 BackgroundScreenStack#692(depth:1) resume to BackgroundScreenDefault#210
[runtime] 2026-04-15 05:43:26 [verbose]: 📺 OsuScreenStack#478(depth:3) exit from ScreenIntro#687
[runtime] 2026-04-15 05:43:26 [verbose]: 📺 OsuScreenStack#478(depth:3) resume to MainMenu#505
[runtime] 2026-04-15 05:43:26 [verbose]: 🌅 Global background change queued
[runtime] 2026-04-15 05:43:26 [verbose]: ButtonSystem's state changed from EnteringMode to TopLevel
[runtime] 2026-04-15 05:43:26 [debug]: Focus changed from nothing to DialogOverlay.
[runtime] 2026-04-15 05:43:26 [error]: An unhandled error has occurred.
[runtime] 2026-04-15 05:43:26 [error]: System.NullReferenceException: Object reference not set to an instance of an object.
[runtime] 2026-04-15 05:43:26 [error]: at osu.Game.Screens.OnlinePlay.Matchmaking.Queue.RatingDistributionGraph.get_TooltipContent() in /home/smgi/Repos/osu/osu.Game/Screens/OnlinePlay/Matchmaking/Queue/RatingDistributionGraph.cs:line 434
[runtime] 2026-04-15 05:43:26 [error]: at osu.Framework.Graphics.Cursor.IHasCustomTooltip`1.osu.Framework.Graphics.Cursor.IHasCustomTooltip.get_TooltipContent()
[runtime] 2026-04-15 05:43:26 [error]: at osu.Framework.Graphics.Cursor.TooltipContainer.hasValidTooltip(ITooltipContentProvider target)
[runtime] 2026-04-15 05:43:26 [error]: at osu.Framework.Graphics.Cursor.TooltipContainer.Update()
[runtime] 2026-04-15 05:43:26 [error]: at osu.Framework.Graphics.Drawable.UpdateSubTree()
```

As unplausible as it may seem, the only thing that can be null here is
`GetContainingInputManager()`. The point of this exercise is to simply
remove it by relying on `OnMouseMove` events instead.

Dan Balasescu · 2026-04-15 16:05:44 +09:00

bcf37127a9

Replicate osu!web logic in display of matchmaking badge (#37303 )

Dan Balasescu · 2026-04-15 15:49:10 +09:00

4fd4544442

Fix KeyboardStep precision in Accuracy Challenge (#37299 )

- closes https://github.com/ppy/osu/issues/37179
- regressed in https://github.com/ppy/osu/pull/37048

Denis Titovets · 2026-04-15 15:06:10 +09:00

16882c64c5

Update CodeFileSanity (#37293 )

Has been failing on master for some time now because .NET 6 is not
supported anymore.

Dan Balasescu · 2026-04-15 01:10:54 +09:00

7c114cd69a

Ranked Play: Fix stutter when entering queue screen (#37295 )

The panels look up the online APIUser models. Maybe I could do this by
doing the lookups async inside `RankedPlayMatchPanel`, but this will
probably do for now?

Dan Balasescu · 2026-04-15 01:10:07 +09:00

daff79b1d3

Ranked Play: Fix chat temporarily appearing during intro (#37294 )

I was kind of lazy with the disappear/appear stuff. Made it properly set
the required state at the correct time now.

Made a second fix to change it into a visibility container, so that
bindable states are deduped. On `master` it would re-appear from the
bottom with every stage change.

Dan Balasescu · 2026-04-15 00:28:26 +09:00

ca40749a14

Add bottom 'ornament' overlay to ranked play (#37288 )

This commit adds an always present overlay to all ranked play screens,
meant to indicate to the user that a ranked play session in currently in
progress.

This has been largely inspired by the pre-shader argon healthbar code.
It shouldn't have the same performance concerns, however, since the
paths are only calculated once when loading the drawable (and eventually
when it is resized, if ever).

`RankedPlayScreen`:

<img width="1838" height="1353" alt="image"
src="https://github.com/user-attachments/assets/c621d759-a88f-49f0-b0df-3a6da90eca65"
/>

Gameplay:

<img width="1838" height="1353" alt="image"
src="https://github.com/user-attachments/assets/ee848d06-3878-4cbb-bd4b-de2c4bcfa688"
/>

Currently the drawable overlaps with some components, but it will be
resolved in later pull requests.

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Krzysztof Gutkowski · 2026-04-15 00:27:43 +09:00

16a2a96bcf

Add additional information to the matchmaking queue screen (#37229 )

- [x] Depends on https://github.com/ppy/osu/pull/37226
- [x] Depends on https://github.com/ppy/osu-server-spectator/pull/464

This adds two new components to the queue screen:
- A listing of the most recently completed matches (global).
- A rank distribution graph.

It looks something like this (fake data / test scene):

<img width="1669" height="1005" alt="image"
src="https://github.com/user-attachments/assets/caa57119-4267-4c6e-9898-2f414de865bf"
/>

It's completely dev-design(TM), but I used Lichess as inspiration for
the graph, and the original design document as inspiration for the
panels.

As for the history, because these are _completed_ matches one of the
player life points will always be 0, but I've designed it so as to
possibly support showing ongoing matches too in the future. It's only
supported for ranked play right now, though there is no reason we
couldn't track quick play rooms too (it's just... I'm not sure how to
design the panels for quick play).

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Dan Balasescu · 2026-04-14 10:54:54 +09:00

ac620ee375

Fix multiple issues with ranked play card audio previews (#37262 )

The main goal here is to:
- Make keyboard selection play previews just like hovering does with
mouse.
- Make sure cards don't play previews when they are in animation.
- Drive by fix to fix toggling discard not working via keyboard.

(I really want to rewrite all these classes, the structure is not great)

---------

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

Dean Herbert · 2026-04-12 15:43:47 +09:00

0e9664bfdf

Fix missing null check

Dan Balasescu · 2026-04-12 14:48:44 +09:00

bcc36b4884

Add more ranked play SFX (#37258 )

- Stage changes (with ducking):


https://github.com/user-attachments/assets/1ed1cf5a-759b-487a-9028-314accc15a6a

- Messages (with debouncing):


https://github.com/user-attachments/assets/c8c38d18-4fcc-4654-887b-be3de3e84949

Message sample might be a bit too clicky, but consider this a first
pass.

---
- [x] depends on ppy/osu-resources#417

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Jamie Taylor · 2026-04-12 01:43:36 +09:00

e36f9b2dcf

Fix lack of encode-decode stability when writing out mania beatmaps with some key counts (#37256 )

Closes https://github.com/ppy/osu/issues/37232.

The actual fix is
https://github.com/ppy/osu/commit/e959b20517497a093d3c00a17457c5d36bf57651;
everything else is window dressing / test harness to ensure I don't try
and do a wrong change like https://github.com/ppy/osu/pull/37251 did. I
recommend reviewing commit-by-commit.

See [this desmos](https://www.desmos.com/calculator/a5yjpacvxa) for
visual explanation of change, I think it does a better job at explaining
this than any words I could type here.

Of note:

- In the end this did only affect 14K but that should never be assumed
when floating point is involved.
- Test cases generated here were generated in stable manually.
- Except for 11 / 13 / 15 / 17K which are not officially supported and
which don't work in lazer due to orthogonal reasons (see comment added
in this PR in `ManiaBeatmapConverter`), decoding in lazer was always
fine.
- My worry was that the old encoding method before this PR could
potentially cause stable to move a note from one column to another but
thankfully that is not the case. The old method of encoding columns as X
positions does not cause issues wherein lazer reads them back
differently than stable after encode.

I checked this by checking out `master`, re-encoding all of the test
stair-pattern nK beatmaps added in this PR on `master`, exporting that
as compatibility, re-importing to stable, and cross-checking that the
decoded beatmap is visually the same on lazer and on stable.

This is important to check because if this wasn't the case, we'd
potentially have cases of actual online beatmaps (remember that we have
BSS now) wherein a beatmap plays differently on stable than on lazer due
to notes moving between columns, and would need to screen for this being
the case and potentially apply corrective / reconciliatory action.

Bartłomiej Dach · 2026-04-11 00:38:22 +09:00

6231e06ebe

Update editor icons (#37201 )

Brings in new fresh icons for the toolbox (select, hitcircle, slider,
spinner, grid) and toggles (new combo, whistle, finish, clap,
grid/distance snap).

Depends on https://github.com/ppy/osu-resources/pull/416.

| Before | After |
|--------|--------|
| <img width="300" height="897" alt="image"
src="https://github.com/user-attachments/assets/279ea162-c3e2-4312-a0a2-39ad08df16f9"
/> | <img width="304" height="889" alt="image"
src="https://github.com/user-attachments/assets/aab2a143-0e6b-45c1-bf84-8998c12bd960"
/> |

Krzysztof Gutkowski · 2026-04-10 20:27:21 +09:00

3e6233072c

Tidy up ResultsScreen (#37242 )

Just the bare minimum code quality so I can start working on these
classes..

Please push back if this doesn't seem better than what was already
there. This is mostly autopilot fixing for me based on how I've been
writing code for osu! to date.

There are changes to the load process but nothing which should cause
issues, I hope.

Dean Herbert · 2026-04-10 20:14:11 +09:00

4b8fa892ea

Improvements to discard screen UX (#37245 )

Just an initial grab bag to keep these PRs small.

### Avoid showing countdown update when at discard screen

This is needless. We already have the `DiscardFinish` stage which has a
short countdown. Playing this change to the user creates unnecessary
confusion.

### Allow stage caption text to be changed at any point

Also remove custom colour support. We'll handle this internally in a
better way in the future.

### Better explain why we're waiting after discarding our own cards

Dean Herbert · 2026-04-10 20:12:27 +09:00

9c43739228

Add matchmaking profile badge (#37241 )

Using the same styling as osu!web + daily challenge.

<img width="1920" height="1034" alt="Screenshot_20260409-164600"
src="https://github.com/user-attachments/assets/97e2270e-af9f-478d-b2d6-c9fb8be16720"
/>

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>

Dan Balasescu · 2026-04-09 19:25:21 +09:00

93b7c3324d

Make RankedPlayColourScheme properly static (#37244 )

Dean Herbert · 2026-04-09 18:22:32 +09:00

b838564039

Do not send replay frames to spectator server if initial begin play invocation failed (#37159 )

RFC

Until now, if the initial `BeginPlaySession()` call failed, the client
would continue operating as if it didn't - it would still continue to
send frames and call `EndPlaySession()` at the end of a session.

Server-side, two things generally can happen after this:

- The sent frames and the `EndPlaySession()` call are
[completely](https://github.com/ppy/osu-server-spectator/blob/7bab117e9d161455485368f63a0607a9e53f9f8a/osu.Server.Spectator/Hubs/Spectator/SpectatorHub.cs#L122-L125)
[ignored](https://github.com/ppy/osu-server-spectator/blob/7bab117e9d161455485368f63a0607a9e53f9f8a/osu.Server.Spectator/Hubs/Spectator/SpectatorHub.cs#L153-L157)
as no-ops, or
- A hub filter (like `ClientVersionChecker`) that failed the initial
`BeginPlaySession()` call continues to fail the calls to
`SendFrameData()` and `EndPlaySession()`, all the while creating a storm
in logs, because it needs to throw `HubException`s to communicate to
users that they need to update their game, and the exceptions can't be
silenced from logs because they look like every other failure.

To that end, this has two goals: reduce useless network traffic, and
reduce noise in spectator server logs after the client version checks
were recently reactivated.

Probably needs tests, but unsure if everyone's going to be on board with
this to begin with to be quite frank, so I'm leaving tests for when I'm
told this needs tests.

Bartłomiej Dach · 2026-04-09 03:40:32 +09:00

ca44d8233d

76789 Commits