Bartłomiej Dach
baa64d1486
Migrate MusicController to Live<T> to fix broken migrations instead
2024-10-09 11:59:04 +02:00
Bartłomiej Dach
081d87fe6d
Revert 'Fix any and all migration attempts dying on MusicController'
...
This reverts commit 310eec69fc
2024-10-09 11:55:59 +02:00
Dean Herbert
48dacd1c15
Remove unused property
2024-10-09 13:45:35 +09:00
Bartłomiej Dach
310eec69fc
Fix any and all migration attempts dying on MusicController
...
I'm not sure why this was "fine" for as long as it apparently was,
but what `MusicController` was doing was completely incorrect and
playing with fire (accessing raw managed realm objects), which went
wrong somewhere around - admittedly -
https://github.com/ppy/osu/pull/29917 , likely because that one started
*storing* these raw managed realm objects to fields, and you know what
will happen to those after you do a migration and recycle realms.
To attempt to circumvent this, (ab)use `DetachedBeatmapStore` instead.
Which does necessitate moving it to `OsuGameBase`, but it's the simplest
way out I can see. I guess the alternative would be to faff around with
`Live<T>` but it's ugly and I'm attempting to fix this relatively quick
right now.
2024-10-08 23:16:10 +02:00
Dean Herbert
682023e130
Merge branch 'master' into grids-4
2024-10-08 16:26:42 +09:00
Dean Herbert
b658d9a681
Merge pull request #30073 from peppy/updates-outside-of-gameplay-only-2
...
Avoid updates (and update notifications) from appearing in more gameplay cases
2024-10-08 15:17:09 +09:00
OliBomby
d7526be243
Merge remote-tracking branch 'upstream/master' into grids-4
2024-10-07 11:56:35 +02:00
OliBomby
0a7d2395d2
fix tooltip in SettingsButton
2024-10-07 10:43:24 +02:00
Dan Balasescu
8dece70097
Merge branch 'master' into updates-outside-of-gameplay-only-2
2024-10-07 17:41:42 +09:00
Dean Herbert
11fc811e2f
Fix delete dialogs having generic "Caution" header text
...
Regressed in https://github.com/ppy/osu/pull/28363 .
2024-10-07 16:46:53 +09:00
Dean Herbert
75f15ccaba
Maybe fix compilation? Fuck knows if this is correct.
2024-10-07 16:04:24 +09:00
Dean Herbert
1ab02b93b3
Merge branch 'master' into grids-4
2024-10-07 15:42:23 +09:00
OliBomby
ae8abc7f35
fix readybutton and favouritebutton
2024-10-05 21:46:00 +02:00
OliBomby
ad734b1a13
Revert "Use new keyword instead of overriding TooltipText to remove setter"
...
This reverts commit 80dffa905a
2024-10-05 15:10:36 +02:00
OliBomby
80dffa905a
Use new keyword instead of overriding TooltipText to remove setter
2024-10-03 11:13:49 +02:00
Dean Herbert
1039d4e45d
Increase chat font size again
2024-10-03 16:23:17 +09:00
OliBomby
4bbefa360c
fix using directive
2024-10-01 15:57:34 +02:00
OliBomby
f8397cccc7
Merge remote-tracking branch 'upstream/master' into grids-4
2024-10-01 15:43:54 +02:00
OliBomby
9fa2849b14
Fixed tooltip inheritors of RoundedButton
2024-10-01 15:34:12 +02:00
Dean Herbert
598bc74614
Merge pull request #30058 from bdach/disabled-beatmap-comment-box
...
Properly disable comment box on things that cannot be commented on
2024-10-01 18:52:40 +09:00
Dean Herbert
ad3007eaad
Adjust ILocalUserPlayInfo to expose whether gameplay is in a paused/break state
2024-10-01 17:53:46 +09:00
Bartłomiej Dach
2a214f7c9f
Fix incorrect implementation of next track choice
...
`SkipWhile()` in this context does not correctly ensure that
`ElementAtOrDefault(1)` is not a protected track. An explicit `Where()`
does.
Spotted accidentally when I noticed that skipping to next track can
select a protected track, but skipping to previous cannot.
2024-10-01 10:19:59 +02:00
Bartłomiej Dach
a2d9302f4a
Move shuffle button to left side
2024-10-01 10:12:38 +02:00
Bartłomiej Dach
8eb5e6b1d5
Merge branch 'master' into shuffle
2024-10-01 10:07:54 +02:00
Bartłomiej Dach
8d2f2517a3
Specify type explicitly
2024-10-01 10:01:31 +02:00
Bartłomiej Dach
74a9899fc0
Fix doubled-up enabled state management of commit button
2024-09-30 14:05:26 +02:00
Bartłomiej Dach
e91c8fb4bd
Properly disable comment box on beatmaps that cannot be commented on
...
Closes https://github.com/ppy/osu/issues/30052 .
Compare:
- 83816dbe24/resources/js/components/comment-editor.tsx (L54-L60)83816dbe24/resources/js/components/comment-editor.tsx (L47-L52)
2024-09-30 11:02:00 +02:00
Bartłomiej Dach
c1e51e05df
Merge pull request #29704 from Fabep/ModCustomisationHeaderColor
...
Mod customisation header color
2024-09-27 12:40:35 +02:00
Dean Herbert
a358731af5
Merge pull request #29913 from Joehuu/fix-romanised-searching
...
Fix searching by clicking title/artist in beatmap overlay not following original language setting
2024-09-27 18:39:33 +09:00
Dean Herbert
e7c4451206
Reduce brightness of hover effect
2024-09-27 18:20:16 +09:00
Dean Herbert
64c1ced80d
Merge branch 'master' into ModCustomisationHeaderColor
2024-09-27 18:15:30 +09:00
Dean Herbert
048e3c2505
Merge branch 'master' into fix-romanised-searching
2024-09-27 17:40:03 +09:00
Bartłomiej Dach
fa90b43233
Merge branch 'master' into selection-center
2024-09-27 09:30:36 +02:00
Dean Herbert
5efdc6cdd7
Merge pull request #29936 from u4vh3/skinning-colour-customisation
...
Add colour customisation to layout editor
2024-09-27 14:20:58 +09:00
Bartłomiej Dach
7f8b64bb6d
Redesign directory & file selector (and update usages accordingly)
2024-09-24 14:54:48 +02:00
OliBomby
8e11cda41a
use minimum enclosing circle selection centre in scale
2024-09-20 01:07:54 +02:00
OliBomby
ee00624751
use minimum enclosing circle selection centre in rotation
2024-09-20 01:07:47 +02:00
Daniel Cios
b86f246095
Fix code inspection failure
2024-09-19 19:24:05 +02:00
Daniel Cios
67f04f75a6
Fix default color
2024-09-19 17:27:26 +02:00
PowerDaniex
6ec3f715d2
Fix formatting
2024-09-19 17:26:09 +02:00
PowerDaniex
8c72feda09
Add colour customization to the layout editor
2024-09-19 17:26:09 +02:00
Dean Herbert
188a430418
Merge branch 'master' into grids-3
2024-09-19 18:21:05 +09:00
Joseph Madamba
c185acdbae
Use GetLocalisedBindableString() instead
2024-09-18 11:16:25 -07:00
Bartłomiej Dach
7f52ae8837
Fix code quality inspection
2024-09-18 15:30:56 +02:00
Bartłomiej Dach
12bd516a57
Shuffle playback order in global playlist by default
...
RFC. Closes https://github.com/ppy/osu/issues/18169 .
Implements the given proposal of keeping the current stable order but
adding a shuffle facility to the now playing overlay, and enabling it by
default.
There are more changes I want to make here but I'd like this to get
discussion first, because I am likely to continue putting this sort of
selection logic into `MusicController` and I just want to confirm nobody
is going to have a problem with that.
In particular this is not sharing the randomisation implementation with
beatmap carousel because it doesn't generalise nicely (song select cares
about the particular *beatmap difficulties* selected to rewind properly,
while the music controller only cares about picking a *beatmap set*).
2024-09-18 14:19:55 +02:00
Joseph Madamba
fd6b3b6b36
Fix searching by clicking title/artist in beatmap overlay not following original language setting
2024-09-17 22:34:06 -07:00
Dean Herbert
4a6266efcf
Merge pull request #29714 from Crystallized21/total-participation-tooltip
...
Add Total Participation stat to users profile Daily Challenge Tooltip
2024-09-08 22:42:02 +09:00
Bartłomiej Dach
7f814d3106
Fix incorrect tiers being used for tooltip total participation display
...
Compare: 95e4561a54
2024-09-08 14:26:50 +02:00
Dan Balasescu
ac6cce5911
Refactor to string interpolation
2024-09-07 17:40:33 +09:00
Ianlucht
581f190856
fixed issues with search by adding the double quotation marks in the BeatmapSetHeaderContents links.
2024-09-06 16:31:48 -06:00
