5617 Commits

• Merge pull request #34465 from Hiviexd/verify/check-inconsistent-timing

  Add verify check for inconsistent timing control points

  Bartłomiej Dach · 2025-08-05 10:34:47 +02:00
  427dc2b31e
• Merge pull request #34467 from Hiviexd/verify/implement-scopes

  Distinguish between set-level and difficulty-specific checks in verify screen

  Bartłomiej Dach · 2025-08-05 10:31:22 +02:00
  da710ad558
• Bring back localisations
  Bartłomiej Dach · 2025-08-05 08:23:47 +02:00
  c1c43fab17
• Use casing of "beatmap set" consistent with the rest of the code base
  Bartłomiej Dach · 2025-08-05 08:18:30 +02:00
  ee5a5cda11
• remove unnecessary localisations
  Hivie · 2025-08-04 22:07:41 +01:00
  2c5aa73ccb
• apply review

  - improve timing tolerance const name and documentation
  - simplify matching logic in `FindMatchingTimingPoint`

  Hivie · 2025-08-04 15:21:43 +01:00
  a7f0ae09bb
• define general checks with a bool in CheckMetadata instead of an interface
  Hivie · 2025-08-04 14:12:59 +01:00
  ed301ec114
• rename scopes
  Hivie · 2025-08-04 14:02:40 +01:00
  8a2053bf61
• mark various set-level checks as general checks
  Hivie · 2025-08-01 21:42:31 +01:00
  0d2618082d
• add VerifyChecksScope enum
  Hivie · 2025-08-01 21:40:33 +01:00
  8e73c57470
• add class for general checks
  Hivie · 2025-08-01 21:39:46 +01:00
  7f8b6981b2
• move methods to TimingCheckUtils

  so they can be reused for future timing-related checks

  Hivie · 2025-08-01 18:37:54 +01:00
  0fcef7b0ee
• add check for inconsistent timing
  Hivie · 2025-08-01 16:01:28 +01:00
  b4dc394127
• Show effect of beatmap attributes on gameplay metrics in osu!
  Bartłomiej Dach · 2025-08-01 11:07:48 +02:00
  655733c06d
• Allow showing additional metrics when hovering over beatmap attributes
  Bartłomiej Dach · 2025-08-01 11:06:40 +02:00
  c68cbc5360
• Fix code quality
  Bartłomiej Dach · 2025-07-30 15:00:55 +02:00
  640fe5752d
• Rename property to reduce confusion

  Caused an actual bug in one of the replaced usages.

  Bartłomiej Dach · 2025-07-30 14:06:38 +02:00
  cd2c5075df
• Refactor beatmap attribute methods

  This change refactors `GetAdjustedDisplayDifficulty()` and
  `GetBeatmapAttributesToDisplay()` in two ways:
  
  - Both methods now accept `IBeatmapInfo` instead of
    `IBeatmapDifficultyInfo`. This is done in order to make mania key
    count display to work, wherein `IBeatmapDifficultyInfo` is not enough
    to calculate the final key count.
  
  - `GetAdjustedDisplayDifficulty()` now applies all
    `IApplicableToDifficulty` mods itself. I did this after noticing that
    every real consumer of this method had to do that themselves for very
    little reason.

  Bartłomiej Dach · 2025-07-30 14:06:34 +02:00
  7c4dd812b6
• Add new ruleset method responsible for displaying beatmap attributes consistently everywhere

  The intention is to use this in every place that wishes to display
  beatmap attributes (and also remove a bunch of local hack-arounds for
  mania, etc.)

  Bartłomiej Dach · 2025-07-30 13:41:19 +02:00
  e2a454ae00
• Merge pull request #34371 from Hiviexd/verify/check-almost-concurrent-objects

  Account for almost concurrent case in concurrent objects check

  Bartłomiej Dach · 2025-07-28 15:03:26 +02:00
  34dfb2f9ea
• apply review
  Hivie · 2025-07-28 12:36:18 +01:00
  e781ad737b
• apply review
  Hivie · 2025-07-28 12:24:24 +01:00
  8466d64c69
• refactor issue templates to be more unified
  Hivie · 2025-07-24 13:25:15 +01:00
  c0ba8bc997
• Account for almost concurrent case in concurrent objects check
  Hivie · 2025-07-24 13:12:24 +01:00
  806d3160f8
• add verify check for inconsistent metadata
  Hivie · 2025-07-24 12:20:45 +01:00
  ee27be1868
• Merge pull request #34181 from Hiviexd/verify/check-lowest-diff-drain

  Add verify check for lowest diff drain/play time requirements

  Bartłomiej Dach · 2025-07-22 08:38:59 +02:00
  c408d60fbe
• oops
  Hivie · 2025-07-21 13:21:30 +01:00
  209a75c4df
• adjust wording
  Hivie · 2025-07-21 13:18:25 +01:00
  9bab2444ea
• fix one tiny miniscule english error i encountered by editing a beatmap
  Shin Morisawa · 2025-07-20 20:50:20 +09:00
  9572c2ba67
• address review

  - add TODO for refactoring verifier context ctor
  - call `GetPlayableBeatmap()` in verifier context ctor
  - filter diffs with relevant ruleset in check logic
  - fix tests

  Hivie · 2025-07-16 01:53:22 +01:00
  747bff1df9
• Attempt to properly quantify the impact of mania Hard Rock / Easy mod application on overall difficulty

  In stable mania, Hard Rock and Easy mods do not work the same way as
  they do on all of the rulesets. The difference is that mania HR and EZ,
  rather than apply a multiplier to the map's original Overall Difficulty,
  apply multipliers to *the durations of hit windows themselves*.
  
  Prior to the last release, lazer was oblivious to this reality and just
  treated mania HR / EZ as it did every other ruleset. Last release, for
  the sake for gameplay parity across rulesets, the mods in question were
  adjusted to match stable, but in the process, it started looking like HR
  / EZ did not change OD anymore.
  
  The problem is that they do, but applying a multiplier to the map's OD
  and applying a multiplier to the hit window duration is not the same
  thing. The second thing is actually *much harsher* in magnitude, to the
  point where applying HR to any map is almost guaranteed to exceed "the
  effective OD" of 10, and applying EZ to any map is almost guaranteed to
  result in "negative effective OD".
  
  This change attempts to convey that reality by displaying "effective
  OD", similar to what's already done in other rulesets when rate-changing
  mods are active. Note that the values this will display *do not match*
  stable *and that is correct*, because stable song select *lies* about
  the actual impact on OD by just assuming it can treat all rulesets in
  the same way.
  
  ---
  
  Would close https://github.com/ppy/osu/issues/34150 I guess.
  
  And yes I would like *all of the above* to land on the changelog if
  possible if this is merged.
  
  For further convincing that this makes any semblance of sense please see
  the following: https://www.desmos.com/calculator/yigt7jycdv

  Bartłomiej Dach · 2025-07-15 09:40:55 +02:00
  131f828e6a
• unlazy BeatmapsetDifficulties
  Hivie · 2025-07-14 13:53:01 +01:00
  806995e951
• Minor cleanups

  Using `ChannelType.Unknown` instead of `0`, adds missing disposal.

  Dan Balasescu · 2025-07-14 15:10:04 +09:00
  8e0ed85ad2
• formatting
  Hivie · 2025-07-13 04:37:22 +01:00
  c36960a06e
• update audio quality check to account for ogg files
  Hivie · 2025-07-13 04:06:16 +01:00
  cf6641e241
• move audio format checks to reusable audio check utils
  Hivie · 2025-07-13 04:05:46 +01:00
  fccfdbf393
• Add verify check for lowest diff drain time requirement
  Hivie · 2025-07-13 02:00:50 +01:00
  ccf6d9c173
• include all of a beatmapset's diffs in the verifier context
  Hivie · 2025-07-13 01:53:07 +01:00
  f1eb7d367b
• Merge pull request #33982 from bdach/mania-hit-windows

  Support mania-specific hit window quirks

  Dan Balasescu · 2025-07-07 18:03:02 +09:00
  321707590a
• Disallow Classic mod from being valid in freestyle as required mod

  Because it's not implemented for all rulesets.
  
  Closes https://github.com/ppy/osu/issues/34004.

  Bartłomiej Dach · 2025-07-03 14:29:35 +02:00
  6013d4c0de
• Fix mania Hard Rock & Easy mods not matching stable

  The implementation in `master` was presuming that Hard Rock and Easy
  worked the same way across all rulesets, but actually, in stable mania,
  the two mods have special treatment as per
  
  	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150
  
  The open question here would be what this means for existing scores set
  on lazer using this mod.

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  8e53f47e78
• Support mania-specific hit window quirks

  The quirks in question being that lazer's hit windows in mania preceding
  this change are used in stable *if and only if* Score V2 is active. If
  Score V2 is *not* active, stable has two disparate other sets of hit
  window ranges, dependent on whether the beatmap is a convert or not.
  
  With this commit, those hit windows are used in lazer when the Classic
  mod is active.
  
  Open points for discussion would be:
  
  - What does this mean for plays already set on lazer using the Classic
    mod? Are there even enough of them to care about? Also, on `master`
    the Classic mod does precisely nothing, so maybe such scores should
    just have Classic mod stripped from them?
  
  - What does this mean for the mod multiplier of Classic in mania? (I don't
    expect an answer to this one.)

  Bartłomiej Dach · 2025-07-02 12:26:50 +02:00
  6afdf99df8
• Merge pull request #33910 from bdach/dont-do-a-barrel-roll-actually

  Fix Flashlight having increased radius when Barrel Roll is active

  Dean Herbert · 2025-07-02 18:25:45 +09:00
  0e39e05d19
• Fix Difficulty Adjust extended mod icon information not showing with extended limits active

  - Closes https://github.com/ppy/osu/issues/33522.
  - Alternative to / closes https://github.com/ppy/osu/pull/33561.

  Bartłomiej Dach · 2025-06-30 12:20:05 +02:00
  28caa03d21
• Fix Flashlight having increased radius when Barrel Roll is active

  Closes https://github.com/ppy/osu/issues/33893.
  
  Regressed in https://github.com/ppy/osu/pull/29841.
  
  This sucks but I don't have better ideas.

  Bartłomiej Dach · 2025-06-27 13:48:44 +02:00
  96569e7829
• Merge pull request #33615 from bdach/slider-encode-decode-instability

  Fix lack of slider encode-decode stability due to truncating control point coordinates on decode

  Dan Balasescu · 2025-06-26 23:25:36 +09:00
  ae3100af11
• Remove no longer used method
  Dan Balasescu · 2025-06-25 18:31:35 +09:00
  d42fcabcf4
• Make assertion completely dead in release mode
  Bartłomiej Dach · 2025-06-25 10:06:04 +02:00
  55ff5a744c
• Refactor hit windows class structure to reduce rigidity

  This change pulls back a significant degree of overspecialisation and
  rigidity in the class structure of `HitWindows` to make subsequent
  changes to hit windows, whose purpose is to improve replay playback
  accuracy, possible to do cleanly.
  
  Notably:
  
  - `HitWindows` is full abstract now. In a few use cases, and as a
    reference for ruleset implementors, `DefaultHitWindows` is provided as
    a separate class instead.
  
    This fixes the weirdness wherein `HitWindows` always declared 6 fields
    for result types but some of them would never be set to a non-zero
    value or read.
  
  - `HitWindow.GetRanges()` is deleted because it is overspecialised and
    prevents being able to adjust hitwindows by ±0.5ms cleanly which will
    be required later.
  
    The fallout of this is that the assertion that used `GetRanges()` in
    the `HitWindows` ctor must use something else now, and the closest
    thing to it was `GetAllAvailableWindows()`, which didn't return
    the miss window - so I made it return the miss window and fixed the
    one consumer that didn't want it (bar hit error meter) to skip it.
  
  - Diff also contains some clean-up around `DifficultyRange` to unify
    handling of it.

  Bartłomiej Dach · 2025-06-25 08:40:12 +02:00
  8b542e5442
• Merge branch 'master' into somewhat-less-weird-toolbar
  Bartłomiej Dach · 2025-06-24 14:16:00 +02:00
  7bea51556c