2946 Commits

• Fix HOC not propagating DHO results applied on kill

  `DrawableHitObject.OnKilled()` calls `UpdateResult()` to clean up a
  hitobject's state definitively with regards to the judgement result
  before returning the DHO back to the pool.
  
  As it turns out, if a consumer was relying on this code path (as taiko
  was in the case of nested strong hit objects), it would not work
  properly with pooling, due to `HitObjectContainer` unsubscribing from
  `On{New,Revert}Result` *before* calling the DHO's `OnKilled()`.
  
  This in turn would lead to users potentially getting stuck in gameplay,
  due to `ScoreProcessor` not receiving all results via that event path.
  
  To resolve, change the call ordering to allow hit result changes applied
  in `OnKilled()` to propagate normally.

  Bartłomiej Dach · 2021-01-21 00:05:37 +01:00
  1d9aaac2c2
• Update namespaces
  Dean Herbert · 2021-01-18 21:24:10 +09:00
  ced7a36788
• Fix default judgement text mispositioned for one frame
  smoogipoo · 2021-01-14 12:33:33 +09:00
  d5878db615
• Rename param to match method body
  Bartłomiej Dach · 2021-01-10 15:35:53 +01:00
  4b4adc927c
• Target logic at this and adjust variables
  Salman Ahmed · 2021-01-09 00:31:18 +03:00
  0aad0c7c6c
• Merge remote-tracking branch 'upstream/master' into fix-mod-buttons-not-copying-settings
  Salman Ahmed · 2021-01-09 00:26:18 +03:00
  375ecf92ed
• Merge pull request #11438 from bdach/difficulty-adjust-defaults

  Fix difficulty adjust mod treating default values as user overrides

  Dean Herbert · 2021-01-09 01:18:34 +09:00
  05ba5d4c31
• Transfer flags indicating if settings were changed
  Bartłomiej Dach · 2021-01-06 22:46:46 +01:00
  303cc62ee7
• Change .StartsWith() to .Equals()

  In line with planned-but-delayed breaking change.

  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  68352782db
• Remove obsoleted IHasEndTime
  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  9cc63e8dce
• Remove obsoleted IHasCurve
  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  539785e422
• Fix mistaken obsoletion notice

  It was added in c9f38f7bb6, which
  specified 2021 in another place (and was committed in October of 2020
  anyway). Update the year so that it doesn't get culled prematurely.

  Bartłomiej Dach · 2021-01-06 18:38:24 +01:00
  09742998cd
• Ensure that all changes to screen backgrounds are on the correct thread
  Dean Herbert · 2021-01-05 15:22:50 +09:00
  b3f08b29ca
• Clarify & cleanup comments some
  Bartłomiej Dach · 2021-01-03 13:44:29 +01:00
  9e4a925ab1
• Rename parameters for readability
  Bartłomiej Dach · 2021-01-03 13:25:44 +01:00
  a3e29b9154
• Copy values using Bind to also copy defaults
  Dean Herbert · 2021-01-03 20:45:03 +09:00
  2501707d7d
• Add internal pathway for ensuring correct application of bindable mods
  Dean Herbert · 2021-01-03 15:48:28 +09:00
  29dbb1cc0d
• Simplify some default value checks (we are sure the return is an IBindable)
  Dean Herbert · 2021-01-03 15:47:15 +09:00
  23e216fa0b
• Revert drive-by changes
  Salman Ahmed · 2021-01-01 15:40:40 +03:00
  c1a1e3acc5
• Apply documentation suggestions

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Salman Ahmed · 2021-01-01 15:34:09 +03:00
  a031c8e0b6
• Add method for copying properties from another mod
  Salman Ahmed · 2021-01-01 03:46:09 +03:00
  b4df2d6d43
• Source display accuracy from header and remove from ScoreProcessor function
  Dean Herbert · 2020-12-24 14:57:23 +09:00
  d66e218318
• Merge branch 'master' into realtime-leaderboard
  Bartłomiej Dach · 2020-12-23 09:56:47 +01:00
  64095307de
• Fix realtime leaderboard showing accuracy based on final base score, not rolling
  Dean Herbert · 2020-12-23 14:20:35 +09:00
  be427a4ec0
• Merge branch 'master' into present-recommended
  Dean Herbert · 2020-12-22 13:52:29 +09:00
  d229fbba6e
• Merge branch 'master' into fix-texture-loader-usages
  Bartłomiej Dach · 2020-12-21 18:35:34 +01:00
  f96d2f4ba4
• Merge branch 'master' into fix-texture-loader-usages
  Dean Herbert · 2020-12-21 13:51:55 +09:00
  bc212b2538
• Fix a couple of simple cases of incorrect TextureLoaderStore initialisation
  Dean Herbert · 2020-12-21 13:35:46 +09:00
  a8569fe15c
• Add guard when clearing samples
  Bartłomiej Dach · 2020-12-20 15:42:24 +01:00
  a31e8d137f
• Extract combo & accuracy ratio calculation helpers
  Bartłomiej Dach · 2020-12-19 19:08:29 +01:00
  ee33c0be93
• Correctly account for max combo of the input, rather than the global
  Dean Herbert · 2020-12-17 16:05:41 +09:00
  f13683dc90
• Revert MaxBaseScore to being a private field (no longe required to be public)
  Dean Herbert · 2020-12-17 15:47:20 +09:00
  41d8b84bd7
• Add method to ScoreProcessor to calculate score and accuracy from statistics
  Dean Herbert · 2020-12-16 16:20:29 +09:00
  2954218897
• Add header class and basic flow for propagating data updates
  Dean Herbert · 2020-12-14 17:33:23 +09:00
  64a2526678
• Pass a score to the replay recorder to allow reading more general scoring data
  Dean Herbert · 2020-12-14 16:52:14 +09:00
  1793385e96
• Seal SetRecordTarget method to simplify modification
  Dean Herbert · 2020-12-14 16:44:29 +09:00
  51e8a05f18
• Fix scrolling hit object displayed in wrong position for one frame
  ekrctb · 2020-12-07 17:26:12 +09:00
  a548269c34
• Merge branch 'master' into fix-sample-expire
  Dean Herbert · 2020-12-04 13:49:08 +09:00
  a0f92628ac
• Merge branch 'master' into dho-remove-onparentreceived
  Dean Herbert · 2020-12-04 11:04:56 +09:00
  5ded4b9faa
• Apply review suggestions
  Endrik Tombak · 2020-12-03 19:44:12 +02:00
  48dad61a46
• Remove OnParentReceived()
  smoogipoo · 2020-12-03 20:08:42 +09:00
  0bdf99b97a
• Change order of OnParentReceived()
  smoogipoo · 2020-12-03 20:06:26 +09:00
  73e99718bc
• Fix DHO expires while hit sound is playing
  ekrctb · 2020-12-03 12:32:49 +09:00
  6c46046c24
• Merge branch 'master' into hit-sample-pooling
  smoogipoo · 2020-12-02 14:45:24 +09:00
  e831c797f3
• Rename parameters
  smoogipoo · 2020-12-02 10:55:48 +09:00
  2150cf1c52
• Fix potentially incorrect override
  smoogipoo · 2020-12-02 10:54:26 +09:00
  e19ef9627a
• Volume should be 0 by default
  smoogipoo · 2020-12-01 18:14:14 +09:00
  2840405112
• Fix bad equality comparer implementations
  smoogipoo · 2020-12-01 18:13:53 +09:00
  6b4a6c12c8
• Volume should be 0 by default
  smoogipoo · 2020-12-01 18:09:28 +09:00
  17560aeeea
• Fix bad equality comparer implementations
  smoogipoo · 2020-12-01 18:09:21 +09:00
  dda4d76d72