1437 Commits

• Merge pull request #11473 from frenzibyte/explicit-search-control

  Add "explicit maps" search filter control to beatmap listing

  Dean Herbert · 2021-01-17 23:27:15 +09:00
  5e0fcc4a6c
• Unify variable names
  Dean Herbert · 2021-01-17 22:42:48 +09:00
  5fd644fc57
• Use task completion source for room join flow

  On Android, users were unable to join or create multiplayer rooms. The
  root cause of that was that the both the wait and set of the
  `ManualResetEvent` in `getRoomUsers` occurred on the same thread, which
  created a chicken-and-egg situation - the set could not proceed until
  the wait had actually completed.
  
  Resolve by substituting the `ManualResetEvent` for a
  `TaskCompletionSource` to achieve a promise-style task, which the
  previous code was a crude approximation of anyway.
  
  Closes #11385.

  Bartłomiej Dach · 2021-01-17 14:40:22 +01:00
  eb53e32792
• Merge branch 'master' into explicit-search-control
  Dean Herbert · 2021-01-17 21:44:25 +09:00
  addd463d26
• Merge pull request #11472 from frenzibyte/explicit-beatmap-markers

  Add explicit content markers to beatmap panels and overlay

  Dean Herbert · 2021-01-17 21:44:10 +09:00
  edb6d3907b
• Merge branch 'master' into fix-is-connected-thread-safety
  Dan Balasescu · 2021-01-15 12:56:21 +09:00
  67b5ebadf5
• Fix stupid mistake

  fuck.

  Salman Ahmed · 2021-01-13 22:35:21 +03:00
  95acc457aa
• Merge branch 'master' into user-beatmap-downloading-states
  Salman Ahmed · 2021-01-13 22:31:31 +03:00
  560b1e970c
• Rename download state Downloaded to Importing
  Salman Ahmed · 2021-01-13 18:04:53 +03:00
  1f12b2bd09
• Merge branch 'explicit-beatmap-markers' into explicit-search-control
  Salman Ahmed · 2021-01-13 12:53:57 +03:00
  a5f99ed8e6
• Add online beatmap "explicit content" property
  Salman Ahmed · 2021-01-13 12:13:14 +03:00
  e8daea91d2
• Fix non-threadsafe usage of MultiplayerClient.IsConnected
  Dean Herbert · 2021-01-12 19:04:16 +09:00
  7298adc9d9
• Add "explicit maps" search filter control
  Salman Ahmed · 2021-01-12 11:09:55 +03:00
  249be461d5
• Fix up code comments

  Default value restated in xmldoc was snipped because it's made redundant
  by the initialiser and possibly bound to be outdated at some point.

  Bartłomiej Dach · 2021-01-11 20:31:52 +01:00
  0d5fbb15ac
• Update code in-line with decided direction
  Salman Ahmed · 2021-01-11 20:52:24 +03:00
  90fb67b377
• Downloaded -> Importing
  Salman Ahmed · 2021-01-11 08:21:07 +03:00
  2286e3679f
• Rename typo'd method
  Salman Ahmed · 2021-01-11 08:04:00 +03:00
  a8dfa5e2a9
• Add JsonConstructor attribute
  Salman Ahmed · 2021-01-11 08:02:57 +03:00
  e99310b59c
• Merge branch 'master' into disable-repeat-multi-actions
  Dean Herbert · 2021-01-04 23:38:29 +09:00
  deb1ad7bca
• Ensure clients don't blow up when given user isn't in room
  Salman Ahmed · 2021-01-03 18:36:37 +03:00
  839f5a7570
• Make constructors design more pleasent to eyes
  Salman Ahmed · 2021-01-03 18:36:05 +03:00
  c8423d1c46
• Make BeatmapAvailability class in-line with other online data structures
  Salman Ahmed · 2021-01-03 18:36:05 +03:00
  152e9ecccf
• Update osu.Game/Online/API/APIMod.cs

  Co-authored-by: Salman Ahmed <slmanarendo1950@gmail.com>

  Dean Herbert · 2021-01-03 17:04:16 +09:00
  6ad1b7767e
• Switch back to FirstOrDefault to allow for weird testing logic to pass
  Dean Herbert · 2021-01-03 16:46:24 +09:00
  99fa0e25dc
• Add internal pathway for ensuring correct application of bindable mods
  Dean Herbert · 2021-01-03 15:48:28 +09:00
  29dbb1cc0d
• Simplify some default value checks (we are sure the return is an IBindable)
  Dean Herbert · 2021-01-03 15:47:15 +09:00
  23e216fa0b
• Use SingleOrDefault for added safety when looking up mod acronyms
  Dean Herbert · 2021-01-03 15:38:30 +09:00
  1a44338124
• Add beatmap availability change state & event methods
  Salman Ahmed · 2021-01-03 05:48:49 +03:00
  dfa8be9173
• Add user beatmap availability property
  Salman Ahmed · 2021-01-03 05:48:49 +03:00
  09e5e2629a
• Introduce beatmap availability structure
  Salman Ahmed · 2021-01-03 05:48:49 +03:00
  8bb84570df
• Merge branch 'master' into fix-signalr-reconnect
  Bartłomiej Dach · 2021-01-02 13:18:02 +01:00
  9ab1091281
• Allow signalr to retry connecting when connection is closed without an exception
  Dean Herbert · 2021-01-02 16:47:00 +09:00
  72a6ca7755
• Move game start logic to a higher level
  Bartłomiej Dach · 2020-12-30 18:15:48 +01:00
  f800448c87
• Add helper IsHost property to Client
  Bartłomiej Dach · 2020-12-30 16:29:19 +01:00
  dd87478690
• Move thread safety / locking logic from MultiplayerRoom
  Dean Herbert · 2020-12-30 20:24:50 +09:00
  497d644a19
• Merge branch 'master' into fix-error-spam-on-disconnection
  Dean Herbert · 2020-12-30 00:55:37 +09:00
  3920dac8af
• Remove unused lock object
  Dean Herbert · 2020-12-29 17:39:00 +09:00
  6bbd0ecfac
• Move ready-up operation logic again to client

  To salvage ready up button tests.

  Bartłomiej Dach · 2020-12-29 09:16:02 +01:00
  e9b0652359
• Handle SocketExceptions and HttpRequestExceptions more silently

  These can occur when a network connection is completely unavailable (ie.
  host resolution failures are occurring). Currently these would appear as
  important errors which spammed the notification overlay every retry
  forever, while no network connection is available.
  
  I also took this opportunity to remove a lot of `bool` passing which was
  no longer in use (previously the fail count / retry process was
  different to what we have today).

  Dean Herbert · 2020-12-29 16:22:11 +09:00
  03b78d1c4b
• Make localUser a client property
  Bartłomiej Dach · 2020-12-29 07:46:22 +01:00
  903dca875e
• Fix error message being shown to user on multiplayer disconnection when not in room
  Dean Herbert · 2020-12-29 15:19:52 +09:00
  2cb84c5111
• Minor xmldoc rewording
  Dean Herbert · 2020-12-29 14:29:40 +09:00
  f31a0e455a
• Rename variable to make more sense

  It needs to be explicitly stated that the users in this list are related
  to the *joined* room. Especially since it's sharing its variable name
  with `SpectatorStreamingClient` where it has the opposite meaning (is a
  list of *globally* playing players).

  Dean Herbert · 2020-12-29 14:27:35 +09:00
  e3a41f6118
• Tidy up update state code, naming, xmldoc
  Dean Herbert · 2020-12-29 14:25:08 +09:00
  6aeb7ece66
• Change PlayingUsers population logic to match expectations
  Bartłomiej Dach · 2020-12-28 19:27:56 +01:00
  1d311a6680
• Merge branch 'master' into changelog-refactor
  Dean Herbert · 2020-12-28 11:00:14 +09:00
  1b7c72f03b
• Merge branch 'master' into fix-gameplay-leaderboard-clickable-avatars
  Dean Herbert · 2020-12-27 19:00:38 +09:00
  3b5260fd67
• Rename {Drawable -> Clickable}Avatar
  Bartłomiej Dach · 2020-12-26 14:35:11 +01:00
  0b42b4b955
• Merge branch 'master' into patch/11310
  Bartłomiej Dach · 2020-12-26 13:19:13 +01:00
  a1af749b4b
• Merge branch 'master' into fix-ready-button-crash
  Bartłomiej Dach · 2020-12-26 12:41:47 +01:00
  b059b5d616