Bartłomiej Dach
ecb7a809f2
Revert "Fix text anchor for mania tooltip"
...
This reverts commit c0b6e784a5076dbaf6addbfdae00bdebd35c3f6f.
The change affects editor and other stuff and I'm not sure it's correct.
It's not like client needs to match the appearance really. It already
doesn't in many places.
2024-12-16 13:18:47 +09:00
Bartłomiej Dach
cfdb959cf6
Split actual methods & fix completely broken localisation
...
Localisable strings cannot be plainly interpolated or joined. That is a
lossy operation that loses data.
2024-12-16 13:16:52 +09:00
Bartłomiej Dach
8d1d026f56
Clean up model
...
- Properly annotate things as nullable
- Remove weird passthrough property (more on that later)
2024-12-16 13:14:21 +09:00
Nicholas Chin
e2edd9e0d5
Fix code quality issues
2024-12-15 13:53:33 +08:00
Nicholas Chin
153e6c0c22
Use Count comparison instead of Any
2024-12-14 08:29:32 +08:00
Nicholas Chin
c0b6e784a5
Fix text anchor for mania tooltip
2024-12-13 21:58:23 +08:00
Nicholas Chin
a22f3416d6
Replace switch expression with LocalisableDescription attribute for variant display
...
Use existing localisation strings from BeatmapsStrings instead of CommonStrings for consistent localisation handling
2024-12-12 22:39:21 +08:00
Nicholas Chin
26f15def70
Add missing mania tooltip overlay for 4k and 7k
2024-12-11 23:15:05 +08:00
Bartłomiej Dach
4e4a99decc
Merge pull request #31076 from peppy/beatmap-store-interface
...
Access beatmap store via abstract base class
2024-12-11 17:48:32 +09:00
Bartłomiej Dach
99f9e2800a
Merge pull request #30763 from Darius-Wattimena/catch-convert-to-stream
...
Add convert to stream functionality for juice streams
2024-12-11 17:37:44 +09:00
Dean Herbert
cc1f94939f
Merge pull request #31037 from frenzibyte/ios-beatmap-export
...
Enable beatmap exports on iOS
2024-12-11 00:12:56 -08:00
Dean Herbert
2a4f596f90
Merge branch 'master' into ios-beatmap-export
2024-12-10 23:59:15 -08:00
Dean Herbert
02c52e41bd
Merge pull request #31039 from frenzibyte/ios-temporary-export-storage
...
Use temporary storage for file exports on iOS
2024-12-10 23:53:40 -08:00
Dean Herbert
8079784e96
Merge pull request #30877 from peppy/medal-display-fix
...
Fix potential issues with medal display
2024-12-10 23:53:34 -08:00
Dean Herbert
a868c33380
Remove BeatmapCarousel testing backdoor
2024-12-11 16:28:51 +09:00
Dean Herbert
c94b393e30
Access beatmap store via abstract base class
...
The intention here is to make things more testable going forward.
Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
where `BeatmapSets` can be set by tests and bypas/block realm retrieval.
2024-12-11 16:28:51 +09:00
Dean Herbert
bab9b9c937
Remove no-longer-correct comment
2024-12-11 16:28:50 +09:00
Dean Herbert
de31a48beb
Some Carousel classes can be abstract
2024-12-11 16:28:50 +09:00
Bartłomiej Dach
5a0b732ee3
Add comments backreferences to copies of duplicated code for future use
2024-12-11 16:26:11 +09:00
Bartłomiej Dach
1f43ad3928
Merge branch 'master' into catch-convert-to-stream
2024-12-11 16:24:45 +09:00
Bartłomiej Dach
c4374c7315
Merge branch 'master' into medal-display-fix
2024-12-11 15:52:38 +09:00
Salman Alshamrani
e0aec6f907
Revert unnecessary complexity
2024-12-11 01:03:55 -05:00
Salman Alshamrani
723883e1f0
Revert "Update exporter test to use OsuStorage"
...
This reverts commit f0f3c5357164334ea788ec928292b6b59768e55f.
2024-12-11 01:03:20 -05:00
Bartłomiej Dach
89e3c551ff
Merge pull request #30860 from frenzibyte/editor-multiple-background-audio-files
...
Allow choosing different background/audio files for individual difficulties
2024-12-11 14:12:58 +09:00
Dean Herbert
842829db7a
Merge pull request #31071 from smoogipoo/add-diffcalc-allowed-users
2024-12-10 18:28:40 -08:00
Dan Balasescu
315a9dba9b
Allow tsunyoku and stanriders to trigger diffcalc spreadsheet generator
2024-12-11 09:59:18 +09:00
Dan Balasescu
86f86fa5d4
Merge pull request #31052 from peppy/fix-hitcircle-lookup-fallback
...
Fix lookups of hit circle slider pieces potentially using wrong source skin
2024-12-10 23:16:40 +09:00
Dean Herbert
dae380b7fa
Fix lookups of hit circle slider pieces potentially using wrong source skin
...
Addresses https://github.com/ppy/osu/discussions/30927 .
2024-12-10 22:03:07 +09:00
Salman Alshamrani
d8e545e034
Merge pull request #31047 from peppy/silly-thing
...
Avoid beatmap lookup per bar in logo visualisation
2024-12-10 03:41:44 -05:00
Salman Alshamrani
e6e79cbd11
Merge branch 'master' into silly-thing
2024-12-10 03:00:53 -05:00
Dean Herbert
bbaa542d4a
Add note about expensive operation
2024-12-10 16:45:26 +09:00
Dean Herbert
3cac583754
Rewrite resource changing code to be more legible (to my eye)
2024-12-10 16:45:26 +09:00
Dean Herbert
48bf2fa001
Merge pull request #30960 from bdach/bookmarks
...
Implement basic bookmark support in editor
2024-12-09 23:42:04 -08:00
Bartłomiej Dach
7fcfebf4b4
Use Alt-{Left,Right} as default bindings for bookmark navigation
2024-12-10 14:59:19 +09:00
Dean Herbert
d69f5fd4cf
Avoid beatmap lookup per bar in logo visualisation
...
Just noticed in passing.
2024-12-10 14:45:36 +09:00
Dean Herbert
92dfcae6eb
Adjust bad grammar
2024-12-10 14:35:09 +09:00
Dean Herbert
7ec2d91e14
Merge branch 'master' into editor-multiple-background-audio-files
2024-12-10 14:19:55 +09:00
Dean Herbert
197d553238
Merge pull request #31041 from bdach/wtf-wtf-wtf-wtf-wtf-wtf
...
Fix top score statistics section total score display being terminally broken
2024-12-09 19:57:00 -08:00
Bartłomiej Dach
1febed66cf
Fix top score statistics section total score display being terminally broken
...
Closes https://github.com/ppy/osu/issues/31038 .
If you don't realise why this does anything, realise this: the drawable
creation callback runs for every created sprite text in the text flow.
ANd the created sprite texts are split by whitespace. And Russian /
Ukrainian / Polish etc. use spaces as thousands separators.
So on those languages the first encountered part of the score would
duplicate itself to the remaining parts.
I'm actively convinced it was _more difficult_ to produce what was in
place in `master` than to do it properly. Why did `TextColumn` even have
`LocalisableString Text` and `Bindable<string> Current` next to each
other?????
2024-12-09 23:51:57 +09:00
Salman Alshamrani
f0f3c53571
Update exporter test to use OsuStorage
2024-12-09 08:26:18 -05:00
Dan Balasescu
216e0c768b
Merge pull request #31035 from frenzibyte/ios-uttype-description
...
Add description to osu! file associations in iOS
2024-12-09 22:16:42 +09:00
Salman Alshamrani
0c0dcb1e15
Use temporary storage for exported files on iOS
2024-12-09 08:16:37 -05:00
Salman Alshamrani
e9868c6318
Enable exporting beatmaps in iOS
2024-12-09 07:47:28 -05:00
Salman Alshamrani
a46070be30
Add description to osu! file associations in iOS
2024-12-09 07:02:53 -05:00
Dan Balasescu
1b8d9370aa
Merge pull request #30973 from frenzibyte/copy-effect-points
...
Preserve effect point specifications when creating blank difficulties
2024-12-09 16:13:52 +09:00
Bartłomiej Dach
459533aba6
Merge branch 'master' into bookmarks
2024-12-07 22:22:04 +09:00
Dean Herbert
eeac8f530f
Merge pull request #31000 from LittleEndu/release-ipc-name
...
Fix IPC not working in release
2024-12-07 04:37:13 -08:00
Endrik Tombak
b04f5ab6e4
Fix IPC not working in release
2024-12-07 14:13:14 +02:00
Dean Herbert
3e7005d50f
Merge pull request #30956 from peppy/named-pipe
...
Fix osu! sometimes not starting when WSL is running in the background
2024-12-06 18:49:52 -08:00
Dean Herbert
b9f1fef250
Update framework
2024-12-07 10:46:03 +09:00
