67496 Commits

This Branch

This Branch

All Branches

• Changed timed difficulty attributes to be "per-HitObject" instead of "per-DifficultyHitObject"
  Givikap120 · 2024-06-18 15:41:41 +03:00
  ec2b8f3bc3
• Merge pull request #28480 from bdach/storyboard-pass-fail-show

  Implement toggling visibility of pass and fail storyboard layers

  Dean Herbert · 2024-06-16 11:08:00 +09:00
  15fbad0097
• Merge pull request #28481 from shiumano/no-offset-change

  Disable the automatic offset adjustment button if the offset of the previous play was 0

  Dan Balasescu · 2024-06-15 19:16:22 +09:00
  294f9bd626
• Merge pull request #28353 from Givikap120/catch_nf_penalty

  Changed Catch NF penalty to match Osu

  Dan Balasescu · 2024-06-15 18:54:02 +09:00
  2ecb9cd79e
• Inline enabled setting
  Dean Herbert · 2024-06-15 17:34:04 +08:00
  ff2d721029
• Apply NRT to test scene
  Dean Herbert · 2024-06-15 17:26:57 +08:00
  6bd633f8ce
• Set to enable or disable at load time
  Shiumano · 2024-06-14 21:43:17 +09:00
  6c82f1de9b
• Implement toggling visibility of pass and fail storyboard layers

  Closes https://github.com/ppy/osu/issues/6842.
  
  This is a rather barebones implementation, just to get this in place
  somehow at least. The logic is simple - 50% health or above shows pass
  layer, anything below shows fail layer.
  
  This does not match stable logic all across the board because I have
  no idea how to package that. Stable defines "passing" in like fifty
  ways:
  
  - in mania it's >80% HP
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Mania/RulesetMania.cs#L333-L336)
  - in taiko it's >80% *accuracy*
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Rulesets/Taiko/RulesetTaiko.cs#L486-L492)
  - there's also the part where "geki additions" will unconditionally set
    passing state
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3561-L3564)
  - and also the part where at the end of the map, the final passing state
    is determined by checking whether the user passed more sections than
    failed
    (https://github.com/peppy/osu-stable-reference/blob/bb57924c1552adbed11ee3d96cdcde47cf96f2b6/osu!/GameModes/Play/Player.cs#L3320)
  
  The biggest issues of these are probably the first two, and they can
  *probably* be fixed, but would require a new member on `Ruleset` and I'm
  not sure how to make one look, so I'm not doing that at this time
  pending collection of ideas on how to do that.

  Bartłomiej Dach · 2024-06-14 13:59:02 +02:00
  67ca7e4135
• Add failing test
  Shiumano · 2024-06-14 20:07:27 +09:00
  bfca64a98e
• Merge pull request #28475 from Joppe27/scorepanel-applause-balance

  Fix excessive `applause` audio balancing in result screen

  Dean Herbert · 2024-06-14 13:33:23 +09:00
  2d4121b14a
• Clamp X value to avoid excessive balance shift
  Joppe27 · 2024-06-13 18:06:19 +02:00
  47f89b8969
• Merge pull request #28466 from smoogipoo/fix-long-hold-length

  Fix missing texture on extremely long hold notes

  Bartłomiej Dach · 2024-06-13 09:13:03 +02:00
  fdb63bd7cd
• Merge pull request #28458 from bdach/mania-editor-hold-note-drag

  Allow modifying hold note start/end time via mania composer playfield

  Dan Balasescu · 2024-06-13 15:42:44 +09:00
  16aebb97a5
• Merge pull request #28465 from smoogipoo/hitobject-drawvis-display

  Use more descriptive HitObject names for debugger displays

  Dean Herbert · 2024-06-13 15:23:13 +09:00
  b61a705f64
• Fix missing texture on extremely long hold notes
  Dan Balasescu · 2024-06-13 15:19:41 +09:00
  1ff20cc13d
• Use more descriptive HitObject names for debugger displays
  Dan Balasescu · 2024-06-13 15:18:39 +09:00
  91f2cf8cc3
• Add test coverage
  Bartłomiej Dach · 2024-06-12 15:43:33 +02:00
  6d2f910813
• Allow modifying hold note start/end time via mania composer playfield
  Bartłomiej Dach · 2024-06-12 15:30:27 +02:00
  feadf7a56e
• Merge pull request #28456 from bdach/daily-challenge/countdown

  Implement time remaining display for daily challenge screen

  Dean Herbert · 2024-06-12 19:56:59 +09:00
  67f1511ad1
• Use extracted headings on daily challenge screen
  Bartłomiej Dach · 2024-06-12 11:44:19 +02:00
  ae6dd9d053
• Move out section header component from editor

  This sort of thing has been showing up on flyte designs more and more
  so I want to start using it more over that rather ugly "overlined" text
  that's there on multiplayer screens right now.

  Bartłomiej Dach · 2024-06-12 11:43:40 +02:00
  51c598627a
• Implement time remaining display for daily challenge screen
  Bartłomiej Dach · 2024-06-12 11:43:24 +02:00
  2be6b29f21
• Add start date to Room
  Bartłomiej Dach · 2024-06-12 11:43:18 +02:00
  6fb0cabf36
• Merge pull request #28440 from bdach/daily-challenge/new-screen

  Add minimal viable new screen for daily challenge feature

  Dean Herbert · 2024-06-12 17:49:02 +09:00
  94b7148a9e
• Fix user mod select button being inserted in incorrect place
  Bartłomiej Dach · 2024-06-12 08:59:50 +02:00
  5e002fbf9b
• Merge pull request #28445 from bdach/mania-key-count-change-force-reload

  Attempt full editor reload on key count change

  Dean Herbert · 2024-06-12 14:42:59 +09:00
  90481223dd
• Merge pull request #28441 from bdach/fix-editor-stacking-not-applying-immediately

  Fix stack leniency not applying immediately after change

  Dan Balasescu · 2024-06-12 12:24:28 +09:00
  39b219bacc
• Fix failing tests due to missing DI pieces
  Dean Herbert · 2024-06-12 11:23:56 +08:00
  2a8bd8d968
• Merge pull request #28443 from ColdVolcano/shorten-accuracy

  Fix Argon accuracy counter layout when under 10% and wireframe off

  Bartłomiej Dach · 2024-06-11 14:57:59 +02:00
  fb99daea2a
• Add test coverage
  Bartłomiej Dach · 2024-06-11 12:28:39 +02:00
  e67d73be7d
• Attempt full editor reload on key count change
  Bartłomiej Dach · 2024-06-11 11:31:49 +02:00
  da53a11d3c
• Add RestoreState() to IEditorChangeHandler
  Bartłomiej Dach · 2024-06-11 11:31:30 +02:00
  3afe98612c
• Split mania difficulty section implementation off completely from base

  - "Circle size" / key count needs completely different handling.
  - Approach rate does not exist in mania.

  Bartłomiej Dach · 2024-06-11 11:30:20 +02:00
  10af642342
• Merge branch 'master' into daily-challenge/new-screen
  Dean Herbert · 2024-06-11 18:24:31 +09:00
  c640fbbaf0
• fix accuracy counter separating whole and fraction parts with wireframes off
  ColdVolcano · 2024-06-11 02:20:14 -06:00
  4048a4bdfb
• Merge pull request #28420 from bdach/mutually-exclusive-save-related-actions

  Disallow running save-related operations concurrently

  Dean Herbert · 2024-06-11 01:03:47 +09:00
  cd3b455341
• Fix stack leniency not applying immediately after change
  Bartłomiej Dach · 2024-06-10 14:34:22 +02:00
  25b2dfa601
• Hide daily challenge from playlists listing
  Bartłomiej Dach · 2024-06-10 13:12:21 +02:00
  073ddcebe4
• Add test scene for daily challenge screen
  Bartłomiej Dach · 2024-06-10 13:12:20 +02:00
  2321e408cb
• Add minimal viable variant of new daily challenge screen
  Bartłomiej Dach · 2024-06-10 13:09:12 +02:00
  e6da17d248
• Use room mod select overlay rely on explicit binding rather than DI resolution
  Bartłomiej Dach · 2024-06-10 12:45:51 +02:00
  ffd788c65c
• Extract user mod select button for reuse
  Bartłomiej Dach · 2024-06-10 12:45:27 +02:00
  dd6e9308b3
• Make SelectedItem externally mutable

  Not being able to externally mutate this was making reuse in new daily
  challenge screen unnecessarily arduous.

  Bartłomiej Dach · 2024-06-10 12:44:38 +02:00
  f135a9a923
• Adjust online play header to be reusable for new daily challenge screen
  Bartłomiej Dach · 2024-06-10 12:43:58 +02:00
  d80f09e0c0
• Extract OnlinePlayScreenWaveContainer from OnlinePlayScreen
  Bartłomiej Dach · 2024-06-10 12:42:37 +02:00
  19f39ca1b6
• Merge branch 'master' into mutually-exclusive-save-related-actions
  Bartłomiej Dach · 2024-06-10 10:30:35 +02:00
  acf4dbb62c
• Refactor further to address code quality complaints
  Bartłomiej Dach · 2024-06-10 10:30:30 +02:00
  1d6b7e9c9b
• Merge pull request #28436 from omkelderman/fix-auto-pick-map-on-zero-ban-round

  Fix auto picking maps on zero ban rounds

  Dean Herbert · 2024-06-10 13:51:41 +09:00
  a8a2e543d5
• On the mappool screen the auto-pick map logic on map change still assumed 1 ban per team. Now it listens to the BanCount value from the round
  Olle Kelderman · 2024-06-09 21:42:37 +02:00
  642095b07b
• Merge pull request #28185 from frenzibyte/footer-v2-become-global

  Move new screen footer to `OsuGame` and add temporary `SongSelectV2` screen

  Dean Herbert · 2024-06-09 19:06:38 +09:00
  be48377c4c