4431 Commits

• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-19 16:33:10 +01:00
  3183f5cee2
• Use more generic wording for future-proofing
  Bartłomiej Dach · 2023-02-19 15:06:40 +01:00
  d9ca7102f0
• Combine config and time checks into one

  Functionally equivalent right now, but the combined variant is more
  localised to what it actually needs to do, and less error-prone if
  any new code gets appended to the method.

  Bartłomiej Dach · 2023-02-19 13:14:51 +01:00
  aac32a2c9f
• change bindable seekToHitObject to private
  Maximilian Kruse · 2023-02-19 10:18:02 +01:00
  f3522c4162
• Add setting to disable automatic seeking after object placement
  Maximilian Kruse · 2023-02-18 19:43:45 +01:00
  ddd37bb319
• Merge branch 'master' into revert-result-in-playfield
  Bartłomiej Dach · 2023-02-16 21:54:29 +01:00
  3ee046000e
• Revert ResumeOverlay setter accessibility change
  Bartłomiej Dach · 2023-02-16 21:26:01 +01:00
  b8084a15eb
• Always create ResumeOverlay, with UseResumeOverlay flag only affecting whether it is displayed or not
  Dean Herbert · 2023-02-16 15:47:20 +09:00
  ce9ef3bc3c
• Merge branch 'master' into hide-resume-overlay
  Dean Herbert · 2023-02-16 15:42:14 +09:00
  7afdcb9383
• Merge branch 'master' into maximum-judgement-offset-in-hit-object
  Dean Herbert · 2023-02-15 14:48:15 +09:00
  da8ab7143b
• Restructure UseResumeOverlay to correctly handle a value change before BDL load
  Dean Herbert · 2023-02-14 15:11:33 +09:00
  63f3498762
• Add UseResumeOverlay and use it for hiding the ResumeOverlay
  Pasi4K5 · 2023-02-13 23:51:39 +01:00
  e4b84ebd0b
• Move taiko-specific property out of DrawableHitObject
  Dean Herbert · 2023-02-12 16:09:28 +09:00
  9d09141ab7
• Merge pull request #22589 from sw1tchbl4d3r/file_hitsample_additions

  Always add to additions soundbank in `convertSoundType`

  Dean Herbert · 2023-02-10 17:14:29 +09:00
  ad8b01b478
• Merge pull request #22554 from Walavouchey/ranking-accuracycircle-readability

  Improve readability of `AccuracyCircle`

  Dean Herbert · 2023-02-10 17:03:46 +09:00
  eccde923e5
• Use if statements rather than conditional case
  Dean Herbert · 2023-02-10 17:03:27 +09:00
  1df6fc6311
• Fix grammar in xmldoc

  Co-authored-by: Walavouchey <36758269+Walavouchey@users.noreply.github.com>

  Bartłomiej Dach · 2023-02-10 00:07:24 +01:00
  96c1832af4
• Always add to additions soundbank in convertSoundType
  sw1tchbl4d3 · 2023-02-09 22:27:52 +01:00
  f0d11f44fc
• Change snapping to only apply to classic mod
  Dean Herbert · 2023-02-09 18:22:14 +09:00
  34d1890f1c
• Store RawTime in JudgementResult
  ekrctb · 2023-02-09 17:15:37 +09:00
  258de3b2d8
• Merge branch 'maximum-judgement-offset-in-hit-object' into revert-result-in-playfield
  ekrctb · 2023-02-09 16:47:58 +09:00
  5f0636c330
• Centralise accuracy cutoff constants and add lookup helper methods
  Dean Herbert · 2023-02-09 15:41:58 +09:00
  cf009432cc
• Merge branch 'master' into sheared_slider_implementation_clean_ii
  Dean Herbert · 2023-02-06 17:49:33 +09:00
  c691a0d3af
• Use equals instead and update other usage
  Joseph Madamba · 2023-02-04 19:58:48 -08:00
  191259c050
• Rename NormalSliderBar.cs to RoundedSliderBar.cs
  mk56-spn · 2023-02-02 17:24:45 +01:00
  3f0ce75bf5
• Merge pull request #22281 from cdwcgt/editor-check-previewtime

  Add preview time setting check

  Dean Herbert · 2023-02-02 15:10:06 +09:00
  b792dc3af0
• Fix typo in missing-preview-point message
  Dean Herbert · 2023-02-02 14:34:59 +09:00
  5b3d7a8f26
• Fix message not reading well
  Dean Herbert · 2023-02-02 14:33:41 +09:00
  c2cde8361a
• Remove multiple cases of excess braces
  Dean Herbert · 2023-02-02 14:28:21 +09:00
  3a861fd943
• Merge pull request #22430 from peppy/skin-editor-nrt

  Apply NRT to all skin editor classes

  Dean Herbert · 2023-02-02 13:57:57 +09:00
  10df64467a
• Consistent with BeatmapsetVerifier
  cdwcgt · 2023-02-01 11:52:14 +08:00
  76296eb35a
• Fix sample store creation mutating shared resource store
  Bartłomiej Dach · 2023-01-30 20:48:52 +01:00
  c5e1f54185
• Remove JudgementResultEntry

  It is not needed anymore as TimeAbsolute is stored raw.

  ekrctb · 2023-01-27 19:35:44 +09:00
  27578c48f5
• Refactor SkinnableSound.Samples to be non-nullable
  Dean Herbert · 2023-01-27 19:32:30 +09:00
  74ab036f3e
• Rename OsuSliderBar.cs as NormalSliderBar.cs
  mk56-spn · 2023-01-26 12:12:56 +01:00
  3988131475
• Merge branch 'master' into revert-result-in-playfield
  Dean Herbert · 2023-01-25 17:35:33 +09:00
  f0406c34fd
• Merge pull request #18402 from ggliv/mod-accuracy-challenge

  Add accuracy challenge mod

  Dean Herbert · 2023-01-24 16:00:55 +09:00
  a966d6c330
• Fix inspection issue
  ekrctb · 2023-01-24 15:43:57 +09:00
  e1702a8ee9
• Store Result.TimeAbsolute separately from offset

  Calculating from TimeOffset is bad because it loses precision.
  The result time won't change anymore
  even If `HitObject.GetEndTime()` changes later.

  ekrctb · 2023-01-24 15:35:06 +09:00
  efef97d5be
• increase min minimum accuracy to 60%
  Gabe Livengood · 2023-01-24 00:31:46 -05:00
  b46ef67a14
• Fix OnRevertResult timing
  ekrctb · 2023-01-24 14:19:24 +09:00
  cc87923179
• Remove unused code
  ekrctb · 2023-01-24 14:15:17 +09:00
  e66e43e17c
• Remove HidesResumeOverlay and set ResumeOverlay to null in OsuModAutopilot
  Pasi4K5 · 2023-01-24 00:49:09 +01:00
  8b47af6503
• Merge branch 'master' into SliderEnd-Snap
  Bartłomiej Dach · 2023-01-23 21:33:16 +01:00
  7483967157
• Clean up xmldocs
  Bartłomiej Dach · 2023-01-23 21:22:18 +01:00
  1f40b2daf6
• change IssueTemplatePreviewTimeConflict's text
  cdwcgt · 2023-01-23 15:26:28 +09:00
  5afb733fb2
• Refactor how additional points are provided to avoid confusion
  Dean Herbert · 2023-01-23 14:13:46 +09:00
  73f083a316
• Hide ResumeOverlay when OsuModAutopilot is enabled
  Pasi4K5 · 2023-01-22 03:44:59 +01:00
  75a1a2ec2f
• Use MaximumJudgementOffset for lifetime
  ekrctb · 2023-01-19 21:25:21 +09:00
  d8f9b7d02f
• Move MaximumJudgementOffset to HitObject

  We want to access this property for computing lifetime

  ekrctb · 2023-01-19 21:23:55 +09:00
  11e1b22bf5