76352 Commits

This Branch

This Branch

All Branches

• Merge pull request #36404 from peppy/fix-carousel-thing

  Fix random selection not showing selection when all groups are collapsed

  Bartłomiej Dach · 2026-01-22 08:24:03 +01:00
  ea0b281f48
• Simplify logic further and fix regressing case
  Dean Herbert · 2026-01-22 14:59:42 +09:00
  6354286452
• Add failing test case showing visual state desync
  Dean Herbert · 2026-01-22 14:59:41 +09:00
  6f146a5ce9
• Merge branch 'master' into fix-carousel-thing
  Dean Herbert · 2026-01-22 01:55:28 +09:00
  5d651628bc
• Fix carousel items becoming incorrectly selected due to bindable leakage (#36414)

  As discussed in discord. Fixed from multiple angles.
  
  ---------
  
  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2026-01-22 01:06:40 +09:00
  10dc1314f6
• Refactor HandleFilterCompleted to (hopefully) be easier to parse

  This is not required to fix the issue, but it is required for my brain
  to follow the method to some degress.

  Dean Herbert · 2026-01-20 21:12:49 +09:00
  46b2d5374e
• Handle expand set logic locally rather than calling HandleItemSelected

  This avoids the implicit group expansion happening that the added code
  was attempting to fix.

  Dean Herbert · 2026-01-20 21:12:49 +09:00
  8860eec9f9
• Revert "Do not forcibly re-expand carousel groups on refilters if the user manually collapsed them"

  This reverts commit bc4d5d07d7.

  Dean Herbert · 2026-01-20 21:12:49 +09:00
  8c86ff36a2
• Revert "Fix current beatmap set being incorrectly expanded after collapsing group with current selection"

  This reverts commit 9ba9966078.

  Dean Herbert · 2026-01-20 21:12:48 +09:00
  fdf9092f41
• Add failing test showing incorrect behaviour on random select with collapsed groups
  Dean Herbert · 2026-01-20 21:12:48 +09:00
  76f05a4837
• Merge pull request #36401 from peppy/fix-skin-save-crash

  Fix skin saving crashing if hashable files are not present

  Bartłomiej Dach · 2026-01-20 11:04:23 +01:00
  ae1402c9cd
• Fix skin saving crashing if hashable files are not present

  This ends up with a bit of an undefined behaviour, but it's already a
  bit of an edge case (files missing in the `files` folder that are
  references in the database).
  
  First and foremost, let's stop the exception. If we allow it to throw,
  it's impossible to exit the skin editor in this state.
  
  Closes https://github.com/ppy/osu/issues/36135.

  Dean Herbert · 2026-01-20 17:41:10 +09:00
  741620d89c
• Fix changing combo colours in beatmap without custom samples opening new sample set popover (#36400)

  Reported [on reddit of all
  places](https://www.reddit.com/r/osugame/comments/1qhnfdn/every_time_i_make_an_adjustment_to_the_hitcircle/).
  
  The reason that this is happening is as follows:
  
  - Changing a combo colour raises `BeatmapSkinChanged`
  - `BeatmapSkinChanged` getting raised triggers the sample chooser
  dropdown to repopulate its items (as intended and correctly)
  - Setting items of a dropdown can also change its `Current.Value`,
  because the relevant logic attempts to ensure that `Current.Value` is
  valid in line with the new items
  - Therefore the `Current.Value` of the dropdown changes from `null` to
  sample set `-1` which corresponds to the "Add new..." item as it's the
  only item in the dropdown...
  - which is indistinguishable from the sequence of events that happens if
  the user manually opens the dropdown and clicks the "Add new..." item.
  
  This change sidesteps this entire car crash by just ensuring that even
  beatmaps without custom samples have at least set number 1 initialised
  (even if it's empty and has no samples). This means that the initial
  value of the dropdown is never `null`, and that every time that the
  value changes to the set `-1` it actually is due to user action.
  
  Should have known better than to play these dumb games.

  Bartłomiej Dach · 2026-01-20 17:10:40 +09:00
  4ee4aac708
• Specialise mod setting hover text in song select scoreboard (#36391)

  - resolves #35992
  
  **Changes**
  
  Introduced GetSettingTooltipText, which returns the value of the
  respective setting. The function can be overwritten, allowing to
  implement specific behavior. This allows you to define that a value of 0
  for the “Muted” mod will instead display “always muted.”
  In the same step, I also adjusted the "NoScope" mod, where we had the
  same problem.
  Wherever we want to implement specialization like this, we can simply
  overwrite GetSettingTooltipText to customize the behavior for the mod
  settings of the mod.
  
  **Result**
  <img width="2560" height="1440" alt="2026-01-19-122307_hyprshot"
  src="https://github.com/user-attachments/assets/20e3aa9a-aa6f-4284-9cf1-3092f52c021d"
  />
  <img width="2560" height="1440" alt="2026-01-19-122324_hyprshot"
  src="https://github.com/user-attachments/assets/6f3fac5b-2a5d-4dd9-a56c-4b09c02cbcca"
  />
  <img width="2560" height="1440" alt="2026-01-19-155307_hyprshot"
  src="https://github.com/user-attachments/assets/f9ee75d3-c200-4536-9ee9-d20ddbd9fa44"
  />
  
  Signed-off-by: Linus Genz <linuslinuxgenz@gmail.com>

  Linus Genz · 2026-01-20 16:51:23 +09:00
  dfa7ac2082
• Fix sample set index entry box crashing on bad input (#36390)

  closes https://github.com/ppy/osu/issues/36374

  Bartłomiej Dach · 2026-01-19 22:21:20 +09:00
  c1d9de7e83
• Add metadata endpoint to refresh friend listing (#36386)

  Alternative to / closes https://github.com/ppy/osu/pull/36341
  See also: https://github.com/ppy/osu-server-spectator/pull/415
  
  This is a simple solution by adding a spectator endpoint to refresh the
  friend listing. A more complicated form of this is to make
  adding/removing friends only via spectator, but that would require
  osu-web changes too.

  Dan Balasescu · 2026-01-19 18:34:00 +09:00
  2026.119.0-lazer 2026.119.0 e62a01cf77
• Remove mention of no-longer-existent "good first issue" label

  It doesn't work in practice, because the skill baseline of an incoming
  "contributor" is so wildly variant that any issue that isn't explicitly
  a one-liner is automatically not suitable for *some* non-trivial subset
  of "new contributor".
  
  The label is also largely used by incoming contributors whose interests
  are not necessarily aligned with the project but instead appear to have
  other ulterior motives.

  Bartłomiej Dach · 2026-01-19 09:26:22 +01:00
  a60f262679
• Fix osu! logo appearing in at new playlist song select screen after opening mod select (#36385)

  Closes https://github.com/ppy/osu/issues/36363.

  Dean Herbert · 2026-01-19 16:55:39 +09:00
  c0b644c905
• Localise "hold for menu" & "press for menu" in HoldForMenuButton (#36381)
  MayoCollector · 2026-01-19 14:39:21 +09:00
  cf73f8f9e6
• Remove now unnecessary mobile hold hack when song select v2 wasn't default (#36384)

  This reverts commit 3931ae3499.

  Joseph Madamba · 2026-01-19 13:31:48 +09:00
  7608ed4d87
• Fix score tooltips being displayed when hovering mod status bar (#36332)

  - addresses https://github.com/ppy/osu/discussions/34079
  - supersedes and closes https://github.com/ppy/osu/pull/34090

  Denis Titovets · 2026-01-17 23:15:46 +09:00
  eee88a3955
• Improve input handling in percentage-based slider bars (#36195)

  Reported in
  https://github.com/ppy/osu/pull/36193#issuecomment-3703406223.
  
  Preview:
  
  
  https://github.com/user-attachments/assets/ac2b86cf-ad92-496b-b3dd-19ad47753a9b
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Salman Alshamrani · 2026-01-17 16:39:28 +09:00
  676b7a36da
• Fix form dropdown open animation not being smooth (#36358)

  Preview:
  
  
  https://github.com/user-attachments/assets/07cb58b7-5980-4fed-bb4c-2443ba1e9635

  Salman Alshamrani · 2026-01-17 02:54:12 +09:00
  b5a989d31e
• Merge pull request #36190 from bdach/add-custom-samples-via-setup

  Add way to add/remove custom beatmap samples to setup screen

  Dean Herbert · 2026-01-17 01:55:59 +09:00
  a6489cd758
• Ensure diffcalc runs after mods get replaced during a ruleset change (#36359)
  Krzysztof Gutkowski · 2026-01-16 16:38:00 +01:00
  952fd0d493
• Add localisation support for some more notifications (#36353)

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Denis Titovets · 2026-01-16 22:58:20 +09:00
  06b89919be
• Merge branch 'master' into add-custom-samples-via-setup
  Dean Herbert · 2026-01-16 20:11:28 +09:00
  e1bde264bc
• Update editor slider controls to new design (#36346)

  (partially) Closes: #36233
  Surpasses: #36244 
  
  This PR meant to be one of the last steps that finally make editor use
  the new forms. Initially it meant to only change one
  SliderWithTextBoxInput in "Effects section" in timing screen, however
  soon after it was obvious that there's many other places that still
  using it. This currently won't affect
  IndeterminateSliderWithTextBoxInput that is being used in hitsounds, for
  example, since I think it needs more consideration.
  Anyways, with this PR, SliderWithTextBoxInput, will no longer be used at
  all, as it's going to be replaced with modern FormSliderBar
  
  Comparison:
  |master|this PR|
  |:---:|:---:|
  |<img width="510" height="316"
  alt="532203751-eb965923-d3a8-441d-a7c8-5c364a6328ad"
  src="https://github.com/user-attachments/assets/268b45b8-e235-494f-91a5-d00db057dba8"
  />|<img width="540" height="321"
  alt="535466527-3a700a8b-bc3c-4610-998f-a4e55ee03eed"
  src="https://github.com/user-attachments/assets/20cd4b58-b0bd-49bc-8c48-7de5cf8556b3"
  />|
  |<img width="694" height="639"
  alt="534509844-f00e4da4-53c4-45e8-80ea-1be62da6c83b"
  src="https://github.com/user-attachments/assets/398c4484-a867-4df1-9de3-0940aa748a01"
  />|<img width="720" height="433" alt="изображение"
  src="https://github.com/user-attachments/assets/b6359443-a224-4a55-b171-07e8f013cf46"
  />|
  |<img width="715" height="353"
  alt="534509421-a6ac950f-16e8-4a16-bca6-1a781f82135f"
  src="https://github.com/user-attachments/assets/4854312b-772f-4b81-a800-89e58d4c715d"
  />|<img width="710" height="296" alt="изображение"
  src="https://github.com/user-attachments/assets/a7fed53e-e006-4285-92c9-bb84cb603f60"
  />|
  |<img width="717" height="374"
  alt="534509478-80222623-7766-481d-8682-088276d415ee"
  src="https://github.com/user-attachments/assets/8143b6dc-4599-45d5-bd3b-f059caf3d93d"
  />|<img width="718" height="328" alt="изображение"
  src="https://github.com/user-attachments/assets/bffa04de-983c-45ae-a1ec-373701ea0e49"
  />|
  |<img width="702" height="446"
  alt="534509935-58954060-7ac1-4392-8754-a58f909e86aa"
  src="https://github.com/user-attachments/assets/2bb67a2d-3f57-42a1-96ce-b30b4891e1a4"
  />|<img width="722" height="386" alt="изображение"
  src="https://github.com/user-attachments/assets/01b7fff4-7f31-4aac-90c9-353b15f4964e"
  />|

  De4n · 2026-01-16 20:08:52 +09:00
  e05b6f44b9
• Fix double-clicking form slider bar not propagating default to other bindables when TransferValueOnCommit is true (#36354)

  - Addresses https://github.com/ppy/osu/pull/36346#discussion_r2692322683
  
  The inner slider bar binds its `Current` to
  `currentNumberInstantaneous`:
  
  
  https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L225-L236
  
  But the current bindable of the form component doesn't update because of
  this.
  
  
  https://github.com/ppy/osu/blob/1add946db486c866cc214c5eb3d728f308aad637/osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs#L285-L293
  
  Fixed it by just moving the `ResetToDefault` action up another level.
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Joseph Madamba · 2026-01-16 19:48:36 +09:00
  a8ada50549
• Merge pull request #36350 from peppy/toast-adjust

  Fix toasts showing "no key bound" for operations which can't have keys bound

  Bartłomiej Dach · 2026-01-15 13:06:33 +01:00
  2026.116.0-tachyon 1add946db4
• Merge pull request #36349 from peppy/spectator-connection-disconnect-notify

  Fix notification spam on websocket connection handshake failures

  Bartłomiej Dach · 2026-01-15 13:06:19 +01:00
  a2ca650a9f
• Scope player handling to specific screens which have issues
  Dean Herbert · 2026-01-15 18:09:04 +09:00
  1313883394
• Stop websocket handshake failures from being shown to users
  Dean Herbert · 2026-01-15 18:09:04 +09:00
  e8154080b3
• Fix toasts showing "no key bound" for operations which can't have keys bound

  Supersedes and closes https://github.com/ppy/osu/pull/35781.
  Closes https://github.com/ppy/osu/issues/36294.

  Dean Herbert · 2026-01-15 17:52:30 +09:00
  b4ba327c1c
• Alert when spectator server disconnects during gameplay

  This can cause issues liek loss of replays, so it's worth notifying the
  user and keeping things visible.

  Dean Herbert · 2026-01-15 17:14:56 +09:00
  c646b4e5ec
• Use same message for multiplayer disconnects to simplify things further
  Dean Herbert · 2026-01-15 17:11:44 +09:00
  15cb3b7a27
• Adjust API disconnection text to be usable in more scenarios
  Dean Herbert · 2026-01-15 17:11:42 +09:00
  0551c75c6b
• Adjust friend notification logic to fix a few flaws (#36348)

  Just a couple of things I noticed in passing:
  
  - When changing the configuration setting, things were not reset.
  Likewise, if the setting was off the queues would still be added to but
  never flushed.
  - When the setting is toggled, a stale next notification time was still
  present due to the `??=` and lack of resetting. This should no longer be
  the case.

  Dean Herbert · 2026-01-15 16:31:15 +09:00
  2bf0dcf398
• Use new star rating text gradient for the difficulty name, "mapped by" text and difficulty bars (#36345)

  Fixes: #36312
  
  I think that's exactly what needed to be done to fix this issue.
  
  |master|this PR|
  |:---:|:---:|
  |<img width="943" height="272" alt="изображение"
  src="https://github.com/user-attachments/assets/e6fb57bd-8393-4476-ac73-a8b559365e6d"
  />|<img width="950" height="270" alt="изображение"
  src="https://github.com/user-attachments/assets/e09de911-0068-4a8b-9abb-f2aa04a87886"
  />|
  |<img width="943" height="274" alt="изображение"
  src="https://github.com/user-attachments/assets/637a86f5-ad26-441d-8fa2-bdf113bb636d"
  />|<img width="936" height="272" alt="изображение"
  src="https://github.com/user-attachments/assets/d72f52a1-6c17-4156-a4eb-cca36e74f644"
  />|
  |<img width="940" height="271" alt="изображение"
  src="https://github.com/user-attachments/assets/cf6a5f18-34c8-4f51-867a-ba1fc30b64a5"
  />|<img width="941" height="270" alt="изображение"
  src="https://github.com/user-attachments/assets/e21cda45-1a69-4623-b9a7-add3eb7c7013"
  />
  |<img width="946" height="275" alt="изображение"
  src="https://github.com/user-attachments/assets/e29647bb-c4aa-4d03-a46d-3bbcd43181b6"
  />|<img width="932" height="271" alt="изображение"
  src="https://github.com/user-attachments/assets/1f777db2-d0f9-4c2a-91fa-e005b9704c9a"
  />
  
  ---------
  
  Co-authored-by: Dean Herbert <pe@ppy.sh>

  De4n · 2026-01-15 16:00:27 +09:00
  3302e2e180
• Fix copy paste failure in MultiplayerMatchSettingsOverlay
  Dean Herbert · 2026-01-14 20:02:11 +09:00
  79f1d77fed
• Merge pull request #36324 from frenzibyte/better-form-button

  Update form button UI/UX and support text wrapping

  Dean Herbert · 2026-01-14 19:47:50 +09:00
  91718447db
• Update button background colour in update function
  Salman Alshamrani · 2026-01-14 01:34:20 -05:00
  3f4d1b798e
• Merge pull request #36328 from bdach/hub-connector-fluff

  Clean up `HubClientConnector` configuration

  Dean Herbert · 2026-01-13 20:17:41 +09:00
  d1a231cacf
• Simplify proxy configuration

  More clean-up.

  Bartłomiej Dach · 2026-01-13 11:16:20 +01:00
  9c8d6e63a7
• Remove no longer needed header alias for version hash

  Clean-up from an old change (see
  https://github.com/ppy/osu/pull/28892#discussion_r1681136250).

  Bartłomiej Dach · 2026-01-13 11:12:03 +01:00
  5abc0f93fe
• Replace manual specification of Authorization header with SignalR-provided provider property

  The property used here is listed in SignalR documentation:
  
  	https://learn.microsoft.com/en-us/aspnet/core/signalr/authn-and-authz?view=aspnetcore-10.0#bearer-token-authentication
  
  While in practice this probably has zero bearing on anything,
  theoretically the way proposed in this commit is more correct.
  As the documentation states, with some transports the token may need to
  be renewed if it expires, which providing it via a header as done
  previously would not achieve, while going through `API.AccessToken`
  every time will perform a token refresh if one is needed.

  Bartłomiej Dach · 2026-01-13 11:03:59 +01:00
  d5aa5b61ad
• Merge pull request #35117 from smoogipoo/new-playlists-song-select

  Use new song select (v2) for playlists

  Dean Herbert · 2026-01-13 17:38:03 +09:00
  f9e70f06b3
• Merge branch 'master' into new-playlists-song-select
  Dean Herbert · 2026-01-13 17:04:42 +09:00
  363b7cf3cb
• Remove unused button
  Dean Herbert · 2026-01-13 16:57:50 +09:00
  eeb4680795
• Improve form dropdown UX (#36325)

  Addresses concerns in
  https://github.com/ppy/osu/pull/36193#issuecomment-3728177951 (excluding
  the last part, that is too involved and I can't imagine any workaround
  for it due to how strict the `Dropdown` structure is). Also adds
  truncation/padding to header label and search bar.
  
  Preview:
  
  
  https://github.com/user-attachments/assets/8885cb90-44dc-42ee-af21-cb33f7723e63

  Salman Alshamrani · 2026-01-13 16:20:03 +09:00
  f892d5fbaa