h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2026-06-03 18:03:55 +08:00
Code Issues Releases Wiki Activity

Improve input handling in percentage-based slider bars (#36195)

Browse Source 
Reported in
https://github.com/ppy/osu/pull/36193#issuecomment-3703406223.

Preview:


https://github.com/user-attachments/assets/ac2b86cf-ad92-496b-b3dd-19ad47753a9b

---------

Co-authored-by: Dean Herbert <pe@ppy.sh>
This commit is contained in:
Salman Alshamrani
2026-01-17 02:39:28 -05:00
committed by GitHub
Unverified
parent b5a989d31e
commit 676b7a36da
1 changed files with 17 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
osu.Game/Graphics/UserInterfaceV2/FormSliderBar.cs
+17 -2
View File
@@ -330,7 +330,11 @@ namespace osu.Game.Graphics.UserInterfaceV2
break;
case Bindable<double> bindableDouble:
bindableDouble.Value = double.Parse(textBox.Current.Value);
bindableDouble.Value = double.Parse(textBox.Current.Value) / (DisplayAsPercentage ? 100 : 1);
break;
case Bindable<float> bindableFloat:
bindableFloat.Value = float.Parse(textBox.Current.Value) / (DisplayAsPercentage ? 100 : 1);
break;
default:
@@ -397,7 +401,18 @@ namespace osu.Game.Graphics.UserInterfaceV2
{
if (updatingFromTextBox) return;
textBox.Text = currentNumberInstantaneous.Value.ToStandardFormattedString(OsuSliderBar<T>.MAX_DECIMAL_DIGITS);
if (DisplayAsPercentage)
{
double floatValue = double.CreateTruncating(currentNumberInstantaneous.Value);
if (currentNumberInstantaneous.Value is int)
floatValue /= 100;
textBox.Text = floatValue.ToStandardFormattedString(Math.Max(0, OsuSliderBar<T>.MAX_DECIMAL_DIGITS - 2));
}
else
textBox.Text = currentNumberInstantaneous.Value.ToStandardFormattedString(OsuSliderBar<T>.MAX_DECIMAL_DIGITS);
valueLabel.Text = LabelFormat(currentNumberInstantaneous.Value);
}