51935 Commits

This Branch

This Branch

All Branches

• Simplify channel retrieval expression
  Bartłomiej Dach · 2022-05-29 18:58:27 +02:00
  e329c160b3
• Fix incorrect indent size
  Bartłomiej Dach · 2022-05-29 18:56:37 +02:00
  e69f8716cd
• Merge branch 'master' into new-chat-announce-channel
  Bartłomiej Dach · 2022-05-29 18:55:43 +02:00
  f9f8a32380
• Merge pull request #18480 from peppy/fix-chat-overlay-v2-tests

  Fix multiple intermittent failures in chat overlay tests

  Bartłomiej Dach · 2022-05-29 16:51:13 +02:00
  83c2b27b69
• Centralise DrawableChannel checks and account for async load delays
  Dean Herbert · 2022-05-29 23:16:26 +09:00
  caee9e67b6
• Fix unsafe config fetching
  Dean Herbert · 2022-05-29 22:55:53 +09:00
  c078c06902
• Merge pull request #18473 from peppy/fix-skin-changed-disposal

  Fix potential `ObjectDisposedException` on realm notification in `SkinSection`

  Dean Herbert · 2022-05-29 22:43:47 +09:00
  186999c4eb
• Update framework
  Dean Herbert · 2022-05-29 21:31:20 +09:00
  70c8a43961
• Move Schedule to only drawable pieces
  Dean Herbert · 2022-05-29 21:28:09 +09:00
  7c97719db1
• Fix potential ObjectDisposedException on realm notification in SkinSection
  Dean Herbert · 2022-05-29 15:15:03 +09:00
  c7570fbce5
• Merge pull request #18459 from bdach/unobserved/convert-slider

  Fix unobserved exceptions in multiple tests due to constructing `GameplayState` instances with unconverted beatmaps

  Dean Herbert · 2022-05-29 00:54:11 +09:00
  20701edc23
• Fix remaining cases of incorrect GameplayState construction in tests

  Manual attempts to initialise replaced by a new `TestGameplayState`
  helper for ease of use.

  Bartłomiej Dach · 2022-05-28 15:23:29 +02:00
  a8e1c5ba87
• Fix unobserved exceptions due to using unconverted beatmap

  `TestSceneBeatmapSkinFallbacks` was locally caching a `GameplayState`
  instance to fulfill dependencies of a
  `SkinnableTargetComponentsContainer`. However, it was doing so using
  `new TestBeatmap()`, which is a raw decoded beatmap that hasn't been
  converted to any ruleset yet, which was causing failures in
  `BeatmapDifficultyCache.GetTimedDifficultyAttributesAsync()` as that
  method is expecting to receive a post-conversion, ready-for-gameplay
  beatmap.
  
  Resolve by proxying forward dependency instances from the
  already-known-to-be-working `actualComponentsContainer`.

  Bartłomiej Dach · 2022-05-28 15:23:29 +02:00
  dcf3d76954
• Revert "Avoid throwing unobserved exception when PerformancePointsCounter requests timed attributes"

  This reverts commit 19b655d75b.

  Bartłomiej Dach · 2022-05-28 15:23:28 +02:00
  1641918c51
• Merge pull request #18457 from bdach/unobserved/not-implemented

  Fix unobserved exceptions in `TestSceneStatisticsPanel` due to unimplemented beatmap converter

  Dean Herbert · 2022-05-28 22:22:25 +09:00
  10d0238e39
• Fix unobserved exceptions due to unimplemented beatmap converter

  `TestSceneStatisticsPanel` intends to check the operation of statistics
  panels using dummy ruleset classes. However, `StatisticsPanel` relies on
  being able to retrieve the playable beatmap, which requires a converter.
  One was not provided by the dummy rulesets, therefore the retrieval
  would fail with an unobserved exception.
  
  To fix, add a barebones converter implementation that is enough for the
  test to pass.

  Bartłomiej Dach · 2022-05-28 14:10:57 +02:00
  e18fec3d89
• Merge pull request #18448 from frenzibyte/editor-metronome-rate

  Fix metronome speed not adjusted on different playback rates

  Dean Herbert · 2022-05-28 10:58:51 +09:00
  2022.528.0 62266c72ea
• Merge pull request #18445 from frenzibyte/editor-background-colour

  Darken background colour in "setup" and "verify" screens

  Dean Herbert · 2022-05-28 10:56:22 +09:00
  4f2910cdb1
• Merge pull request #18443 from frenzibyte/fix-beatmap-badge-colouring

  Fix beatmap badge colours not updated inline with recent changes

  Dean Herbert · 2022-05-28 10:55:07 +09:00
  3aa7e3141e
• Merge pull request #18446 from frenzibyte/editor-row-attribute-background

  Update row attribute background colour to fit screen

  Dean Herbert · 2022-05-28 10:53:50 +09:00
  68684f5fe7
• Merge pull request #18447 from frenzibyte/editor-verify-settings-width

  Fix editor verify settings looking cramped up due to small width

  Dean Herbert · 2022-05-28 10:51:52 +09:00
  6ed21973b0
• Increase usable width slightly further
  Dean Herbert · 2022-05-28 10:51:39 +09:00
  93a8092da6
• Add step for adjusting editor clock rate in test scene
  Salman Ahmed · 2022-05-28 04:10:39 +03:00
  2fac710d4b
• Fix metronome speed not adjusted on different playback rates
  Salman Ahmed · 2022-05-28 04:10:39 +03:00
  e12d188dad
• Increase editor verify settings width to give more breathing space
  Salman Ahmed · 2022-05-28 03:09:04 +03:00
  d12e4928e6
• Update row attribute background colour to fit screen
  Salman Ahmed · 2022-05-28 02:20:04 +03:00
  e71d907164
• Darken background colour in "setup" and "verify" screens
  Salman Ahmed · 2022-05-28 02:10:18 +03:00
  eec9248cde
• Fix beatmap badge colours not updated inline with recent changes
  Salman Ahmed · 2022-05-28 01:05:43 +03:00
  06832a4baf
• Code quality
  Jai Sharma · 2022-05-27 20:12:00 +01:00
  c5845f307a
• Update framework
  Dean Herbert · 2022-05-28 04:02:35 +09:00
  5eb16ff46c
• Merge pull request #18421 from peppy/reconnect-on-server-shutdown-exception

  Handle server shutdown messages in room creation and spectator initialisation

  Dean Herbert · 2022-05-28 03:52:24 +09:00
  ca9b2648a3
• Refactor ChannelList to use new ChannelGroup class for each type of channel
  Jai Sharma · 2022-05-27 19:46:53 +01:00
  e950c8c1d0
• Merge pull request #18437 from peppy/fa-playlist-category

  Add featured artist playlist category

  Dean Herbert · 2022-05-28 01:28:21 +09:00
  03d9ca0d8d
• Merge pull request #18438 from Susko3/use-normalised-precise-scrolling

  Adjust `ScrollDelta` usages to account for normalised `IsPrecise` values

  Dean Herbert · 2022-05-28 01:10:10 +09:00
  f708b98058
• Display Announce type channels separately in new chat overlay
  Jai Sharma · 2022-05-27 16:18:22 +01:00
  320b6ca631
• Merge branch 'master' into use-normalised-precise-scrolling
  Bartłomiej Dach · 2022-05-27 16:55:13 +02:00
  e511c1dfff
• Merge pull request #18441 from peppy/update-resources

  Update resources

  Bartłomiej Dach · 2022-05-27 16:52:50 +02:00
  aadcf25129
• Fix drawable room border colour not matching badge
  Bartłomiej Dach · 2022-05-27 16:40:15 +02:00
  a94432f3bd
• Update resources
  Dean Herbert · 2022-05-27 23:29:48 +09:00
  6960bec52d
• Update framework
  Dean Herbert · 2022-05-27 23:29:39 +09:00
  d9ecf69d20
• Merge pull request #18436 from peppy/fix-unsafe-mutation

  Fix potential crash from unsafe drawable mutation in scoreboard update code

  Dean Herbert · 2022-05-27 21:00:15 +09:00
  046867f5f4
• Fix unexpected assertion failure
  Dean Herbert · 2022-05-27 20:59:00 +09:00
  2f57849bcb
• Update colour of spotlights playlist to match new specs
  Dean Herbert · 2022-05-27 20:26:35 +09:00
  883c6f1eb3
• Add featured artist playlist category
  Dean Herbert · 2022-05-27 20:18:46 +09:00
  ef47b380c6
• Fix potential crash from unsafe drawable mutation in scoreboard update code
  Dean Herbert · 2022-05-27 20:03:30 +09:00
  d94315ee3f
• Merge pull request #18435 from peppy/silence-parse-failures

  Don't output beatmap parse failures in a visible manner

  Dan Balasescu · 2022-05-27 19:42:18 +09:00
  5657cb757d
• Don't output beatmap parse failures in a visible manner

  The user can't do much about this. When a user reports a beatmap issue,
  the logs will still contain this useful information. Should be fine I
  think.
  
  As mentioned in
  
  https://github.com/ppy/osu/discussions/18426
  https://github.com/ppy/osu/issues/750
  https://github.com/ppy/osu/issues/18372
  
  etc.

  Dean Herbert · 2022-05-27 19:18:38 +09:00
  e53c8518de
• Merge pull request #18433 from Joehuu/use-exisiting-chat-translations

  Use existing web localisation for chat strings

  Dean Herbert · 2022-05-27 14:50:54 +09:00
  ab444c213f
• Use existing web localisation for chat strings
  Joseph Madamba · 2022-05-26 22:23:03 -07:00
  105d581f24
• Merge pull request #18431 from Joehuu/fix-scores-container-visibility

  Fix beatmap info scores container not hiding when there's no leaderboard

  Dan Balasescu · 2022-05-27 14:17:42 +09:00
  198afb6aa7