Bartłomiej Dach
d6552f00be
Do not attempt to automatically reconnect if there is no login to use
...
Because it'll fail anyway - there is either no username or no password.
The reason why this is important is that the block was also setting API
state to `Connecting`.
2025-02-18 10:14:00 +01:00
Bartłomiej Dach
8299dfc6f2
Add local guard before scheduled placeholder user set
...
When API is in `RequiresSecondFactorAuth` state, `attemptConnect()` is
called over and over in a loop, with no sleeping, which means that the
scheduler accumulates hundreds of thousands of these delegates. Sure you
could add a sleep in there maybe, but it seems pretty wasteful to have
the `localUser.IsDefault` guard *inside* the schedule anyway, so this is
what I opted for.
2025-02-18 10:10:51 +01:00
Dan Balasescu
cef1d02f3d
Merge pull request #31923 from peppy/fix-editor-slider-selection
...
Fix selected sliders sometimes not being clickable in editor
2025-02-18 14:31:44 +09:00
Dean Herbert
f5bdbb91d6
Merge pull request #31232 from Plextora/sudden-death-feat
...
Add "Fail when missing on a slider end" option in Sudden Death mod
2025-02-18 14:25:46 +09:00
Dean Herbert
77e40140e5
Fix selected sliders sometimes not being clickable in editor
...
Closes https://github.com/ppy/osu/issues/31918 .
Regressed with
1648f2efa3
2025-02-18 13:41:30 +09:00
Dean Herbert
2d8e35be32
Add test coverage
2025-02-18 13:08:33 +09:00
Dean Herbert
20dbe096e0
Refactor slightly
2025-02-18 13:04:38 +09:00
Dan Balasescu
3b8b8ae87f
Merge pull request #31917 from bdach/nudge-fix
...
Fix nudge operations incurring FP error from coordinate space conversions
2025-02-18 12:19:14 +09:00
Bartłomiej Dach
f37a56c307
Fix nudge operations incurring FP error from coordinate space conversions
...
Closes https://github.com/ppy/osu/issues/31915 .
Reproduction of aforementioned issue requires 1280x720 resolution, which
should also be a good way to confirm that this does anything.
To me this is also equal-parts-bugfix, equal-parts-code-quality PR,
because tell me: what on earth was this code ever doing at
`ComposeBlueprintContainer` level? Nudging by one playfield-space-unit
doesn't even *make sense* in something like taiko or mania.
2025-02-17 15:21:07 +01:00
Dean Herbert
5304ea2446
Fix minor typo
2025-02-17 22:42:03 +09:00
Dean Herbert
42fb544218
Merge pull request #31912 from bdach/more-snap-grid
...
Fix some more visual issues with osu! distance snap grid
2025-02-17 21:11:17 +09:00
Bartłomiej Dach
2b4b21beb6
Fix distance snap grid line opacity being incorrect on non-1.0x velocities
...
Noticed in passing.
2025-02-17 10:11:47 +01:00
Bartłomiej Dach
8423d9de9b
Fix distance snap grid colours being off-by-one in certain cases
...
Closes https://github.com/ppy/osu/issues/31909 .
Previously: https://github.com/ppy/osu/pull/30062 .
Happening because of rounding errors - in this case the beat index
pre-flooring was something like a 0.003 off of a full beat, which would
get floored down rather than rounded up which created the discrepancy.
But also we don't want to round *too* far, which is why this
frankenstein solution has to exist I think. This is probably all
exacerbated by stable not handling decimal control point start times.
Would add tests if not for the fact that this is like extremely annoying
to test.
2025-02-17 10:11:23 +01:00
Dean Herbert
eaf3679621
Update resources
2025-02-17 17:17:07 +09:00
Bartłomiej Dach
6448c676fb
Merge pull request #31910 from peppy/beat-divisor-focus
...
Stop beat divisor "slider" from accepting focus
2025-02-17 08:48:25 +01:00
Bartłomiej Dach
282039f0a8
Merge pull request #31911 from peppy/update-framework
...
Update framework (and minor package bumps)
2025-02-17 08:36:43 +01:00
Dean Herbert
db4a4a1723
Minor bump some packages
2025-02-17 15:23:26 +09:00
Dean Herbert
2738221c0b
Update framework
2025-02-17 15:07:21 +09:00
Dean Herbert
d5566831d2
Stop beat divisor "slider" from accepting focus
2025-02-17 15:06:35 +09:00
Salman Alshamrani
20d89f3c87
Merge pull request #31904 from Joehuu/fix-profile-team-flag-layout
...
Fix team flag layout on user profile
2025-02-16 20:23:03 -05:00
Plextora
cb012123ab
Merge branch 'master' into sudden-death-feat
2025-02-16 19:43:55 -05:00
Salman Alshamrani
afc2c52195
Add proper spacing between username, title, and country/team row
2025-02-16 17:55:13 -05:00
Salman Alshamrani
1b333ad51c
Add sample team to user profile test scene
2025-02-16 17:53:34 -05:00
Joseph Madamba
7eb32ef351
Fix team flag layout on user profile
2025-02-16 13:45:13 -08:00
Dean Herbert
605979e790
Merge pull request #31885 from peppy/clock-align
2025-02-16 13:58:56 +09:00
Dean Herbert
b21dd01de7
Use fixed width for digital clock display
...
Supersedes and closes https://github.com/ppy/osu/pull/31093 .
2025-02-15 00:03:41 +09:00
Dean Herbert
4c851a327e
Merge pull request #31880 from peppy/team-logo-support
...
Add basic display support for team logos
2025-02-14 22:59:57 +09:00
Dean Herbert
ff81096e1b
Merge pull request #31371 from frenzibyte/ios-ui-scale
...
Improve default UI scale on iOS
2025-02-14 22:57:36 +09:00
Bartłomiej Dach
ef2f482d04
Fix skin deserialisation test
2025-02-14 12:40:54 +01:00
Salman Alshamrani
27b9a6b7a3
Reset UI scale for mobile platforms
2025-02-14 06:25:53 -05:00
Salman Alshamrani
55809f5e0d
Apply changes to Android
2025-02-14 06:15:32 -05:00
Dean Herbert
1b5101ed5e
Add team flag display to rankings overlays
2025-02-14 19:30:23 +09:00
Dean Herbert
b86eeabef0
Fix one more misalignment on leaderboard scores
2025-02-14 19:16:03 +09:00
Dean Herbert
82c16dee60
Add missing LongRunningLoad attribute
2025-02-14 19:16:02 +09:00
Dean Herbert
26a2d0394e
Invalidate drawable on potential presence change
2025-02-14 19:04:26 +09:00
Dean Herbert
248bf43ec9
Apply nullability to ScalingContainer
2025-02-14 18:35:43 +09:00
Dean Herbert
4e043e7cab
Change how values are applied to (hopefully) simplify things
2025-02-14 18:35:27 +09:00
Dean Herbert
74eae3cda3
Merge branch 'master' into ios-ui-scale
2025-02-14 18:22:47 +09:00
Dean Herbert
071a4ba9b0
Merge pull request #31821 from Layendan/playlist-collection
...
Add playlist to new collection button present on playlist room
2025-02-14 18:03:54 +09:00
Dean Herbert
22d6135cd5
Merge pull request #31596 from Rudicito/fix-settings-toolbox-hiding-when-dragging-a-slider
...
Fix toolbox settings hiding when dragging a slider
2025-02-14 17:58:33 +09:00
Dean Herbert
4184dd2718
Give more breathing room in leaderboard scores
2025-02-14 17:39:22 +09:00
Dean Herbert
44faabddcd
Add skinnable team flag
2025-02-14 17:39:21 +09:00
Dean Herbert
303961d101
Add drawable implementations of team logo
2025-02-14 17:39:21 +09:00
Dean Herbert
88188e8fcb
Add API models for teams
2025-02-14 17:39:20 +09:00
Dan Balasescu
35b8a3d3c9
Merge pull request #31876 from peppy/dont-focus-range-slider
...
Disallow focus on difficulty range slider
2025-02-14 16:10:53 +09:00
Dean Herbert
9456e376f3
Fix expanded state not updating on drag end
2025-02-14 15:15:05 +09:00
Rudi Herouard
3f3cb3df2a
Fix toolbox settings hiding when dragging a slider
2025-02-14 15:08:02 +09:00
Dean Herbert
8ce28d56bb
Fix tests not waiting enough
2025-02-14 14:58:04 +09:00
Dean Herbert
f9b7a8ed10
Make realm operation asynchronous for good measure
2025-02-14 14:51:48 +09:00
Dean Herbert
8561df40c5
Add better messaging and handling of edge cases
2025-02-14 14:30:33 +09:00
