1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-16 22:32:55 +08:00
Commit Graph

12 Commits

Author SHA1 Message Date
Bartłomiej Dach
9f834ca1a2
Silence beatmap retrieval failures from results screen favourite button
As reported (very poorly) in
https://github.com/ppy/osu/pull/28991#issuecomment-2331854970.

I believe this is a total edge case and is mostly visible on dev due to
some beatmaps existing on `osu.ppy.sh` and not on `dev.ppy.sh`, but I
tend to agree in general that these types of failures should not be
firing very loud error notifications; logging to network and disabling
the button with a tooltip adjustment should be enough.
2024-09-06 10:29:23 +02:00
Bartłomiej Dach
28d0a24555
Fix the fix
The more proper way to do this would be to address the underlying issue,
which is https://github.com/ppy/osu/issues/29546, but let's do this
locally for now.
2024-08-21 12:27:56 +02:00
Layendan
59ba48bc81 Fix crash if favourite button api request fails 2024-08-19 07:58:20 -07:00
Joseph Madamba
b4ca07300a Use same size button for everything 2024-07-27 18:43:54 -07:00
Joseph Madamba
b5ff2dab43 Move some properties/bindables around 2024-07-27 18:42:49 -07:00
Joseph Madamba
aed2b3c7c6 Inherit GrayButton instead
Also fixes hover highlight.
2024-07-27 18:42:49 -07:00
Layendan
6a4872faa8 Remove nullable disable 2024-07-21 23:56:47 -07:00
Layendan
e4cccb5e31
Fix lint errors 2024-07-22 12:22:52 +09:00
Layendan
a575566638
Add tests 2024-07-22 12:22:51 +09:00
Layendan
c16b7c5c70
Update favorite button 2024-07-22 12:22:51 +09:00
Layendan
3296beb003
Added collection button to result screen 2024-07-22 12:22:50 +09:00
Layendan
0bc14ba646 Add favourite button to results screen 2024-07-17 12:45:20 -07:00