53914 Commits

This Branch

This Branch

All Branches

• Add basic tests for KPS

  Created private mock classes to use them in place of `GameplayClock` and
  `DrawableRuleset`.

  Ryuki · 2022-08-11 00:51:13 +02:00
  d58d5eebe2
• Make KPS counter strictly depending only on KPS calculator

  `KeysPerSecondCounter` now depends on `KeysPerSecondCalculator` via the
  `BackgroundDependencyLoaderAttribute` method, making it appear only in a
  gameplay context without requiring `GameplayClock` without using it.

  Ryuki · 2022-08-11 00:46:39 +02:00
  0a94fb4039
• Add more readiness checks in KeysPerSecondCalculator
  Ryuki · 2022-08-11 00:43:15 +02:00
  46e372cb99
• Re-adjust timespan conditions in KeysPerSecondCalculator
  Ryuki · 2022-08-11 00:42:22 +02:00
  9e80d3f71c
• Temporarily emptying TestSceneKeysPerSecondCounter until a good test can be found
  Ryuki · 2022-08-09 02:43:41 +02:00
  edb8e5e33e
• Use DI to provide dependencies for KPS Calculator and improve input

  gathering
  
  KPS Calculator now uses DI to retrieve the clocks. Using `HUDOverlay` it
  is now cached for `KeysPerSecondCounter`s to resolve it. This also
  allows to make an "Attach" flow like `KeyCounter`.

  Ryuki · 2022-08-08 21:54:06 +02:00
  b52a07c16a
• Refactor KPS

  - Remove '#nullable disable' in KeysPerSecondCalculator and
    KeysPerSecondCounter
  - Remove KeysPerSecondCalculator IDisposable implementation
  - Make KeysPerSecondCalculator static instance initialized once by
    KeysPerSecondCounters
  - Auto transfer dependencies from KeysPerSecondCounter to
    KeysPerSecondCalculator using Resolved properties
  - Add internal reset logic to KeysPerSecondCalculator and make it
    independent from Player
  - Use GameplayClock.TrueGameplayRate to get real-time rate. If 0 then it
    defaults to the last non 0 rate if no such mod is enabled

  Ryuki · 2022-08-07 00:53:00 +02:00
  b2557a8d2d
• Prevent KeysPerSecondCounter from NRE when no instance is initialized
  Ryuki · 2022-08-05 21:03:00 +02:00
  0886137e39
• Remove DT from KPS test
  Ryuki · 2022-08-05 21:02:37 +02:00
  0c07df2c26
• Rewrite tests for KPS
  Ryuki · 2022-08-05 15:53:06 +02:00
  b4e0fa7c53
• Do not add KPS calculation when gameplay rate is 0
  Ryuki · 2022-08-05 15:51:07 +02:00
  24c29b7e2f
• Move KPS calculation to a standalone class
  Ryuki · 2022-08-05 04:17:01 +02:00
  42d1bdfc95
• Change KPS Counter implementation base and add better replay integration

  The counter implementaiton is now list based, and will not invalidate
  previous hits by removing them but by testing if they are within the 1
  second span, allowing better integration with replays and spectators.

  Ryuki · 2022-07-31 01:29:57 +02:00
  89855cc1d6
• Merge branch 'master' into kps
  Ryuki · 2022-07-28 18:38:09 +02:00
  2df24019fd
• Add some tests
  Ryuki · 2022-07-28 18:37:50 +02:00
  079150849a
• Add basic Queue based implementation of KPS
  Ryuki · 2022-07-28 18:37:12 +02:00
  b2e7da5aa0
• Merge pull request #19443 from smoogipoo/fix-intermittent-hud-tests

  Fix intermittent HUD tests

  Dean Herbert · 2022-07-28 23:20:46 +09:00
  45879f7836
• Merge pull request #19431 from peppy/collections-track-beatmap-updates

  Add collection transfer logic to beatmap import-as-update flow

  Dan Balasescu · 2022-07-28 22:52:54 +09:00
  0d6b45e515
• Merge branch 'master' into collections-track-beatmap-updates
  Dan Balasescu · 2022-07-28 22:05:34 +09:00
  a59d7f6710
• Merge pull request #19441 from peppy/test-working-beatmap-unfuck

  Reduce calls to `LoadTrack` by implicitly running on test/dummy classes

  Dan Balasescu · 2022-07-28 22:05:25 +09:00
  aa03df905f
• Merge pull request #19430 from peppy/realm-collections

  Move beatmap collections to realm

  Dan Balasescu · 2022-07-28 22:05:10 +09:00
  5003eb5629
• Merge branch 'master' into realm-collections
  Dan Balasescu · 2022-07-28 21:00:08 +09:00
  11e0022fad
• Reduce calls to LoadTrack by implicitly running on test/dummy classes
  Dean Herbert · 2022-07-28 18:11:40 +09:00
  a21aee4e9c
• Fix intermittent HUD tests
  Dan Balasescu · 2022-07-28 17:58:07 +09:00
  1039338d80
• Remove incorrect TrackLoaded override from TestWorkingBeatmap
  Dean Herbert · 2022-07-28 17:49:17 +09:00
  628a30193f
• Merge pull request #19435 from peppy/remove-beatmap-manager-ruleset-store

  Remove unused `RulesetStore` from `BeatmapManager` constructor

  Dan Balasescu · 2022-07-28 17:46:12 +09:00
  1da9830145
• Adjust comment
  Dan Balasescu · 2022-07-28 16:56:11 +09:00
  6d4023b933
• Merge pull request #19433 from peppy/beatmap-model-documentation

  Add more comprehensive xmldoc for beatmap model classes

  Dan Balasescu · 2022-07-28 16:40:29 +09:00
  ebe64422d6
• Fix assertion
  Dan Balasescu · 2022-07-28 16:34:31 +09:00
  cd01c5d3ac
• Merge pull request #19432 from peppy/fix-update-test-failures

  Add realm refresh calls to fix intermittent test failures on new update tests

  Dan Balasescu · 2022-07-28 16:19:46 +09:00
  fe6b487d75
• Remove unused RulesetStore from BeatmapManager constructor
  Dean Herbert · 2022-07-28 16:19:05 +09:00
  2b9d46d803
• Link to correct model in xmldoc
  Dan Balasescu · 2022-07-28 16:02:19 +09:00
  c1aaf27c54
• Fix crash in DrawableRoomPlaylistItem context menu creation due to incorrect enumeration casting
  Dean Herbert · 2022-07-28 15:51:18 +09:00
  525e4a2019
• Fix managed object reused between test runs
  Dan Balasescu · 2022-07-28 15:45:33 +09:00
  6bf293e130
• Add more comprehensive xmldoc for beatmap model classes
  Dean Herbert · 2022-07-28 15:41:28 +09:00
  452d82f292
• Merge pull request #19419 from andy840119/remove-nullable-disable-in-the-mods-for-taiko-ruleset

  Remove nullable disable annotation in mods for taiko ruleset.

  Salman Ahmed · 2022-07-28 09:32:35 +03:00
  ce48984bda
• Update test to account for sort order
  Dean Herbert · 2022-07-28 15:20:25 +09:00
  8ac886a247
• Add realm Refresh calls to ensure tests are stable
  Dean Herbert · 2022-07-28 15:18:04 +09:00
  67c44552cb
• Add realm refresh calls to fix intermittent test failures on new update tests
  Dean Herbert · 2022-07-28 15:15:41 +09:00
  485d140a21
• Add collection transfer logic to beatmap import-as-update flow
  Dean Herbert · 2022-07-28 15:03:23 +09:00
  070f56c30c
• Mark Live methods as InstantHandleAttribute
  Dean Herbert · 2022-07-28 15:03:08 +09:00
  2209afd0e8
• Add test coverage of beatmap updates transferring collection hashes
  Dean Herbert · 2022-07-28 15:02:58 +09:00
  2ae5a34c0e
• Merge branch 'master' into remove-nullable-disable-in-the-mods-for-taiko-ruleset
  Salman Ahmed · 2022-07-28 09:01:50 +03:00
  1f13d89205
• Merge pull request #19418 from andy840119/remove-nullable-disable-in-the-mods-for-mania-ruleset

  Remove nullable disable annotation in mods for mania ruleset.

  Salman Ahmed · 2022-07-28 08:57:12 +03:00
  61bdcab651
• Make NotificationOverlay dependency optional in CollectionSettings
  Dean Herbert · 2022-07-28 14:35:27 +09:00
  ca68574473
• Merge branch 'master' into remove-nullable-disable-in-the-mods-for-mania-ruleset
  Salman Ahmed · 2022-07-28 08:21:23 +03:00
  c74ffea236
• Force alphabetical ordering for now
  Dean Herbert · 2022-07-28 14:07:42 +09:00
  392cb352cc
• Add missing realm subscription cleanup
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  da06467891
• Tidy up naming of collection dropdowns
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  ad482b8afc
• Add note about hash storage
  Dean Herbert · 2022-07-28 13:57:21 +09:00
  226eefcc5c