Dean Herbert
d1b5d31ea6
Add explicit parameter in
2024-11-14 22:23:42 +09:00
Dean Herbert
3262b6d989
Refactor to avoid dual-boolean mess
2024-11-14 22:10:45 +09:00
Dean Herbert
afeb138ea0
Fix occasional flash when quick exiting / retrying from player
...
The gist of the issue is that `fadeOut` was being called *twice* in the
quick exit/retry scenarios, causing weirdness with transforms.
I've restructured things to ensure it's only called once.
2024-11-14 21:54:34 +09:00
Bartłomiej Dach
7ee9802923
Merge pull request #30616 from peppy/collection-management-revamp
...
Fix collection management dialog refreshing full display when any change occurs
2024-11-14 13:21:09 +01:00
Bartłomiej Dach
d08c8ae482
Merge pull request #30620 from peppy/fix-offset-adjust-crash
...
Fix crash when resetting offset after a play with no hit events
2024-11-14 12:43:47 +01:00
Bartłomiej Dach
1355fa636d
Merge pull request #30603 from peppy/quick-restart-faster-better
...
Make quick restart even faster
2024-11-14 12:30:13 +01:00
Bartłomiej Dach
f9489690cb
Fix code inspection
2024-11-14 11:58:57 +01:00
Dean Herbert
36d48a01c8
Add missing expire call
...
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>
2024-11-14 19:33:34 +09:00
Dean Herbert
9849a88eef
Adjust transition further to avoid brief "jumpscare" display of metadata
2024-11-14 18:28:27 +09:00
Bartłomiej Dach
88aea70429
Do not permit new combo toggle to remain in indeterminate state on deselect
2024-11-14 10:07:09 +01:00
Bartłomiej Dach
1b279e45cc
Merge branch 'master' into feat/optimize-polygon-tool
2024-11-14 09:54:04 +01:00
Dean Herbert
23167b0221
Merge pull request #30618 from Natelytle/ltca-broke-pp
...
Fix NaN PP counter values while SR is 0
2024-11-14 17:42:05 +09:00
Dean Herbert
4957a517aa
Update framework
2024-11-14 16:38:26 +09:00
Bartłomiej Dach
02e4907fb6
Merge pull request #29896 from OliBomby/hs-toggle2
...
Collapse sample point indicators into dots if they cannot be displayed in full
2024-11-14 08:28:11 +01:00
Dean Herbert
7f8eebc510
Merge pull request #30578 from smoogipoo/beatmap-legacy-object-type
...
Simplify convertible hitobject parsing and add `IHasLegacyHitObjectType`
2024-11-14 16:16:44 +09:00
Dean Herbert
88d220f4c5
Fix crash when resetting offset after a play with no hit events
...
Closes https://github.com/ppy/osu/issues/30573 .
2024-11-14 16:03:15 +09:00
Nathen
d0e793a3b3
More correct but not too important
2024-11-14 01:50:05 -05:00
Nathen
2ea2e5f1db
Be doubly careful
2024-11-14 01:47:24 -05:00
Nathen
ce818f59e7
Fix NaN PP values when SR is 0
2024-11-14 01:42:07 -05:00
Dean Herbert
fea6a54432
Fix more tests reading in wrong order
2024-11-14 14:46:58 +09:00
Dean Herbert
17b1888c59
Avoid using newTexst as it doesn't work well with tests
2024-11-14 14:39:05 +09:00
Dean Herbert
ebe9a9f083
Avoid writing changes to realm when collection name wasn't actually changed
2024-11-14 14:39:05 +09:00
Dean Herbert
695f156f5f
Change collection management dialog to handle changes more correctly
2024-11-14 14:39:05 +09:00
Dean Herbert
d37c1bb6d0
Remove redundant null initialisation and apply nullability
2024-11-14 13:37:58 +09:00
Dean Herbert
7670a81181
Merge branch 'master' into bat-max-performance
2024-11-14 13:35:29 +09:00
Dan Balasescu
85d292ae57
Merge pull request #30602 from peppy/increase-idle-time
...
Increase idle time before gameplay loads when hovering controls
2024-11-13 21:21:23 +09:00
Dean Herbert
68945daa40
Add confirmation when pressing 'q' to quit at the main menu
...
Kinda a weird key. I feel like this deserves a confirmation step unlike
mouse clicking the exit button.
Addresses https://github.com/ppy/osu/discussions/30471 .
2024-11-13 19:27:20 +09:00
Dean Herbert
b82f420b52
Merge pull request #30433 from stanriders/fix-userpanel-overflow
...
Fix `UserRankPanel` rank overflowing on 6+ digits
2024-11-13 19:19:30 +09:00
Dean Herbert
54ca705680
Merge branch 'master' into hs-toggle2
2024-11-13 19:15:00 +09:00
Dean Herbert
2dbc275bb8
Make quick restart even faster
2024-11-13 18:11:25 +09:00
Dan Balasescu
60d45d44bb
Merge pull request #30536 from stanriders/add-diffcalc-helpers
...
Add `DifficultyCalculationUtils`
2024-11-13 17:49:40 +09:00
Dean Herbert
2ae8c36d17
Increase idle time before gameplay loads when hovering controls
2024-11-13 17:39:21 +09:00
Dean Herbert
78084e33af
Merge pull request #30411 from frenzibyte/editor-slider-touch-support-2
...
Fix placing objects via touch in editor not working sometimes
2024-11-13 15:09:57 +09:00
Dean Herbert
19f887e283
Merge branch 'master' into feat/optimize-polygon-tool
2024-11-13 13:59:54 +09:00
Bartłomiej Dach
c25215d2cf
Merge pull request #30579 from peppy/fix-rank-display-song-select
...
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-12 12:26:26 +01:00
Dan Balasescu
678d14aa60
Merge pull request #30534 from Lawtrohux/difficult-strain
...
Globalise `CountDifficultStrains` within StrainSkill
2024-11-12 14:50:18 +09:00
Dean Herbert
8c5785fdf6
Make math more logical
2024-11-11 22:57:26 +09:00
Dean Herbert
ee4d58544d
Update framework (and other common packages)
2024-11-11 21:58:13 +09:00
Bartłomiej Dach
b430ac2214
Merge branch 'master' into song-select-less-semi-opaque
2024-11-11 11:04:48 +01:00
Bartłomiej Dach
d29dd2c223
Remove unused using directives
2024-11-11 11:04:43 +01:00
Bartłomiej Dach
c37e4877e2
Move setting back to timing panel
2024-11-11 10:08:26 +01:00
Dean Herbert
f84ee3996f
Reduce semi-opaque layers at song select
...
I made these changes while working on
https://github.com/ppy/osu/pull/30579 . Basically, it's hard to fix the
ranks not loading while underneath the footer, and the transparency both
looks bad, and is going away in the redesign.
I've chosen values here that are moving *in the direction* of the new
design without overhauling everything.
- I know that there's still some transparency. I did this because it
helps keep all current elements / colours contrasting without too much
effort.
- I completely removed the transparency adjustments on the beatmap
panels. This always looked bad due to being applied per-layer, and I
don't think it added much.
2024-11-11 17:57:23 +09:00
Bartłomiej Dach
0cddb93dda
Move setting to user config
2024-11-11 09:57:17 +01:00
Bartłomiej Dach
a6cdf6df07
Merge branch 'master' into move-already-placed-objects-when-adjusting-offset-bpm
2024-11-11 09:50:00 +01:00
Dean Herbert
e8b69581b7
Fix top rank display not showing up on beatmaps with many difficulties
2024-11-11 17:49:34 +09:00
Dean Herbert
f8ac54d61c
Fix weird local variable typo
2024-11-11 16:59:02 +09:00
Dan Balasescu
8c68db0a36
Remove unused params
2024-11-11 16:10:15 +09:00
Dan Balasescu
7206e97b7b
Add IHasLegacyHitObjectType to ConvertHitObject
2024-11-11 16:10:15 +09:00
Dan Balasescu
e1d93a7d9c
Merge implementations of ConvertHitObjectParser
...
Having these be separate implementations sounded awesome at the time,
but it only ever led to confusion. There's no practical difference if,
for example, catch sees hitobjects with `IHasPosition` instead of
`IHasXPosition`.
2024-11-11 15:09:13 +09:00
Dean Herbert
322df72cce
Merge pull request #30425 from bdach/multiplayer-song-select-wyd
...
Fix multiplayer song select not correctly applying filter sometimes
2024-11-11 14:54:48 +09:00
