35594 Commits

This Branch

This Branch

All Branches

• Change asserts into until steps
  Dean Herbert · 2020-12-24 22:28:25 +09:00
  d0e8347968
• Re-sort the leaderboard order a maximum of once a second
  Dean Herbert · 2020-12-24 21:49:38 +09:00
  f991448a3e
• Merge pull request #11282 from peppy/disallow-skipping

  Disallow skipping in multiplayer

  Dean Herbert · 2020-12-24 21:31:02 +09:00
  2020.1224.0 21a4e6a3f9
• Merge pull request #11281 from peppy/fix-ruleset-pollution

  Schedule UpdateFilter calls to avoid operations occuring while at a sub screen

  Dean Herbert · 2020-12-24 21:30:47 +09:00
  647cb8310a
• Merge pull request #11283 from peppy/add-match-start-sound

  Play a sound when starting a timeshift or multiplayer room

  Dean Herbert · 2020-12-24 21:30:24 +09:00
  9b654c741b
• Merge pull request #11284 from peppy/add-ready-changed-sound

  Add sound when players change ready state

  Dean Herbert · 2020-12-24 21:30:06 +09:00
  25ff32cdf8
• Merge branch 'master' into add-match-start-sound
  Bartłomiej Dach · 2020-12-24 13:22:06 +01:00
  49103a4421
• Invert if & early-return to reduce nesting
  Bartłomiej Dach · 2020-12-24 12:45:01 +01:00
  40b9d1bc5e
• Merge branch 'master' into disallow-skipping
  Bartłomiej Dach · 2020-12-24 12:35:22 +01:00
  d5fc517fab
• Merge pull request #11279 from peppy/improved-loading-experience
  Bartłomiej Dach · 2020-12-24 12:35:02 +01:00
  c00d6f78be
• Merge branch 'master' into improved-loading-experience
  Bartłomiej Dach · 2020-12-24 11:59:46 +01:00
  ee5a6ff9fa
• Merge pull request #11278 from peppy/frame-bundle-accuracy
  Bartłomiej Dach · 2020-12-24 11:53:37 +01:00
  dd97fcb43c
• Update outdated comment
  Bartłomiej Dach · 2020-12-24 11:33:49 +01:00
  261c250b46
• Merge branch 'master' into frame-bundle-accuracy
  Bartłomiej Dach · 2020-12-24 11:20:06 +01:00
  4fb2610c82
• Merge pull request #11267 from peppy/disallow-multiplayer-restart-retry
  Bartłomiej Dach · 2020-12-24 10:18:46 +01:00
  4cc58903ed
• Merge branch 'master' into disallow-multiplayer-restart-retry
  Bartłomiej Dach · 2020-12-24 09:45:50 +01:00
  6750f1574f
• Add sound when players change ready state
  Dean Herbert · 2020-12-24 17:17:45 +09:00
  c35454081c
• Play a sound when starting a timeshift or multiplayer room
  Dean Herbert · 2020-12-24 16:53:25 +09:00
  3148c04fb8
• Disallow skipping in multiplayer for now
  Dean Herbert · 2020-12-24 16:29:51 +09:00
  6bd6888a93
• Schedule UpdateFilter calls to avoid operations occuring while at a sub screen
  Dean Herbert · 2020-12-24 16:20:38 +09:00
  5457e4598b
• Don't begin gameplay until all users are in a completely prepared state
  Dean Herbert · 2020-12-24 15:32:55 +09:00
  e86e9bfae6
• Source display accuracy from header and remove from ScoreProcessor function
  Dean Herbert · 2020-12-24 14:57:23 +09:00
  d66e218318
• Add accuracy to frame bundle header
  Dean Herbert · 2020-12-24 14:46:52 +09:00
  1f80f01b53
• Merge pull request #11273 from bdach/duplicate-user-in-mp-room

  Improve reliability of handling user joined messages

  Dean Herbert · 2020-12-24 14:31:44 +09:00
  43370d7021
• Remove double handling of restart allowance on results screen (already handled locally)
  Dean Herbert · 2020-12-24 13:32:35 +09:00
  61a5d3ef4a
• Merge branch 'master' into disallow-multiplayer-restart-retry
  Dean Herbert · 2020-12-24 13:31:54 +09:00
  76935b93b6
• Merge pull request #11270 from bdach/better-error-handling

  Improve error handling at realtime room settings screen

  Dean Herbert · 2020-12-24 13:23:49 +09:00
  b29a5e2073
• Merge pull request #11275 from peppy/safer-user-ids

  Send multiplayer user IDs via ctor for better thread safety

  Dean Herbert · 2020-12-24 12:20:48 +09:00
  15cef44351
• Merge pull request #11268 from bdach/fix-room-song-select-stuck

  Fix realtime multiplayer song select getting stuck after selecting invalid beatmap

  Dean Herbert · 2020-12-24 11:26:07 +09:00
  1ac93d4eeb
• Merge pull request #11274 from bdach/create-match-button

  Split create game buttons for timeshift and realtime multiplayer

  Dean Herbert · 2020-12-24 11:07:36 +09:00
  547c71bdaf
• Send multiplayer user IDs via ctor for better thread safety
  Dean Herbert · 2020-12-24 10:39:15 +09:00
  d6dadd12fa
• Split timeshift & multiplayer "create" buttons

  Multiplayer button gets new, different "Create match" text, and disable
  logic in case of a dropped connection to the multiplayer server.

  Bartłomiej Dach · 2020-12-23 22:03:57 +01:00
  414f886b02
• Move out sizing logic to multiplayer screen
  Bartłomiej Dach · 2020-12-23 22:03:30 +01:00
  c13acb609a
• Move out create room button to separate class
  Bartłomiej Dach · 2020-12-23 22:03:30 +01:00
  05d9f23762
• Sanity check received user joined messages

  While test failures fixed in 9843da5 were a shortcoming of the test,
  they exposed a potential vulnerable point of the multiplayer client
  logic. In case of unreliable message delivery it is not unreasonable
  that duplicate messages might arrive, in which case the same scenario
  that failed in the tests could crash the game.
  
  To ensure that is not the case, explicitly screen each new joined user
  against the room user list, to ensure that duplicates do not show up.
  `UserLeft` is already tolerant in that respect (if a user is requested
  to be removed twice by the server, the second removal just won't do
  anything).

  Bartłomiej Dach · 2020-12-23 21:00:49 +01:00
  a71496bc4e
• Add failing test cases
  Bartłomiej Dach · 2020-12-23 21:00:47 +01:00
  47020c8887
• Fix intermittent test fail due to duplicate user

  `TestSceneRealtimeReadyButton` was manually adding `API.LocalUser`,
  which wasn't actually needed. The base `RealtimeMultiplayerTestScene` by
  default creates a new room as `API.LocalUser`, therefore automatically
  adding that user to the room - and as such there is no need to add them
  manually unless the `joinRoom` ctor param is specified as `false`.

  Bartłomiej Dach · 2020-12-23 20:29:17 +01:00
  9843da59f4
• Merge branch 'master' into better-error-handling
  Bartłomiej Dach · 2020-12-23 18:13:50 +01:00
  152df2ad84
• Merge branch 'master' into fix-room-song-select-stuck
  Bartłomiej Dach · 2020-12-23 18:13:27 +01:00
  e7a91b3dca
• Merge pull request #11266 from peppy/fix-hard-crash-on-signal-r-exceptions
  Bartłomiej Dach · 2020-12-23 18:12:43 +01:00
  3087aba5bc
• Merge branch 'master' into fix-hard-crash-on-signal-r-exceptions
  Bartłomiej Dach · 2020-12-23 17:37:49 +01:00
  b1fb906773
• Merge pull request #11265 from peppy/fix-multiplayer-server-disconnection-flow
  Bartłomiej Dach · 2020-12-23 17:35:53 +01:00
  2549039362
• Improve user-facing error messages in room settings
  Bartłomiej Dach · 2020-12-23 17:10:53 +01:00
  e4959489b7
• Fix JoinRoom failing to return canceled token

  As it turns out, `Task.FromCanceled` expects to receive an already
  cancelled `CancellationToken`, which `CancellationToken.None` is not.

  Bartłomiej Dach · 2020-12-23 17:01:01 +01:00
  3b0bf11366
• Merge branch 'master' into fix-multiplayer-server-disconnection-flow
  Bartłomiej Dach · 2020-12-23 16:55:22 +01:00
  6c421b873d
• Refactor player exit logic to convey intention better
  Bartłomiej Dach · 2020-12-23 16:16:24 +01:00
  980e85ce25
• Tidy up event flow of change settings call
  Dean Herbert · 2020-12-23 22:39:14 +09:00
  4296f61d6c
• Merge pull request #11254 from frenzibyte/fix-multi-songselect-looping

  Fix beatmap track not looping on multiplayer song selects

  Dean Herbert · 2020-12-23 22:35:11 +09:00
  60be1bedc9
• Re-enable carousel selection after error
  Bartłomiej Dach · 2020-12-23 14:19:30 +01:00
  c5692a5d6a
• Revert logic to be closer to original

  Note the reversal of the order of operations in `endHandlingTrack()`
  (done for extra safety, to ensure no more value changed events can be
  fired at the point of cancelling looping).

  Bartłomiej Dach · 2020-12-23 13:47:28 +01:00
  582b0d2a74