478 Commits

• Fix incorrect editor screen padding
  Dean Herbert · 2024-07-16 18:20:33 +09:00
  4ad7d900c1
• Merge pull request #28788 from bdach/timeline-redesign

  Redesign editor timelines to address most frequent user complaints

  Bartłomiej Dach · 2024-07-12 10:58:59 +02:00
  518dc17518
• Merge pull request #28821 from peppy/fix-editor-dim

  Fix editor UI transparency being incorrectly opaque when hovering slider control points

  Bartłomiej Dach · 2024-07-11 12:05:10 +02:00
  ccc4d288b2
• Merge branch 'master' into timeline-redesign
  Dean Herbert · 2024-07-11 18:38:17 +09:00
  95464ebf36
• Fix editor UI remaining transparent when switching away from compose tab

  Could still happen if using the keyboard F-key shortcuts. In that case
  the composer becomes non-present, so its `Update()` can't really do
  anything.

  Bartłomiej Dach · 2024-07-11 11:23:09 +02:00
  6801ccbbc5
• Fix editor UI transparency being incorrectly opaque when hovering slider control points

  As mentioned at
  https://github.com/ppy/osu/pull/28787#issuecomment-2221150025.

  Dean Herbert · 2024-07-11 16:41:21 +09:00
  fe421edd8f
• Move full export async flow inside screen and add error handling
  Dean Herbert · 2024-07-11 14:27:12 +09:00
  bdbdc3592e
• Add confirmation before saving for external edit
  Dean Herbert · 2024-07-11 12:20:33 +09:00
  599a765fd1
• Simplify save dialogs
  Dean Herbert · 2024-07-11 12:15:17 +09:00
  cd6b0e875a
• Abort operation on save failure
  Dean Herbert · 2024-07-11 11:42:06 +09:00
  b0d6c8ca6d
• Add sub screen to limit user interactions
  Dean Herbert · 2024-07-10 18:34:45 +09:00
  118162c631
• Add basic flow for mounting beatmaps for external editing
  Dean Herbert · 2024-07-10 18:29:51 +09:00
  d3c66e2404
• Add failing test case showing editor save then delete failure
  Dean Herbert · 2024-07-09 20:41:22 +09:00
  0e2e44a2f5
• Slim down bottom timeline

  This removes the BPM display, which is commonly cited to have
  no functional purpose by users, and reduces the height of the bottom bar
  in exchange for more space for the playfield.

  Bartłomiej Dach · 2024-07-09 09:25:22 +02:00
  29b8948609
• Fix composer disappearing when undoing change to control points

  As mentioned in https://github.com/ppy/osu/issues/28752.
  Regressed in https://github.com/ppy/osu/pull/28444.

  Bartłomiej Dach · 2024-07-08 16:28:54 +02:00
  275b959c02
• Fix editor menus overflowing off screen

  Closes https://github.com/ppy/osu/issues/28750.
  
  Yes this is not the perfect change to fix this (which would probably be
  some framework change to take bounds of the parenting input manager into
  account). I really do not want to go there and would like to just fix
  this locally and move on. Due to the game-wide scaling container this
  sorta works for any resolution anyhow.

  Bartłomiej Dach · 2024-07-08 11:05:39 +02:00
  2ceedb0f93
• Merge branch 'master' into navigate-to-timestamp
  Dean Herbert · 2024-07-03 20:42:32 +09:00
  5f56ed6872
• Fix editor setting arbitrary beat divisor
  OliBomby · 2024-06-27 12:22:00 +02:00
  29412bb29b
• Merge pull request #28444 from bdach/scrolling-ruleset-editor-reloads

  Reload scrolling hitobject composer on control point changes

  Dean Herbert · 2024-06-20 15:15:26 +09:00
  0eb533f2fd
• Address review feedback
  Bartłomiej Dach · 2024-06-18 13:07:18 +02:00
  e1827ac28d
• Reduce editor opacity of several editor components when hovering over composer

  Addresses https://github.com/ppy/osu/discussions/24384.

  Bartłomiej Dach · 2024-06-17 12:14:28 +02:00
  7cfe8d8df2
• Remove redundant type spec
  Bartłomiej Dach · 2024-06-17 10:54:52 +02:00
  f7910f774d
• Move timeline toggle controls to "view" menu
  Bartłomiej Dach · 2024-06-17 10:16:40 +02:00
  b42752c9f0
• Reload scrolling composer on control point changes
  Bartłomiej Dach · 2024-06-11 12:01:35 +02:00
  922837dd3a
• Attempt full editor reload on key count change
  Bartłomiej Dach · 2024-06-11 11:31:49 +02:00
  da53a11d3c
• Refactor further to address code quality complaints
  Bartłomiej Dach · 2024-06-10 10:30:30 +02:00
  1d6b7e9c9b
• Disallow running save-related operations concurrently

  Closes https://github.com/ppy/osu/issues/25426.
  
  Different approach to prior ones, this just disables the relevant
  actions when something related to save/export is going on. Still ends up
  being convoluted because many things you wouldn't expect to touch save
  do touch save, so it's not just a concern between export and save
  specifically.

  Bartłomiej Dach · 2024-06-07 08:13:51 +02:00
  e13e9abda9
• Move workaround to subscreen
  Bartłomiej Dach · 2024-05-24 10:35:33 +02:00
  807d982a72
• Update to not use obsoleted method
  Bartłomiej Dach · 2024-05-24 10:35:31 +02:00
  a80dbba9d0
• Merge branch 'master' into fix-editor-didnt-save
  Bartłomiej Dach · 2024-05-24 10:16:46 +02:00
  4089071299
• Revert "Temporary rollback of framework / SDL3"

  This reverts commit d7d569cf4e.

  Dean Herbert · 2024-05-22 16:29:39 +08:00
  d0b1ebff5a
• Temporary rollback of framework / SDL3
  Dean Herbert · 2024-05-21 14:36:16 +08:00
  d7d569cf4e
• Fix deleting modified difficulty via editor leaving user in broken state

  Closes https://github.com/ppy/osu/issues/22783.
  
  If the difficulty being edited has unsaved changes, the editor exit flow
  would prompt for save *after* the deletion method has run. This is
  undesirable from a UX standpoint, and also leaves the user in a broken
  state.
  
  Thus, just fake an update of the last saved hash of the beatmap to fool
  the editor into thinking that it's not dirty, so that the exit flow will
  not show a save dialog.

  Bartłomiej Dach · 2024-04-25 12:55:34 +02:00
  19d006d818
• Change editor screen selection logic to use SelectItem for sound feedback
  Salman Ahmed · 2024-04-17 11:20:17 +03:00
  9e69268676
• Fix potential editor data loss if exiting while a textbox is focused
  Dean Herbert · 2024-01-26 13:59:32 +09:00
  45f2980dc0
• Add visual offset to better align editor waveforms with expectations
  Dean Herbert · 2023-12-26 17:44:49 +09:00
  f9e47242db
• Merge pull request #25520 from peppy/context-menu-spacers

  Allow context menus to have visible spacers

  Dean Herbert · 2023-11-21 16:56:36 +09:00
  21bf288277
• Merge pull request #25371 from RatinFX/open-editor-timestamp

  Implement opening editor timestamp links

  Bartłomiej Dach · 2023-11-21 15:48:36 +09:00
  d83b2e24e7
• Use SimpleErrorNotification for error display
  Dean Herbert · 2023-11-21 15:10:41 +09:00
  7c5345bf7e
• Adjust localisablel strings and keys
  Dean Herbert · 2023-11-21 15:08:15 +09:00
  917a68eac3
• Allow context menus to have visible spacers
  Dean Herbert · 2023-11-21 14:24:10 +09:00
  405ab499e9
• Rename and document SelectFromTimestamp
  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  b6215b2809
• Remove unnecessary guard

  Setting a bindable's value to something if that value is already there
  is a no-op (doesn't trigger bindings / callbacks).

  Bartłomiej Dach · 2023-11-20 21:57:14 +09:00
  246aacb216
• Simplify parsing code

  Less methods, less smeared around logic, saner data types.

  Bartłomiej Dach · 2023-11-20 21:57:12 +09:00
  0e0ab66148
• Refactor HitObject selection in Composer
  ratinfx · 2023-11-11 14:02:42 +01:00
  4e1e19728c
• Forgot a clock.Stop call
  ratinfx · 2023-11-07 12:23:22 +01:00
  544d5d1d86
• HitObject Selection logic and separation for gamemodes

  + moved time_regex into EditorTimestampParser

  ratinfx · 2023-11-07 01:36:58 +01:00
  aa87e0a44d
• Renamed method and moved Notifications inside
  ratinfx · 2023-11-07 00:56:24 +01:00
  0834b79cc7
• Display "required save" popup when creating another difficulty on a new beatmap
  Salman Ahmed · 2023-11-06 21:54:40 +03:00
  b2749943e2
• Moved error checks into Editor

  - Invoke Action on error to Notify user
  - added some comments

  ratinfx · 2023-11-04 21:17:58 +01:00
  7492d953ae