54099 Commits

This Branch

This Branch

All Branches

• Merge pull request #19552 from andy840119/remove-nullable-disable-in-the-desktop-project

  Remove nullable disable in the osu.Desktop

  Dan Balasescu · 2022-08-04 13:07:06 +09:00
  cbe09b51c4
• Merge pull request #19570 from peppy/more-until-steps

  Change all filter control button state test to until steps

  Salman Ahmed · 2022-08-03 21:55:27 +03:00
  656c9eb504
• Merge branch 'master' into more-until-steps
  Salman Ahmed · 2022-08-03 21:25:30 +03:00
  571a93e1bc
• Merge pull request #19548 from peppy/more-beat-sync-dependence

  Improve `IBeatSyncProvider` interface and reduce beatmap track dependence

  Salman Ahmed · 2022-08-03 20:54:57 +03:00
  8489963abc
• Move properties and mark as get-only
  Salman Ahmed · 2022-08-03 20:31:51 +03:00
  b00c3a4d6d
• Merge branch 'master' into more-beat-sync-dependence
  Salman Ahmed · 2022-08-03 20:22:42 +03:00
  7c45c571a0
• Replace parantheses with nullable-bool equality operation
  Salman Ahmed · 2022-08-03 20:11:08 +03:00
  844430502b
• Give this class a constructor to make sure that message data will always assigned.
  andy840119 · 2022-08-03 23:17:09 +08:00
  8b02c955d8
• Merge pull request #19522 from frenzibyte/improve-download-limit-message

  Display readable error message when reaching download limit

  Dean Herbert · 2022-08-03 23:32:04 +09:00
  1eb8168a8d
• Fix test step names being too long
  Dean Herbert · 2022-08-03 21:13:49 +09:00
  7022d9e5f8
• Merge branch 'master' into improve-download-limit-message
  Dean Herbert · 2022-08-03 20:17:02 +09:00
  87cc2db624
• Use existing localised error message
  Dean Herbert · 2022-08-03 20:15:46 +09:00
  d3954fc583
• Convert interface methods to extension methods
  Dean Herbert · 2022-08-03 20:07:55 +09:00
  a32149fda1
• Change all filter control button state test to until steps

  There's multiple schedules at play which could be adding multi-frame
  delays. let's play it safe and try and fix flaky tests.
  
  Example of `Schedule` which could cause an issue:
  https://github.com/ppy/osu/blob/392cb352cc71da8b0f82aa0877ea6a7febfc54b1/osu.Game/Collections/CollectionDropdown.cs#L77-L78
  
  Example of test failure:
  https://github.com/ppy/osu/runs/7648118894?check_suite_focus=true

  Dean Herbert · 2022-08-03 20:03:07 +09:00
  24d84890e4
• Merge pull request #19564 from peppy/fix-legacy-song-progress-mouse-blocking

  Fix `LegacySongProgress` incorrectly blocking mouse input from gameplay

  Dan Balasescu · 2022-08-03 18:51:59 +09:00
  b822a6de9e
• Merge branch 'master' into fix-legacy-song-progress-mouse-blocking
  Salman Ahmed · 2022-08-03 12:12:58 +03:00
  4063f92381
• Merge pull request #19563 from peppy/realm-migration-safety

  Change migration logic to ignore realm pipe files regardless of database filename

  Salman Ahmed · 2022-08-03 12:11:50 +03:00
  dbdfa90012
• Use different variable source
  Dean Herbert · 2022-08-03 17:47:32 +09:00
  16ff8d5c38
• Fix LegacySongProgress incorrectly blocking mouse input from gameplay

  Closes #19555.

  Dean Herbert · 2022-08-03 17:42:29 +09:00
  6ad6561e1c
• Change migration logic to ignore realm pipe files regardless of database filename
  Dean Herbert · 2022-08-03 17:37:30 +09:00
  f743dc623f
• Remove the null check.
  andy840119 · 2022-08-02 23:14:08 +08:00
  8d175bc402
• give the object a default value(null).
  andy840119 · 2022-08-02 23:02:14 +08:00
  c8c2758d63
• give the field a default value.
  andy840119 · 2022-08-02 22:29:54 +08:00
  13b2441c51
• Prevent return the null value.
  andy840119 · 2022-08-02 22:29:54 +08:00
  11a4bb5833
• Remove nullable disable annotation and fix the api broken.
  andy840119 · 2022-08-02 22:29:54 +08:00
  78cc28d75f
• Tidy up kiai time access
  Dean Herbert · 2022-08-02 18:18:40 +09:00
  258ad7c6b9
• Improve IBeatSyncProvider interface and reduce beatmap track dependence
  Dean Herbert · 2022-08-02 17:59:18 +09:00
  cc4cde2c79
• Merge pull request #19543 from peppy/dont-clear-chat-overlay

  Avoid clearing chat overlay textbox when pressing "back" key binding

  Dean Herbert · 2022-08-02 14:34:17 +09:00
  227906e30e
• Avoid clearing chat overlay textbox when pressing "back" key binding

  Generally this is expected behaviour for usages of focused text boxes
  (ie. to clear search content), but not so much here.
  
  Addresses https://github.com/ppy/osu/discussions/19403#discussioncomment-3230395.

  Dean Herbert · 2022-08-02 13:56:03 +09:00
  34ffc51c51
• Merge pull request #19536 from frenzibyte/playlists-settings-leak

  Fix playlist settings reference leak due to unsafe binding

  Dan Balasescu · 2022-08-02 13:30:55 +09:00
  fc0914bf77
• Merge pull request #19535 from naipofo/overlay-filter-rank

  Hide F rank from the beatmap overlay

  Dan Balasescu · 2022-08-02 13:06:27 +09:00
  4295dc3cb9
• Merge pull request #19534 from andy840119/fix-up-remaining-issue-in-the-mods

  Update nullability specifications in osu!catch and osu!taiko mods

  Dan Balasescu · 2022-08-02 12:09:44 +09:00
  9a468f85f7
• Merge pull request #19538 from bdach/mod-overlay/sheared-button-broken-autosize

  Fix broken sheared button autosizing logic

  Dean Herbert · 2022-08-02 11:51:14 +09:00
  5501195ed7
• Remove un-need using.
  andy840119 · 2022-08-02 10:23:52 +08:00
  eb73f9e88c
• Fix broken ShearedButton autosizing logic
  Bartłomiej Dach · 2022-08-01 22:04:16 +02:00
  298efa5391
• Add failing assertions to demonstrate autosize failure
  Bartłomiej Dach · 2022-08-01 22:04:14 +02:00
  923d9a4e5f
• Merge branch 'master' into overlay-filter-rank
  NaiPofo · 2022-08-01 21:54:44 +02:00
  3356909026
• Remove localisation for now
  Salman Ahmed · 2022-08-01 22:05:52 +03:00
  7354f9e6ba
• Merge pull request #19532 from frenzibyte/fix-new-items-sort-stability

  Fix newly imported beatmaps not using correct comparer for sorting

  Dean Herbert · 2022-08-02 02:20:51 +09:00
  c0e5f11c90
• Enable NRT on playlists settings overlay
  Salman Ahmed · 2022-08-01 20:15:08 +03:00
  7e9d11ee24
• Fix playlist settings reference leak due to unsafe callback binding
  Salman Ahmed · 2022-08-01 20:08:18 +03:00
  c851e3d8f3
• Hide F rank from beatmap overlay
  notmyname · 2022-08-01 18:54:00 +02:00
  6686b09549
• Use non-nullable instead in the taiko ruleset.
  andy840119 · 2022-08-02 00:48:23 +08:00
  b1d320bf67
• Use non-nullable instead in the catch ruleset.
  andy840119 · 2022-08-02 00:45:47 +08:00
  1fe7e4d19a
• Fix newly imported beatmaps not using correct comparer for sorting
  Salman Ahmed · 2022-08-01 19:13:57 +03:00
  fc7fc3d673
• Merge pull request #19479 from frenzibyte/carousel-update-on-resume

  Fix song select not updating selected beatmap card on editor resume

  Dean Herbert · 2022-08-02 00:48:18 +09:00
  01cc9bd7ef
• Add failing test case
  Salman Ahmed · 2022-08-01 18:43:01 +03:00
  682192dbd7
• Merge pull request #16589 from mk56-spn/Wiggle-strength-duration

  Add strength setting for wiggle mod

  Dean Herbert · 2022-08-02 00:03:53 +09:00
  c53a4f1c45
• Rename variable to not include mode name itself
  Dean Herbert · 2022-08-01 23:30:00 +09:00
  a5fac70c3b
• Merge branch 'master' into Wiggle-strength-duration
  Dean Herbert · 2022-08-01 23:29:03 +09:00
  d09976bb39