34 Commits

• Fix lack of encode-decode stability when writing out mania beatmaps with some key counts (#37256)

  Closes https://github.com/ppy/osu/issues/37232.
  
  The actual fix is
  https://github.com/ppy/osu/commit/e959b20517497a093d3c00a17457c5d36bf57651;
  everything else is window dressing / test harness to ensure I don't try
  and do a wrong change like https://github.com/ppy/osu/pull/37251 did. I
  recommend reviewing commit-by-commit.
  
  See [this desmos](https://www.desmos.com/calculator/a5yjpacvxa) for
  visual explanation of change, I think it does a better job at explaining
  this than any words I could type here.
  
  Of note:
  
  - In the end this did only affect 14K but that should never be assumed
  when floating point is involved.
  - Test cases generated here were generated in stable manually.
  - Except for 11 / 13 / 15 / 17K which are not officially supported and
  which don't work in lazer due to orthogonal reasons (see comment added
  in this PR in `ManiaBeatmapConverter`), decoding in lazer was always
  fine.
  - My worry was that the old encoding method before this PR could
  potentially cause stable to move a note from one column to another but
  thankfully that is not the case. The old method of encoding columns as X
  positions does not cause issues wherein lazer reads them back
  differently than stable after encode.
  
  I checked this by checking out `master`, re-encoding all of the test
  stair-pattern nK beatmaps added in this PR on `master`, exporting that
  as compatibility, re-importing to stable, and cross-checking that the
  decoded beatmap is visually the same on lazer and on stable.
  
  This is important to check because if this wasn't the case, we'd
  potentially have cases of actual online beatmaps (remember that we have
  BSS now) wherein a beatmap plays differently on stable than on lazer due
  to notes moving between columns, and would need to screen for this being
  the case and potentially apply corrective / reconciliatory action.

  Bartłomiej Dach · 2026-04-11 00:38:22 +09:00
  6231e06ebe
• Fix mania hold notes dimming unexpectedly (#37008)

  Fixes https://github.com/ppy/osu/issues/29223
  
  This fixes several issues around hold note dimming.
  
  Notice in the following video:
  - The tail piece of the first note not getting dimmed.
  - The body of the second note not responding to dimming at all.
  
  
  https://github.com/user-attachments/assets/8e51053d-8d88-4e48-909b-79218d65917b
  
  Then, notice in the following video:
  - The body piece of the second note is dimmed from the very beginning.
  
  
  https://github.com/user-attachments/assets/a514c630-5c72-4ba5-96d5-472bae1058b3
  
  This requires a specific setup whereby the hold note and its components
  must be reused from the pool. In particular:
  1. The hold note must be long. So long that by the time the tail becomes
  on screen, the body will already have dimmed.
  2. The hold note must be re-used from the pool. We can induce this by
  setting the pool sizes to 1 in
  [`Column.cs`](https://github.com/ppy/osu/blob/780ce2666099c22d1e0673cafab544418b5d14b0/osu.Game.Rulesets.Mania/UI/Column.cs#L121-L123).
  3. The second hold note should be placed far enough in the timeline that
  the first hold note dies by the time it becomes visible.
    4. Scroll speed should be adjusted to fit the above constraints.
  
  I haven't done a full deep dive into exactly _why_ this is happening, so
  the fix here is hand-wavy. That said, just by looking at the old code in
  `LegacyBodyPiece` you'll get a feeling that something's bound to go
  wrong;
  - It never resets the `missingFadeTime` state.
  - It never resets the colours back to `Color4.White`.
  - It applies transforms onto external components.
  - It jumps through hoops to figure out how to set `missingFadeTime`.
  
  My hope is that these changes first bring some sanity in the process,
  and if it breaks again I'll consider doing a more proper root cause
  (I've had this issue in the back of my mind for about 1 year).
  
  With this PR, they now behave as expected:
  
  
  https://github.com/user-attachments/assets/140b37c5-cf84-44ba-b797-86ac6d8130c8
  
  
  https://github.com/user-attachments/assets/6f2342a4-6a9a-4941-a55a-24a357f27c25

  Dan Balasescu · 2026-03-23 08:33:23 +01:00
  d4a4acd3f4
• formatting
  Nathan Du · 2024-06-29 16:46:16 +08:00
  463ab46fee
• add tests for No Release mod

  The new test scene is essentially a copy of TestSceneHoldNoteInput,
  modified to test the judgement changes applied by the new mod. A base
  class might need to be abstracted out for them.

  Nathan Du · 2024-06-29 16:20:07 +08:00
  679f4735b3
• Remove outdated inline comments
  Bartłomiej Dach · 2023-12-20 15:44:02 +01:00
  b0da24176e
• Update test expectations
  Dean Herbert · 2023-12-20 19:57:42 +09:00
  d417b156b2
• Fix code quality inspection (weird one)
  Dean Herbert · 2023-10-16 15:16:10 +09:00
  d9d0629157
• Fix various tests
  Dean Herbert · 2023-10-16 14:21:33 +09:00
  7c49843411
• Make combo assertion actually work as expected
  Dan Balasescu · 2023-10-10 08:32:35 +09:00
  7211c88e83
• Adjust test to fail
  Dan Balasescu · 2023-09-01 20:42:27 +09:00
  0fd445f913
• Remove mania hold note ticks
  Dan Balasescu · 2023-08-31 17:30:27 +09:00
  c60f13dd92
• Add one more test
  Dan Balasescu · 2023-08-31 16:31:54 +09:00
  5241634c49
• Add extra tests of hold note input in more standard scenarios
  Dean Herbert · 2023-05-08 17:49:41 +09:00
  bcabe96714
• Apply nullability in related classes and remove unused variable
  Dean Herbert · 2023-05-08 17:09:08 +09:00
  1b7dd32eb1
• Partial everything
  Dan Balasescu · 2022-11-27 00:00:27 +09:00
  7bc8908ca9
• Add test coverage of input near end of hold note with nearby subsequent note

  Covers the scenarios mentioned in #21371.
  
  Turns out this seems mostly okay already, so there are no fixes applied here.

  Dean Herbert · 2022-11-22 17:09:14 +09:00
  c1b193149c
• Fix tests
  ekrctb · 2022-10-25 19:48:33 +09:00
  0b8b322322
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Update tests to use more correct control point definitions
  Dean Herbert · 2021-09-06 22:04:51 +09:00
  1952ebece9
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Merge branch 'master' into mania-pooling
  Dean Herbert · 2021-05-19 17:23:45 +09:00
  bddc3121dc
• Fix hold note input test

  Not sure why this was checking visibility. If it needs to be tested, it
  does not belong in an "Input" test.

  smoogipoo · 2021-05-13 20:11:06 +09:00
  1ae57a6105
• Replace failed mania test (pooling not accounted) with a more robust test

  Also fix null reference in Playfield

  ekrctb · 2021-04-29 14:38:01 +09:00
  799d2a3300
• Add failing test
  smoogipoo · 2021-04-22 18:59:57 +09:00
  30e6ea4291
• Improve assertions
  smoogipoo · 2021-03-31 12:21:07 +09:00
  f78d628878
• Add failing test
  smoogipoo · 2021-03-31 12:11:43 +09:00
  ded91b32a4
• Make hold note input tests fail due to head hiding
  Bartłomiej Dach · 2021-03-21 18:39:57 +01:00
  c4f3714385
• Move player constructor configuration to dedicated class; add AllowRestart parameter
  Dean Herbert · 2020-12-23 17:47:46 +09:00
  3c8f871b28
• Adjust hold note tests
  smoogipoo · 2020-09-29 17:48:44 +09:00
  379a4cca85
• Fix hold notes accepting presses during release lenience
  smoogipoo · 2020-07-20 22:26:58 +09:00
  f044c06d08
• Replace all judged event logic with HasCompleted bindable
  Salman Ahmed · 2020-04-19 05:36:04 +03:00
  fc6c245de5
• Fix test text
  smoogipoo · 2019-12-23 18:50:18 +09:00
  d5288760a7
• Add failing tests
  smoogipoo · 2019-12-23 18:47:58 +09:00
  7bb4a08f10