Dean Herbert
c885ad87d5
Update HitErrorDisplay tests
2021-05-18 15:12:29 +09:00
Dean Herbert
829d326e36
Remove alignment logic completely for the time being
...
This was overly complex and does not play well with the new layout
customisation system. We can add it back as required.
2021-05-18 14:55:34 +09:00
Dean Herbert
7137315fa7
Remove HitErrorDisplay container and hook up data
2021-05-17 19:46:50 +09:00
Dean Herbert
42d2711dc6
Use ShouldBeConsideredForInput instead of ReceivePositionalInputAtSubTree
2021-05-17 19:29:59 +09:00
Dean Herbert
60f3e628bc
Fix song progress being interactable inside toolbox button
2021-05-17 19:05:22 +09:00
Dean Herbert
ecf70c1707
Remove unnecessary container
2021-05-17 18:55:18 +09:00
Dean Herbert
b80768b44a
Hook up seeking flow
2021-05-17 18:52:56 +09:00
Dean Herbert
0c433cda86
Update HUDOverlay logic to add automatic layout for bottom-aligned components
2021-05-17 18:52:56 +09:00
Dean Herbert
da0913ca2d
Make SongProgress a skinnable component
2021-05-17 18:52:56 +09:00
Dean Herbert
1f3ae901ce
Expose DrawableRuleset for consupmtion by HUD components
2021-05-17 18:23:01 +09:00
Dean Herbert
7921930a92
Merge pull request #12781 from Game4all/directory-select-screen
...
Implement a directory selection screen
2021-05-17 17:23:00 +09:00
Dan Balasescu
d75ef160e8
Merge branch 'master' into directory-select-screen
2021-05-17 17:22:03 +09:00
Dean Herbert
baa4089364
Expose method to adjust header text, not whole drawable
2021-05-17 16:41:46 +09:00
Dean Herbert
de2900bc7c
Merge pull request #12834 from Henry-YSLin/flip-mod
...
Added "invert" mod for taiko
2021-05-17 12:47:05 +09:00
Dan Balasescu
22f75ce271
Merge pull request #12464 from PercyDan54/playlist-unicode
...
Add support for original language metadata display on playlist items
2021-05-17 12:25:35 +09:00
Henry Lin
f34637ea9c
Renamed TaikoModFlip to TaikoModSwap
2021-05-17 11:04:01 +08:00
Henry Lin
c4ae70a827
Revert "Renamed TaikoModFlip to TaikoModInvert"
...
This reverts commit 5972e43bc2
2021-05-17 10:59:56 +08:00
Dan Balasescu
ce7c503e6e
Merge branch 'master' into playlist-unicode
2021-05-17 11:47:10 +09:00
Dean Herbert
a32f1ef35a
Merge pull request #12811 from PercyDan54/hidden-code-cleanup
...
Remove obsolete methods in `ModHidden` and apply few touches
2021-05-16 22:07:45 +09:00
Henry Lin
5972e43bc2
Renamed TaikoModFlip to TaikoModInvert
2021-05-16 12:51:40 +08:00
Dean Herbert
422a3b76b6
Remove unused using statements
2021-05-16 13:21:19 +09:00
Dean Herbert
cbc2a38b59
Move new mod to end to avoid reordering
2021-05-16 13:21:06 +09:00
Henry Lin
3d83741a23
Separate Flip and Random
2021-05-16 12:03:03 +08:00
Henry Lin
da13be6dd0
Trimmed trailing white space
2021-05-16 11:28:11 +08:00
Henry Lin
3519398a22
Added "flip" mod for taiko
2021-05-16 11:16:12 +08:00
Dean Herbert
9010cd0839
Merge pull request #12833 from Henry-YSLin/master
2021-05-16 12:12:20 +09:00
Henry Lin
a91f2d3dba
Change "judgment" to "judgement"
2021-05-16 10:17:04 +08:00
Dean Herbert
50a3775a22
Merge pull request #12717 from frenzibyte/player-loader-star-rating
...
Add star rating to the beatmap metadata in player loading screen
2021-05-15 18:25:58 +09:00
Salman Ahmed
34d1490754
Remove null conditional
...
Shouldn't guard against that here.
2021-05-15 10:00:05 +03:00
Dean Herbert
dc56250a3c
Merge branch 'master' into player-loader-star-rating
2021-05-15 15:39:57 +09:00
Dean Herbert
94b7e89ac0
Merge pull request #12747 from frenzibyte/current-star-rating
...
Allow changing current star difficulty of a `StarRatingDisplay`
2021-05-15 15:39:39 +09:00
Dean Herbert
bdcb1a624e
Merge pull request #12759 from Naxesss/beatmap-verifier-context
...
Encapsulate check arguments in context object
2021-05-15 15:39:12 +09:00
PercyDan54
166974506e
Duplicate implementions
2021-05-15 11:55:50 +08:00
PercyDan54
6e5c4ed7c6
Revert "Remove empty override"
...
This reverts commit a86a4bab91
2021-05-15 11:45:14 +08:00
PercyDan54
63ac430386
Rename startTime in parameters
2021-05-15 11:26:16 +08:00
Dean Herbert
7632b8621e
Merge pull request #12805 from peppy/add-user-id-beatmap-metadata
...
Add database tracking of beatmap creator `user_id`s
2021-05-15 09:03:52 +09:00
Dean Herbert
cb9db0da0a
Merge pull request #12801 from peppy/null-assignment-warning-enable
...
Switch null assignment to non-nullable entity warnings on
2021-05-15 09:03:03 +09:00
Bartłomiej Dach
7665bdfbbb
Merge branch 'master' into null-assignment-warning-enable
2021-05-15 01:08:34 +02:00
Bartłomiej Dach
69fc072429
Ignore skin component json data if deserialisation fails instead
...
Crashing was not really the best thing to do there given the preceding
code that already allowed a few continues in case of a missing file.
2021-05-15 01:08:11 +02:00
Bartłomiej Dach
ae71389ebe
Ignore possible nulls from stream reader in IPC
...
Any failures will be caught. They're not logged, but they also weren't
before. Error handling can be improved at a future date, this series of
changes is primarily intending to unblock a new inspection.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
d581e0a252
Ignore possible nulls in NotifyCollectionChangedArgs
...
Safe to access by the virtue of the preceding case labels on
`args.Action`. And they're in test code anyways.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
e62e473bb2
Ignore possible null in multiplayer test
...
A null value will fail the test anyhow.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
b51d038088
Ignore possible path-related nulls
...
They're all in test code anyway, so any issue there will cause a test to
fail.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
fa6b5515b7
Ignore possible null from JsonConvert.DeserializeObject()
...
Nothing better can be done if a `null` is indeed returned.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
5b2b701915
Ignore possible null in GetResponseString()
...
A null there indicates a deserialisation error and therefore due to the
catch block immediately succeeding the changed line everything will
continue to work as intended.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
628e7a71ed
Ignore possible nulls in Type.GetType() calls
...
They're mostly used in extensibility scenarios, so everything happens in
runtime. There is no better resolution than to crash with a null
reference exception.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
43c73f9583
Mark access to exception if task faulted as safe
...
There are seemingly no C#-side compile-time guarantees that it is safe,
but if the task's state is `Faulted` (as is checked right before), the
exception cannot be null as per the documentation.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
f2d0f7db99
Remove list null-checks in LogoTrackingContainer test
...
If the null-checks were tripped, the test would crash anyway. It is not
possible to call `.Any()` and get a valid result instead of an exception
on a null reference.
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
483e0dd943
Pass placeholder hitobject instead of null
2021-05-15 00:09:34 +02:00
Bartłomiej Dach
f716fb0968
Remove bogus InternalChildren null-check
...
`InternalChildren` can't viably be `null`, and if it were, we have
bigger problems. The removed null-check was triggering false-positive
inspections further down.
2021-05-15 00:09:34 +02:00
