1
0
mirror of https://github.com/ppy/osu.git synced 2024-11-17 22:52:54 +08:00
Commit Graph

27021 Commits

Author SHA1 Message Date
Dean Herbert
c7c7e626b8
Merge pull request #8163 from bdach/fix-circle-piece-hitbox
Fix osu! hitbox accepting input outside of circle
2020-03-07 16:40:13 +09:00
Bartłomiej Dach
b608764554 Cover area just outside circle in test 2020-03-06 22:09:02 +01:00
Bartłomiej Dach
77fd748035 Fix incorrect circle piece hitbox
Hitboxes of circle pieces in osu! have regressed with commit 8592335.
The reason for the regression was that hit detection was moved from
DrawableHitCircle itself to a newly-introduced private HitArea class
(now named HitReceptor).

As HitArea inherited from Drawable, it would return IsHovered == true
over its entire bounding box. This meant that the hit area could wrongly
pick up actions that are not within circle radius and make them into
hits.

To resolve, make HitReceptor a CompositeDrawable and set its corner
radius to match the circle piece. This fixes the invalid hitbox, as
IsHovered takes radius into account.
2020-03-06 21:21:20 +01:00
Bartłomiej Dach
491840b17d Add failing tests 2020-03-06 21:10:23 +01:00
Dean Herbert
8ceaa39fb4
Merge pull request #8100 from smoogipoo/fix-testscene-rate
Fix test scene virtual track not respecting rate adjustments
2020-03-06 23:45:34 +09:00
Dean Herbert
d39e9df27f
Merge branch 'master' into fix-testscene-rate 2020-03-06 23:21:24 +09:00
Dean Herbert
09bd5ad185
Merge pull request #8151 from peppy/tourney-simplify-video-spec
Simplify tournament video construction
2020-03-06 23:15:02 +09:00
Dean Herbert
3295f8657a Restore clamp behaviour 2020-03-06 22:44:11 +09:00
Dean Herbert
fa8e7adf07 Merge branch 'master' into fix-testscene-rate 2020-03-06 22:40:02 +09:00
Dan Balasescu
3d54334dd6
Merge pull request #8150 from peppy/remove-layout-durations-tournament-editors
Remove layout durations from tournament editor screens for better performance
2020-03-06 22:38:06 +09:00
Dan Balasescu
3f51effe98
Merge pull request #8149 from peppy/add-load-delay-for-avatars
Add a short load delay for avatars to avoid unnecessary fetching
2020-03-06 22:31:16 +09:00
Dan Balasescu
643b25e484
Merge branch 'master' into tourney-simplify-video-spec 2020-03-06 22:28:21 +09:00
Dan Balasescu
092c02c3b3
Merge pull request #8148 from peppy/fix-tournament-screen-aspect-in-tests
Ensure tournament screens respect aspect ratio in tests
2020-03-06 22:18:01 +09:00
Dan Balasescu
cac4c6b724
Merge branch 'master' into remove-layout-durations-tournament-editors 2020-03-06 22:09:48 +09:00
Dan Balasescu
28c665e7a6
Merge branch 'master' into add-load-delay-for-avatars 2020-03-06 22:09:47 +09:00
Dan Balasescu
fa8ee0ca0d
Merge branch 'master' into fix-tournament-screen-aspect-in-tests 2020-03-06 21:59:42 +09:00
Dean Herbert
b6a695ec11
Update framework (#8152)
Update framework
2020-03-06 19:19:51 +09:00
Dean Herbert
16cc49daa0 Update framework 2020-03-06 18:47:31 +09:00
Dean Herbert
fd16d24362
Make KeyCounter not count key presses during breaks (#8059)
Make KeyCounter not count key presses during breaks
2020-03-06 18:42:22 +09:00
Dean Herbert
0a72fa69ab Simplify video creation (and handle fallback better) 2020-03-06 18:39:12 +09:00
Dean Herbert
2d95f29925 Add gameplay screen specific video 2020-03-06 18:38:54 +09:00
Dean Herbert
a59c3d997d Refactor implementation to better match what already existed 2020-03-06 18:00:17 +09:00
Dean Herbert
0ccf691c97 Remove unnecessary interpolation 2020-03-06 18:00:07 +09:00
Dean Herbert
3b0e3cd71a Remove using statements 2020-03-06 17:55:57 +09:00
Dean Herbert
40074f10db Remove unnecessary override 2020-03-06 17:55:05 +09:00
Dean Herbert
90dbb90470 Merge branch 'master' into disable-keycounter-breaks 2020-03-06 17:53:10 +09:00
Dean Herbert
88759e65a0 Remove layout durations from tournament editor screns for better performance 2020-03-06 16:31:36 +09:00
Dean Herbert
8ff3370273 Add a short load delay for avatars to avoid unnecessary fetching 2020-03-06 16:27:38 +09:00
Dean Herbert
ac88ba717b Ensure screens respect aspect ratio in tests 2020-03-06 16:13:07 +09:00
Dean Herbert
c3ad08f230 Remove wild writeline 2020-03-06 02:18:35 +09:00
Dean Herbert
ebc86c1075 Fix random test failure 2020-03-06 02:14:16 +09:00
Dean Herbert
e3509c742c Track time in a simpler way in TrackVirtualManual 2020-03-06 02:03:19 +09:00
Dean Herbert
583e2c3f4a Actually check rate is applied 2020-03-06 00:10:05 +09:00
Dean Herbert
2b89fb68f7
Merge branch 'master' into fix-testscene-rate 2020-03-05 23:38:33 +09:00
Dan Balasescu
aafdfbca1f
Merge pull request #8129 from peppy/fix-dummy-track-completion-feedback
Fix DummyWorkingBeatmap's track completion attempting to change game-wide beatmap
2020-03-05 17:57:57 +09:00
Dan Balasescu
8a4bfb90d7
Merge pull request #8135 from mcendu/vscode-ld-library-path
Remove LD_LIBRARY_PATH from vscode launch.json
2020-03-05 17:57:49 +09:00
Dan Balasescu
07a54a10b5
Merge pull request #8066 from voidedWarranties/mod-testscene
Add base test scene allowing different player initialisation per test method
2020-03-05 17:40:08 +09:00
Dan Balasescu
71cea29b09
Merge branch 'master' into vscode-ld-library-path 2020-03-05 17:14:12 +09:00
smoogipoo
0c1775b522 Fix incorrect condition and add test 2020-03-05 17:12:14 +09:00
Dan Balasescu
f12a515ca5
Merge branch 'master' into mod-testscene 2020-03-05 17:10:24 +09:00
Dan Balasescu
f7777ecb01
Merge pull request #8142 from peppy/add-star-difficulty-max-migration
Fix song select max displayable star difficulty getting stuck at wrong maximum
2020-03-05 17:10:10 +09:00
smoogipoo
9307caa3bf Fix typos 2020-03-05 16:58:07 +09:00
Dan Balasescu
98929a65d4
Merge pull request #8140 from peppy/less-test-players
Centralise TestPlayer implementations as much as possible
2020-03-05 16:54:25 +09:00
Dan Balasescu
f0fd2a86e3
Merge branch 'master' into add-star-difficulty-max-migration 2020-03-05 16:30:38 +09:00
Dan Balasescu
5368f5214b
Merge branch 'master' into less-test-players 2020-03-05 16:30:38 +09:00
Dan Balasescu
0487440f53
Merge pull request #8141 from peppy/centralise-update-managers
Centralise creation of UpdateManagers
2020-03-05 16:02:05 +09:00
Dean Herbert
646c8fe077 Add note about version override 2020-03-05 15:40:48 +09:00
Dean Herbert
5b8037ea7d Add note about early migration return on non-release transitions 2020-03-05 15:36:36 +09:00
Dean Herbert
507af4fa72 Add comment about rationale behind always updating version in config 2020-03-05 15:35:27 +09:00
Dean Herbert
d3786a9382 Merge branch 'centralise-update-managers' into add-star-difficulty-max-migration 2020-03-05 15:07:20 +09:00