1021 Commits

• Move BeatmapSetOnlineInfo to an interface type
  Dean Herbert · 2021-10-21 16:58:42 +09:00
  0706ad70fb
• Remove APIPlaylistBeatmap subclass
  Dean Herbert · 2021-10-21 16:43:46 +09:00
  a5c155bc87
• Fix intendation in a way it doesn't regress with older inspectcode
  Dean Herbert · 2021-10-18 14:28:29 +09:00
  ad112cbbc5
• Fix new indentation inspections
  Dean Herbert · 2021-10-18 14:00:35 +09:00
  6d6eed61aa
• Merge pull request #14954 from peppy/rename-result-response

  Rename `APIRequest.Result` to `Response`

  Dan Balasescu · 2021-10-06 10:52:33 +09:00
  9491e5a547
• Merge pull request #14967 from bdach/fix-accidental-json-property-rename

  Fix "most played beatmap" request breakage after property rename

  Dean Herbert · 2021-10-06 05:00:12 +09:00
  c23acb8f05
• Fix "most played beatmap" request breakage after property rename
  Bartłomiej Dach · 2021-10-05 21:17:19 +02:00
  baa8baaa1e
• Add test coverage for loading process on channel join
  Bartłomiej Dach · 2021-10-05 20:52:40 +02:00
  12da27cde7
• Rename APIRequest.Result to Response
  Dean Herbert · 2021-10-05 14:28:56 +09:00
  b41fa41c85
• Rename last remaining BeatmapInfo Beatmap usage
  Dean Herbert · 2021-10-04 17:35:53 +09:00
  853cf6feaa
• Merge pull request #14949 from peppy/login-error-display

  Show login failure messages on login form

  Dan Balasescu · 2021-10-04 17:23:11 +09:00
  5937a93e2d
• Add fallback to use Message when Hint is not available
  Dean Herbert · 2021-10-04 16:18:55 +09:00
  3a0b7ba8ff
• Expose login errors from IAPIProvider and show on the login form
  Dean Herbert · 2021-10-04 15:40:24 +09:00
  266b4c7124
• Make AuthenticateWithLogin throw instead of return a bool success status
  Dean Herbert · 2021-10-04 15:40:00 +09:00
  5aaafce597
• Rename all remaining cases
  Dean Herbert · 2021-10-03 00:55:29 +09:00
  ec61c3c5ee
• Merge branch 'master' into chat-command
  Dan Balasescu · 2021-09-13 13:32:44 +09:00
  d9b4fae4e5
• make user lookup string public
  Davran Dilshat · 2021-09-11 16:22:29 +01:00
  1b264a2dd0
• Merge pull request #14704 from peppy/modicon-imod-support

  Update `LeaderboardModSelector` to avoid creating mod instances

  Dan Balasescu · 2021-09-10 16:43:32 +09:00
  f4b1d8b9d1
• Merge pull request #14675 from ekrctb/featured-artist-markers

  Add featured artist markers to beatmap listing and overlay

  Dean Herbert · 2021-09-10 14:30:33 +09:00
  309460e505
• Update LeaderboardModSelector to avoid creating mod instances
  Dean Herbert · 2021-09-10 12:43:21 +09:00
  28e9329136
• Disable APIMod/Mod cross equality support
  Dean Herbert · 2021-09-10 11:24:56 +09:00
  76e877f160
• Refactor exposed mod retrieval methods for better safety
  Dean Herbert · 2021-09-10 11:09:13 +09:00
  cf633973a9
• Remove unused IMod specification from APIMod
  Dean Herbert · 2021-09-10 10:59:30 +09:00
  ce6b022a90
• Add ability to lookup mod from a type specification
  Dean Herbert · 2021-09-09 16:50:59 +09:00
  2edb851008
• Add new methods to ruleset for quicker mod lookups
  Dean Herbert · 2021-09-09 16:46:14 +09:00
  4d0530ca9d
• Avoid settings copy if there are no settings
  Dean Herbert · 2021-09-09 15:43:55 +09:00
  e66d76d26e
• Add featured artist track ID online info
  ekrctb · 2021-09-08 12:21:24 +09:00
  7543f9dfb0
• fix "key" having wrong url parameter name
  Davran Dilshat · 2021-09-07 17:17:10 +01:00
  be9540e535
• Add "featured artists" filter to beatmap search
  ekrctb · 2021-09-07 16:44:45 +09:00
  b6c80f04b0
• Use correct lookup type to ensure username based lookups always prefer username
  Dean Herbert · 2021-09-06 15:04:27 +09:00
  1c4a3c584a
• more code quality :/
  Davran Dilshat · 2021-09-05 15:27:28 +01:00
  e78dc1bb4c
• add xmldoc
  Davran Dilshat · 2021-09-05 10:42:38 +01:00
  e409f2dc6d
• remove braces

  Co-authored-by: Salman Ahmed <frenzibyte@gmail.com>

  rednir · 2021-08-30 13:23:33 +01:00
  8104b15874
• add methods to get a user from their username
  Davran Dilshat · 2021-08-29 19:19:55 +01:00
  90c313e2ad
• Merge branch 'master' into pinned-comment
  Dean Herbert · 2021-08-24 14:37:31 +09:00
  8cd972a9fe
• Return early to avoid updating state and failure count in fail cases
  Dean Herbert · 2021-08-20 12:11:41 +09:00
  da8eba9996
• Ensure all request failures are correctly handled during login
  Dean Herbert · 2021-08-19 19:55:14 +09:00
  a6b7ca1a4c
• Fix code formatting
  Opelkuh · 2021-08-15 16:02:25 +02:00
  7d7c5c06f0
• Add test for ChannelManager.MarkChannelAsRead
  Opelkuh · 2021-08-15 15:44:23 +02:00
  2f9f1ba862
• add pinned comment to users setter in comment bundle
  Gagah Pangeran Rosfatiputra · 2021-08-13 19:40:37 +07:00
  480d5ffa5d
• add pinned comments property in comment bundle
  Gagah Pangeran Rosfatiputra · 2021-08-13 13:13:28 +07:00
  39b13efdd5
• add pinned property in comment
  Gagah Pangeran Rosfatiputra · 2021-08-13 12:57:29 +07:00
  0901333ef3
• Add missing xmldoc comment

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-08-03 14:50:56 +09:00
  556962a3d8
• Add the ability to not use MessagePack when creating a HubConnector
  Dean Herbert · 2021-08-02 18:50:22 +09:00
  617ff40de7
• Fix incorrect authorisation loss exception handling with recent changes
  Dean Herbert · 2021-07-30 18:11:40 +09:00
  185ea776f5
• Fix aborting an APIRequest potentially resulting in incorrect success
  Dean Herbert · 2021-07-29 13:01:52 +09:00
  3a5324c947
• Avoid deserialisation JSON request content when error is not present (or not relevant)
  Dean Herbert · 2021-07-28 20:13:40 +09:00
  1ed4fdd5f5
• Fix beatmap search requests double-escaping

  Closes #14008.

  Dean Herbert · 2021-07-25 17:06:40 +09:00
  bb3747ffc9
• Fix authentication loss not handled correctly

  This handles the case where on initial API connection, the server
  responds with an `Unauthorized` response. It doesn't perform this same
  checking/handling on every API request, which is probably what we want
  eventually.
  
  Opting to not address the full issue because I know this is going to be
  a long one (see
  https://github.com/ppy/osu/blob/05c50c0f6cfafab359963586ec265ad4f143a46c/osu.Game/Online/API/APIAccess.cs#L233).

  Dean Herbert · 2021-07-23 19:03:19 +09:00
  17168b8137
• Fix derived API request types firing success when they shouldn't

  The usual case of `virtual`/`override` being dangerous when logic is
  added to the base implementation. As such, I've removed this completely.

  Dean Herbert · 2021-07-22 14:23:27 +09:00
  57e5f5575a