154 Commits

• Merge branch 'master' into sample-set-controls
  Dean Herbert · 2023-05-24 14:03:04 +09:00
  298989ffd2
• Make HitSampleInfo.Bank non-nullable
  Dean Herbert · 2023-05-16 18:12:56 +09:00
  83dcd78826
• Fix incorrect xmldoc
  OliBomby · 2023-04-25 12:54:45 +02:00
  bf1951fc38
• Move OmitFirstBarLine to TimingControlPoint
  Dean Herbert · 2023-02-28 19:29:31 +09:00
  044b0604b2
• Make snapped time always positive
  ansel · 2023-01-12 03:38:57 +03:00
  51e21ee6f0
• Use new ArgumentNullException.ThrowIfNull throw-helper API
  Berkan Diler · 2022-12-22 21:27:59 +01:00
  08d2fbeb8e
• Use MaxBy in all locations that can and update inspection level to match dotnet-build
  Dean Herbert · 2022-12-19 16:47:10 +09:00
  4a7d7c6ed9
• Fix some more inspections
  Dean Herbert · 2022-12-16 20:21:19 +09:00
  192536643c
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Fix incorrect fallback logic

  Regressed when attempting to share implementation of binary search.

  Dean Herbert · 2022-10-20 23:08:44 +09:00
  5c13c443ff
• Expose binary search methods publicly

  Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

  Dean Herbert · 2022-10-20 14:34:07 +09:00
  a754dc6d3b
• Update osu.Game/Beatmaps/ControlPoints/IControlPoint.cs

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2022-10-20 08:06:05 +09:00
  78943a21d8
• Add and consume sample bank constants
  Dean Herbert · 2022-10-19 20:47:58 +09:00
  579d5b51eb
• Standardise control point search logic in OverlappingScrollAlgorithm

  Was using a very local algorithm which I cannot guarantee is correct.
  I'd rather it just use the one used everywhere else.

  Dean Herbert · 2022-10-18 16:01:05 +09:00
  ec3761ced9
• Cleanup all other leftover binding instantiation
  o-dasher · 2022-09-25 16:02:40 -04:00
  feadac1f79
• Update parameter discards
  Dean Herbert · 2022-06-24 21:26:19 +09:00
  31a447fda0
• Compare by reference in ControlPoint.Equals()
  Dan Balasescu · 2022-06-21 12:05:28 +09:00
  6a26461683
• Properly annotate method to allow null
  Dan Balasescu · 2022-06-20 16:56:19 +09:00
  16281f4a48
• Implement IEquatable on ControlPoint
  Dan Balasescu · 2022-06-20 15:27:43 +09:00
  03ab6fc141
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Add initial waveform comparison display
  Dean Herbert · 2022-05-24 14:36:44 +09:00
  588c5d1583
• Add flow for changing set of valid divisors between presets
  Bartłomiej Dach · 2022-02-27 15:37:51 +01:00
  d0c01afc2e
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Copy time between ControlPoints
  Dean Herbert · 2021-09-10 14:36:38 +09:00
  34f875187c
• Throw rather than ignore on invalid control point addition
  Dean Herbert · 2021-09-06 22:04:37 +09:00
  eabca016d4
• Refactor some incorrect/outdated terminology
  Dean Herbert · 2021-09-06 21:32:43 +09:00
  693ecdf62a
• Rename ApproachRate to ScrollSpeed for now (to reduce complexity/confusion)
  Dean Herbert · 2021-09-06 21:06:13 +09:00
  766d789845
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Move DifficultyControlPoints list to LegacyControlPointInfo
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  db3fc1d4af
• Actually serialise SampleControlPoints along with HitObjects
  Dean Herbert · 2021-08-31 15:14:03 +09:00
  d988aa1680
• Fix editor not cloning control points as expected
  Dean Herbert · 2021-08-30 21:55:08 +09:00
  a2cff75fc0
• Move to legacy namespace
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  ccacf56dd8
• Move samples to LegacyControlPointInfo
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  7257aae7f2
• Add IDeepCloneable interface and update existing CreateCopy methods to use it
  Dean Herbert · 2021-07-19 12:54:17 +09:00
  3c028ce05c
• Specify types explicitly and don't handle non-nullable values with fallbacks
  Dean Herbert · 2021-06-16 16:24:30 +09:00
  5944c45f55
• Fix GetClosestBeatDivisor returning the wrong divisor
  Justus Franklin Tumacder · 2021-05-01 14:13:42 +08:00
  0d077b7a5d
• Refactor lookup methods to avoid linq and reduce TimingPointAt calls
  Dean Herbert · 2021-04-28 17:16:05 +09:00
  859898d98f
• Revert return values to non-rounded doubles
  Dean Herbert · 2021-04-28 16:59:49 +09:00
  c5186b6a69
• Rename methods to match generally how these find-methods are named elsewhere
  Dean Herbert · 2021-04-28 16:57:52 +09:00
  f3c7694eeb
• Move snap/divisor helper methods to inside ControlPointInfo
  Dean Herbert · 2021-04-28 16:47:30 +09:00
  48d6c9ac4b
• Combine logic of Difficulty and Timing pieces where feasible
  Dean Herbert · 2021-04-14 20:55:34 +09:00
  be08b9d1ef
• Update design for TimingControlPoint
  Dean Herbert · 2021-04-14 20:11:47 +09:00
  a8df2388eb
• Increase the precision of speed multiplier to match osu-stable
  Dean Herbert · 2021-03-19 17:09:49 +09:00
  0195d654ca
• Make most common BPM more accurate
  smoogipoo · 2021-01-15 14:28:49 +09:00
  c6e9a6cd5a
• Fix incorrectly copy pasted xmldoc
  Dean Herbert · 2021-01-07 19:06:10 +09:00
  69ac22dd7f
• Use CreateCopy instead of Clone interface

  I was going for conformity by using the IClonable interface, but it
  doesn't look like we use it anywhere else in the project.

  Dean Herbert · 2021-01-05 13:13:52 +09:00
  caa88c6100
• Clone and copy ControlPointInfo when retrieving a playable beatmap
  Dean Herbert · 2021-01-04 16:37:07 +09:00
  ba4e411422
• Rename parameters
  smoogipoo · 2020-12-02 10:55:48 +09:00
  2150cf1c52
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc