Dan Balasescu
be2dbf42c3
Flatten DrawableRoomPlaylistWithResults into base class
2021-12-09 01:40:16 +09:00
Dan Balasescu
26f6c5e5a5
Remove ctor params from PlaylistsRoomPlaylist
2021-12-09 01:16:37 +09:00
Dan Balasescu
3be4d8b68d
Remove ctor params from DrawableRoomPlaylist/DrawablePlaylistItem
2021-12-09 01:04:56 +09:00
Dean Herbert
8d9c37a825
Merge branch 'master' into primary-key-consistency
2021-12-08 21:34:38 +09:00
Dan Balasescu
beb5d61a42
Separate playlist item deletion to Playlists-specific class
2021-12-08 20:50:25 +09:00
Dean Herbert
b1d78c4284
Merge pull request #16005 from Susko3/add-ime-sounds
...
Add sounds for IME composition
2021-12-08 19:02:02 +09:00
Dean Herbert
8fa73fcbf6
Move helper method to end of class
2021-12-08 18:30:08 +09:00
Susko3
de89e321c8
Add sounds for IME composition
2021-12-08 09:57:53 +01:00
Susko3
af1e97b7c7
Move playing text added samples to private helper and fix it never playing the last sample
...
`RNG.Next` is exclusive of the upper bound, meaning that the last sample would never be played.
2021-12-08 09:49:36 +01:00
Dan Balasescu
f2318d7e26
Merge pull request #15992 from frenzibyte/ios-high-frame-rate
...
Disable minimum frame durations on osu! for iOS
2021-12-08 16:36:15 +09:00
Dan Balasescu
65a09692da
Merge pull request #16001 from peppy/fix-own-rank-results-panel-in-multiplayer
...
Fix the local user's rank not showing on multiplayer/playlist results screen
2021-12-08 16:34:36 +09:00
Dan Balasescu
9e3a1c75d2
Merge pull request #16000 from peppy/fix-legacy-combo-counter-anchor
...
Fix `LegacyComboCounter` not handling non-default anchor/origin specifications correctly
2021-12-08 16:00:06 +09:00
Dan Balasescu
99991a6703
Minor cleanups, unifying wording a bit more
2021-12-08 15:59:15 +09:00
Dan Balasescu
1a09a3469a
Merge branch 'master' into refactor-osu-difficulty-hit-object
2021-12-08 15:53:44 +09:00
Dan Balasescu
11104124f1
Restructure doc for easier readability
2021-12-08 15:52:59 +09:00
Dean Herbert
872e0884c0
Fix the local user's rank not showing on multiplayer/playlist results screen
...
Applying the simple solution for now. Not sure how this will evolve over
time, but seems sane enough.
2021-12-08 15:22:10 +09:00
Dan Balasescu
814f072767
Use new LazyJumpDistance terminology in documentation
2021-12-08 15:17:56 +09:00
Dean Herbert
6ec3f41839
Fix LegacyComboCounter not handling non-default anchor/origin specifications correctly
2021-12-08 15:07:15 +09:00
Dan Balasescu
7c0f7b1baa
Use "x" for cursor position in diagrams
2021-12-08 14:57:21 +09:00
Dean Herbert
0775053a18
Fix the unmute notification potentially overwriting user's volume levels unnecessarily
...
I've also changed the cutoffs to 5% rather than zero, as this seems like
a saner method of showing this dialog. With levels 5% or less, the game
is basically inaudible.
Arguably, the cutoff can be increased to 10%.
2021-12-08 13:38:43 +09:00
Dean Herbert
a969fe3ef8
Add test coverage showing intended UX of user's volume levels being retained when unmuting
2021-12-08 13:37:47 +09:00
Dean Herbert
724d72b975
Merge pull request #15988 from bdach/fix-team-versus-test-failure
...
Fix test failures in team versus test
2021-12-08 11:54:00 +09:00
Dean Herbert
2e640ff2ad
Merge pull request #15989 from bdach/fix-editor-clipboard-test-failure
...
Fix editor crashing if paste is performed while composer is loading
2021-12-08 11:18:59 +09:00
Dean Herbert
f86931b66f
Merge pull request #15978 from peppy/beatmap-card/scale-on-hover
...
Scale card when expanding to better distinguish hovered card from other cards in listing
2021-12-08 11:18:07 +09:00
Salman Ahmed
fea3b9d7a9
Disable minimum frame durations on osu! for iOS
2021-12-08 04:43:02 +03:00
Bartłomiej Dach
7720a1b69b
Fix test to wait for drawable ruleset load before attempting paste
2021-12-07 21:10:45 +01:00
Bartłomiej Dach
10dd64e07c
Fix being able to paste objects while composer is loading
...
Would lead to exceptions due to modification of `Beatmap.HitObjects`
during its enumeration by `DrawableRuleset`, which was happening as an
async load via `EditorScreenWithTimeline.CreateMainContent()`.
2021-12-07 21:00:25 +01:00
Bartłomiej Dach
e9694dc74e
Wait for match type changes in team versus test
2021-12-07 20:40:10 +01:00
Susko3
0b0ff36154
Allow only number characters parseable by int.TryParse
...
char.IsNumber() is too broad, allowing full width and other numbers.
2021-12-07 20:06:22 +01:00
Bartłomiej Dach
8b7ed759e3
Merge branch 'master' into beatmap-card/scale-on-hover
2021-12-07 19:11:01 +01:00
Dan Balasescu
74db8da11b
Merge pull request #15758 from GoldenMine0502/speedbug
...
Make speed skill consider only the shortest movement distance
2021-12-08 01:31:07 +09:00
Dan Balasescu
86eacfdbd8
Merge pull request #15879 from peppy/multiplayer-delayed-playlist-load-broken
...
Load playlist panels on demand to reduce initial load time when joining a room
2021-12-08 00:42:20 +09:00
Dean Herbert
25a0505c97
Scale card when expanding to better distinguish hovered card from other cards in listing
2021-12-07 23:48:14 +09:00
Dan Balasescu
bcda777071
Merge branch 'master' into speedbug
2021-12-07 23:43:17 +09:00
Dean Herbert
d6e68feadc
Merge pull request #15948 from bdach/beatmap-card/difficulty-dropdown
...
Add difficulty dropdown to beatmap card
2021-12-07 23:40:06 +09:00
Dan Balasescu
7e236c3a41
Remove unused dependency
2021-12-07 23:36:48 +09:00
Dan Balasescu
ded86282c1
Rename + better documentation
2021-12-07 23:14:35 +09:00
Dan Balasescu
52230a6f00
Merge branch 'master' into multiplayer-delayed-playlist-load-broken
2021-12-07 22:45:05 +09:00
Dean Herbert
a8c20368c0
Merge pull request #15976 from smoogipoo/add-modes-to-room-panels
...
Add match type and queue mode to multiplayer room panels
2021-12-07 22:08:30 +09:00
Dan Balasescu
7c3d1d630e
Merge branch 'master' into refactor-osu-difficulty-hit-object
2021-12-07 21:05:49 +09:00
Dan Balasescu
4683193f09
Move implementation to base class
2021-12-07 20:36:39 +09:00
Dan Balasescu
4078372480
Merge pull request #15975 from peppy/update-framework
...
Update framework
2021-12-07 19:23:16 +09:00
Dan Balasescu
5ffe702dd6
Add match type and queue mode to multiplayer room panels
2021-12-07 18:57:13 +09:00
Dean Herbert
9978caab12
Update framework
2021-12-07 18:37:30 +09:00
Dan Balasescu
08dac3fcda
Merge pull request #15974 from peppy/fix-participant-list-state-desync
...
Fix multiplayer user panels potentially getting out of sync with player's state
2021-12-07 18:01:11 +09:00
Dean Herbert
dea7f2308c
Fix participant panels potentially keeping a reference to an old user
...
If a user leave and then rejoins a multiplayer match while another user
is not at the lobby screen, there is a potential the `ParticipantPanel`
tracking the user will not correctly be recreated to reference the new
instance of the `MultiplayerUser`.
This happens because the `OnRoomUpdated` call is scheduled, which means
it is not running in the background, coupled with the local logic that
relies on `IEquatable(MultiplayerRoomUser)` (which in turn falls back to
a UserID comparison).
Changing this to a reference comparison is the easiest way to resolve
this. Whether we change the `IEquatable` implementation is up for
discussion.
Closes https://github.com/ppy/osu/issues/15970 .
2021-12-07 17:24:04 +09:00
Dan Balasescu
9f77529e35
Merge pull request #15972 from peppy/cancellation-woes
...
Fix `GetPlayableBeatmap` timeout not being applied when no `CancellationToken` is provided to difficulty calculations
2021-12-07 14:31:56 +09:00
Dean Herbert
cfa712473d
Use default timeout in GetPlayableBeatmap when provided CancellationToken is default
2021-12-07 13:33:41 +09:00
Dean Herbert
f3e9fb76fc
Add the ability to pass a CancellationToken through DifficultyCalculator.CalculateAll
...
Was weirdly missing from this one method.
2021-12-07 13:32:47 +09:00
tbrose
882223b27f
Using static call and verbatim symbol and optimizes regex pattern for username check
2021-12-07 02:38:10 +01:00
