66382 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	1aa695add9	Implement alternate design of player loader disclaimers	2024-03-15 09:53:18 +01:00
Joseph Madamba	f8a841e907	Add comment explaining why width is limited to the button area ... Same comment as a47ccb8edd/osu.Game/Screens/Select/BeatmapInfoWedgeV2.cs (L91-L92).	2024-03-14 00:17:22 -07:00
Joseph Madamba	b309aad895	Fix noticeable masking artifact of beatmap cards when already downloaded ... Had a similar fix before seeing https://github.com/ppy/osu/pull/20743#discussion_r994955470, but using that diff instead so co-authoring. Co-Authored-By: Bartłomiej Dach <dach.bartlomiej@gmail.com>	2024-03-13 22:36:52 -07:00
Dean Herbert	a47ccb8edd	Merge pull request #27600 from bdach/dont-die-on-audio-in-video-check ... Fix audio in video check crashing on unexpected failures	2024-03-14 10:28:45 +08:00
Dean Herbert	a900ae87bb	Merge pull request #27601 from bdach/fix-bold-mod-select ... Fix first word bold not applying correctly after first language change	2024-03-14 10:27:12 +08:00
Bartłomiej Dach	d32f19b546	Fix first word bold not applying correctly after first language change ... Closes https://github.com/ppy/osu/issues/27549. I'm not entirely sure why the old solution failed exactly, but also think it's unimportant because I think past me was an idiot and was playing stupid games with the juggling of indices between two callbacks with no ordering guarantees and expecting not to win stupid prizes. I'm not sure this requires any follow-up reconsiderations of that entire text flow API, but if opinions differ, I'll re-examine.	2024-03-13 15:18:20 +01:00
Bartłomiej Dach	20c760835a	Fix audio in video check crashing on unexpected failures	2024-03-13 13:55:49 +01:00
Bartłomiej Dach	c575cce10c	Merge pull request #27595 from Joehuu/rearrange-rankings-overlay-tabs ... Rearrange rankings overlay tabs to match web	2024-03-13 11:26:57 +01:00
Joseph Madamba	e2e99fc5cc	Rearrange rankings overlay tabs to match web	2024-03-12 21:15:59 -07:00
Bartłomiej Dach	5a46808e9b	Merge pull request #27587 from peppy/remember-login ... Remember login by default	2024-03-12 14:27:23 +01:00
Dean Herbert	a4a433b92a	Remember login by default ... Kinda what is expected from a user's perspective	2024-03-12 20:14:50 +08:00
Dean Herbert	e431c1240e	Merge pull request #27562 from EVAST9919/osu-performance ... Don't update SubTreeMasking in `OsuPlayfield`	2024-03-12 18:15:14 +08:00
Dean Herbert	88ec0cdbc7	Fix seek ending too early in sample playback test	2024-03-12 17:35:39 +08:00
Dean Herbert	5b2dd95fd6	Merge pull request #27586 from bdach/ignore-directory-zip-entries ... Fix exports containing zero byte files after import from specific ZIP archives	2024-03-12 17:18:39 +08:00
Bartłomiej Dach	62a997c5fa	Merge pull request #27585 from peppy/downgrade-realm ... Downgrade realm to work around crashes on latest release	2024-03-12 09:59:16 +01:00
Bartłomiej Dach	83e47b3c4c	Fix exports containing zero byte files after import from specific ZIP archives ... Closes https://github.com/ppy/osu/issues/27540. As it turns out, some ZIP archivers (like 7zip) will decide to add fake entries for directories, and some (like windows zipfolders) won't. The "directory" entries aren't really properly supported using any actual data or attributes, they're detected by sharpcompress basically by heuristics: ab5535eba3/src/SharpCompress/Common/Zip/Headers/ZipFileEntry.cs (L19-L31) When importing into realm we have thus far presumed that these directory entries will not be a thing. Having them be a thing breaks multiple things, like: - When importing from ZIPs with separate directory entries, a separate `RealmFile` is created for a directory entry even though it doesn't represent a real file - As a result, when re-exporting a model with files imported from such an archive, a zero-byte file would be created because to the database it looks like it was originally a zero-byte file. If you want to have fun, google "zip empty directories". You'll see a whole gamut of languages, libraries, and developers stepping on this rake. Yet another episode of underspecced mistakes from decades ago that were somebody's "good idea" but continue to wreak havoc forevermore because now there are two competing conventions you can't just pick one.	2024-03-12 09:06:24 +01:00
Bartłomiej Dach	961058f5c8	Add failing test case	2024-03-12 09:05:28 +01:00
Dean Herbert	83052fe1d9	Downgrade realm to work around crashes on latest release ... See https://github.com/ppy/osu/issues/27577.	2024-03-12 15:41:50 +08:00
Dean Herbert	45f9d722a5	Merge branch 'master' into osu-performance	2024-03-12 14:04:56 +08:00
jvyden	e4e7dd14f3	Revert "Update presence on changes to multiplayer room" ... This reverts commit 8b730acb08.	2024-03-11 18:16:13 -04:00
jvyden	5580ce31fa	Log Discord RPC updates	2024-03-11 18:15:18 -04:00
Dean Herbert	301750f77f	Merge pull request #27574 from bdach/fix-invalid-type ... Fix ruleset medals not displaying due to deserialisation failure	2024-03-12 05:20:22 +08:00
Bartłomiej Dach	f30dfcb728	Fix ruleset medals not displaying due to deserialisation failure ... 🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦🤦 Reported in https://discord.com/channels/188630481301012481/188630652340404224/1216812697589518386.	2024-03-11 21:34:10 +01:00
Bartłomiej Dach	9bc55be515	Merge pull request #27564 from EVAST9919/editor-blueprint-gradient ... Fix incorrect gradient application in `TimelineHitObjectBlueprint`	2024-03-11 16:02:05 +01:00
Bartłomiej Dach	2b40effbdb	Merge pull request #27541 from Joehuu/wrap-beatmap-listing-filters ... Wrap beatmap listing filters and match web spacing	2024-03-11 15:29:38 +01:00
Bartłomiej Dach	09179f99c0	Merge branch 'master' into wrap-beatmap-listing-filters	2024-03-11 14:59:48 +01:00
Bartłomiej Dach	e5e7c8f268	Wrap beatmap listing filter names too ... While we're here fixing... Addresses https://github.com/ppy/osu/discussions/15452#discussioncomment-2734237.	2024-03-11 14:58:28 +01:00
Salman Ahmed	8b730acb08	Update presence on changes to multiplayer room	2024-03-11 13:16:00 +03:00
Salman Ahmed	169e2e1b4e	Change maximum room number to closest powers of two	2024-03-11 13:16:00 +03:00
Dean Herbert	226df7163e	Update client ID	2024-03-11 16:55:49 +08:00
Dan Balasescu	e0f1f70b82	Adjust NRT to prevent future issues ... This way, it will yet at us if the setter is ever moved out of the ctor.	2024-03-11 15:52:40 +09:00
Dean Herbert	fc05268fc3	Apply NRT to DrawableOsuEditorRuleset too	2024-03-11 14:45:52 +08:00
Dean Herbert	091425db30	Fix nullability hint	2024-03-11 14:43:58 +08:00
Dean Herbert	d12b11e234	Revert "Remove local optimisation in DrawableHitObject" ... This reverts commit e3936930c7.	2024-03-11 13:14:29 +08:00
Dean Herbert	e3936930c7	Remove local optimisation in DrawableHitObject	2024-03-11 13:11:57 +08:00
Dean Herbert	f3d154a995	Add inline comment explaining optimisation	2024-03-11 11:28:15 +08:00
Dean Herbert	2be6d1f1c6	Apply NRT to OsuPlayfield	2024-03-11 11:26:03 +08:00
Salman Ahmed	283de215d3	Adjust log message and comment	2024-03-11 01:17:17 +03:00
Andrei Zavatski	6ecef33fd7	Fic incorrect ExtendableCircle gradient	2024-03-10 22:45:29 +03:00
Andrei Zavatski	6ff4b1d7e3	Don't update SubTreeMasking in OsuPlayfield	2024-03-10 15:42:03 +03:00
Dean Herbert	1ae8d341cc	Merge pull request #27556 from EVAST9919/editor-timing-alloc ... Reduce allocations in editor timing screen	2024-03-10 09:43:02 +08:00
Dean Herbert	36f99a0c5a	Merge branch 'master' into editor-timing-alloc	2024-03-10 09:03:24 +08:00
Dean Herbert	b07f903d63	Merge pull request #27558 from EVAST9919/argon-sound-test-scene	2024-03-10 09:01:05 +08:00
Andrei Zavatski	e08651668c	Fix TestSceneSkinnableSound failing	2024-03-09 21:55:00 +03:00
Andrei Zavatski	549a8d678e	Reduce allocations in ControlPointList	2024-03-09 20:50:54 +03:00
Dean Herbert	31739be499	Update resources	2024-03-09 20:48:57 +08:00
Dean Herbert	d74ae12321	Merge pull request #27551 from EVAST9919/flag-tooltip-alloc ... Reduce allocations while hovering `DrawableFlag`	2024-03-09 20:48:54 +08:00
Dean Herbert	b8a362fcb6	Simplify assignment by using an auto property	2024-03-09 20:17:27 +08:00
Andrei Zavatski	58b6acde10	Further simplify tooltip text creation	2024-03-09 14:10:32 +03:00
Andrei Zavatski	dd36942508	Reduce allocations in DrawableFlag tooltip	2024-03-09 13:58:05 +03:00