285 Commits

• Use similar method of consuming OnlineID as done in beatmap classes
  Dean Herbert · 2021-12-10 18:34:31 +09:00
  f7c5a3f506
• Add MatchesOnlineID implementation for IScoreInfo
  Dean Herbert · 2021-12-10 18:34:31 +09:00
  c9f6c5c673
• Remove OnlineID comparison from ScoreInfo.Equals

  This matches the implementation we have for `BeatmapInfo` and
  `BeatmapSetInfo`. All comparisons of `OnlineID` should be done directly
  using them (ie. how it's done in `ScoreModelDownloader`).

  Dean Herbert · 2021-12-10 18:17:43 +09:00
  5f6e887be7
• Change IScoreInfo.User to an interface type
  Dean Herbert · 2021-12-10 16:11:49 +09:00
  c6d0d6451d
• Use OnlineID for set operations
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  dbb08f7d46
• Add setter for ScoreInfo.OnlineID
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  7ac63485ef
• Use OnlineID instead of legacy IDs for equality and lookups
  Dean Herbert · 2021-12-10 16:11:48 +09:00
  bf1418bafc
• Merge branch 'master' into primary-key-consistency
  Dean Herbert · 2021-12-08 21:34:38 +09:00
  8d9c37a825
• Fix score encoder being dependent on current culture

  As it turns out, on some cultures, the "negative integer" sign is not
  encoded using the U+002D HYPHEN-MINUS codepoint. For instance, Swedish
  uses U+2212 MINUS SIGN instead. This was confusing the legacy decoder,
  since it is correctly depending on the serialisation being
  culture-independent.
  
  To fix, ensure that the special "end replay" frame, as well as the
  replay MD5 hash, are generated in a culture-invariant manner.
  
  Thankfully the replay MD5 hash is currently being discarded in
  `LegacyScoreDecoder`, so it changing in future scores should not have
  any negative effect on lazer operation.

  Bartłomiej Dach · 2021-12-04 17:13:43 +01:00
  f051720fa1
• Merge pull request #15795 from peppy/realm-integration/separate-download-flow

  Split out download logic from main manager classes

  Dan Balasescu · 2021-11-25 20:59:23 +09:00
  f712aeee01
• Remove unused using
  Dan Balasescu · 2021-11-25 19:36:06 +09:00
  8baf00c023
• Merge branch 'master' into realm-integration/stable-export-flow
  Dan Balasescu · 2021-11-25 19:06:18 +09:00
  d3a4890c31
• Remove unnecessary GameHost parameter
  Dean Herbert · 2021-11-25 17:42:41 +09:00
  eeccf836ec
• Move score download logic out of ScoreManager
  Dean Herbert · 2021-11-25 17:33:04 +09:00
  a2ab9f457d
• Split out legacy model export logic into LegacyModelExporter classes
  Dean Herbert · 2021-11-25 16:41:12 +09:00
  cc1b91e4bd
• Update all models to implement IHasNamedFiles
  Dean Herbert · 2021-11-25 16:41:12 +09:00
  7488ccd5fe
• Merge branch 'master' into realm-integration/stable-import-flow
  Dan Balasescu · 2021-11-25 16:36:02 +09:00
  6d60725b31
• Move stable import handling into its own class
  Dean Herbert · 2021-11-25 15:36:58 +09:00
  6cab7b877d
• Reduce interface exposure of ScoreManager
  Dean Herbert · 2021-11-25 14:34:13 +09:00
  60b207f20a
• Merge branch 'master' into remove-model-file-list-inits
  Dean Herbert · 2021-11-24 18:39:01 +09:00
  ddbd4f9473
• Update all actual usages of RulesetInfo.ID to use OnlineID instead
  Dean Herbert · 2021-11-24 15:50:26 +09:00
  bbd3ea5b77
• Initialise all file lists at construction time (and remove setter)
  Dean Herbert · 2021-11-24 13:56:21 +09:00
  99a139dc98
• Merge pull request #15705 from bdach/fix-difficulty-cache-caching-zeroes

  Fix zero star difficulty values being cached when diffcalc was interrupted

  Dan Balasescu · 2021-11-21 15:45:29 +09:00
  a06b361fe2
• Change difficulty cache storage type to nullable

  The recent changes related to adding support for working beatmap load
  cancellation exposed a flaw in the beatmap difficulty cache. With the
  way the difficulty computation logic was written, any error in the
  calculation process (including beatmap load timeout, or cancellation)
  would result in a 0.00 star rating being permanently cached in memory
  for the given beatmap.
  
  To resolve, change the difficulty cache's return type to nullable.
  In failure scenarios, `null` is returned, rather than
  `default(StarDifficulty)` as done previously.

  Bartłomiej Dach · 2021-11-20 17:00:50 +01:00
  15feb17da8
• Add IsManaged helper method to EF classes to match realm implementation
  Dean Herbert · 2021-11-19 21:56:06 +09:00
  eecf6ad558
• Move StoragePath implementation to an extension method
  Dean Herbert · 2021-11-19 16:08:38 +09:00
  59e763467f
• Rename method + xmldoc
  Dan Balasescu · 2021-11-17 20:45:48 +09:00
  9182eab486
• Expose LegacyScoreDecoder.CalculateAccuracy()
  Dan Balasescu · 2021-11-17 20:09:30 +09:00
  08f129b4c8
• Move ScoreInfo string representation to extension method
  Bartłomiej Dach · 2021-11-09 13:23:57 +01:00
  eba3cfc96e
• Merge branch 'master' into remove-stupid-weak-reference-bindable-events
  Dean Herbert · 2021-11-08 13:35:49 +09:00
  78aef9ce86
• Rename User to APIUser and move to correct namespace
  Dean Herbert · 2021-11-07 11:26:01 +09:00
  0ecf5f201c
• Fix incorrectly specified events
  Dean Herbert · 2021-11-06 22:31:49 +09:00
  89cc2523ef
• Merge branch 'master' into remove-stupid-weak-reference-bindable-events
  Dean Herbert · 2021-11-06 14:08:39 +09:00
  2881ce0f5a
• Revert weird event flow in model manager/importers
  Dean Herbert · 2021-11-05 19:12:49 +09:00
  54f72d68ca
• Move second generic to abstract model downloader rather than interface type
  Dean Herbert · 2021-11-05 17:37:05 +09:00
  6c385ccd29
• Change ModelDownloader's requirement to an IModelImporter rather than IModelManager
  Dean Herbert · 2021-11-05 16:47:18 +09:00
  1fe9bca819
• Remove importer inheritance from IModelManager

  Now only exists in legacy implementations, to reduce inheritance
  complexity of interfaces which are going to be used going forwards.

  Dean Herbert · 2021-11-05 16:45:38 +09:00
  b90f44493c
• Merge branch 'master' into score-refactor/isolated-serialisation
  Dean Herbert · 2021-11-01 15:49:25 +09:00
  b98faf6159
• Merge branch 'master' into beatmap-refactor/download-tracker
  Dean Herbert · 2021-11-01 13:15:36 +09:00
  19feae4a8e
• Remove misplaced access modifier in interface specification

  Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

  Dean Herbert · 2021-10-31 23:49:26 +09:00
  b63a90966b
• Mark IScoreInfo implementation with region
  Bartłomiej Dach · 2021-10-30 15:08:45 +02:00
  e9ba1ea198
• Merge branch 'master' into score-refactor/isolated-serialisation
  Bartłomiej Dach · 2021-10-30 15:07:34 +02:00
  8053b2c320
• Mark IHasOnlineID implementation with region
  Bartłomiej Dach · 2021-10-30 14:15:20 +02:00
  6e4f7af8d3
• Remove Statistics from interface until we figure how to properly deserialise
  Dean Herbert · 2021-10-29 14:18:10 +09:00
  cd7bd935f6
• Isolate score submissions model and remove serialisation from ScoreInfo
  Dean Herbert · 2021-10-29 14:13:43 +09:00
  54073d8a1e
• Implement score interfaces
  Dean Herbert · 2021-10-29 13:49:30 +09:00
  1944c255a7
• Extract interface
  Dean Herbert · 2021-10-29 13:41:21 +09:00
  49b5de64be
• Allow for long online IDs and implement in ScoreInfo
  Dean Herbert · 2021-10-29 11:48:36 +09:00
  34d4715220
• Refactor ModelDownloader to allow for different OnlineID matching
  Dean Herbert · 2021-10-27 21:00:46 +09:00
  617e6febb6
• Implement new version of download tracker
  Dean Herbert · 2021-10-27 21:00:46 +09:00
  9015ac6ba8