1
0
mirror of https://github.com/ppy/osu.git synced 2024-12-14 07:42:57 +08:00
osu-lazer/osu.Game/Scoring
Bartłomiej Dach 15feb17da8
Change difficulty cache storage type to nullable
The recent changes related to adding support for working beatmap load
cancellation exposed a flaw in the beatmap difficulty cache. With the
way the difficulty computation logic was written, any error in the
calculation process (including beatmap load timeout, or cancellation)
would result in a 0.00 star rating being permanently cached in memory
for the given beatmap.

To resolve, change the difficulty cache's return type to nullable.
In failure scenarios, `null` is returned, rather than
`default(StarDifficulty)` as done previously.
2021-11-20 17:00:50 +01:00
..
Legacy Rename method + xmldoc 2021-11-17 20:45:48 +09:00
HitResultDisplayStatistic.cs Extract tuple into class 2020-10-07 15:34:03 +09:00
IScoreInfo.cs Rename User to APIUser and move to correct namespace 2021-11-07 11:26:01 +09:00
LegacyDatabasedScore.cs Apply batch fixing of built-in types using var 2021-10-27 13:04:41 +09:00
Score.cs Add deep cloning support to Score/ScoreInfo/Replay 2021-07-19 14:14:28 +09:00
ScoreFileInfo.cs Update licence header (and remove year) 2019-01-24 17:43:03 +09:00
ScoreInfo.cs Move ScoreInfo string representation to extension method 2021-11-09 13:23:57 +01:00
ScoreInfoExtensions.cs Move ScoreInfo string representation to extension method 2021-11-09 13:23:57 +01:00
ScoreManager.cs Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
ScoreModelDownloader.cs Move second generic to abstract model downloader rather than interface type 2021-11-05 17:37:05 +09:00
ScoreModelManager.cs Split out IModelDownloader and also split apart ScoreManager 2021-09-30 18:25:20 +09:00
ScorePerformanceCache.cs Change difficulty cache storage type to nullable 2021-11-20 17:00:50 +01:00
ScoreRank.cs Update mapper usages with LocalisableDescription 2021-07-31 01:47:14 +03:00
ScoreStore.cs Rename last remaining BeatmapInfo Beatmap usage 2021-10-04 17:35:53 +09:00