99 Commits

• Don't include nested hit objects' DifficultyControLPoints in legacy encoder logic

  The editor doesn't currently propagate velocity to nested objects. We're
  not yet sure whether it should or not. For now, let's just ignore nested
  objects' `DifficultyControlPoints` for simplicity.
  
  Note that this only affects osu! ruleset due to the pre-check on
  `isOsuRuleset`.

  Dean Herbert · 2022-01-24 19:54:08 +09:00
  c3758047fd
• Replace TimeSignatures enum with struct for storage of arbitrary meter
  Bartłomiej Dach · 2022-01-22 20:50:31 +01:00
  735414bc49
• Update null fallback cases involving OnlineID
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  213d89b479
• Rename BeatmapSetInfo.OnlineBeatmapSetID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:52:44 +09:00
  692e846acd
• Rename BeatmapInfo.OnlineBeatmapID to OnlineID to match interface
  Dean Herbert · 2021-11-12 17:46:24 +09:00
  6a098a8634
• Rename BeatmapInfo.Version to DifficultyName to match underlying interface
  Dean Herbert · 2021-11-11 17:20:53 +09:00
  51a353e12d
• Update all existing usages of AuthorString/AuthorId

  Unfortunately the getters need to be left in place else EF breaks.

  Dean Herbert · 2021-11-04 18:59:37 +09:00
  ed07ee8c61
• Fix new inspections
  Dean Herbert · 2021-11-04 14:02:09 +09:00
  67d9590a79
• Apply batch fixing of built-in types using var
  Dean Herbert · 2021-10-27 13:04:41 +09:00
  6944151486
• Fix LegacyBeatmapEncoder using incorrect path length value
  Dean Herbert · 2021-10-26 17:34:52 +09:00
  e92def0ba2
• Merge branch 'master' into no-more-difficulty-control-points-info
  smoogipoo · 2021-10-08 18:41:17 +09:00
  bc37cb6f43
• Copy BaseDifficulty to Beatmap<T> and move all write operations across
  Dean Herbert · 2021-10-06 15:10:45 +09:00
  b339c149d8
• Merge branch 'master' into no-more-difficulty-control-points-info
  Dean Herbert · 2021-09-28 13:53:56 +09:00
  46bafb6252
• Collect and sort points from nested objects before extracting
  Bartłomiej Dach · 2021-09-18 14:38:38 +02:00
  76ccdd1340
• Move difficulty -> effect point conversion back to decoder
  Bartłomiej Dach · 2021-09-18 14:38:38 +02:00
  8026968939
• Add encoding support for SamplesMatchPlaybackRate
  Bartłomiej Dach · 2021-09-12 16:47:38 +02:00
  af7c2b93e6
• Handle control point flattening of nested hit objects
  Dean Herbert · 2021-09-10 17:29:09 +09:00
  943e0d49f7
• Move mania-specific conversion to converter
  Dean Herbert · 2021-09-06 21:06:13 +09:00
  3c7a34bdbd
• Replace todo with permanent comment
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  0e6660da30
• Populate new approach rate where required
  Dean Herbert · 2021-09-03 17:11:12 +09:00
  d587dc6203
• Move approach rate to EffectControlPoint
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  a3d9ab1e2e
• Update decoder to also extract DifficultyControlPoints from HitObjects
  Dean Herbert · 2021-09-03 16:58:16 +09:00
  4eb09ea1a9
• Remove outdated TODO
  Dean Herbert · 2021-08-31 14:51:19 +09:00
  9fa8bee094
• Merge branch 'remove-ijsonserializable' into no-more-sample-control-points-info
  Dean Herbert · 2021-08-31 14:40:54 +09:00
  ce0d7cce2d
• Add new control point to legacy regeneration logic
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  d35c4da906
• Move samples to LegacyControlPointInfo
  Dean Herbert · 2021-08-30 17:14:53 +09:00
  7257aae7f2
• Update inline comment to point to new variable location

  Co-authored-by: PercyDan <50285552+PercyDan54@users.noreply.github.com>

  Dean Herbert · 2021-08-30 16:27:24 +09:00
  da7a871afa
• Move taiko legacy speed multiplier to osu.Game project

  Allows it to be used in local case in `LegacyBeatmapEncoder`.

  Dean Herbert · 2021-08-30 15:13:31 +09:00
  ee49305cad
• Remove bindable usage in PathControlPoint

  This is quite a breaking change, but I think it is beneficial due to the large amount of usage of this class.
  
  I originally intended just to remove the allocations of the two delegates handling the `Changed` flow internally, but as nothing was really using the bindables for anything more than a general "point has changed" case, this felt like a better direction.

  Dean Herbert · 2021-08-26 12:33:53 +09:00
  6dcd9427ac
• Add countdown settings to beatmap info model
  Bartłomiej Dach · 2021-08-24 21:55:10 +02:00
  a6c2cbd2e5
• Enable epilepsy warning setting persistence in encoder
  Bartłomiej Dach · 2021-08-22 17:43:20 +02:00
  d602dc9d90
• Preserve Y position of hit objects in osu!catch
  ekrctb · 2021-07-14 14:38:38 +09:00
  7f432665e5
• Fix legacy encoder
  smoogipoo · 2021-04-09 15:28:42 +09:00
  9b0ce2999f
• Add tests for consecutive perfect-curve segments
  Leon Gebler · 2021-04-06 13:32:17 +02:00
  dd902441b0
• Always encode perfect curves as explicit segments
  Leon Gebler · 2021-04-06 13:29:31 +02:00
  d81f270e21
• Fix floating point error in slider path encoding
  smoogipoo · 2021-04-06 14:10:59 +09:00
  a2544100d4
• Fix legacy beatmap encoding
  smoogipoo · 2021-04-05 19:59:54 +09:00
  d0510222ae
• Fix a couple of new inspections introduced in Rider EAPs
  Dean Herbert · 2021-03-15 13:35:08 +09:00
  6d4c1ba2ae
• Make HitSampleInfo immutable
  smoogipoo · 2020-12-01 15:37:51 +09:00
  5760e1c1fc
• Always write [HitObjects] to file

  I think this is expected. If not, there's an alternative solution.

  Dean Herbert · 2020-11-08 00:18:27 +09:00
  c5b6908e71
• Resolve CA1834 inspection

  "Use `StringBuilder.Append(char)` instead of
  `StringBuilder.Append(string)` when the input is a constant unit string"

  Bartłomiej Dach · 2020-11-01 18:50:13 +01:00
  ca5de22ca5
• Change types back
  Craftplacer · 2020-09-01 17:58:06 +02:00
  c2ade44656
• Update LegacyBeatmapEncoder.cs
  Craftplacer · 2020-08-31 17:24:03 +02:00
  fb37a14d57
• Update osu.Game/Beatmaps/Formats/LegacyBeatmapEncoder.cs

  Co-authored-by: Salman Ahmed <email@iisalman.me>

  Craftplacer · 2020-08-30 16:11:49 +02:00
  7e668fc31a
• Fix xmldoc in LegacyBeatmapEncoder
  Craftplacer · 2020-08-30 16:07:58 +02:00
  1fdf8e6200
• Use IBeatmapSkin
  Craftplacer · 2020-08-30 11:34:50 +02:00
  e428144f73
• Resolve review comments
  Craftplacer · 2020-08-23 15:08:02 +02:00
  e6646b9877
• Add required parameters and other various changes
  Craftplacer · 2020-08-15 22:03:24 +02:00
  c4a7fac760
• Handle additional null case
  Craftplacer · 2020-08-12 06:40:21 +02:00
  8ffaa49839
• Add documentation for constructor
  Craftplacer · 2020-08-12 06:40:21 +02:00
  139c0c75f8