458 Commits

• Remove Task from the inner-most Import method in RealmArchiveModelImporter

  One of my pending work items for post-realm merge.
  
  The lowest-level import task is no longer asynchronous, as we don't want
  it to span multiple threads to allow easier interaction with realm.
  Removing the `Task` spec simplifies a heap of usages.
  
  Individual usages should decide whether they want to run the import
  asynchronously, by either using an alternative override or spooling up a
  thread themselves.

  Dean Herbert · 2022-01-25 15:30:29 +09:00
  778d2a71b4
• Update remaining cases of clashing variable name in realm.Run(realm..
  Dean Herbert · 2022-01-25 13:04:05 +09:00
  e23b10e6a5
• Rename RealmContextFactory to RealmAccess
  Dean Herbert · 2022-01-24 20:38:07 +09:00
  6eb2c28e41
• Add forced refresh on GetAllUsableBeatmapSets()

  This is commonly used in tests in a way where it's not feasible to
  guarantee correct results unless a refresh is called. This method
  shouldn't really be used outside of tests anyway, but that's for a
  folow-up effort.

  Dean Herbert · 2022-01-21 17:33:29 +09:00
  495636538f
• Update all usages of CreateContext to use either Run or Write
  Dean Herbert · 2022-01-21 17:27:08 +09:00
  114c9e8c1f
• Fix various cases of creating realm contexts from update thread when not necessary
  Dean Herbert · 2022-01-21 01:44:56 +09:00
  a5d2047f05
• Merge pull request #16505 from peppy/remove-base-difficulty-usage

  Remove all usage of `BaseDifficulty` (and access `Difficulty` instead)

  Dan Balasescu · 2022-01-19 13:53:55 +09:00
  3e5d29ed00
• Avoid file retrieval overhead when detaching BeatmapSetInfo

  It seems that no usages of `BeatmapSetInfo` detaches require files - a
  `WorkingBeatmap` is always obtained before doing further lookups.
  
  Therefore we can omit this include unless the detaching object is a
  `BeatmapInfo`. A refetch is performed when retrieving a
  `WorkingBeatmap` to complete the equation.

  Dean Herbert · 2022-01-19 00:49:18 +09:00
  60b80c88b6
• Remove all usage of BaseDifficulty (and access Difficulty instead)
  Dean Herbert · 2022-01-18 22:57:39 +09:00
  7f65f3a47f
• Move manager Update methods to be explicit to where they are still used by legacy code

  Also fixes skin hash repopulation being completely broken.

  Dean Herbert · 2022-01-12 17:49:11 +09:00
  a4de0f93fa
• Fix protected beatmap sets getting deleted
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  157dfdaa82
• Fix beatmap restore/undelete flows
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  72656ae01e
• Fix beatmap mass deletion flow
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  46206f70d6
• Add refetch for non-managed hide/restore attempts
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  d5239d550a
• Clean up BeatmapManager query methods
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  46e92c3b60
• Remove hide/restore event flow
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  9beabad6a4
• Fix multiple remaining warnings
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  c06b5951fd
• Update BeatmapModelManager.Save to work for editor scenarios
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  7509a9ff8f
• Fix incorrect realm access after new beatmap import
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  8c3dc4333d
• Fix multiple tests via null checks and changing ToLive to Detach

  flow

  Dean Herbert · 2022-01-12 17:00:17 +09:00
  e74a5022c9
• BeatmapSetInfo detach support
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8461eaab46
• Remove updated/removed flow method mapping
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  fe8a5e867d
• Update ToLive usages in line with recent changes
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  1f9318265e
• Remove unused includeProtected parameter
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  db05727ec4
• Inline query methods from BeatmapModelManager to BeatmapManager where possible
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  b91f309879
• Start introducing ILive
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  1d536fd0bc
• Fix intro screen

  Fix things

  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8696f82627
• Apply NRT to BeatmapManager and move Hide/Restore methods across
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  c4a9211179
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• Various updates to ruleset and primary key usages to move closer to realm support
  Dean Herbert · 2022-01-12 16:57:13 +09:00
  b8cd3cdbbc
• Remove EF FileStore
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  116f35c52a
• Use RealmContextFactory instead of EF
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  89d6ffa7f3
• Remove unnecessary assigns of BeatmapSetInfo.Metadata
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  6a671b0a52
• Update usages of APIUser to RealmUser
  Dean Herbert · 2022-01-12 16:39:36 +09:00
  fda529de26
• Update usages to new naming
  Dean Herbert · 2022-01-06 22:54:43 +09:00
  00177a3ae1
• Replace usage of .Result with .WaitSafelyForResult
  Dean Herbert · 2022-01-04 11:51:41 +09:00
  73b40e6833
• Remove the ability to specify a filename in ReplaceFile
  Dean Herbert · 2021-11-29 18:11:51 +09:00
  a7e4e7be3a
• Merge pull request #15795 from peppy/realm-integration/separate-download-flow

  Split out download logic from main manager classes

  Dan Balasescu · 2021-11-25 20:59:23 +09:00
  f712aeee01
• Move beatmap download logic out of BeatmapManager
  Dean Herbert · 2021-11-25 17:29:41 +09:00
  716543b5b3
• Split out legacy model export logic into LegacyModelExporter classes
  Dean Herbert · 2021-11-25 16:41:12 +09:00
  cc1b91e4bd
• Move stable import handling into its own class
  Dean Herbert · 2021-11-25 15:36:58 +09:00
  6cab7b877d
• Merge pull request #15779 from peppy/remaining-misc-fixes

  Apply some various code quality fixes that don't fit elsewhere

  Dan Balasescu · 2021-11-24 16:59:49 +09:00
  5ff62a8e04
• Remove unnecessary mainTrackMixer parameter from BeatmapManager
  Dean Herbert · 2021-11-24 16:27:17 +09:00
  9c61ec217b
• Initialise BeatmapSet.Beatmaps list to line up with realm expectations
  Dean Herbert · 2021-11-24 13:25:55 +09:00
  49c2cb9125
• Update all simple cases of switching to IWorkingBeatmap
  Dean Herbert · 2021-11-17 20:56:57 +09:00
  7c2e79f911
• Rewrite PreviewTrackManager to avoid constructing TrackBass locally

  This paves the way for the framework code quality change
  (https://github.com/ppy/osu-framework/pull/4873) which stops exposing
  the constructor.
  
  Most of the restructuring here is required to give `PreviewTrackManager`
  an adjustable target to apply the global mute.

  Dean Herbert · 2021-11-09 17:38:12 +09:00
  3b485b5f37
• Merge branch 'master' into remove-stupid-weak-reference-bindable-events
  Dean Herbert · 2021-11-08 13:35:49 +09:00
  78aef9ce86
• Update remaining actions to events
  Dean Herbert · 2021-11-07 11:34:37 +09:00
  f0809801c5
• Fix incorrectly specified events
  Dean Herbert · 2021-11-06 22:31:49 +09:00
  89cc2523ef
• Merge branch 'master' into remove-stupid-weak-reference-bindable-events
  Dean Herbert · 2021-11-06 14:08:39 +09:00
  2881ce0f5a