h1or4dme8/osu-lazer
1
0
Fork 0
mirror of https://github.com/ppy/osu.git synced 2024-12-20 01:32:56 +08:00
Code Issues Releases Wiki Activity
37,605 Commits 5 Branches 664 Tags 365 MiB
bdc783b55f
Commit Graph

37605 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Bartłomiej Dach
96f56d1c94 Return tracker lease via UnbindAll() 
Improves reliability by being fail-safe in case of multiple returns,
which can happen if the operation tracker is part of a screen being
exited (as is the case with its current primary usage in multiplayer).
 2021-01-30 21:00:13 +01:00
Bartłomiej Dach
0aaa62efc2 Add failing test case 2021-01-30 20:55:56 +01:00
Bartłomiej Dach
c3ba92f057 Set canceled result in scheduleAsync 
Was holding up the task completion source, and in consequence,
potentially the entire task chain.
 2021-01-30 16:13:50 +01:00
Bartłomiej Dach
9ab1ad25eb Merge branch 'master' into fix-leave-room-race-2 2021-01-30 13:41:04 +01:00
Bartłomiej Dach
fec3bd898e
Merge pull request #11500 from peppy/fix-skin-dropdown-update-crash 2021-01-30 13:34:00 +01:00
Bartłomiej Dach
6a1387191a
Merge branch 'master' into fix-skin-dropdown-update-crash 2021-01-30 13:01:52 +01:00
Bartłomiej Dach
ae08ef2543 Reset SPM counter state on DHO application 2021-01-29 20:32:45 +01:00
Bartłomiej Dach
44e88f09e5
Merge pull request #11625 from peppy/fix-beatmap-cache-lookup-null-failure 
Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present
 2021-01-29 18:58:00 +01:00
Dean Herbert
d521bfc251 Don't directly update HandleUserInput (as it is used by mods) 2021-01-30 02:35:11 +09:00
Dean Herbert
5a306dfc2b Fix unused using 2021-01-29 20:22:25 +09:00
Dean Herbert
f25809d35f Ensure spinners only handle input during their hittable time 
While this was already being enforced inside of `CheckForResult`, the
internal tracking values of rotation were still being incremented as
long as the `DrawableSpinner` was present. This resulted in incorrect
SPM values being displayed if a user was to start spinning before the
object's `StartTime`.

Kind of annoying to write a test for (there's no setup for spinners yet)
but am willing to do so if that is deemed necessary.

Closes https://github.com/ppy/osu/issues/11600.
 2021-01-29 19:55:55 +09:00
Dean Herbert
16f3d1815f Fix SQLite exception thrown is a beatmap lookup is attempted without an OnlineBeatmapID present 
It turns out the SQLite API isn't smart enough to handle nullables
directly, so we need to help it out a bit.

Stops the following from being thrown:

```
System.InvalidOperationException: Value must be set.
   at Microsoft.Data.Sqlite.SqliteParameter.Bind(sqlite3_stmt stmt) = 3
at
   at Microsoft.Data.Sqlite.SqliteParameterCollection.Bind(sqlite3_stmt
stmt) = 3 at
   at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader(CommandBehavior
behavior)
   at Microsoft.Data.Sqlite.SqliteCommand.ExecuteReader()
   at
osu.Game.Beatmaps.BeatmapManager.BeatmapOnlineLookupQueue.checkLocalCache(BeatmapSetInfo
set, BeatmapInfo beatmap) in
/Users/dean/Projects/osu/osu.Game/Beatmaps/BeatmapManager_BeatmapOnlineLookupQueue.cs:line
166 = 166
```
 2021-01-29 19:53:57 +09:00
Dan Balasescu
cd8ef5373d
Merge pull request #11622 from peppy/remove-unobserved-exception-handling 
Remove all usage of CatchUnobservedExceptions
 2021-01-29 19:31:07 +09:00
Dean Herbert
d52376cc17
Merge pull request #11623 from Firmatorenio/apply-sv-to-taiko-diffadjust 
Add scroll speed adjustment to taiko's DifficultyAdjust mod
 2021-01-29 19:25:17 +09:00
Dean Herbert
18e6afbec0 Ensure the item is present before trying to select it 2021-01-29 19:17:12 +09:00
Dean Herbert
1ce383fc20 Merge branch 'master' into fix-skin-dropdown-update-crash 2021-01-29 19:16:20 +09:00
smoogipoo
ab9a3e6dd0 Pass allowed mods and consume on server callback 2021-01-29 18:21:22 +09:00
Firmatorenio
37ef5c7072 rename SliderVelocity to ScrollSpeed 2021-01-29 15:04:55 +06:00
Dean Herbert
a61444690e Remove all usage of CatchUnobservedExceptions 
This should no longer be required with the recent framework side change
that stops a game from crashing on unobserved exceptions
(https://github.com/ppy/osu-framework/pull/4171).
 2021-01-29 16:32:29 +09:00
Dean Herbert
c3aec3bfe4 Revert test changes to test original class/scope 
Importantly, this removes the call to CatchUnobservedExceptions(), which was
outright incorrect (awaiting on the wrong task as a result) in the
original test code.
 2021-01-29 16:20:26 +09:00
Dean Herbert
1ec305e10d Update TaskChain to use ContinueWithSequential internally 
It turns out we may still want to use TaskChain for its locking
behaviour, so I've made it internally use the refactored version I
implemented, while keeping the general structure.
 2021-01-29 16:19:46 +09:00
Firmatorenio
449f883be1 add SV multiplier adjustment to TaikoModDifficultyAdjust 2021-01-29 11:48:51 +06:00
Dan Balasescu
4c4770bf4b
Merge pull request #11618 from vltspr/catch-auto-fix 
Fix Catch autoplay rewinding on instantaneous hits
 2021-01-29 12:17:46 +09:00
Corentin PALLARD
d168de0ae3 Formatting 2021-01-29 03:03:23 +01:00
Corentin PALLARD
da4c207a73 Fix the ctb auto mod speedup in some occasions 2021-01-29 02:53:26 +01:00
Bartłomiej Dach
1d76cfe585
Merge pull request #11615 from peppy/ios-signalr-use-json 2021-01-29 00:04:16 +01:00
Bartłomiej Dach
0f1d72e073 Merge branch 'master' into ios-signalr-use-json 2021-01-28 23:28:49 +01:00
Bartłomiej Dach
c592c80a07
Merge pull request #11616 from peppy/fix-ios-beatmap-cache-lookups 
Avoid using Dapper to fix iOS compatibility of beatmap lookup cache
 2021-01-28 23:17:54 +01:00
Bartłomiej Dach
386f9f7842 Fix typos in comments 2021-01-28 22:36:07 +01:00
Bartłomiej Dach
8afd1bce21
Merge branch 'master' into fix-ios-beatmap-cache-lookups 2021-01-28 22:33:58 +01:00
Dean Herbert
34f8e4b672
Merge pull request #11613 from bdach/order-attribute-move 
Remove game-local enum `[Order]` attribute
 2021-01-29 00:41:43 +09:00
Dean Herbert
87e23d22cf
Merge pull request #11611 from frenzibyte/fix-package-downgrade 
Fix dotnet run/publish with runtime specified not working again
 2021-01-29 00:18:27 +09:00
Dean Herbert
a616688a47 Update framework 2021-01-28 23:55:03 +09:00
Dean Herbert
c3d4044017 Avoid using Dapper to fix iOS compatibility of beatmap lookup cache 2021-01-28 16:53:56 +09:00
Dean Herbert
90a82f986b Fallback to using json for signalr communication if JIT is unavailable 2021-01-28 16:20:19 +09:00
Bartłomiej Dach
2c08ce05fa Remove game-local enum [Order] attribute 
In favour of the newly-added framework one.
 2021-01-27 22:29:52 +01:00
Salman Ahmed
63f057a525 Fix dotnet run/publish with runtime specified not working again 2021-01-27 20:45:52 +03:00
Dean Herbert
15e455231e
Merge pull request #11610 from peppy/update-framework 
Update framework
 2021-01-27 23:56:08 +09:00
Dean Herbert
45395cb5e8 Update framework 2021-01-27 23:00:14 +09:00
smoogipoo
b79d1c7b81 Add mods to footer 2021-01-27 22:33:03 +09:00
smoogipoo
ff8ee379fb Fix possible nullref 2021-01-27 22:27:31 +09:00
smoogipoo
c408b46a21 Add AllowedMods to MultiplayerRoomSettings model 2021-01-27 22:25:14 +09:00
smoogipoo
4c256f1fb3 Actually populate the playlist item 2021-01-27 22:23:38 +09:00
smoogipoo
45e41aaeac Initial implementation of freemod selection overlay 2021-01-27 22:15:53 +09:00
smoogipoo
4019cc38e5 Allow footer buttons to be customised 2021-01-27 22:03:51 +09:00
smoogipoo
91d34d86f7 Abstractify ModSelectOverlay 2021-01-27 22:02:23 +09:00
smoogipoo
0ff300628e Fix type not being set 2021-01-27 20:07:22 +09:00
Dean Herbert
a30aecbafe Comment and add xmldoc 2021-01-27 20:01:21 +09:00
smoogipoo
f2fa51bf5e Make ModSections overrideable 2021-01-27 19:59:28 +09:00
Dean Herbert
fcfb0d52c2 Proposal to use extension method instead of TaskChain class 2021-01-27 19:50:16 +09:00