138 Commits

• Fix xmldoc reference fail at CI
  Dean Herbert · 2023-02-08 15:39:18 +09:00
  4fdba880b1
• Reword xmldoc to read better
  Dean Herbert · 2023-02-08 14:20:58 +09:00
  5c113ddb03
• Fix minor formating issues
  Cootz · 2023-02-08 05:50:52 +03:00
  086b3eb542
• Fix a typo
  Cootz · 2023-02-08 05:42:06 +03:00
  ab7c9a200b
• Add warning for ScoreInfo
  Cootz · 2023-02-08 05:40:20 +03:00
  6bf56aff73
• Fix CSharpWarnings::CS1574,CS1584,CS1581,CS1580
  Cootz · 2023-02-08 05:23:42 +03:00
  391af2791b
• Update reference
  PC · 2023-02-07 11:52:47 +03:00
  7e127dafe2
• Update osu.Game/Scoring/ScoreInfo.cs

  Co-authored-by: Dean Herbert <pe@ppy.sh>

  Cootz · 2023-02-07 11:23:39 +03:00
  957c9e7e27
• Add summary for OriginalBeatmapHash
  Cootz · 2023-02-07 02:43:27 +03:00
  723f13af25
• Add OriginalBeatmapHash to ScoreInfo. Update db schema_version, migration
  Cootz · 2023-02-05 21:46:38 +03:00
  4598112586
• Fix the MOTHERLOAD of undetected issues that are now visible thanks to net6.0
  Dean Herbert · 2022-12-16 18:16:26 +09:00
  27c497145f
• Hide spinner ticks / bonus from results screen when not applicable to score
  Dean Herbert · 2022-11-21 14:20:36 +09:00
  93a189603a
• Fix mods potentially keeping reference to runtime gameplay elements

  As noticed by smoogipoo during multiplayer match on the weekend.

  Dean Herbert · 2022-09-19 12:18:46 +09:00
  0a625bd879
• Ensure clones don't reference to MaximumStatistics
  Dan Balasescu · 2022-08-25 13:58:58 +09:00
  17029f0b92
• Add maximum statistics to ScoreInfo/SoloScoreInfo
  Dan Balasescu · 2022-08-24 17:28:41 +09:00
  f70af779a4
• Update naming
  Dean Herbert · 2022-07-18 16:17:20 +09:00
  51f91fe62e
• Store user country on databased scores
  Salman Ahmed · 2022-07-16 06:39:05 +03:00
  4e7156cee8
• Standardise HasReplay implementation (and remove from persisting to realm)
  Dean Herbert · 2022-07-15 16:14:21 +09:00
  c8c79d2185
• Automated #nullable processing
  Dan Balasescu · 2022-06-17 16:37:17 +09:00
  f8830c6850
• Obsolete BeatmapInfo.MaxCombo and suppress in usages
  Salman Ahmed · 2022-03-20 16:30:29 +03:00
  b9859f9f21
• Fix ScoreInfo.RealmUser not getting deep cloned correctly

  I'm still not at all happy with the play-to-results flow (with multiple
  clones), but this will have to do for now.

  Dean Herbert · 2022-01-26 14:27:48 +09:00
  3491b77c8c
• Avoid constructor overhead for realm ScoreInfo parameterless constructor
  Dean Herbert · 2022-01-20 16:47:27 +09:00
  3c852e6d02
• Use empty string instead of empty array for ModsJson when no mods are present

  Not really correct, but this is how most scores have been stored until
  now so let's do this for consistency.

  Dean Herbert · 2022-01-19 14:34:27 +09:00
  18886f5d2e
• Fix legacy score imports not correctly getting classic mod assigned
  Dean Herbert · 2022-01-19 14:34:27 +09:00
  664b4fdaf0
• Add ignore rules on more helper properties
  Dean Herbert · 2022-01-19 09:46:45 +09:00
  3bc091fe6d
• Improve reliability of mod deserialisation
  Dean Herbert · 2022-01-18 15:46:27 +09:00
  a5862ca00d
• Update automapper spec in line with v11

  See https://docs.automapper.org/en/latest/11.0-Upgrade-Guide.html for
   more details.

  Dean Herbert · 2022-01-18 15:23:28 +09:00
  9a43ed742b
• Initialise all parameters is paramaterless constructor for now for added safety
  Dean Herbert · 2022-01-17 13:51:30 +09:00
  744084b418
• Ensure detached when performing model Clone operations on BeatmapInfo/ScoreInfo
  Dean Herbert · 2022-01-14 13:08:20 +09:00
  9b33fbbee5
• Fix scores not using correct filename/display strings

  I've updated all cases where we should have been using
  `GetDisplayString()` anyway, but left the `ToString()` implementations
  in place for safety. They should probably be removed in the future.

  Dean Herbert · 2022-01-13 16:56:11 +09:00
  c61419dfe5
• Sanitise mods / statistics cache logic in ScoreInfo
  Dean Herbert · 2022-01-13 12:59:16 +09:00
  65dd80e6f6
• Fix potential mod nullref in APIUserScoreAggregate's CreateScoreInfo implementation
  Dean Herbert · 2022-01-13 00:28:16 +09:00
  4c79145c11
• Replace compatibility properties with direct references
  Dean Herbert · 2022-01-12 18:13:14 +09:00
  eb70a1eeb7
• Update null allowances across beatmaps and scores
  Dean Herbert · 2022-01-12 17:49:11 +09:00
  f451560203
• Add support for persisting score's mods to realm
  Dean Herbert · 2022-01-12 17:49:10 +09:00
  ae8f522c20
• Fix ScoreInfo oversights causing automapper to fail

  Parameter in ctor *has* to be named `realmUser` else automapper will try
  to map to the `User` property.

  Dean Herbert · 2022-01-12 17:48:49 +09:00
  ba62d2c756
• Mention safety failures of Beatmap/Score constructors
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  83ccbc1d13
• Better handle Statistics to avoid losing data
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  13401a8846
• Handle ignored mappings locally in Detach configuration
  Dean Herbert · 2022-01-12 17:00:17 +09:00
  aaefd72c69
• Detach and reattach scores to make work
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  2b8706b6ce
• Fix many shortcomings and compatibility issues with EF classes post-rename
  Dean Herbert · 2022-01-12 17:00:16 +09:00
  8d943b5709
• Update model manager and many related classes to get things compiling again
  Dean Herbert · 2022-01-12 17:00:00 +09:00
  00e3af3366
• more fixes (almost compiles, except ruleset and manager)
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  53792811b2
• Update many score-related classes to move closer to being able to persist to realm
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  2a4bee61dd
• Add required properties for compatibility with existing code
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  e44751c275
• Add statistics storage to realm model
  Dean Herbert · 2022-01-12 16:57:27 +09:00
  638b3d9161
• Replace EF ScoreInfo with realm version

  May contain errors.

  Dean Herbert · 2022-01-12 16:57:27 +09:00
  3da762e145
• Use similar method of consuming OnlineID as done in beatmap classes
  Dean Herbert · 2021-12-10 18:34:31 +09:00
  f7c5a3f506
• Remove OnlineID comparison from ScoreInfo.Equals

  This matches the implementation we have for `BeatmapInfo` and
  `BeatmapSetInfo`. All comparisons of `OnlineID` should be done directly
  using them (ie. how it's done in `ScoreModelDownloader`).

  Dean Herbert · 2021-12-10 18:17:43 +09:00
  5f6e887be7
• Change IScoreInfo.User to an interface type
  Dean Herbert · 2021-12-10 16:11:49 +09:00
  c6d0d6451d