70001 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Bartłomiej Dach	b78e7d5d9a	Fix multiplayer song select not correctly applying filter sometimes ... Fixes the root client-side failure causing https://github.com/ppy/osu/issues/30415. Thread of breakage is as follows: 1. `SongSelect` loads the carousel. At this point, the ruleset is what the ambient ruleset would have been at the time of pushing song select, so most likely it will match the current ruleset. Notably, the carousel is loaded with `AllowSelection == false`. 2. `OnlinePlaySongSelect` sets the ruleset to the one taken from the relevant playlist item in `LoadComplete()`. 3. At any point between the previous and the next step, the user changes the ruleset manually. 4. `SongSelect.carouselBeatmapsLoaded()` is ran, which calls `transferRulesetValue()`, which calls `FilterControl.FilterChanged`. But at this stage `Carousel.AllowSelection` is still false, so the filter is not executed, but `pendingFilterApplication` is set instead. Unfortunately, the pending filter never gets applied after that. The only place that checks that flag is `OnEntering()`, which at this point has already ran. To fix, move the `pendingFilterApplication` check to `Update()`, which seems like the most obvious and safe solution.	2024-10-25 21:29:53 +02:00
Bartłomiej Dach	36bcc5896c	Add failing test case	2024-10-25 21:29:49 +02:00
Dean Herbert	47aa2c2bfc	Merge pull request #29648 from OliBomby/auto-addition2 ... Add support for the auto sample addition bank in the editor	2024-10-25 16:15:52 +09:00
OliBomby	88e88bdc4f	Fix addition banks disabled on reset	2024-10-24 13:17:49 +02:00
OliBomby	5b92a9ff59	Fix enabled state not updating drawable	2024-10-24 13:15:09 +02:00
Dean Herbert	940220b649	Fix big oops	2024-10-24 19:57:39 +09:00
Dean Herbert	a039ee8305	Merge pull request #30408 from OliBomby/clean-editor-test ... Move TestTouchInputAfterTouchingComposeArea to separate test scene	2024-10-24 18:42:41 +09:00
Dean Herbert	787d3dceea	Merge branch 'master' into auto-addition2	2024-10-24 18:40:27 +09:00
Dean Herbert	77bd0e8d70	Add visual disabled state to ternary buttons	2024-10-24 18:36:34 +09:00
OliBomby	ddbeb56f0f	Show tooltip on auto normal bank when not usable	2024-10-23 21:25:37 +02:00
OliBomby	bf88219dfb	Move TestTouchInputAfterTouchingComposeArea to separate test scene	2024-10-23 20:21:38 +02:00
Dean Herbert	7b2ca2f388	Merge pull request #30400 from peppy/quote-source-search ... Quote source text when searching for it via click	2024-10-23 23:50:03 +09:00
Dean Herbert	77d2f35765	Merge pull request #30375 from bdach/fix-broken-playfield-skin-layer-rotation ... Fix playfield skinning layer no longer correctly rotating with the playfield	2024-10-23 19:50:39 +09:00
Dean Herbert	064aaeb60e	Initialise container earlier to avoid null reference failures	2024-10-23 18:46:20 +09:00
Dean Herbert	c1453cfd0c	Merge pull request #30389 from bdach/fix-looping-samples-not-stopping ... Fix old looping samples not stopping when replacing a `SkinnableSound`'s `Samples`	2024-10-23 18:39:55 +09:00
Dean Herbert	b1b0aadbfb	Merge pull request #30294 from bdach/fuzzin ... Fix several cases of deselection not correctly terminating drag operations on slider selection blueprint	2024-10-23 18:35:52 +09:00
Dean Herbert	ba4411f72c	Merge pull request #30315 from OliBomby/popover-ux ... Improve scale/rotate popover UX to better match user expectation	2024-10-23 18:18:24 +09:00
Dan Balasescu	2bea1fe4a6	Also add source prefix	2024-10-23 16:21:28 +09:00
Dan Balasescu	af7d35bfbf	Doubly quote strings ... Note the external-action case (currently used for tags) doesn't match osu!web but it doesn't matter because tags are single words anyway.	2024-10-23 16:15:49 +09:00
Dean Herbert	7df3976d1c	Merge pull request #30284 from bdach/mania-selection-preservation-again ... Fix flip operations sometimes not preserving selection in mania editor	2024-10-23 16:13:20 +09:00
Dean Herbert	5939c78760	Merge branch 'master' into auto-addition2	2024-10-23 15:53:07 +09:00
Dean Herbert	2103b3e186	Merge pull request #28863 from OliBomby/additions ... Add toggles and hotkeys for configuring sample addition bank	2024-10-23 15:52:55 +09:00
Dean Herbert	21351b1be4	Quote source text when searching for it via click ... Addresses https://github.com/ppy/osu/discussions/30181.	2024-10-23 15:41:42 +09:00
Dan Balasescu	71eb7120ba	Merge pull request #27691 from Finadoggie/estimation-removal ... Remove estimations where score data is available for osu! difficulty calculations	2024-10-23 00:59:34 +09:00
Bartłomiej Dach	1008d32ddb	Fix old looping samples not stopping when replacing a SkinnableSound's Samples ... Closes https://github.com/ppy/osu/issues/30365.	2024-10-22 14:35:21 +02:00
Dean Herbert	53a340938a	Merge pull request #30377 from bdach/very-bad-completely-no-good-comparer ... Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted	2024-10-22 20:20:03 +09:00
Bartłomiej Dach	24dfc1b66e	Merge pull request #30328 from TaterToes/seekingControlPointFix ... Add breathing room to seek back between control points in editor	2024-10-22 13:14:24 +02:00
Dean Herbert	213be029ed	Merge pull request #30382 from Maks1mio/ChatChannelListSearch ... Add search box to chat overlay	2024-10-22 20:10:53 +09:00
Bartłomiej Dach	54aeeaa529	Add test coverage	2024-10-22 12:29:34 +02:00
Bartłomiej Dach	2ab68c6ab9	Select first filtered channel on search box commit	2024-10-22 12:29:23 +02:00
Bartłomiej Dach	826b35e031	Use SearchContainer instead of manual search implementation	2024-10-22 12:29:20 +02:00
Dean Herbert	c15490ed58	Merge pull request #30146 from bdach/lookup-users-endpoint ... Fix currently online display hitting rate limits	2024-10-22 19:24:14 +09:00
Dean Herbert	7b3376ccd6	Merge pull request #30385 from peppy/fix-selection-lost-during-update ... Fix beatmap selection being lost during update process	2024-10-22 19:24:01 +09:00
Dean Herbert	3158338fe4	Merge pull request #30137 from bdach/send-mods-in-frame-headers ... Send mods in spectator frame headers	2024-10-22 19:23:21 +09:00
Dean Herbert	187fa5eccd	Use full async flow rather than ContinueWith	2024-10-22 18:48:01 +09:00
Dean Herbert	6ea1623889	Merge branch 'master' into lookup-users-endpoint	2024-10-22 18:48:00 +09:00
Bartłomiej Dach	256d8c6559	Move search box to the top, remove redundant heading, and use existing search box	2024-10-22 11:28:59 +02:00
Bartłomiej Dach	84e08d96ca	Merge pull request #30330 from jhk2601/mod_acronym_search_fix ... Prioritize selecting exact searched acronym with select keybind	2024-10-22 11:20:06 +02:00
Dean Herbert	a35551ecd9	Merge pull request #30383 from CloneWith/feature/placeholder-hoverbk ... Add hover background back to `ClickablePlaceholder`	2024-10-22 18:17:36 +09:00
Dean Herbert	16bc188ba7	Refactor code to read better (and adjust lenience to match stable)	2024-10-22 18:08:25 +09:00
Dean Herbert	e1a950e2d3	Fix beatmap selection being lost during update process ... Broke due to something changing in the way we handle realm things in the carousel. The deselection happens in `updateBeatmapSet` so we need to store / check the original selection before this occurs. Doesn't seem this had test coverage? Probably implies that the overhead of adding a test was very large, so maybe best to leave it that way.	2024-10-22 17:53:34 +09:00
Bartłomiej Dach	9258916fa8	Merge pull request #30263 from frenzibyte/editor-slider-touch-support-1 ... Fix drawing slider with touch inserts a random control point at beginning	2024-10-22 10:29:30 +02:00
Dean Herbert	13fba9f92e	Adjust glow slightly	2024-10-22 17:16:09 +09:00
Bartłomiej Dach	03683e28be	Merge branch 'master' into editor-slider-touch-support-1	2024-10-22 09:31:03 +02:00
Dan Balasescu	1bdae2af41	Merge pull request #30379 from peppy/dont-delete-scores ... Don't delete scores when deleting beatmaps	2024-10-22 14:22:14 +09:00
EvT	17cd411567	Added search box to ChannelGroup Private Message	2024-10-22 01:33:53 +03:00
Dean Herbert	cbaee98674	Don't delete scores when deleting beatmaps ... The score model's spec allows for null `BeatmapInfo` so the reasoning of the inline comment is no longer valid. We match based on hash these days.	2024-10-22 01:39:05 +09:00
Bartłomiej Dach	455ed0607f	Merge pull request #30346 from wezwery/perfect-combo-and-accuracy-highlighted ... Highlight maximum combo and accuracy on user best score display to match web	2024-10-21 15:34:03 +02:00
CloneWith	9940be818d	Add hover color back to ClickablePlaceholder	2024-10-21 21:09:26 +08:00
Bartłomiej Dach	dbc2e78dd9	Fix timeline blueprints sometimes causing crashes due to current placement blueprint becoming unsorted ... Closes https://github.com/ppy/osu/issues/30324.	2024-10-21 14:48:57 +02:00