osu-lazer

Improve adjusting mods settings values with keyboard (#36090 )

- closes https://github.com/ppy/osu/issues/36016

Co-authored-by: Dean Herbert <pe@ppy.sh>

Denis Titovets · 2026-02-09 11:35:01 +09:00

60d98f0afd

Make Difficulty Adjust and Target Practice mods incompatible (#36524 )

Closes https://github.com/ppy/osu/issues/36490.

While I'm out here already taking heat for deleting mod combinations let
me do more of that.

The main problem with the mod combination here, again, is that the
application of the mods does not commute.

- The current behaviour is that TP is applied first, then DA. This is,
again, "enforced" by the mod select overlay implicitly enforcing order
of the mod instances in the global mod bindable to match the display
order of mods inside it.

Even this doesn't "work" correctly as is, because as the bug reporter
points out, if they throw on DA with no changes expecting the map's
default AR to be applied, it still gets halved. This is because DA works
in a way wherein if you don't touch the AR slider, DA does not touch AR.
Which means that the DA slider should *really* be at *half* of the map's
base AR by default in this case because TP is active. How do you program
this?

- The *alternative* behaviour would be that DA is applied first, then
TP. This in turn would mean that the effective range of AR adjustment
offered by DA when TP is active would be halved to [0, 5] (or [-5, 5.5]
with extended ranges). How do you program this?

The above is just client-side concerns, while leaving out the other
giant concern, which is "how do you get every single place in the game
that may want to apply mods to a beatmap to apply them *in the same
order*?". Then extend that to server-side components, then extend that
to every external library that may want to re-implement SR/PP
calculations, etc. etc.

One additional remark:
What the bug reporter *did not* say however, but I am saying, is that
there's an elephant in the room, and that is the Easy mod, which *also*
changes AR, but also *happens* to apply commutatively with Target
Practice simply because both mods are implemented to halve the AR, which
means that the order of application doesn't matter. If I were *really*
bent on being a bad guy and just deleting mod combinations
indiscriminately, I'd delete that one as well. But I'm not doing that.

Bartłomiej Dach · 2026-01-29 17:59:28 +09:00

1885ab86f5

Make Hidden and Freeze Frame mods incompatible (#36515 )

Effectively closing https://github.com/ppy/osu/issues/21471 as a
wontfix.

The issue is demonstrated by the following test case:

<details>
<summary>patch</summary>

```diff
diff --git a/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs b/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs
index 31498295da..36b4fe5122 100644
--- a/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs
+++ b/osu.Game.Rulesets.Osu.Tests/Mods/TestSceneOsuModFreezeFrame.cs
@@ -55,5 +55,49 @@ public void TestSkipToFirstSpinnerNotSuppressed()
                 PassCondition = () => Player.GameplayClockContainer.GameplayStartTime > 0
             });
         }
+
+        [Test]
+        public void TestFreezeFrameAppliedBeforeHidden()
+        {
+            CreateModTest(new ModTestData
+            {
+                Mods =
+                [
+                    new OsuModFreezeFrame(),
+                    new OsuModHidden(),
+                ],
+                CreateBeatmap = () => new OsuBeatmap
+                {
+                    HitObjects =
+                    {
+                        new HitCircle { StartTime = 3000, Position = OsuPlayfield.BASE_SIZE / 2, NewCombo = true },
+                        new HitCircle { StartTime = 5000, Position = OsuPlayfield.BASE_SIZE / 2 },
+                    }
+                },
+                PassCondition = () => ((HitCircle)Player.GameplayState.Beatmap.HitObjects[1]).TimeFadeIn == 480
+            });
+        }
+
+        [Test]
+        public void TestFreezeFrameAppliedAfterHidden()
+        {
+            CreateModTest(new ModTestData
+            {
+                Mods =
+                [
+                    new OsuModHidden(),
+                    new OsuModFreezeFrame(),
+                ],
+                CreateBeatmap = () => new OsuBeatmap
+                {
+                    HitObjects =
+                    {
+                        new HitCircle { StartTime = 3000, Position = OsuPlayfield.BASE_SIZE / 2, NewCombo = true },
+                        new HitCircle { StartTime = 5000, Position = OsuPlayfield.BASE_SIZE / 2 },
+                    }
+                },
+                PassCondition = () => ((HitCircle)Player.GameplayState.Beatmap.HitObjects[1]).TimeFadeIn == 480
+            });
+        }
     }
 }

```

</details>

The reason that this is happening is a data dependency. Freeze Frame
modifies `TimePreempt` of hitobjects:


https://github.com/ppy/osu/blob/54c0b2c20c3209f1f17be81b8883ef66ec8a83bb/osu.Game.Rulesets.Osu/Mods/OsuModFreezeFrame.cs#L53

while Hidden uses `TimePreempt` to set `TimeFadeIn`:


https://github.com/ppy/osu/blob/54c0b2c20c3209f1f17be81b8883ef66ec8a83bb/osu.Game.Rulesets.Osu/Mods/OsuModHidden.cs#L45

Therefore the final value of `TimeFadeIn` with these two mods active
depends on the order of application.

The reason why I'm bothering to do this is that I was pinged from the PP
development server about this again in the context of some ongoing
'rework' and I wish to get ahead of this before it becomes a bigger
problem than it already is.

The current order of application of these mods as done in `Player` is
constant, but essentially undefined. I'm not even sure what even
enforces the current order. It's currently Hidden, then Freeze Frame. If
I were to guess, the thing "enforcing" (insert 400 tonne solid lead air
quotes) it is probably the mod select overlay with its "I need to own
all of the mod instances in the global bindable" substitution logic.

I'm already getting pushback for this from the PP server crowd who are
attempting to justify the current "behaviour" by saying that the player
base wants this or by saying that it's already broken so it should
remain that way forever. I am however not willing to accept
[stable-taiko-tier stupidity
again](https://github.com/ppy/osu/pull/27136#issuecomment-1957055402)
and am not willing to accept the complexity this would invite everywhere
else.

I do not see any other easy way of fixing this problem at this point in
time. I had hoped that I could inline the `TimePreempt` read in
`OsuModHidden`, but it's not that easy because it's set in multiple
places.

Existing HDFF scores would probably need to be delisted from the
leaderboards. I'm not even sure I can get myself to pretend to care.

Bartłomiej Dach · 2026-01-29 16:35:13 +09:00

9bf52034d7

Move Traceable to difficulty increasing mods section (#35500 )

TC is a mod that always increases difficulty and is quite similar to HD.
Given we even have diffcalc/pp considerations for it it's time to move
it to the category it belongs.

This doesn't cover any other mods that might need reshuffling too
because TC is the only one that has actual impact on difficulty-based
leaderboards (as in pp) and some people are actively playing it for the
difficulty increase and not just as a fun gimmick.

After a quick search turns out it was difficulty increasing from the
start but was moved to fun in review
https://github.com/ppy/osu/pull/3569#discussion_r300085523 but I don't
really agree with that.

Also as far as I know multimods don't do anything anymore?.. I've put it
into HD multimod for consistency, but can move it to be separate if you
want

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>

StanR · 2026-01-25 20:30:01 +09:00

df1dc46603

Fix Freeze Frame mod suppressing skip if the first object is a spinner

Fixes https://osu.ppy.sh/community/forums/topics/2169899?n=1.

`TimePreempt` doesn't affect the appearance of a spinner, but it *will*
affect the value of `GameplayStartTime`:

	https://github.com/ppy/osu/blob/4bf90a5571bb508444178f3d98a2b2a10c549534/osu.Game.Rulesets.Osu/UI/DrawableOsuRuleset.cs#L82-L91

While at parsing it is enforced that every object following a spinner
has `NewCombo` set, it is *not* enforced that every spinner has
`NewCombo` set. See also: https://github.com/ppy/osu/issues/24156.

But that's sort of orthogonal to the entire issue as well because why
touch the preempt of an object that's not visually affected by preempt
to begin with.

Bartłomiej Dach · 2026-01-12 11:11:38 +01:00

38c89a914b

Merge branch 'master' into rikimasan/rank-alternate-mod

Dean Herbert · 2025-11-21 14:00:18 +09:00

721ba8aeba

Fix cursor incorrectly flashing red after a rewind in replays with Alternate mod active (#35725 )

* Fix red cursor with alt mod when rewind

* Change rewind detection in input blocking

Urantij · 2025-11-18 09:52:37 +01:00

f0ca079fe6

Always use current culture in ToStandardFormattedString()

Bartłomiej Dach · 2025-10-24 08:26:01 +02:00

ae7ba034a7

Allow NumberFormattingExtensions.ToStandardFormattedString() to accept culture

I had previously made it invariant in
https://github.com/ppy/osu/pull/32837, and in another instance of past
me being an asshole, I can't actually find the reasoning for this at
this time.

That said, you'd be excused for thinking "why does this matter"? Well,
this will fix https://github.com/ppy/osu/issues/35381, because that
failure only occurs when the user's culture is set to one that doesn't
use a decimal point (.) but rather a decimal comma (,). This messes with
framework, which uses the *current* culture to check for decimal
separator rather than invariant:

https://github.com/ppy/osu-framework/blob/d3226a7842487de43a0d989e1bb59a9ebbc479af/osu.Framework/Graphics/UserInterface/TextBox.cs#L106-L111

An alternative would be to change framework instead to always accept the
invariant decimal separator.

God I hate this culture crap.

Bartłomiej Dach · 2025-10-22 10:31:12 +02:00

a29a5ab7e6

Merge pull request #34761 from frenzibyte/fix-flashlight

Fix flashlight not always matching gameplay scaling

Bartłomiej Dach · 2025-08-25 12:03:58 +02:00

6e8246b539

Adjust default flashlight size on osu! & osu!catch

Because the flashlight is made to be scaled by playfield, there are
constant scale factors applied somewhere in the
`PlayfieldAdjustmentContainer` which needs to be reflected in the
flashlight size to keep the size the same.

The factor is specifically 1.6x, computed in {Osu,Catch}PlayfieldAdjustmentContainer.ScalingContainer`.

More generally, I've deduced these factors by logging the difference
between the `flashlightSize` before and after b78abe2f.

Salman Alshamrani · 2025-08-21 19:03:43 +03:00

7530ad1a7b

Add and use new mod icon assets

Bartłomiej Dach · 2025-08-21 09:00:44 +02:00

92016a7d9b

change access modifier of internal mods to public

minisbett · 2025-08-16 13:44:01 +02:00

d3910d80e5

Merge branch 'master' into fix_strict_tracking_scoring

Bartłomiej Dach · 2025-07-08 13:26:03 +02:00

b9a4f0068e

Fix mania Hard Rock & Easy mods not matching stable

The implementation in `master` was presuming that Hard Rock and Easy
worked the same way across all rulesets, but actually, in stable mania,
the two mods have special treatment as per

	https://github.com/peppy/osu-stable-reference/blob/996648fba06baf4e7d2e0b248959399444017895/osu!/GameplayElements/HitObjectManagerMania.cs#L147-L150

The open question here would be what this means for existing scores set
on lazer using this mod.

Bartłomiej Dach · 2025-07-02 12:26:50 +02:00

8e53f47e78

Merge branch 'master' into fix_strict_tracking_scoring

Dan Balasescu · 2025-07-02 18:14:15 +09:00

4b7dcd0b3c

Replace using static with inner class name

Dan Balasescu · 2025-07-02 18:14:13 +09:00

2016fc5ea1

Fix Difficulty Adjust extended mod icon information not showing with extended limits active

- Closes https://github.com/ppy/osu/issues/33522.
- Alternative to / closes https://github.com/ppy/osu/pull/33561.

Bartłomiej Dach · 2025-06-30 12:20:05 +02:00

28caa03d21

Remove no longer used method

Dan Balasescu · 2025-06-25 18:31:35 +09:00

d42fcabcf4

Add failing test case

Salman Alshamrani · 2025-06-18 19:19:54 +03:00

9cb824df6f

remove using not used

Fayar35 · 2025-06-18 00:15:18 +02:00

48e6f09b4d

change StrictTrackingTailJudgement to regular TailJudgement but with LargeTickMiss in case of break

Fayar35 · 2025-06-17 23:20:50 +02:00

065fc446da

Fix rider EAP new naming inspections

Dean Herbert · 2025-05-25 20:39:55 +09:00

5e3fd7a42a

Fix Strict Tracking running miss-on-tracking-loss logic during rewind

Probably closes https://github.com/ppy/osu/issues/29945.

Bartłomiej Dach · 2025-05-20 14:17:16 +02:00

3a136a4c81

Don't bother with localised implementation of AdjustedSettingsCount

I was avoiding using reflection to save on overheads, but it's probably
not worth it.

Dean Herbert · 2025-04-30 12:58:40 +09:00

babccca2bb

Show singular difficulty adjust modifications inline in mod icons

Dean Herbert · 2025-04-28 16:58:16 +09:00

c16514274d

Minor fix to the description text

Shavixinio · 2025-04-22 19:49:34 +02:00

3b2382ceb0

Fix "spins per minute" shows up early #31173

Make isSpinnableTime public in SpinnerRotationTracker and use it to set Tracking in OsuModSpunOut.

Tracking was previously set to true, causing the "spins per minute" to appear immediately when the spinner appeared.

Rudi Herouard · 2025-04-13 23:35:44 +02:00

7cdbc2c20a

Change SettingDescription to differentiate between settings and values

Salman Alshamrani · 2025-03-23 13:43:26 -04:00

6e635f124a

Fix double-clicking difficulty adjust sliders not resetting the value to default correctly

- Closes https://github.com/ppy/osu/issues/31888
- Supersedes / closes https://github.com/ppy/osu/pull/32060

Bartłomiej Dach · 2025-02-25 07:40:55 +01:00

1f562ab47d

Refactor slightly

Dean Herbert · 2025-02-18 13:04:38 +09:00

20dbe096e0

Merge branch 'master' into sudden-death-feat

Plextora · 2025-02-16 19:43:55 -05:00

cb012123ab

Change mirror mod direction setting tooltip to hopefully be less confusing

See https://github.com/ppy/osu/issues/29720,
https://discord.com/channels/188630481301012481/188630652340404224/1334294048541904906.

This removes the tooltip due to being zero or negative information, and
also changes the description of the setting to not contain the word
"mirror", which will hopefully quash the "this is where I would place a
mirror to my screen to achieve what I want" interpretation which seems
to be a minority interpretation.

The first time this was complained about I figured this was probably a
one guy issue, but now it's happened twice, and I never want to see this
conversation again.

Bartłomiej Dach · 2025-01-30 08:59:33 +01:00

bad2959d5b

Reduce HitSampleInfo constants allocations