osu-lazer

Bump difficulty calculator versions

To trigger client-side recalculations of star ratings.

Should have been done in https://github.com/ppy/osu/pull/35029.

Probably closes https://github.com/ppy/osu/issues/35357.

Bartłomiej Dach · 2025-10-20 08:46:30 +02:00

03a5aedf99

Reading bonus hotfix for Traceable mod (#35266 )

* Pass slider factor to visibility bonus correctly for TC

* Decrease reading bonuses for TC

James Wilson · 2025-10-13 13:34:57 +09:00

28c846b4d9

Use DeltaTime in RhythmEvaluator to increase stability (#32790 )

* Update RhythmEvaluator.cs

* Rename `StrainTime` into `AdjustedDeltaTime`

---------

Co-authored-by: StanR <hi@stanr.info>

Givy120 · 2025-09-16 13:31:14 +00:00

7852df639a

Reduce rhythm difficulty if current object is doubletappable (#34877 )

* Reduce rhythm difficulty if current object is doubletappable

* Buff rhythm multiplier

StanR · 2025-09-02 10:22:12 +01:00

84309f57c5

Move SpunOut penalty back to PP (#34838 )

This isn't a super common mod compared to every other one on the list, it's probably not worth the storage (and memory in case of stable) implications. We can look at revisiting this once we have actual spinner difficulty considerations

James Wilson · 2025-08-31 12:32:28 +05:00

90ac249f5e

Nerf Low AR HD bonus for slideraim (#34215 )

* Refactor slider factor calculation

* Nerf low AR HD bonus for slideraim

* finish merge

* Fixes

* Fix comment

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Givikap120 · 2025-08-09 19:40:37 +00:00

dce4132209

Fix edge case that estimates sliderbreaks in impossible scenarios (#34544 )

* Test theory crafting

* Place in more appropriate place

* fix a bit better

* Move things around

* Reduce diff

---------

Co-authored-by: StanR <hi@stanr.info>

James Wilson · 2025-08-07 19:13:00 +01:00

fa1fea02dc

Add DF flashlight rating reduction (#34081 )

* Add DF flashlight rating reduction

* Use reverse lerp

StanR · 2025-08-06 17:10:00 +01:00

802e559472

Make visibility-based bonuses be additive to ratingMultiplier instead of multiplicative (#34367 )

* Make visibility-based bonuses be additive to `ratingMultiplier` instead of multiplicative

* Slightly buff low AR HD, slightly nerf low AR TC

StanR · 2025-07-25 19:51:30 +00:00

83765abe34

Move rating calculations to OsuRatingCalculator (#33265 )

* Move rating calculations to `OsuRatingCalculator`

* Use `CalculateDifficultyRating`

James Wilson · 2025-07-25 18:47:21 +03:00

28d36dd3bd

Fix backwards logic on visibility bonus (#34369 )

Co-authored-by: StanR <hi@stanr.info>

James Wilson · 2025-07-25 06:50:23 +00:00

945db7b431

remove high CS bonus from slider bonus (#34214 )

Co-authored-by: StanR <hi@stanr.info>

Givikap120 · 2025-07-24 15:41:36 +00:00

56b072cfd9

Refactor AR and OD calculations in osu! pp calculation (#34065 )

* Add AR and OD calculation functions

* use created functions in perfcalc

Givikap120 · 2025-07-08 18:37:41 +03:00

a75e0c3850

Merge branch 'master' into pp-dev

Dan Balasescu · 2025-07-08 20:58:22 +09:00

f2dcf2024a

Update OsuPerformanceCalculator.cs

Givikap120 · 2025-07-05 12:24:36 +03:00

f19bc18f49

Replace error functions in DifficultyCalculationUtils with good-enough approximations (#33717 )

* Reimplement error functions

* Fix bug with adjustment for negative values

* Formatting

---------

Co-authored-by: tsunyoku <tsunyoku@gmail.com>

Natelytle · 2025-06-18 13:14:01 +00:00

d5ef8c8524

Optimize rhythm evaluation by replacing curve (#33423 )

* Update RhythmEvaluator.cs

* add smoothstep bell curve

* Update osu.Game.Rulesets.Osu/Difficulty/Evaluators/RhythmEvaluator.cs

Co-authored-by: StanR <castl@inbox.ru>

* Update osu.Game.Rulesets.Osu/Difficulty/Evaluators/RhythmEvaluator.cs

Co-authored-by: StanR <castl@inbox.ru>

* Rename variables

---------

Co-authored-by: StanR <castl@inbox.ru>
Co-authored-by: James Wilson <tsunyoku@gmail.com>

Givikap120 · 2025-06-13 13:02:31 +05:00

b783bb70e9

Q2 osu! PP rebalance (#33640 )

* Rebalance aim and speed

* Rebalance star rating

* Attempt further speed balancing

* More balancing

* More balancing

* Buff aim a bit

* More speed balancing

* Global rebalance

* Speed balancing

* Global rebalancing

* More speed balancing

* Buff aim

* MORE BALANCING

* Revert "Rebalance star rating"

This reverts commit f48c7445e1.

James Wilson · 2025-06-11 19:46:46 +03:00

19e9bffc11

Remove wide/wiggle angle bonus rhythm requirements (#31409 )

* Remove aim angle bonuses angle restrictions

* Remove unrelated change

* Only apply acute bonus for similar rhythms

* Cleanup

* Fix incorrect multiplication order

* Remove unrelated wide bonus change

* Remove redundant check

* Award less wide/wiggle bonus for sliders

* Balancing

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2025-06-10 11:20:55 +00:00

87023b22ea

Decouple velocity change bonus from wide angle bonus (#33541 )

* Decouple velocity change bonus from wide angle bonus

* Replace sin with smoothstep

* Set multiplier back to 0.75

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2025-06-09 11:02:49 +00:00

699fbb1a85

Refactor and re-comment osu! standard deviation calculations (#33218 )

* Refactor

* Fix typo

* Prevent double.PositiveInfinity from occuring

* Fix leftover code branch

* Fix some idiot putting Math.Max instead of Math.Min

* Address NaN values

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Natelytle · 2025-06-08 22:41:13 +00:00

c4b07413b1

Fix incorrect limit for sliderbreak estimation (#33110 )

* fix incorrect clamp

* Add inline comment to explain `possibleBreaks` calculation

* move limit to aim and speed functions

* fix negative okMehAdjustment

* fix cases where lazer effective misscount gets reduced

* Simplify scope of changes

* Correct variable name

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Givikap120 · 2025-06-03 09:29:16 +01:00

366f2469ef

Replace HD acc scaling adjust with reverse lerp util (#33271 )

Givikap120 · 2025-05-28 13:59:23 +01:00

63654ad1e0

Rebalance HD bonus (#33237 )

* initial commit

* changed HD curve

* removed AR variable

* update for new rework

* nerf HD acc bonus for AR>10

* add another HD nerf for AR>10

* Update OsuDifficultyCalculator.cs

* fix speed part being missing

* Update OsuDifficultyCalculator.cs

* rework to difficulty-based high AR nerf

* move TC back to perfcalc

* fix nvicka

* fix comment

* use utils function instead of manual one

* Clean up

* Use "visibility" term instead

* Store `mechanicalDifficultyRating` field

* Rename `isFullyHidden` to `isAlwaysPartiallyVisible` and clarify intent

* Remove redundant comment

* Add `calculateDifficultyRating` method

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Givikap120 · 2025-05-26 13:16:48 +03:00

01d9c526d9

Add spinners support to combo based estimated misscount (#33170 )

* add spinner support

* Make `CalculateSpinnerScore` private & clarify comments

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

Givikap120 · 2025-05-22 22:27:16 +00:00

ee055ba8f5

Buff precision difficulty rating in osu! (#28877 )

* Buff precision difficulty rating in osu!

* Fix position repetition calculation

* Fix aim evaluator crashing, move small circle bonus calculation, adjust the curve slightly

* Refactor

* Fix code quality

* Semicolon

* Apply small circle bonus to speed too

* Fix formatting

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2025-05-22 09:11:51 +01:00

60eaf088df

Add AimEstimatedSliderBreaks and SpeedEstimatedSliderBreaks performance attributes (#33181 )

James Wilson · 2025-05-18 12:50:29 +00:00

553a8601ed

Change effective misscount to be based on legacy score and combo at the same time (#33066 )

* implement stuff

* fix basic issues

* rework calculations

* sanity check

* don't use score based misscount if no scorev1 present

* Update OsuPerformanceCalculator.cs

* update misscount diff attribute names

* add raw score misscount attribute

* introduce more reasonable high bound for misscount

* code quality changes

* Fix osu!catch SR buzz slider detection (#32412)

* Use `normalized_hitobject_radius` during osu!catch buzz slider detection

Currently the algorithm considers some buzz sliders as standstills when
in reality they require movement. This happens because `HalfCatcherWidth`
isn't normalized while `exactDistanceMoved` is, leading to an inaccurate
comparison.

`normalized_hitobject_radius` is the normalized value of `HalfCatcherWidth`
and replacing one with the other fixes the problem.

* Rename `normalized_hitobject_radius` to `normalized_half_catcher_width`

The current name is confusing because hit objects have no radius in the
context of osu!catch difficulty calculation. The new name conveys the
actual purpose of the value.

* Only set `normalized_half_catcher_width` in `CatchDifficultyHitObject`

Prevents potential bugs if the value were to be changed in one of the
classes but not in both.

* Use `CatchDifficultyHitObject.NORMALIZED_HALF_CATCHER_WIDTH` directly

Requested during code review.

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Move osu!catch movement diffcalc to an evaluator (#32655)

* Move osu!catch movement state into `CatchDifficultyHitObject`

In order to port `Movement` to an evaluator, the state has to be either
moved elsewhere or calculated inside the evaluator. The latter requires
backtracking for every hit object, which in the worst case is continued
until the beginning of the map is reached. Limiting backtracking can
lead to difficulty value changes.

Thus, the first option was chosen for its simplicity.

* Move osu!catch movement difficulty calculation to an evaluator

Makes the code more in line with the other game modes.

* Add documentation for `CatchDifficultyHitObject` fields

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Move all score-independent bonuses into star rating (#31351)

* basis refactor to allow for more complex SR calculations

* move all possible bonuses into star rating

* decrease star rating scaling to account for overall gains

* add extra FL guard for safety

* move star rating multiplier into a constant

* Reorganise some things

* Add HD and SO to difficulty adjustment mods

* Move non-legacy mod multipliers back to PP

* Some merge fixes

* Fix application of flashlight rating multiplier

* Fix Hidden bonuses being applied when Blinds mod is in use

* Move part of speed OD scaling into difficulty

* Move length bonus back to PP

* Remove blinds special case

* Revert star rating multiplier decrease

* More balancing

---------

Co-authored-by: StanR <hi@stanr.info>

* Add diffcalc considerations for Magnetised mod (#33004)

* Add diffcalc considerations for Magnetised mod

* Make speed reduction scale with power too

* cleaning up

* Update OsuPerformanceCalculator.cs

* Update OsuPerformanceCalculator.cs

* add new check to avoid overestimation

* fix code style

* fix nvicka

* add database attributes

* Refactor

* Rename `Working` to `WorkingBeatmap`

* Remove redundant condition

* Remove useless variable

* Remove `get` wording

* Rename `calculateScoreAtCombo`

* Remove redundant operator

* Add comments to explain how score-based miss count derivations work

* Remove redundant `decimal` calculations

* use static method to improve performance

* move stuff around for readability

* move logic into helper class

* fix the bug

* Delete OsuLegacyScoreProcessor.cs

* Delete ILegacyScoreProcessor.cs

* revert static method for multiplier

* use only basic combo score attribute

* Clean-up

* Remove unused param

* Update osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceCalculator.cs

Co-authored-by: StanR <castl@inbox.ru>

* rename variables

* Add `LegacyScoreUtils`

* Add fail safe

* Move `countMiss`

* Better explain `CalculateRelevantScoreComboPerObject`

* Add `OsuLegacyScoreMissCalculator`

* Move `CalculateScoreAtCombo` and `CalculateRelevantScoreComboPerObject`

* Remove unused variables

* Move `GetLegacyScoreMultiplier`

* Add `estimated` wording

---------

Co-authored-by: wulpine <wulpine@proton.me>
Co-authored-by: James Wilson <tsunyoku@gmail.com>
Co-authored-by: StanR <hi@stanr.info>
Co-authored-by: StanR <castl@inbox.ru>

Givikap120 · 2025-05-16 23:38:12 +00:00

9314ea94b5

Remove track usage in difficulty and performance calculations (#33132 )

James Wilson · 2025-05-14 12:37:08 +00:00

d22b3fb200

Use proportion of difficult sliders to better estimate sliderbreaks on classic accuracy scores (#31234 )

* scale misscount by proportion of difficult sliders

* cap sliderbreak count at count100 + count50

* use countMiss instead of effectiveMissCount as the base for sliderbreaks

* make code inspector happy + cleanup

* refactor to remove unnecesary calculation and need for new tuple

* scale sliderbreaks with combo

* use aimNoSliders for sliderbreak factor

* code cleanup

* make inspect code happy

* use diffcalcutils

* fix errors (oops)

* scaling changes

* fix div by zeros

* Fix compilation error

* Add online attributes for new difficulty attributes

* Formatting

* Rebase fixes

* Make `CountTopWeightedSliders` to remove weird protected `SliderStrains` list

* Prevent top weighted slider factor from being Infinity

---------

Co-authored-by: tsunyoku <tsunyoku@gmail.com>

KermitNuggies · 2025-05-12 14:05:07 +01:00

3165b147ee

Add diffcalc considerations for Magnetised mod (#33004 )

* Add diffcalc considerations for Magnetised mod

* Make speed reduction scale with power too

StanR · 2025-05-01 11:52:43 +01:00

ce73dbbcc6

Use sliders in acc pp if scorev2 is enabled (#32634 )

Co-authored-by: StanR <hi@stanr.info>

Nathan Corbett · 2025-04-27 11:57:51 +00:00

4f298760de

Move all score-independent bonuses into star rating (#31351 )

* basis refactor to allow for more complex SR calculations

* move all possible bonuses into star rating

* decrease star rating scaling to account for overall gains

* add extra FL guard for safety

* move star rating multiplier into a constant

* Reorganise some things

* Add HD and SO to difficulty adjustment mods

* Move non-legacy mod multipliers back to PP

* Some merge fixes

* Fix application of flashlight rating multiplier

* Fix Hidden bonuses being applied when Blinds mod is in use

* Move part of speed OD scaling into difficulty

* Move length bonus back to PP

* Remove blinds special case

* Revert star rating multiplier decrease

* More balancing

---------

Co-authored-by: StanR <hi@stanr.info>

James Wilson · 2025-04-27 12:30:05 +01:00

2aeb80a8bd

Move difficulty calculation fields from Slider to OsuDifficultyHitObject (#32410 )

* Move difficulty calculation fields from `Slider` to `OsuDifficultyHitObject`

* Remove redundant check

* Use `LastObject` where possible

* Update tests

* Make `LazyTravelDistance` `double`

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2025-04-09 13:37:26 +00:00

cf7fdc0627

Reduce RX Ok multiplier (#32434 )

StanR · 2025-04-09 12:48:18 +00:00

30f9716db9

Use Precision.AlmostEquals to compare deviation lower bound (#32694 )

James Wilson · 2025-04-06 09:36:18 +01:00

69c90f9926

Bump difficulty calculator versions in preparation for release

Dean Herbert · 2025-03-06 16:05:51 +09:00

bdd2808fb5

Fix failed scores with no hits on beatmaps with ridiculous mod combinations showing hundreds of pp points awarded (#31741 )

See
https://discord.com/channels/188630481301012481/1097318920991559880/1334716356582572074.

On `master` this is actually worse and shows thousands of pp points, so
I guess `pp-dev` is a comparable improvement, but still flagrantly
wrong. The reason why `pp-dev` is better is the `speedDeviation == null`
guard at the start of `computeSpeedValue()` which turns off the rest of
the calculation, therefore not exposing the bug where
`relevantTotalDiff` can go negative. I still guarded it in this commit
just for safety's sake given it is clear it can do very wrong stuff.

Bartłomiej Dach · 2025-02-14 14:52:05 +00:00

4e66536ae8

Calculate hit windows in performance calculator instead of databased difficulty attributes (#31735 )

* Calculate hit windows in performance calculator instead of databased difficulty attributes

* Apply mods to beatmap difficulty in osu! performance calculator

* Remove `GreatHitWindow` difficulty attribute for osu!mania

* Remove use of approach rate and overall difficulty attributes for osu!

* Remove use of hit window difficulty attributes in osu!taiko

* Remove use of approach rate attribute in osu!catch

* Remove unused attribute IDs

* Code quality

* Fix `computeDeviationUpperBound` being called before `greatHitWindow` is set

James Wilson · 2025-02-07 19:21:12 +09:00

9f90ebb2f7

Clamp estimateImproperlyFollowedDifficultSliders between 0 and attributes.AimDifficultSliderCount (#31736 )

James Wilson · 2025-01-30 13:58:38 +00:00

2ee480c442

Remove unnecessary strain sorting in difficult slider count (#31724 )

Rian (Reza Mouna Hendrian) · 2025-01-29 19:06:05 +00:00

46144960e5

Replace indexed skill access with skills.OfType<...>().Single() (#30034 )

* Replace indexed skill access with `skills.First(s is ...)`

* Fix comment

* Further refactoring to remove casts

---------

Co-authored-by: Dan Balasescu <smoogipoo@smgi.me>
Co-authored-by: Bartłomiej Dach <dach.bartlomiej@gmail.com>

StanR · 2025-01-20 09:39:35 +00:00

22e839d62b

Remove redundant angle check (#31566 )

James Wilson · 2025-01-19 18:47:39 +03:00

e320f17faf

Move error function from osu.Game.Utils to osu.Game.Rulesets.Difficulty.Utils (#31520 )

* Move error function implementation to osu.Game.Rulesets.Difficulty.Utils

* Rename ErrorFunction.cs to DifficultyCalculationUtils_ErrorFunction.cs

Natelytle · 2025-01-17 19:37:34 +00:00

5b4ba9225d

fix spinners not increasing cumulative strain time (#31525 )

Co-authored-by: StanR <hi@stanr.info>

molneya · 2025-01-16 09:08:47 +00:00

974fa76987

Remove problematic total deviation scaling, rebalance aim (#31515 )

* Remove problematic total deviation scaling, rebalance aim

* Fix tests

James Wilson · 2025-01-14 18:27:25 +00:00

6cf15e3e5a

Use total deviation to scale accuracy on aim, general aim buff (#31498 )

* Make aim accuracy scaling harsher

* Use deviation-based scaling

* Bring the balancing multiplier down

* Adjust multipliers, fix incorrect deviation when using slider accuracy

* Adjust multipliers

* Update osu.Game.Rulesets.Osu/Difficulty/OsuPerformanceAttributes.cs

Co-authored-by: James Wilson <tsunyoku@gmail.com>

* Change high speed deviation threshold to 22-27 instead of 20-24

* Update tests

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2025-01-14 13:18:02 +00:00

c53188cf45

Punish speed PP for scores with high deviation (#30907 )

Givikap120 · 2025-01-09 13:27:54 +00:00

b21c6457b1

Apply a bunch of balancing changes to aim (#31456 )

* Apply a bunch of balancing changes to aim

* Update tests

---------

Co-authored-by: James Wilson <tsunyoku@gmail.com>

StanR · 2025-01-09 09:57:48 +00:00

db58ec8645

Simplify angle bonus formula (#31449 )

* Simplify angle bonus formula

* Simplify further

* Simplify acute too

* Tests

StanR · 2025-01-08 10:03:22 +00:00

392bb5718c

847 Commits