5869 Commits

• Fix crash when selecting swap mod as freemod
  Dan Balasescu · 2022-02-02 18:42:22 +09:00
  b5fb3b7dae
• Merge pull request #16726 from dekrain/leaderboard-score-tooltip

  Add basic tooltip for leaderboard scores

  Dean Herbert · 2022-02-02 13:56:45 +09:00
  6d962e7925
• Revert mod flow changes and add visual test coverage showing an overflow case
  Dean Herbert · 2022-02-02 09:13:19 +09:00
  35b7653290
• Remove unused FindProvider() methods

  No longer needed since 39f99bf785.

  Bartłomiej Dach · 2022-02-01 21:53:21 +01:00
  7cdf63c654
• Add test scores in BeatmapLeaderboard test scene with more mods
  Dean Herbert · 2022-02-01 16:35:25 +09:00
  3ca2c90684
• Merge branch 'master' into spectator-consistency-frames
  Dan Balasescu · 2022-02-01 14:35:30 +09:00
  0641264a11
• Add replay statistics frames to FramedReplayInputHandler
  Dan Balasescu · 2022-01-31 18:53:47 +09:00
  0458d408bb
• Give last bundled replay frame the frame header
  Dan Balasescu · 2022-01-31 18:53:47 +09:00
  4727aeda01
• Merge pull request #16713 from frenzibyte/fix-spectator-gcc-state-2

  Fix multiplayer spectator occasionally rewinding time unexpectedly

  Dan Balasescu · 2022-01-31 18:33:08 +09:00
  f3d4756c7f
• Merge pull request #16717 from peppy/fix-dialog-overlay-missing-test-failures

  Fix test failures if `DialogOverlay` is not loaded in time

  Dean Herbert · 2022-01-31 17:06:24 +09:00
  575d9671bf
• Fix test failures if DialogOverlay is not loaded in time

  As seen at https://github.com/ppy/osu/runs/4999391205?check_suite_focus=true, where `DialogOverlay` hasn't loaded in single file yet.

  Dean Herbert · 2022-01-31 15:17:07 +09:00
  9001c3a396
• Merge branch 'master' into flush-frames-end-play
  Dean Herbert · 2022-01-31 15:12:41 +09:00
  c8c0ae5658
• Rename dictionary and make private for added safety
  Dean Herbert · 2022-01-31 15:12:08 +09:00
  57f793aff0
• Merge pull request #16703 from peppy/leaderboard-component-fixes

  Rewrite `Leaderboard` component to bring up to current code standards

  Dan Balasescu · 2022-01-31 14:33:04 +09:00
  e9f3e7f5cb
• Track loading via state as well
  Dean Herbert · 2022-01-31 01:12:03 +09:00
  f8939af5e6
• Avoid test failures on non-triangle intro tests
  Dean Herbert · 2022-01-30 18:59:18 +09:00
  6a21d58325
• Add test coverage of intro fail scenario
  Dean Herbert · 2022-01-30 18:51:16 +09:00
  1dbcb5ab63
• Disallow setting "NoScores" externally as it is handled internally
  Dean Herbert · 2022-01-30 16:18:19 +09:00
  04dbb5d3c6
• Consolidate flows of Set operations, either result or error
  Dean Herbert · 2022-01-30 16:16:00 +09:00
  acc1199add
• Also refactor placeholder logic to make more sense
  Dean Herbert · 2022-01-30 10:50:32 +09:00
  c401629dd8
• Add failing test case
  Salman Ahmed · 2022-01-30 01:46:10 +03:00
  4f4f60248f
• Fix null beatmap in test scene
  Dean Herbert · 2022-01-30 03:02:56 +09:00
  06660ff960
• Fix assertions to work in both directions
  Dean Herbert · 2022-01-30 02:54:51 +09:00
  d21464ea61
• Change test exposure to property instead of method
  Dean Herbert · 2022-01-30 02:29:51 +09:00
  51acf79935
• Remove pointless tests that no longer show anything valid
  Dean Herbert · 2022-01-30 00:03:22 +09:00
  9861c50b33
• Fix occasional failures in TestSceneDeleteLocalScore
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  a915b9cd30
• Make score setter private
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  661fec7c8a
• Rename methods to make more sense (and always run through AddOnce)
  Dean Herbert · 2022-01-29 23:58:57 +09:00
  aee93934d5
• Fix score presentation tests not correctly entering song select before running
  Dean Herbert · 2022-01-29 14:46:24 +09:00
  4c97ed676f
• Replace LINQ Count() invocation with count property access
  Bartłomiej Dach · 2022-01-28 20:25:12 +01:00
  1253e1ecc1
• Purge final spectator frames before ending play
  Dan Balasescu · 2022-01-28 22:26:05 +09:00
  3037a3a769
• Merge pull request #16681 from peppy/fix-delete-local-scores

  Fix delete local scores via "Clear all scores" button crashing the game

  Dan Balasescu · 2022-01-28 17:01:31 +09:00
  f021a274d2
• Add test coverage of the same thing but via "clear all scores" button
  Dean Herbert · 2022-01-28 15:54:53 +09:00
  2453bf5ed0
• Add test coverage of local score import and deletion
  Dean Herbert · 2022-01-28 15:50:36 +09:00
  778eebc94d
• Remove unused using
  Dan Balasescu · 2022-01-28 15:26:29 +09:00
  32f9299fe0
• Ensure hold for menu button fades out if the cursor is never moved

  Closes https://github.com/ppy/osu/discussions/16669.

  Dean Herbert · 2022-01-28 14:48:35 +09:00
  28c8e07e3f
• Bring HoldForMenuButton tests up-to-date in code quality
  Dean Herbert · 2022-01-28 14:48:17 +09:00
  f32d56e213
• Merge branch 'master' into song-select-scroll-position-during-delete
  Bartłomiej Dach · 2022-01-27 20:46:19 +01:00
  04d6ca59a3
• Merge pull request #16648 from peppy/fix-song-select-tests

  Fix song select tests not waiting for beatmap imports to arrive

  Dean Herbert · 2022-01-27 23:00:58 +09:00
  e872877185
• Move nulling of previous songSelect to SetUpSteps instead
  Dean Herbert · 2022-01-27 21:59:44 +09:00
  fae4f8bd8e
• Fix song select tests not waiting for beatmap imports to arrive

  After the change to realm, notification fires could take a frame or two.
  We aren't accounting for this.
  
  Fixes test failures like
  https://github.com/ppy/osu/runs/4963255990?check_suite_focus=true

  Dean Herbert · 2022-01-27 19:35:42 +09:00
  831fa44433
• Merge branch 'master' into ruleset-id-fixes
  Dean Herbert · 2022-01-27 17:07:18 +09:00
  a5d422e82c
• Add failing test coverage showing carousel deletions don't keep scroll position
  Dean Herbert · 2022-01-27 16:52:02 +09:00
  f2cecad83b
• Update all usages of RulesetID and Ruleset.ID to use Ruleset.OnlineID
  Dean Herbert · 2022-01-27 15:38:03 +09:00
  5288eedd31
• Fix test gameplay tests failing due to beatmap refetch on suspend
  Bartłomiej Dach · 2022-01-26 21:15:49 +01:00
  e0616476e2
• Add test coverage for editor changes not resetting after exit without save
  Bartłomiej Dach · 2022-01-26 21:15:49 +01:00
  4382adad82
• Merge branch 'master' into playlist-overlay-optimisations
  Dan Balasescu · 2022-01-26 19:01:33 +09:00
  cdca1285ab
• Merge pull request #16623 from frenzibyte/refactor-editor-save-test

  Refactor editor saving test scene for scalability

  Dean Herbert · 2022-01-26 15:40:39 +09:00
  68ee80c5de
• Merge pull request #16609 from peppy/fix-realm-related-failures

  Fix some realm-related test failures

  Dan Balasescu · 2022-01-26 15:31:18 +09:00
  701f00a4b1
• Remove ILive remnants
  Dean Herbert · 2022-01-26 15:12:07 +09:00
  9532454e2a