Jamie Taylor
af87722be8
Add audio feedback for 'Dangerous' dialog buttons
2022-06-15 15:41:27 +09:00
Jamie Taylor
930ec2a197
Add specific samples for dialog 'Ok' and 'Cancel' buttons
2022-06-15 15:41:27 +09:00
Dean Herbert
d1c236e187
Merge pull request #18697 from frenzibyte/timeline-track-change-crash
...
Fix `ZoomableScrollContainer` attempting to update zoom with invalid range
2022-06-15 14:41:37 +09:00
Salman Ahmed
d3feb07bc1
Split zoom updating to named method with value as optional
2022-06-15 07:57:16 +03:00
Salman Ahmed
268a7e1334
Fix ZoomableScrollContainer attempting to update zoom with overlapping range
2022-06-15 05:43:41 +03:00
Salman Ahmed
850afcb1c3
Add failing test case
2022-06-15 05:43:39 +03:00
Salman Ahmed
674a9bb399
Merge pull request #18669 from peppy/fix-hit-error-when-not-visible
...
Fix hit error meters not updating visual state when hidden
2022-06-15 00:39:19 +03:00
Salman Ahmed
9517e0f789
Merge branch 'master' into fix-hit-error-when-not-visible
2022-06-14 23:58:15 +03:00
Bartłomiej Dach
a8f5daa2f1
Merge pull request #15702 from jaxxibae/master
...
Add "View beatmap" button to Discord Rich Presence
2022-06-14 22:34:40 +02:00
Salman Ahmed
36599d1174
Merge branch 'master' into fix-hit-error-when-not-visible
2022-06-14 22:47:11 +03:00
Bartłomiej Dach
439ce63eb1
Merge branch 'master' into master
2022-06-14 21:47:07 +02:00
Bartłomiej Dach
54eb2083c0
Merge pull request #18691 from peppy/toolbar-scrolling-ruleset-selection
...
Allow scrolling overflow of ruleset buttons in the toolbar
2022-06-14 21:43:00 +02:00
Bartłomiej Dach
300663684c
Merge branch 'master' into toolbar-scrolling-ruleset-selection
2022-06-14 20:25:06 +02:00
Dean Herbert
c55c7becba
Always use current ruleset to ensure URL is valid
2022-06-15 02:38:44 +09:00
Dean Herbert
1951eb30bc
Remove call to RegisterUriScheme
...
Seems both unnecessary, and crashes the whole came on macOS.
2022-06-15 02:27:51 +09:00
Dean Herbert
0d36495cfc
Fix up code quality, use more correct URL and update button text
2022-06-15 02:25:06 +09:00
Dean Herbert
7861043202
Merge pull request #18690 from frenzibyte/toolbar-block-scroll
...
Block scroll input from passing through game toolbar
2022-06-15 02:23:28 +09:00
Dean Herbert
cf82843e3d
Merge branch 'master' into jaxxibae/master
2022-06-15 02:15:24 +09:00
Dean Herbert
49ec2572b8
Allow scrolling overflow of ruleset buttons in the toolbar
2022-06-15 01:43:10 +09:00
Salman Ahmed
d89c11e49e
Allow Toolbar to block scroll input from passing through
2022-06-14 19:10:13 +03:00
Salman Ahmed
cd74f22e12
Add failing test case
2022-06-14 19:10:13 +03:00
Dean Herbert
6be4209458
Fix AlwaysPresent specification in wrong container
2022-06-15 01:04:43 +09:00
Dean Herbert
cf2238f683
Merge pull request #18688 from peppy/too-many-import-methods
...
Various clean-up on model managers / importer classes
2022-06-15 00:12:33 +09:00
Dan Balasescu
cc7943dfb1
Merge pull request #18687 from peppy/editor-repeat-behaviour-change-collapsing
...
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 20:24:13 +09:00
Dean Herbert
94ba71aa13
Remove one more usage of lowPriority
2022-06-14 20:21:28 +09:00
Dean Herbert
c179a13d25
Merge pull request #18685 from peppy/fix-editor-z-key
...
Fix ctrl-z in editor also seeking to start in addition to undo
2022-06-14 20:12:42 +09:00
Dean Herbert
6250caca29
Remove duplicate implementation of same thing
2022-06-14 20:01:11 +09:00
Dean Herbert
e96c5ce703
Move and correct xmldoc to interfaces
2022-06-14 20:00:16 +09:00
Dean Herbert
84e526a2d9
Move methods around to make more sense
2022-06-14 20:00:08 +09:00
Dean Herbert
9f599a5ab4
Remove unused lowPriority flag from one Import method
2022-06-14 19:52:30 +09:00
Dean Herbert
ca0765a932
Tidy up various delegation implementations
2022-06-14 19:46:59 +09:00
Dean Herbert
d73c0ca659
Remove unused methods from IModelImporter
...
All the xmldoc is already present in `RealmArchiveModelImporter` so
nothing is lost here.
2022-06-14 19:42:11 +09:00
Dean Herbert
c30644328c
Fix timing adjustment repeat buttons firing one change per repeat invocation
2022-06-14 19:21:02 +09:00
Dean Herbert
aeca138930
Fix ctrl-z in editor also seeking to start in addition to undo
2022-06-14 18:48:57 +09:00
Dean Herbert
0147a8ecee
Add test coverage of HUD components still getting updated when hidden
2022-06-14 18:35:49 +09:00
Dean Herbert
a20e43c2ae
Ensure containers which are being used to hide HUD elements still update for now
...
I don't think this is necessarily a final solution (as this means all
HUD elements are adding overhead even when not visible), but this will
make the implementations much easier for the time being.
I've checked and can't notice any perceivable overhead in profiling so
we should be fine for now.
2022-06-14 18:22:25 +09:00
Dean Herbert
bd9ea9bd6f
Revert most unnecessary changes
...
Turns out `AlwaysPresent` at top level is actually enough.
This reverts commit 86163d2225
2022-06-13 23:58:14 +09:00
Dan Balasescu
0771265caf
Merge pull request #18458 from apollo-dw/evaluators
...
Move individual object difficulty calculations to separate methods in osu!
2022-06-13 22:23:17 +09:00
Dan Balasescu
f73142c50f
Remove for loop
2022-06-13 20:43:56 +09:00
Dan Balasescu
b300bc1e24
Fix ever-increasing flashlight-strain
2022-06-13 20:41:32 +09:00
apollo-dw
4e3dd1ce18
Merge remote-tracking branch 'master/master' into evaluators
2022-06-13 12:27:02 +01:00
apollo-dw
add9b4a7a4
Merge branch 'master' into evaluators
2022-06-13 12:16:22 +01:00
Bartłomiej Dach
54980cbfc1
Merge pull request #18674 from peppy/remvoe-unnecessary-existing-check
...
Remove unnecessary file existence check in model import process
2022-06-13 12:52:21 +02:00
Dean Herbert
336df62a1f
Remove unnecessary file existence check
...
This is not required due to `createFileInfos` always being run before we
get to this point (I believe this was added after the initial code to
check existence was added).
This flow is covered in
`BeatmapImportTests.TestImportThenReimportAfterMissingFiles`, which
still passes with the change.
While this check isn't doing any harm, as I'm going through the flow for
import-skipping, less checks are appreciated.
2022-06-13 18:57:30 +09:00
Dan Balasescu
b88461b3c9
Merge pull request #18671 from peppy/latency-scrolling-gameplay
...
Add scrolling gameplay visualisation mode to latency certifier
2022-06-13 18:46:46 +09:00
Dan Balasescu
7ac8ba0a74
Merge pull request #18368 from apollo-dw/dho
...
Move object history in difficulty calculation to the object itself
2022-06-13 17:31:08 +09:00
Dean Herbert
f997886142
Add scrolling gameplay visualisation mode to latency certifier
2022-06-13 17:18:32 +09:00
Dean Herbert
fd09760421
Merge pull request #18667 from peppy/remove-unlimited-frames-warning
...
Remove unlimited frame limiter warning
2022-06-13 16:40:36 +09:00
Dean Herbert
86163d2225
Fix hit error meters not updating visual state when hidden
...
It is an expectation of users that when the HUD is shown after a period
of being hidden, it will visually reflect the state based on recent
judgements.
To achieve this, I've added `AlwaysPresent` and moved the transform
application to the meter level, rather than at a child level. If this is
seen as a bad direction, `AlwaysPresent` can be applied to the drawable
children and the transforms can be moved back.
Also of note, `ColourHitErrorMeter` is pretty weird. The flow class
could potentially be removed and reduce `AlwaysPresent` usage by one.
Can do that refactor as part of this PR if preferred.
Closes #18624 .
2022-06-13 16:38:57 +09:00
Dean Herbert
17eaf7bb5c
Add failing test coverage showing hit meters don't update when not visible
2022-06-13 16:36:22 +09:00
