3227 Commits

• Always refresh leaderboard for now
  Dean Herbert · 2025-04-23 14:51:00 +09:00
  f945abb72e
• Remove LeaderboardManager return value and simplify flow further

  The rationale for this change is that the return value was mostly
  useless, and at worst, misleading.
  
  When using `LeaderboardManager`, it's assumed that a consumer will bind
  to the global `Scores` list to ensure they receive updates for things
  like local score changes via the internal realm subscription. If one
  decides to instead use the return value of the task, it will be a static
  snapshot that potentially becomes stale in the future.
  
  I fell into this trap when refactoring the new leaderboard component
  (while attempting to assert correctness that the values we are
  displaying were in fact from the fetch operation we requested).
  
  In the interest of keeping things simple, removing the return value
  seems to be the best path forward.

  Dean Herbert · 2025-04-22 19:31:02 +09:00
  f7d1809cb7
• Avoid clearing global cache on entering song select
  Dean Herbert · 2025-04-22 19:29:09 +09:00
  7e6e082bac
• Move bindable list population to load complete to fix threading woes
  Bartłomiej Dach · 2025-04-21 09:05:54 +02:00
  4d08c81e8d
• Merge branch 'master' into leaderboards/gameplay-provider
  Bartłomiej Dach · 2025-04-21 09:03:24 +02:00
  6b0567e882
• Fix gameplay leaderboard showing scores from wrong beatmaps

  Kind of a big oversight this. In wanting to get the leaderboard
  refactors to move forward I sort of didn't realise the fact that all of
  the error handling related to online status and such in
  `BeatmapLeaderboard` kind of... can't stay there...
  
  It's also an all-or-nothing business too - moving this stuff can't
  really be done only in part.
  
  Not sure whether tests are warranted if it's more or less moving logic
  across?

  Bartłomiej Dach · 2025-04-18 20:37:02 +02:00
  c29f59fcdb
• Remove unnecessary interface
  Bartłomiej Dach · 2025-04-18 12:12:21 +02:00
  6d258d4ed5
• Add clarification to IsPartial xmldoc
  Bartłomiej Dach · 2025-04-18 12:02:21 +02:00
  006670c442
• Attempt to fix tests
  Bartłomiej Dach · 2025-04-17 14:26:34 +02:00
  d546bbaf8f
• Separate gameplay leaderboard data management from display

  This is a prerequisite for supporting skinning of leaderboards.
  
  - New `IGameplayLeaderboardProvider` and `IGameplayLeaderboardScore`
    interfaces are introduced. They are strictly concerned with supplying
    leaderboard data.
  
  - Logic of managing display, which was previously jammed into the
    inheritance hierarchy of `GameplayLeaderboard`, is now moved into
    `IGameplayLeaderboardProvider` implementations. Solo play,
    multiplayer, and multiplayer spectator get their own implementation of
    the interface.
  
  - The inheritance hierarchy of `GameplayLeaderboard` and per-player
    overriding of the implementation of the gameplay leaderboard is gone.
    Only one drawable class (renamed to `DrawableGameplayLeaderboard`) is
    allowed to display the leaderboards, across all modes of play.

  Bartłomiej Dach · 2025-04-16 14:46:55 +02:00
  c231571f06
• Merge pull request #32815 from peppy/global-shear

  Change global shear definition to be a `Vector2`

  Dean Herbert · 2025-04-16 18:34:39 +09:00
  572bc6d8b4
• Change global shear definition to be a Vector2

  Saves having this defined in 20+ places. If we ever make any changes to
  shear, it's 100% going to need to be applied to every usage (there will
  never be a case of multiple different shears in the game).
  
  Also fixes a mismatching definition in `ShearedNub`.

  Dean Herbert · 2025-04-16 18:01:08 +09:00
  7a8e96f322
• Fix local leaderboards not showing when starting game offline

  Broke in https://github.com/ppy/osu/pull/32494. Oops.

  Bartłomiej Dach · 2025-04-16 10:27:33 +02:00
  cf2f6d7233
• Merge pull request #32494 from bdach/yet-another-leaderboard-rewrite-attempt

  Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  Dean Herbert · 2025-04-16 16:06:07 +09:00
  57a81658f8
• Fix status pill animating from zero height
  Dean Herbert · 2025-04-10 20:11:04 +09:00
  69035ef48f
• Actually use leaderboard manager in players

  This was supposed to be the case all along, but I guess in all of the
  rewrite attempts I forgot?
  
  With this, https://github.com/ppy/osu/issues/29861 is actually fixed
  again - and additionally, so is https://github.com/ppy/osu/issues/26716.

  Bartłomiej Dach · 2025-04-10 09:46:44 +02:00
  42ff312ece
• Move key binding string retrieval to RealmKeyBindingStore
  Dean Herbert · 2025-04-09 15:23:55 +09:00
  9e90f80ab5
• Fix various weirdness around refetching
  Bartłomiej Dach · 2025-04-08 13:35:24 +02:00
  68b5f9a314
• Merge branch 'master' into yet-another-leaderboard-rewrite-attempt
  Bartłomiej Dach · 2025-04-08 12:54:27 +02:00
  567c7cb798
• Changed the Regex expression to make it able to detect the NotEqual (!= or !:) operator
  iamnotcoding · 2025-03-31 19:15:41 +09:00
  545575eab3
• Added the "!:" option for NotEqual operator
  iamnotcoding · 2025-03-31 18:39:02 +09:00
  e2bdb70daa
• Added NotEqual(!=) operator
  iamnotcoding · 2025-03-31 18:34:51 +09:00
  1e315a3af6
• Show user tags on beatmap set overlay

  Resolves one part of
  https://github.com/ppy/osu/discussions/32568#discussioncomment-12612928
  
  A few caveats:
  
  - Layout is slightly different than web intentionally. Web does things
    that I think will be difficult to reproduce or just plain look bad in
    client, such as:
  
    - On web, the metadata info box has 200px min height and 300px max
      height. I just hardcoded 300 units.
  
    - On web, user tags and mapper tags are individually scrollable, and
      the amount of space taken up by each is calculated in a way that
      is - as far as I can tell - indeterminate, and probably influenced
      by some flexbox magic. I just made the entire thing scrollable
      instead.
  
  - Because song select shares controls with the beatmap set overlay, now
    song select says "Mapper Tags" in the header instead of just "Tags"
    too. I think this is fine, because people asked for user tags to be
    shown in song select too.
  
  - Search query syntax lifted from
    https://github.com/ppy/osu-web/pull/12047.
  
  - Using hardcoded English strings for now, will update to the
    translations after the next osu-resources localisations update.

  Bartłomiej Dach · 2025-03-27 14:58:03 +01:00
  7bb97d5796
• Extract leaderboard fetch logic from song select beatmap leaderboard drawable

  RFC. Another attempt at this.
  
  - Supersedes https://github.com/ppy/osu/pull/31881
  - Supersedes / closes https://github.com/ppy/osu/pull/31355
  - Closes https://github.com/ppy/osu/issues/29861
  
  This is a weird diff because I am feeling rather boxed in by all the
  constraints, namely that:
  
  - Leaderboard state should be global state
  - But the global state is essentially managed by song select and namely
    `BeatmapLeaderboard` itself. That's because trying to e.g. not have
    `BeatmapLeaderboard` pass the beatmap and the ruleset to the global
    leaderboard manager is worse, as it essentially introduces two
    parallel paths of execution that need to be somehow merged into one
    (as in I'd have to somehow sync `LeaderboardManager` responding to
    beatmap/ruleset changes with `BeatmapLeaderboard` which is inheritance
    hell)
  - Also local leaderboard fetching is data-push (as in the scores can
    change under the leaderboard manager), and online leaderboard fetching
    is data-pull (as in the scores do not change unless the leaderboard
    manager does something). Also online leaderboard fetching can fail.
    Which is why I need to still have the weird setup wherein there's a
    `FetchWithCriteriaAsync()` (because I need to be able to respond to
    online requests taking time, or failing), but also the
    `BeatmapLeaderboard` only uses the public `Scores` bindable to
    actually read the scores (because it needs to respond to new local
    scores arriving).
  - Another thing to think about here is what happens when a retrieval
    fails because e.g. the user requested friend leaderboards without
    having supporter. With how this diff is written, that special
    condition is handled to `BeatmapLeaderboard`, and
    `LeaderboardManager`'s state will remain as whatever it was before
    that scope change was requested, which may be considered good or it
    may not (I imagine it's better to show scores in gameplay than not in
    this case, but maybe I'm wrong?)

  Bartłomiej Dach · 2025-03-21 12:06:16 +01:00
  0209129618
• Rename localised string to something slightly more correct
  Dean Herbert · 2025-03-18 00:12:13 +09:00
  43d7918548
• Change CopyUrlToClipboard to CopyStringToClipboard
  GAMIS65 · 2025-03-14 10:02:41 +01:00
  f72de39e4d
• Use localisable string
  Bartłomiej Dach · 2025-03-13 08:37:02 +01:00
  c18764d764
• Remove unused using
  Bartłomiej Dach · 2025-03-13 08:36:19 +01:00
  3515f9a8f8
• Add support for team beatmap leaderboards
  Dean Herbert · 2025-03-13 16:28:20 +09:00
  b0cf5e8bff
• Add helper methods to check whether beatmap leaderboard scope requires supporter
  Dean Herbert · 2025-03-13 16:28:19 +09:00
  9af3c8351d
• Change ModSelectOverlay.ShowPresets to init
  Dean Herbert · 2025-03-04 22:32:13 +09:00
  dff354247e
• Flash footer freemod/freestyle buttons when active
  Dean Herbert · 2025-02-12 18:30:34 +09:00
  218151bb3c
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-01-24 17:23:35 +09:00
  1bfb4d4c2b
• Perform client side validation that the selected beatmap and ruleset have valid online IDs

  This is local to playlists, since in multiplayer the validation is
  already provided by `osu-server-spectator`.

  Dean Herbert · 2025-01-21 19:51:55 +09:00
  459847cb80
• Add tooltips explaining multiplayer mod selection buttons
  Dean Herbert · 2025-01-21 18:35:59 +09:00
  f88102610d
• Merge branch 'master' into multiplayer-free-style
  Dean Herbert · 2025-01-21 17:49:21 +09:00
  c68a0bc7e3
• Add back explicit right click handling of carousel absolute scrolling
  Dean Herbert · 2025-01-21 17:24:42 +09:00
  6c27e87714
• Don't highlight friends' scores under beatmap's friend score leaderboard
  CloneWith · 2025-01-20 00:21:10 +08:00
  72e1b2954c
• Move absolute scroll support local to carousel and allow custom bindings
  Dean Herbert · 2025-01-16 20:47:59 +09:00
  a6057a9f54
• Remove setting for right-mouse scroll (make it always applicable)
  Dean Herbert · 2025-01-16 20:27:38 +09:00
  56b450c4a6
• Update game ScrollContainer usage in line with framework changes

  See https://github.com/ppy/osu-framework/pull/6467.

  Dean Herbert · 2025-01-11 01:42:59 +09:00
  94ea003d90
• Merge pull request #31138 from bdach/mark-as-played

  Implement ability to mark beatmap as played

  Dean Herbert · 2024-12-24 21:43:15 +09:00
  62e536baf6
• Initial support for free style selection
  Dan Balasescu · 2024-12-23 20:12:25 +09:00
  638d959c5c
• Move "global" scroll-adjusts-volume to a per-screen component-based implementation
  Dean Herbert · 2024-12-16 15:21:07 +09:00
  bdd417c1a1
• Implement ability to mark beatmap as played

  Reported at https://osu.ppy.sh/community/forums/topics/2015478?n=1.
  
  Would you believe it that this button that has been there for literal
  years never did anything?
  
  Implemented at a per-beatmap level. Also additionally added to context
  menu (at @peppy's suggestion), and also copy reworded from "Delete from
  unplayed" to "Mark as played" because double negation hurt my tiny
  brain.

  Bartłomiej Dach · 2024-12-16 10:49:19 +09:00
  a6e00d6eac
• Move BeatmapInfoWedgeV2 to correct namespace
  Dean Herbert · 2024-12-12 12:53:05 +09:00
  862b41c38e
• Remove BeatmapCarousel testing backdoor
  Dean Herbert · 2024-12-11 16:28:51 +09:00
  a868c33380
• Access beatmap store via abstract base class

  The intention here is to make things more testable going forward.
  Specifically, to remove the "back-door" entrance into `BeatmapCarousel`
  where `BeatmapSets` can be set by tests and bypas/block realm retrieval.

  Dean Herbert · 2024-12-11 16:28:51 +09:00
  c94b393e30
• Remove no-longer-correct comment
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  bab9b9c937
• Some Carousel classes can be abstract
  Dean Herbert · 2024-12-11 16:28:50 +09:00
  de31a48beb